60636fa872
getTag() becomes invalid when entry is dropped because mMsg disappears to save space; but the per-tag spam filter depends on it still being valid. Conserve space in LogBufferElement by optimizing the size of the fields, then add a new mTag field that is set in the object constructor. Add an isBinary() method. SideEffects: save 12 bytes/log message overhead on 64-bit. Test: define DEBUG_CHECK_FOR_STALE_ENTRIES and look for stale entries Bug: 32247044 Change-Id: Iaa5f416718a92c9e0e6ffd56bd5260d8b908d5c0
90 lines
3 KiB
C++
90 lines
3 KiB
C++
/*
|
|
* Copyright (C) 2012-2014 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef _LOGD_LOG_BUFFER_ELEMENT_H__
|
|
#define _LOGD_LOG_BUFFER_ELEMENT_H__
|
|
|
|
#include <stdatomic.h>
|
|
#include <stdlib.h>
|
|
#include <sys/types.h>
|
|
|
|
#include <log/log.h>
|
|
#include <sysutils/SocketClient.h>
|
|
|
|
class LogBuffer;
|
|
|
|
#define EXPIRE_HOUR_THRESHOLD 24 // Only expire chatty UID logs to preserve
|
|
// non-chatty UIDs less than this age in hours
|
|
#define EXPIRE_THRESHOLD 10 // A smaller expire count is considered too
|
|
// chatty for the temporal expire messages
|
|
#define EXPIRE_RATELIMIT 10 // maximum rate in seconds to report expiration
|
|
|
|
class LogBufferElement {
|
|
|
|
friend LogBuffer;
|
|
|
|
// sized to match reality of incoming log packets
|
|
uint32_t mTag; // only valid for isBinary()
|
|
const uint32_t mUid;
|
|
const uint32_t mPid;
|
|
const uint32_t mTid;
|
|
const uint64_t mSequence;
|
|
log_time mRealTime;
|
|
char *mMsg;
|
|
union {
|
|
const uint16_t mMsgLen; // mMSg != NULL
|
|
uint16_t mDropped; // mMsg == NULL
|
|
};
|
|
const uint8_t mLogId;
|
|
|
|
static atomic_int_fast64_t sequence;
|
|
|
|
// assumption: mMsg == NULL
|
|
size_t populateDroppedMessage(char *&buffer,
|
|
LogBuffer *parent);
|
|
public:
|
|
LogBufferElement(log_id_t log_id, log_time realtime,
|
|
uid_t uid, pid_t pid, pid_t tid,
|
|
const char *msg, unsigned short len);
|
|
virtual ~LogBufferElement();
|
|
|
|
bool isBinary(void) const {
|
|
return (mLogId == LOG_ID_EVENTS) || (mLogId == LOG_ID_SECURITY);
|
|
}
|
|
|
|
log_id_t getLogId() const { return static_cast<log_id_t>(mLogId); }
|
|
uid_t getUid(void) const { return mUid; }
|
|
pid_t getPid(void) const { return mPid; }
|
|
pid_t getTid(void) const { return mTid; }
|
|
uint32_t getTag() const { return mTag; }
|
|
unsigned short getDropped(void) const { return mMsg ? 0 : mDropped; }
|
|
unsigned short setDropped(unsigned short value) {
|
|
if (mMsg) {
|
|
delete [] mMsg;
|
|
mMsg = NULL;
|
|
}
|
|
return mDropped = value;
|
|
}
|
|
unsigned short getMsgLen() const { return mMsg ? mMsgLen : 0; }
|
|
uint64_t getSequence(void) const { return mSequence; }
|
|
static uint64_t getCurrentSequence(void) { return sequence.load(memory_order_relaxed); }
|
|
log_time getRealTime(void) const { return mRealTime; }
|
|
|
|
static const uint64_t FLUSH_ERROR;
|
|
uint64_t flushTo(SocketClient *writer, LogBuffer *parent, bool privileged);
|
|
};
|
|
|
|
#endif
|