platform_system_core/fs_mgr
Ray Chin 702a779edb Fix overflow issue when computing ideal size of scratch partition
The type of f_frsize is `unsigned long` which is 32 bit for some system so it will overflow after multiplied by f_bfree. This solution adds one more type casting to ensure the type is 64 bit unsigned integer during the computing.

Bug: 281599020
Test: adb root; adb shell disable-verity
Change-Id: I377ed722d5e245c235c3ae12ff66ac7e91d1d6e8
2023-05-23 09:49:19 +00:00
..
fuzz libfstab_fuzzer: fuzz TransformFstabForDsu() and skip mount logic 2022-10-21 19:51:25 +08:00
include Expose system property for dm-verity check_at_most_once 2022-10-25 21:12:52 +00:00
include_fstab/fstab libfstab: Add const overload of GetEntryForMountPoint() 2022-12-13 01:53:37 +08:00
libdm ueventd: Fix a race condition in handling device-mapper events. 2023-05-17 15:52:16 -07:00
libfiemap libfiemap: Handle EAGAIN in fallocate(). 2023-05-17 15:52:33 -07:00
libfs_avb Remove unused variable mount_point 2023-03-23 14:14:21 +08:00
liblp liblp: Fix a crash when adding an image to a partition with no extents. 2023-02-08 22:09:58 -08:00
libsnapshot Merge "Support ZSTD in userspace COW" 2023-05-16 19:02:57 +00:00
libstorage_literals Make libfs_mgr and its dependencies vendor_ramdisk_available. 2021-07-23 16:50:06 -07:00
libvbmeta fs_mgr: Add one space between [libfs_mgr] tag and log msg 2023-01-31 09:41:43 +00:00
tests Update vts_fs_test to reflect VSR. 2022-12-14 22:08:40 -08:00
tools dmctl: add repalce command to usage list 2023-03-31 15:20:06 +08:00
.clang-format Fix-up coding style 2017-02-18 12:33:36 +08:00
Android.bp remount: Merge 'remount' and 'set-verity-state' 2022-11-03 22:58:43 +08:00
blockdev.cpp android::base::ResultError/Error are template classes 2021-12-14 17:34:40 +09:00
blockdev.h Reduce the queue depth of loop devices used by the zram driver 2021-08-18 11:00:31 -07:00
clean_scratch_files.rc fs_mgr: Fix executable path in clean_scratch_files. 2020-04-15 21:27:56 +00:00
file_wait.cpp snapuserd: Allow connecting to the first-stage daemon. 2021-07-27 19:35:29 -07:00
fs_mgr.cpp UDC: Dm-Bow failed to load when size is not Multiple of 4096 2023-01-24 09:59:32 +00:00
fs_mgr_boot_config.cpp Revert "Handle "hardware" bootconfig parameter as "androidboot.hardware"" 2021-06-29 12:53:08 -07:00
fs_mgr_dm_linear.cpp libsnapshot_test: Fix running on DSUs. 2020-05-19 18:48:10 +00:00
fs_mgr_format.cpp Add zoned device support 2022-06-08 13:12:15 -07:00
fs_mgr_fstab.cpp Find a zoned partition automatically 2023-01-14 10:29:31 -08:00
fs_mgr_overlayfs.cpp Fix overflow issue when computing ideal size of scratch partition 2023-05-23 09:49:19 +00:00
fs_mgr_priv.h fs_mgr: Add one space between [libfs_mgr] tag and log msg 2023-01-31 09:41:43 +00:00
fs_mgr_priv_boot_config.h Support bootconfig in first stage init and fs_mgr 2021-02-23 07:42:06 -08:00
fs_mgr_priv_overlayfs.h overlayfs: fs_mgr_overlayfs_setup() should accept Fstab as input 2022-12-13 01:53:37 +08:00
fs_mgr_remount.cpp remount: Add checkpoint instructions with warning 2023-01-12 00:04:54 +00:00
fs_mgr_roots.cpp fs_mgr: remove crypt_footer argument from fs_mgr_do_format() 2021-11-09 22:44:50 -08:00
fs_mgr_slotselect.cpp Add android::fs_mgr namespace for new Fstab code 2019-01-30 20:20:05 -08:00
fs_mgr_vendor_overlay.cpp fs_mgr_overlayfs: Cleanup -user build stubs 2022-09-26 16:46:03 +08:00
NOTICE fs_mgr: License boilerplate 2021-07-09 06:24:04 +00:00
OWNERS fs_mgr/OWNERS: Update bug component 2022-12-01 23:47:02 +08:00
README.overlayfs.md LRAP->DAP 2020-12-17 10:56:09 -08:00
TEST_MAPPING libsnapshot: Turn off vabc_legacy_tests on presubmit 2023-05-02 20:40:25 +00:00

Android OverlayFS Integration with adb Remount

Introduction

Users working with userdebug or eng builds expect to be able to remount the system partition as read-write and then add or modify any number of files without reflashing the system image, which is efficient for a development cycle.

Limited memory systems use read-only types of file systems or dynamic Android partitions (DAPs). These file systems land system partition images right-sized, and have been deduped at the block level to compress the content. This means that a remount either isnt possible, or isn't useful because of space limitations or support logistics.

OverlayFS resolves these debug scenarios with the adb disable-verity and adb remount commands, which set up backing storage for a writable file system as an upper reference, and mount the lower reference on top.

Performing a remount

Use the following sequence to perform the remount.

$ adb root
$ adb disable-verity
$ adb reboot
$ adb wait-for-device
$ adb root
$ adb remount

Then enter one of the following sequences:

$ adb shell stop
$ adb sync
$ adb shell start
$ adb reboot

or

$ adb push <source> <destination>
$ adb reboot

Note that you can replace these two lines in the above sequence:

$ adb disable-verity
$ adb reboot

with this line:

$ adb remount -R

Note: adb remount -R wont reboot if the device is already in the adb remount state.

None of this changes if OverlayFS needs to be engaged. The decisions whether to use traditional direct file-system remount, or one wrapped by OverlayFS is automatically determined based on a probe of the file-system types and space remaining.

Backing Storage

When OverlayFS logic is feasible, it uses either the /cache/overlay/ directory for non-A/B devices, or the /mnt/scratch/overlay directory for A/B devices that have access to LRAP. It is also possible for an A/B device to use the system_ partition for backing storage. eg: if booting off system_a+vendor_a, use system_b. The backing store is used as soon as possible in the boot process and can occur at first stage init, or when the mount_all commands are run in init RC scripts.

By attaching OverlayFS early, SEpolicy or init can be pushed and used after the exec phases of each stage.

Caveats

  • Backing storage requires more space than immutable storage, as backing is done file by file. Be mindful of wasted space. For example, defining BOARD_IMAGE_PARTITION_RESERVED_SIZE has a negative impact on the right-sizing of images and requires more free dynamic partition space.
  • The kernel requires CONFIG_OVERLAY_FS=y. If the kernel version is higher than 4.4, it requires source to be in line with android-common kernels.  The patch series is available on the upstream mailing list and the latest as of Sep 5 2019 is https://www.spinics.net/lists/linux-mtd/msg08331.html This patch adds an override_creds mount option to OverlayFS that permits legacy behavior for systems that do not have overlapping sepolicy rules, principals of least privilege, which is how Android behaves. For 4.19 and higher a rework of the xattr handling to deal with recursion is required. https://patchwork.kernel.org/patch/11117145/ is a start of that adjustment.
  • adb enable-verity frees up OverlayFS and reverts the device to the state prior to content updates. The update engine performs a full OTA.
  • adb remount overrides are incompatible with OTA resources, so the update engine may not run if fs_mgr_overlayfs_is_setup() returns true.
  • If a dynamic partition runs out of space, making a logical partition larger may fail because of the scratch partition. If this happens, clear the scratch storage by running either either fastboot flashall or adb enable-verity. Then reinstate the overrides and continue.
  • For implementation simplicity on retrofit dynamic partition devices, take the whole alternate super (eg: if "a" slot, then the whole of "system_b"). Since landing a filesystem on the alternate super physical device without differentiating if it is setup to support logical or physical, the alternate slot metadata and previous content will be lost.
  • There are other subtle caveats requiring complex logic to solve. Have evaluated them as too complex or not worth the trouble, please File a bug if a use case needs to be covered.
    • The backing storage is treated fragile, if anything else has issue with the space taken, the backing storage will be cleared out and we reserve the right to not inform, if the layering does not prevent any messaging.
    • Space remaining threshold is hard coded. If 1% or more space still remains, OverlayFS will not be used, yet that amount of space remaining is problematic.
    • Flashing a partition via bootloader fastboot, as opposed to user space fastbootd, is not detected, thus a partition may have override content remaining. adb enable-verity to wipe.
    • Space is limited, there is near unlimited space on userdata, we have made an architectural decision to not utilize /data/overlay/ at this time. Acquiring space to use for backing remains an ongoing battle.
    • First stage init, or ramdisk, can not be overriden.
    • Backing storage will be discarded or ignored on errors, leading to confusion. When debugging using adb remount it is currently advised to confirm update is present after a reboot to develop confidence.
  • File bugs or submit fixes for review.