03e31332a3
This works around a deadlock when a bridge that is about to be closed is reused for a new call to openFile. The call to open() ends up holding the vold lock, waiting for appfuse to respond. The appfuse event loop calls onClosed(), which ends up calling vold.unmountAppFuse(), which cannot get the lock. Closing this file descriptor causes any current calls to open() on its mount path to fail with either ECONNABORTED or ENOTCONN, allowing the event loop to make progress, call onClosed() and unmount the path. Note that the failed call to open() will result in a retry, which will create a new appfuse bridge. This is not ideal but not a new problem -- the common case here is that that each call to openProxyFileDescriptor creates a new bridge. This should ideally be improved. Bug: 132344997 Test: flick through info of photos with location info attached Change-Id: I878e5cf86f18c5233f8505f52eb9db076bd72d01 Merged-In: I878e5cf86f18c5233f8505f52eb9db076bd72d01 |
||
|---|---|---|
| .. | ||
| include/libappfuse | ||
| tests | ||
| Android.bp | ||
| AndroidTest.xml | ||
| EpollController.cc | ||
| FuseAppLoop.cc | ||
| FuseBridgeLoop.cc | ||
| FuseBuffer.cc | ||
| OWNERS | ||