platform_system_core/adb
Josh Gao 4039051d6d adb: clean up handle_host_request.
Previously, we were returning the result of SendOkay/SendFail in a few
places after handling a host request, which is incorrect for two
reasons. First, the return type of SendOkay/SendFail is bool, and
handle_host_request was expected to return 0 on success. Second, we
don't care if the SendOkay fails; if we got to that point, we're done
with the request, regardless of whether we succeeded to report our
result. The result of this was a spurious failure result reported after
the initial result, which was ignored by the adb client.

Test: manually straced adb server
Test: python test_adb.py
Test: python test_device.py
Change-Id: I7d45ba527e1faccbbae5b15e7a0d1557b0a84858
2018-08-07 14:24:36 -07:00
..
client Accept DexMetadata files (.dm) for install-multiple 2018-08-03 11:21:06 -07:00
daemon adbd: when rebooting, don't close socket before pausing. 2018-08-02 12:52:26 -07:00
sysdeps adb: Remove most C-style allocations 2018-07-19 09:41:40 -07:00
.clang-format
adb.bash Adb and fastboot completion supports zsh users. 2018-07-17 14:19:35 +08:00
adb.cpp adb: clean up handle_host_request. 2018-08-07 14:24:36 -07:00
adb.h adb: clean up handle_host_request. 2018-08-07 14:24:36 -07:00
adb_auth.h adb: switch apacket over to a std::string payload. 2018-02-21 14:30:17 -08:00
adb_io.cpp [adb] Modernize codebase by replacing NULL with nullptr 2018-07-13 18:21:00 -07:00
adb_io.h
adb_io_test.cpp
adb_listeners.cpp adb: Remove most C-style allocations 2018-07-19 09:41:40 -07:00
adb_listeners.h adb: move all cleanup to a function with defined ordering. 2017-05-09 14:32:47 -07:00
adb_listeners_test.cpp
adb_mdns.h
adb_trace.cpp adb: don't spew to logcat when tracing is enabled. 2018-02-06 15:55:06 -08:00
adb_trace.h adb: don't spew to logcat when tracing is enabled. 2018-02-06 15:55:06 -08:00
adb_unique_fd.cpp adb: actually enable fdsan. 2018-08-06 18:50:10 -07:00
adb_unique_fd.h adb: actually enable fdsan. 2018-08-06 18:50:10 -07:00
adb_utils.cpp adb: move AdbCloser to its rightful place. 2018-08-06 18:50:10 -07:00
adb_utils.h Give a clear error message if we can't start the server. 2017-06-20 14:21:41 -07:00
adb_utils_test.cpp adb: fix escape_arg for multiple quotes 2018-07-10 23:32:09 -07:00
Android.bp adb: adbd uses shared libraries. 2018-08-06 11:40:47 -07:00
Android.mk adb: restore adb/adb.exe in the list of artifacts. 2018-03-28 12:57:48 -07:00
benchmark_device.py adb: add benchmark script. 2018-05-23 11:26:04 -07:00
bugreport_test.cpp Merge "Don't preserve file attributes when pulling bugreport file..." 2017-08-22 22:41:26 +00:00
fdevent.cpp [adb] Modernize codebase by replacing NULL with nullptr 2018-07-13 18:21:00 -07:00
fdevent.h adb: add an id field to fdevent. 2018-06-18 14:55:27 -07:00
fdevent_test.cpp adb: remove fdevent_install, fdevent_remove. 2018-05-22 14:54:49 -07:00
fdevent_test.h adb: move ownership of the fdevent thread into FdeventTest. 2018-03-30 14:57:09 -07:00
file_sync_protocol.h adb: split file_sync_service.h into client and daemon parts. 2018-07-25 18:08:32 -07:00
MODULE_LICENSE_APACHE2
NOTICE
OVERVIEW.TXT adb: fix obsolete documentation. 2018-06-22 13:12:19 -07:00
OWNERS Add OWNERS. 2017-12-07 13:30:03 -08:00
protocol.txt adb: convert Connection to a nonblocking interface. 2018-03-05 13:00:28 -08:00
security_log_tags.h
services.cpp adb: split daemon services out of service_to_fd. 2018-07-25 18:49:37 -07:00
services.h adb: split daemon services out of service_to_fd. 2018-07-25 18:49:37 -07:00
SERVICES.TXT adb: fix obsolete documentation. 2018-06-22 13:12:19 -07:00
shell_protocol.h adb: split shell_service.h into client/daemon/protocol parts. 2018-07-25 18:08:44 -07:00
shell_service_protocol.cpp adb: split shell_service.h into client/daemon/protocol parts. 2018-07-25 18:08:44 -07:00
shell_service_protocol_test.cpp adb: split shell_service.h into client/daemon/protocol parts. 2018-07-25 18:08:44 -07:00
socket.h adb: add IOVector. 2018-05-23 11:26:04 -07:00
socket_spec.cpp Add std::string StartsWith*/EndsWith* overloads. 2017-12-20 09:42:22 -08:00
socket_spec.h
socket_spec_test.cpp
socket_test.cpp adb: switch apacket payload to a type that doesn't initialize its contents. 2018-04-11 12:54:07 -07:00
sockets.cpp adb: clean up handle_host_request. 2018-08-07 14:24:36 -07:00
sockets.dia
SYNC.TXT Fix typos in ADB documentation 2017-11-30 10:57:51 -08:00
sysdeps.h Remove unused #include. 2018-07-11 11:21:36 -07:00
sysdeps_test.cpp adb: fix FdeventTest.invalid_fd on Windows. 2018-03-29 14:24:03 -07:00
sysdeps_unix.cpp
sysdeps_win32.cpp [adb] Modernize codebase by replacing NULL with nullptr 2018-07-13 18:21:00 -07:00
sysdeps_win32_test.cpp
test_adb.py adb: Add a test for emulator connection 2018-05-16 15:20:48 -07:00
test_device.py adb: work around adbd push bug. 2018-07-10 13:20:40 -07:00
trace.sh
transport.cpp adb: delete hellish hodgepodge. 2018-08-02 14:51:05 -07:00
transport.h adb: delete hellish hodgepodge. 2018-08-02 14:51:05 -07:00
transport_benchmark.cpp adb: add nonblocking fd Connection. 2018-06-12 17:04:34 -07:00
transport_fd.cpp adb: add nonblocking fd Connection. 2018-06-12 17:04:34 -07:00
transport_local.cpp adb: adbd uses shared libraries. 2018-08-06 11:40:47 -07:00
transport_test.cpp adb: Remove most C-style allocations 2018-07-19 09:41:40 -07:00
transport_usb.cpp adb: Have device usb_handle return io size 2018-07-17 11:53:30 -07:00
types.h adb: Remove most C-style allocations 2018-07-19 09:41:40 -07:00
types_test.cpp adb: add IOVector. 2018-05-23 11:26:04 -07:00
usb.h adb: get libusb compiling on Windows. 2017-12-08 13:11:15 -08:00