No description
Find a file
Tom Cherry 48db85c19f init: fix variable scope issue with ExpandArgs()
ExpandArgs() was factored out of Service::Start() to clean up init,
however this introduced a bug: the scope of expanded_args ends when
ExpandArgs() returns, yet pointers to the c strings contained within
those std::strings are returned from the function.  These pointers are
invalid and have been seen to cause failures on real devices.

This change moves the execv() into ExpandArgs() and renames it
ExpandArgsAndExecv() to keep the clean separation of Service::Start()
but fix the variable scope issue.

Bug: 65303004
Test: boot fugu
Change-Id: I612128631f5b58d040bffcbc2220593ad16cd450
(cherry picked from commit 5e405cacb1)
2017-09-13 13:11:48 -07:00
adb Revert "adbd: lessen security constraints when the device is unlocked" 2017-08-31 16:26:49 +08:00
adf libadf is a new member of VNDK 2017-09-06 13:31:12 +09:00
base Mark the modules as VNDK-SP in Android.bp 2017-07-31 23:37:32 +00:00
bootstat bootstat: Log the ro.boot.bootreason property through the new 2017-09-13 08:38:38 -07:00
cpio Possible null pointer miss on realloc 2017-03-23 22:41:14 +01:00
debuggerd debuggerd_handler: print pid and process name. 2017-08-14 18:06:26 +00:00
demangle Mark libdemangle as vendor_available. 2017-06-20 20:29:57 +00:00
fastboot Merge "fastboot: bail out if failed to generate fs image" into oc-mr1-dev 2017-08-23 23:28:14 +00:00
fs_mgr Allow the use of a custom Android DT directory 2017-07-31 15:27:09 -07:00
gatekeeperd gatekeeperd: use std::unique_ptr 2017-08-17 14:58:23 +09:00
healthd resolve merge conflicts of 74a5f22d9 to oc-dr1-dev-plus-aosp 2017-07-19 18:25:51 -07:00
include Move android_filesystem_config.h => fs_config.h 2017-08-03 17:20:27 +00:00
init init: fix variable scope issue with ExpandArgs() 2017-09-13 13:11:48 -07:00
libappfuse Remove ScopedLogSeverity for debugging 2017-07-14 16:44:16 +09:00
libbacktrace Mark the modules as VNDK-SP in Android.bp 2017-07-31 23:37:32 +00:00
libbinderwrapper libbinderwrapper: Android.mk -> Android.bp 2017-04-25 15:55:26 -07:00
libcrypto_utils Mark the modules as VNDK in Android.bp 2017-08-03 06:43:23 +00:00
libcutils libcutils_header exports liblog_headers 2017-09-04 12:18:40 +09:00
libdiskconfig Mark the modules as VNDK in Android.bp 2017-08-03 06:43:23 +00:00
libgrallocusage Mark libgrallocusage as vendor_available 2017-05-04 12:25:43 +09:00
libion Mark the modules as VNDK-SP in Android.bp 2017-07-31 23:37:32 +00:00
libkeyutils Add libkeyutils. 2017-05-10 14:53:28 -07:00
liblog Hide implementation details of log_time struct 2017-09-06 15:30:50 +09:00
libmemtrack Mark libmemtrack as VNDK in Android.bp 2017-08-03 15:49:19 +09:00
libmemunreachable Merge "libmemunreachable: track kernel binder references" 2017-07-13 19:41:26 +00:00
libmetricslogger bootstat: Log the ro.boot.bootreason property through the new 2017-09-13 08:38:38 -07:00
libnativebridge Move libnativebridge headers into the module. 2017-07-06 11:23:16 -07:00
libnativeloader system/core: use proper nativehelper headers 2017-07-18 17:03:20 -07:00
libnetutils Mark the modules as VNDK in Android.bp 2017-08-03 06:43:23 +00:00
libpackagelistparser
libpixelflinger Va_end should be used with va_start 2017-03-23 22:41:42 +01:00
libprocessgroup Add memcg related configs to init. 2017-07-18 15:58:40 -07:00
libprocinfo Mark the modules as VNDK in Android.bp 2017-08-03 06:43:23 +00:00
libsparse Merge "libsparse: Fix odd-sized input files total_blks" am: 652ce94f40 am: ab74c778df 2017-04-19 19:26:27 +00:00
libsuspend Mark the modules as VNDK in Android.bp 2017-08-03 06:43:23 +00:00
libsync Mark libsync as LL-NDK 2017-08-14 15:28:11 +09:00
libsystem Define priority for video threads 2017-09-07 16:14:07 -07:00
libsysutils Mark the modules as VNDK in Android.bp 2017-08-03 06:43:23 +00:00
libunwindstack Speed up StepIfSignalHandler path. 2017-07-19 21:35:46 +00:00
libusbhost Mark the modules as VNDK in Android.bp 2017-08-03 06:43:23 +00:00
libutils Fix integer overflow in utf{16,32}_to_utf8_length am: 47efc676c8 2017-09-11 09:30:42 +00:00
libvndksupport Make libvndksupport look for default namespace as well. 2017-08-18 15:20:20 +09:00
libziparchive zip_archive: reject files that don't start with an LFH signature. 2017-08-15 13:44:05 +01:00
lmkd Allow ANDROID_LOW_MEMORY_KILLER to coexist with lmkd 2017-09-11 16:57:26 -07:00
logcat logcat: Add missing newline to read failure 2017-07-08 17:51:27 +02:00
logd Decrease size of LogBufferElements to 32 bytes. 2017-08-15 13:03:13 -07:00
logwrapper Merge "logwrapper: add a benchmark for android_fork_execvp_ext" 2017-03-23 11:56:10 +00:00
mkbootimg
qemu_pipe Mark libqemu_pipe vendor_available 2017-06-08 14:16:11 -07:00
reboot
rootdir Merge "fix: boot fails on ASAN builds with VNDK restriction" into oc-mr1-dev 2017-09-08 01:20:30 +00:00
run-as
sdcard Make sdcardfs the default 2017-03-20 13:11:10 -07:00
shell_and_utilities Remove reference to deleted gzip module 2017-07-06 22:33:22 +00:00
storaged storaged: call getNamesForUids to get uid names 2017-08-08 20:59:03 +00:00
toolbox Add building and installing of grep for vendor. 2017-06-19 13:12:37 -07:00
trusty Move trusty reference implementations to /vendor 2017-08-22 11:23:45 +08:00
.clang-format
.clang-format-2 Only allow short functions in class definitions. 2017-03-28 12:31:37 -07:00
.clang-format-4 Only allow short functions in class definitions. 2017-03-28 12:31:37 -07:00
.gitignore
Android.bp
Android.mk
CleanSpec.mk Move trusty reference implementations to /vendor 2017-08-22 11:23:45 +08:00
MODULE_LICENSE_APACHE2
NOTICE
platform_tools_tool_version.mk Fix warning on the build servers 2017-05-25 12:35:40 -07:00
PREUPLOAD.cfg