platform_system_core/adb
David Pursell 0aacbbe9f3 adb: fix GetFeatureSet() to indicate failure.
Previously GetFeatureSet() on an invalid target would just return an
empty feature set, leading to some invalid assumptions, e.g. if there
isn't exactly one device connected this happens:

$ adb shell -t
error: target doesn't support PTY args -Tt

This CL adds a success/failure return value to GetFeatureSet(), and
also adds an option to print errors to stderr since that's the most
common behavior.

This will cause a slight difference in behavior for install/uninstall.
Previously they would block until the device was available, now they
print an error and quit immediately, which seems to be the more common
behavior for adb functions.

Bug: http://b/26387641
Change-Id: I0ea6ffaec922e04b9946e84f05c3870e5b549fde
2016-01-22 08:49:15 -08:00
..
client Merge "adb: shell: add -n flag to not read from stdin." 2015-12-10 21:30:19 +00:00
daemon adbd: Remove check for set_supplementary_gids. 2016-01-08 10:56:20 -08:00
.clang-format adb: add 100 column limit to .clang-format. 2015-11-11 14:16:07 -08:00
adb.cpp base: add network address parsing function from adb. 2016-01-21 20:03:33 -08:00
adb.h adb: tag fatal, fatal_errno with printf attribute. 2016-01-15 15:25:31 -08:00
adb_auth.cpp Adb: use VLOG() to replace D() for verbose logging. 2015-09-23 12:53:38 -07:00
adb_auth.h Ignore ro.adb.secure in user builds. 2015-06-19 13:26:02 -07:00
adb_auth_client.cpp Switch from using sockaddr to sockaddr_storage. 2015-12-07 16:07:46 +09:00
adb_auth_host.cpp Track rename of base/ to android-base/. 2015-12-04 22:00:26 -08:00
adb_client.cpp Increase the maximum shell command length to 4096ish. 2016-01-15 15:02:19 -08:00
adb_client.h Fix error handling/reporting for "adb forward" and "adb reverse". 2015-05-29 18:03:57 -07:00
adb_io.cpp Increase the maximum shell command length to 4096ish. 2016-01-15 15:02:19 -08:00
adb_io.h adb: fix adb client running out of sockets on Windows 2015-10-30 16:23:10 -07:00
adb_io_test.cpp Track rename of base/ to android-base/. 2015-12-04 22:00:26 -08:00
adb_listeners.cpp Merge "Switch from using sockaddr to sockaddr_storage." 2015-12-08 01:41:38 +00:00
adb_listeners.h adb: win32: initial IPv6 support and improved Winsock error reporting 2015-07-30 23:07:55 -07:00
adb_trace.cpp Track rename of base/ to android-base/. 2015-12-04 22:00:26 -08:00
adb_trace.h Track rename of base/ to android-base/. 2015-12-04 22:00:26 -08:00
adb_utils.cpp base: add network address parsing function from adb. 2016-01-21 20:03:33 -08:00
adb_utils.h base: add network address parsing function from adb. 2016-01-21 20:03:33 -08:00
adb_utils_test.cpp base: add network address parsing function from adb. 2016-01-21 20:03:33 -08:00
Android.mk adbd: Depend only on libminijail. 2016-01-08 13:33:01 -08:00
commandline.cpp adb: fix GetFeatureSet() to indicate failure. 2016-01-22 08:49:15 -08:00
console.cpp Track rename of base/ to android-base/. 2015-12-04 22:00:26 -08:00
CPPLINT.cfg Ignore whitespace/indent issues from cpplint. 2015-05-18 16:49:07 -07:00
diagnose_usb.cpp Share the new adb USB diagnostic code with fastboot. 2015-12-14 10:50:21 -08:00
diagnose_usb.h Share the new adb USB diagnostic code with fastboot. 2015-12-14 10:50:21 -08:00
fdevent.cpp adbd: don't leave zombies when subprocess creation fails. 2016-01-20 11:40:31 -08:00
fdevent.h Add unit tests for local socket. 2015-09-16 15:00:59 -07:00
fdevent_test.cpp adb: keep file flags in fdevent_install. 2015-10-06 16:15:30 -07:00
file_sync_client.cpp Give adb a proper progress bar. 2015-12-18 14:43:31 -08:00
file_sync_service.cpp Track rename of base/ to android-base/. 2015-12-04 22:00:26 -08:00
file_sync_service.h adb: allow multiple args to push/pull. 2015-11-02 12:48:24 -08:00
framebuffer_service.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
get_my_path_darwin.cpp Move get_my_path_darwin to C++. 2015-04-16 13:24:58 -07:00
get_my_path_linux.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
jdwp_service.cpp Switch from using sockaddr to sockaddr_storage. 2015-12-07 16:07:46 +09:00
line_printer.cpp Improve dumb terminal support (emacs is dumb). 2016-01-08 15:47:07 -08:00
line_printer.h Simplify adb LinePrinter newline handling. 2015-12-09 18:42:41 -08:00
MODULE_LICENSE_APACHE2 eclair snapshot 2009-11-12 18:46:23 -08:00
mutex_list.h adb: add basename_lock to mutex_list.h. 2015-11-06 12:19:23 -08:00
NOTICE eclair snapshot 2009-11-12 18:46:23 -08:00
OVERVIEW.TXT Fixing spelling errors in adb docs 2010-04-28 11:38:39 -04:00
protocol.txt Increase size of the the adb packets sent over the wire 2015-07-22 13:06:06 -07:00
remount_service.cpp adb: remove exit-time destructors. 2015-11-12 11:20:19 -08:00
remount_service.h Failure to find an oem partition should not be a remount failure. 2015-05-11 13:36:13 -07:00
services.cpp base: add network address parsing function from adb. 2016-01-21 20:03:33 -08:00
services.h adb: put legacy shell: service back in. 2015-09-30 15:40:09 -07:00
SERVICES.TXT adb sync cleanup. 2015-08-24 11:15:01 -07:00
set_verity_enable_state_service.cpp adb: use libfec in disable-verity 2015-10-20 13:55:24 +01:00
shell_service.cpp adbd: use pty to determine whether a session is interactive. 2016-01-20 15:32:56 -08:00
shell_service.h Track rename of base/ to android-base/. 2015-12-04 22:00:26 -08:00
shell_service_protocol.cpp adb: create shell protocol class (take 2). 2015-09-08 10:04:10 -07:00
shell_service_protocol_test.cpp adb: fix shell_service_protocol_test for Windows. 2015-09-11 18:28:27 -07:00
shell_service_test.cpp Track rename of base/ to android-base/. 2015-12-04 22:00:26 -08:00
socket.h Add unit tests for local socket. 2015-09-16 15:00:59 -07:00
socket_test.cpp adb: detect sockets in CLOSE_WAIT state to prevent socket leak on linux. 2015-09-30 15:03:26 -07:00
sockets.cpp Increase the maximum shell command length to 4096ish. 2016-01-15 15:02:19 -08:00
sockets.dia auto import from //depot/cupcake/@135843 2009-03-03 19:32:55 -08:00
SYNC.TXT adb sync cleanup. 2015-08-24 11:15:01 -07:00
sysdeps.h Track rename of base/ to android-base/. 2015-12-04 22:00:26 -08:00
sysdeps_win32.cpp adb: tag fatal, fatal_errno with printf attribute. 2016-01-15 15:25:31 -08:00
sysdeps_win32_test.cpp Fix a couple sign-comparison warnings. 2016-01-15 12:18:14 -08:00
test_adb.py adb: fix adb client running out of sockets on Windows 2015-10-30 16:23:10 -07:00
test_device.py adb: make pulling symlinks and devices work. 2015-12-11 12:51:38 -08:00
test_track_devices.cpp Track rename of base/ to android-base/. 2015-12-04 22:00:26 -08:00
transport.cpp Share the new adb USB diagnostic code with fastboot. 2015-12-14 10:50:21 -08:00
transport.h adb: add help text for USB permission errors. 2015-12-03 11:00:47 -08:00
transport_local.cpp Merge "Switch from using sockaddr to sockaddr_storage." 2015-12-08 01:41:38 +00:00
transport_test.cpp adb: fix adbd feature parsing for no features. 2015-09-25 13:10:17 -07:00
transport_usb.cpp Adb: use VLOG() to replace D() for verbose logging. 2015-09-23 12:53:38 -07:00
usb_linux.cpp Share the new adb USB diagnostic code with fastboot. 2015-12-14 10:50:21 -08:00
usb_linux_client.cpp adb: extract USB FFS read/write limit constants. 2015-12-17 14:28:24 -08:00
usb_osx.cpp Share the new adb USB diagnostic code with fastboot. 2015-12-14 10:50:21 -08:00
usb_windows.cpp Share the new adb USB diagnostic code with fastboot. 2015-12-14 10:50:21 -08:00