platform_system_core/fs_mgr
Akilesh Kailash 24305239d6 snapuserd: Send header-response once per entire IO request
Header response from daemon is sent once at the
beginning of the payload. This is a corner case
when the IO request can get broken into multiple chunks
if the IO is un-aligned.

Additionally, add error checks in the IO path
to validate sector information when the read
requests are merged.

Bug: 188361387
Test: Simulate an IO request to forcefully break the IO
response into multiple chunks and verify the correctness.

Signed-off-by: Akilesh Kailash <akailash@google.com>
Change-Id: I1f4fa7a79c60493f4bbed3ad49e257098b930beb
Merged-In: I1f4fa7a79c60493f4bbed3ad49e257098b930beb
2021-05-19 01:01:52 +00:00
..
include OverlayFS support for fstab 2021-05-05 09:30:18 -07:00
include_fstab/fstab OverlayFS support for fstab 2021-05-05 09:30:18 -07:00
libdm Add new dm-verity error handling mode 2021-04-14 09:10:37 +09:00
libfiemap Merge changes Ibffdd9c9,Ief5a16d1 2021-05-06 17:57:46 +00:00
libfs_avb fs_avb_test_util: adding logs for debugging 2021-05-07 16:53:04 +08:00
liblp liblp: Remove uses of alignment_offset. 2021-03-02 18:35:05 -08:00
libsnapshot snapuserd: Send header-response once per entire IO request 2021-05-19 01:01:52 +00:00
libstorage_literals fastboot driver: RunAndReadBuffer don't allocate too much mem 2021-03-17 15:38:06 -07:00
libvbmeta [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
tests Fix CtsFsMgrTestCases failures 2021-05-11 07:12:22 +00:00
tools follows the advice of -Wsign-compare 2021-02-25 02:20:17 +00:00
.clang-format
Android.bp [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
clean_scratch_files.cpp remount: Use /data for backing scratch storage. 2020-01-28 12:04:38 -08:00
clean_scratch_files.rc fs_mgr: Fix executable path in clean_scratch_files. 2020-04-15 21:27:56 +00:00
file_wait.cpp Introduce inotify-based replacements for fs_mgr_wait_for_file. 2019-06-18 15:27:09 -07:00
fs_mgr.cpp add missing spaces 2021-04-16 17:07:50 +08:00
fs_mgr_boot_config.cpp Handle "hardware" bootconfig parameter as "androidboot.hardware" 2021-03-09 14:10:48 -08:00
fs_mgr_dm_linear.cpp libsnapshot_test: Fix running on DSUs. 2020-05-19 18:48:10 +00:00
fs_mgr_format.cpp Rename external storage properties. 2020-04-16 10:13:28 +02:00
fs_mgr_fstab.cpp OverlayFS support for fstab 2021-05-05 09:30:18 -07:00
fs_mgr_overlayfs.cpp OverlayFS support for fstab 2021-05-05 09:30:18 -07:00
fs_mgr_priv.h fs_mgr: Remove the timeout parameter to DestroyLogicalPartition. 2019-07-11 15:39:53 -07:00
fs_mgr_priv_boot_config.h Support bootconfig in first stage init and fs_mgr 2021-02-23 07:42:06 -08:00
fs_mgr_remount.cpp Try to remount mounted points only 2021-02-22 20:46:41 +00:00
fs_mgr_roots.cpp Add erofs to supported fs type 2020-12-04 13:39:34 +00:00
fs_mgr_slotselect.cpp Add android::fs_mgr namespace for new Fstab code 2019-01-30 20:20:05 -08:00
fs_mgr_vendor_overlay.cpp Allow product partition to have vendor_overlay 2018-11-27 23:34:00 +00:00
fs_mgr_verity.cpp fs_mgr: Remove the timeout parameter to DestroyLogicalPartition. 2019-07-11 15:39:53 -07:00
OWNERS Add new owners to various sub-projects. 2020-12-11 12:45:45 -08:00
README.overlayfs.md LRAP->DAP 2020-12-17 10:56:09 -08:00
TEST_MAPPING Add cow_api_test to presubmit. 2021-05-05 15:29:35 -07:00

Android OverlayFS Integration with adb Remount

Introduction

Users working with userdebug or eng builds expect to be able to remount the system partition as read-write and then add or modify any number of files without reflashing the system image, which is efficient for a development cycle.

Limited memory systems use read-only types of file systems or dynamic Android partitions (DAPs). These file systems land system partition images right-sized, and have been deduped at the block level to compress the content. This means that a remount either isnt possible, or isn't useful because of space limitations or support logistics.

OverlayFS resolves these debug scenarios with the adb disable-verity and adb remount commands, which set up backing storage for a writable file system as an upper reference, and mount the lower reference on top.

Performing a remount

Use the following sequence to perform the remount.

$ adb root
$ adb disable-verity
$ adb reboot
$ adb wait-for-device
$ adb root
$ adb remount

Then enter one of the following sequences:

$ adb shell stop
$ adb sync
$ adb shell start
$ adb reboot

or

$ adb push <source> <destination>
$ adb reboot

Note that you can replace these two lines in the above sequence:

$ adb disable-verity
$ adb reboot

with this line:

$ adb remount -R

Note: adb remount -R wont reboot if the device is already in the adb remount state.

None of this changes if OverlayFS needs to be engaged. The decisions whether to use traditional direct file-system remount, or one wrapped by OverlayFS is automatically determined based on a probe of the file-system types and space remaining.

Backing Storage

When OverlayFS logic is feasible, it uses either the /cache/overlay/ directory for non-A/B devices, or the /mnt/scratch/overlay directory for A/B devices that have access to LRAP. It is also possible for an A/B device to use the system_ partition for backing storage. eg: if booting off system_a+vendor_a, use system_b. The backing store is used as soon as possible in the boot process and can occur at first stage init, or when the mount_all commands are run in init RC scripts.

By attaching OverlayFS early, SEpolicy or init can be pushed and used after the exec phases of each stage.

Caveats

  • Backing storage requires more space than immutable storage, as backing is done file by file. Be mindful of wasted space. For example, defining BOARD_IMAGE_PARTITION_RESERVED_SIZE has a negative impact on the right-sizing of images and requires more free dynamic partition space.
  • The kernel requires CONFIG_OVERLAY_FS=y. If the kernel version is higher than 4.4, it requires source to be in line with android-common kernels.  The patch series is available on the upstream mailing list and the latest as of Sep 5 2019 is https://www.spinics.net/lists/linux-mtd/msg08331.html This patch adds an override_creds mount option to OverlayFS that permits legacy behavior for systems that do not have overlapping sepolicy rules, principals of least privilege, which is how Android behaves. For 4.19 and higher a rework of the xattr handling to deal with recursion is required. https://patchwork.kernel.org/patch/11117145/ is a start of that adjustment.
  • adb enable-verity frees up OverlayFS and reverts the device to the state prior to content updates. The update engine performs a full OTA.
  • adb remount overrides are incompatible with OTA resources, so the update engine may not run if fs_mgr_overlayfs_is_setup() returns true.
  • If a dynamic partition runs out of space, making a logical partition larger may fail because of the scratch partition. If this happens, clear the scratch storage by running either either fastboot flashall or adb enable-verity. Then reinstate the overrides and continue.
  • For implementation simplicity on retrofit dynamic partition devices, take the whole alternate super (eg: if "a" slot, then the whole of "system_b"). Since landing a filesystem on the alternate super physical device without differentiating if it is setup to support logical or physical, the alternate slot metadata and previous content will be lost.
  • There are other subtle caveats requiring complex logic to solve. Have evaluated them as too complex or not worth the trouble, please File a bug if a use case needs to be covered.
    • The backing storage is treated fragile, if anything else has issue with the space taken, the backing storage will be cleared out and we reserve the right to not inform, if the layering does not prevent any messaging.
    • Space remaining threshold is hard coded. If 1% or more space still remains, OverlayFS will not be used, yet that amount of space remaining is problematic.
    • Flashing a partition via bootloader fastboot, as opposed to user space fastbootd, is not detected, thus a partition may have override content remaining. adb enable-verity to wipe.
    • Space is limited, there is near unlimited space on userdata, we have made an architectural decision to not utilize /data/overlay/ at this time. Acquiring space to use for backing remains an ongoing battle.
    • First stage init, or ramdisk, can not be overriden.
    • Backing storage will be discarded or ignored on errors, leading to confusion. When debugging using adb remount it is currently advised to confirm update is present after a reboot to develop confidence.
  • File bugs or submit fixes for review.