platform_system_core/fs_mgr
Mark Salyzyn 38a17f0d76 fs_mgr: overlayfs: test issues with single super device
Cleanup test issues with single super device.  Indicate mount point
instead of partitions as that can lead to confusion when referencing
the partition when there is none.  For example root (/) partition
uses overlay on /system.  Resolve a script syntax error when there
are no devices.  Fix script logic surrounding detection of overlayfs
takeover and handling of reboot device request from
adb disable-verity.

In README.overlayfs.md discuss
BOARD_<partitiion>IMAGE_PARTITION_RESERVED_SIZE and its negative
impact on right sizing.

Soften README.overlayfs.md wording with respect to update_engine
to match changes in handling.

Test: adb-remount-test.sh
Bug: 120536582
Bug: 109821005
Change-Id: Iad7e19a436322ff9c3bdc597f4545028be112ff5
2018-12-17 11:26:03 -08:00
..
include Start using new C++ Fstab class widely 2018-12-12 17:08:09 +00:00
include_fstab/fstab fstab: allow mounting other slot 2018-12-14 05:50:21 +00:00
libdm Add noexcept to move constructors and assignment operators. 2018-10-05 16:43:47 +00:00
libfs_avb Start using new C++ Fstab class widely 2018-12-12 17:08:09 +00:00
liblp fs_mgr: remove -Wno-unused-variable from cflags 2018-12-12 10:30:10 -08:00
tests fs_mgr: overlayfs: test issues with single super device 2018-12-17 11:26:03 -08:00
tools Adding bow dm-target 2018-10-02 10:12:30 -07:00
.clang-format Fix-up coding style 2017-02-18 12:33:36 +08:00
Android.bp fs_mgr: remove -Wno-unused-variable from cflags 2018-12-12 10:30:10 -08:00
fs_mgr.cpp Fix sign-compare warnings 2018-12-14 16:02:38 -08:00
fs_mgr_boot_config.cpp fs_mgr: reorder getting boot config 2018-06-12 00:16:14 +08:00
fs_mgr_dm_linear.cpp Handle renamed "super" device correctly 2018-12-04 11:21:34 -08:00
fs_mgr_format.cpp Start using new C++ Fstab class widely 2018-12-12 17:08:09 +00:00
fs_mgr_fstab.cpp Fix sign-compare warnings 2018-12-14 16:02:38 -08:00
fs_mgr_overlayfs.cpp fs_mgr: errno handling in fs_mgr_overlayfs_setup() 2018-12-12 14:21:10 -08:00
fs_mgr_priv.h fstab: allow mounting other slot 2018-12-14 05:50:21 +00:00
fs_mgr_priv_boot_config.h fs_mgr: fs_mgr_get_boot_config_from_kernel_cmdline deal with quote 2018-06-08 16:04:17 -07:00
fs_mgr_slotselect.cpp fstab: allow mounting other slot 2018-12-14 05:50:21 +00:00
fs_mgr_vendor_overlay.cpp Allow product partition to have vendor_overlay 2018-11-27 23:34:00 +00:00
fs_mgr_verity.cpp Start using new C++ Fstab class widely 2018-12-12 17:08:09 +00:00
OWNERS Add OWNERS. 2017-12-07 13:30:03 -08:00
README.overlayfs.md fs_mgr: overlayfs: test issues with single super device 2018-12-17 11:26:03 -08:00

Android Overlayfs integration with adb remount

Introduction

Users working with userdebug or eng builds expect to be able to remount the system partition as read-write and then add or modify any number of files without reflashing the system image, which is understandably efficient for a development cycle. Limited memory systems that chose to use readonly filesystems like squashfs, or Logical Resizable Android Partitions which land system partition images right-sized, and with filesystem that have been deduped on the block level to compress the content; means that either a remount is not possible directly, or when done offers little or no utility because of remaining space limitations or support logistics.

Overlayfs comes to the rescue for these debug scenarios, and logic will automatically setup backing storage for a writable filesystem as an upper reference, and mount overtop the lower. These actions will be performed in the adb disable-verity and adb remount requests.

Operations

Cookbook

The typical action to utilize the remount facility is:

$ adb root
$ adb disable-verity
$ adb reboot
$ adb wait-for-device
$ adb root
$ adb remount

Followed by one of the following:

$ adb stop
$ adb sync
$ adb start
$ adb reboot

or

$ adb push <source> <destination>
$ adb reboot

Note that the sequence above:

$ adb disable-verity
$ adb reboot

can be replaced with:

$ adb reboot -R

which will not reboot if everything is already prepared and ready to go.

None of this changes if overlayfs needs to be engaged. The decisions whether to use traditional direct filesystem remount, or one wrapped by overlayfs is automatically determined based on a probe of the filesystem types and space remaining.

Backing Storage

When overlayfs logic is feasible, it will use either the /cache/overlay/ directory for non-A/B devices, or the /mnt/scratch/overlay directory for A/B devices that have access to Logical Resizeable Android Partitions. The backing store is used as soon as possible in the boot process and can occur at first stage init, or at the mount_all init rc commands.

This early as possible attachment of overlayfs means that sepolicy or init itself can also be pushed and used after the exec phases that accompany each stage.

Caveats

  • Space used in the backing storage is on a file by file basis and will require more space than if updated in place. As such it is important to be mindful of any wasted space, for instance BOARD_IMAGE_PARTITION_RESERVED_SIZE being defined will have a negative impact on the overall right-sizing of images and thus free dynamic partition space.
  • Kernel must have CONFIG_OVERLAY_FS=y and will need to be patched with "overlayfs: override_creds=off option bypass creator_cred" if higher than 4.6.
  • adb enable-verity will free up overlayfs and as a bonus the device will be reverted pristine to before any content was updated. Update engine does not take advantage of this, will perform a full OTA.
  • Update engine may not run if fs_mgr_overlayfs_is_setup() reports true as adb remount overrides are incompatable with an OTA resources.
  • For implementation simplicity on retrofit dynamic partition devices, take the whole alternate super (eg: if "a" slot, then the whole of "system_b"). Since landing a filesystem on the alternate super physical device without differentiating if it is setup to support logical or physical, the alternate slot metadata and previous content will be lost.
  • If dynamic partitions runs out of space, resizing a logical partition larger may fail because of the scratch partition. If this happens, either fastboot flashall or adb enable-verity can be used to clear scratch storage to permit the flash. Then reinstate the overrides and continue.
  • File bugs or submit fixes for review.