1253186728
This cleans up the unit tests and update them to pass. Cleaned up: * removed the irrelevant bits. * Used ScopedTempDir for all test specific files (instead of the current directory). * Update some objects to make them more easily testable. * Group all the test in a single binary and use bionic's test runner. BUG: 23682444 Change-Id: I289e3a5ff89968fdecd4a156e93bc38bbc25f58b
104 lines
2.8 KiB
C++
104 lines
2.8 KiB
C++
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include "persistent_integer.h"
|
|
|
|
#include <fcntl.h>
|
|
|
|
#include <base/logging.h>
|
|
#include <base/posix/eintr_wrapper.h>
|
|
|
|
#include "constants.h"
|
|
#include "metrics/metrics_library.h"
|
|
|
|
|
|
namespace chromeos_metrics {
|
|
|
|
// Static class member instantiation.
|
|
std::string PersistentInteger::metrics_directory_ = metrics::kMetricsDirectory;
|
|
|
|
PersistentInteger::PersistentInteger(const std::string& name) :
|
|
value_(0),
|
|
version_(kVersion),
|
|
name_(name),
|
|
synced_(false) {
|
|
backing_file_name_ = metrics_directory_ + name_;
|
|
}
|
|
|
|
PersistentInteger::~PersistentInteger() {}
|
|
|
|
void PersistentInteger::Set(int64_t value) {
|
|
value_ = value;
|
|
Write();
|
|
}
|
|
|
|
int64_t PersistentInteger::Get() {
|
|
// If not synced, then read. If the read fails, it's a good idea to write.
|
|
if (!synced_ && !Read())
|
|
Write();
|
|
return value_;
|
|
}
|
|
|
|
int64_t PersistentInteger::GetAndClear() {
|
|
int64_t v = Get();
|
|
Set(0);
|
|
return v;
|
|
}
|
|
|
|
void PersistentInteger::Add(int64_t x) {
|
|
Set(Get() + x);
|
|
}
|
|
|
|
void PersistentInteger::Write() {
|
|
int fd = HANDLE_EINTR(open(backing_file_name_.c_str(),
|
|
O_WRONLY | O_CREAT | O_TRUNC,
|
|
S_IWUSR | S_IRUSR | S_IRGRP | S_IROTH));
|
|
PCHECK(fd >= 0) << "cannot open " << backing_file_name_ << " for writing";
|
|
PCHECK((HANDLE_EINTR(write(fd, &version_, sizeof(version_))) ==
|
|
sizeof(version_)) &&
|
|
(HANDLE_EINTR(write(fd, &value_, sizeof(value_))) ==
|
|
sizeof(value_)))
|
|
<< "cannot write to " << backing_file_name_;
|
|
close(fd);
|
|
synced_ = true;
|
|
}
|
|
|
|
bool PersistentInteger::Read() {
|
|
int fd = HANDLE_EINTR(open(backing_file_name_.c_str(), O_RDONLY));
|
|
if (fd < 0) {
|
|
PLOG(WARNING) << "cannot open " << backing_file_name_ << " for reading";
|
|
return false;
|
|
}
|
|
int32_t version;
|
|
int64_t value;
|
|
bool read_succeeded = false;
|
|
if (HANDLE_EINTR(read(fd, &version, sizeof(version))) == sizeof(version) &&
|
|
version == version_ &&
|
|
HANDLE_EINTR(read(fd, &value, sizeof(value))) == sizeof(value)) {
|
|
value_ = value;
|
|
read_succeeded = true;
|
|
synced_ = true;
|
|
}
|
|
close(fd);
|
|
return read_succeeded;
|
|
}
|
|
|
|
void PersistentInteger::SetMetricsDirectory(const std::string& directory) {
|
|
metrics_directory_ = directory;
|
|
}
|
|
|
|
|
|
} // namespace chromeos_metrics
|