306f8b5713
Perhaps the better question is, why have I 100s of times, typed "ASSERT_NE(nullptr, foo)" for sp<> foo, and got a compiler error and then change it to "foo.get()". This CL so we can stop wasting cycles with that error. Fixes: 147842528 Test: libutils_test Change-Id: Id63b29d2a1ff3077201a62b69d864c5a826c47e0
73 lines
2.1 KiB
C++
73 lines
2.1 KiB
C++
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <utils/StrongPointer.h>
|
|
#include <utils/RefBase.h>
|
|
|
|
using namespace android;
|
|
|
|
class SPFoo : public LightRefBase<SPFoo> {
|
|
public:
|
|
explicit SPFoo(bool* deleted_check) : mDeleted(deleted_check) {
|
|
*mDeleted = false;
|
|
}
|
|
|
|
~SPFoo() {
|
|
*mDeleted = true;
|
|
}
|
|
private:
|
|
bool* mDeleted;
|
|
};
|
|
|
|
TEST(StrongPointer, move) {
|
|
bool isDeleted;
|
|
SPFoo* foo = new SPFoo(&isDeleted);
|
|
ASSERT_EQ(0, foo->getStrongCount());
|
|
ASSERT_FALSE(isDeleted) << "Already deleted...?";
|
|
sp<SPFoo> sp1(foo);
|
|
ASSERT_EQ(1, foo->getStrongCount());
|
|
{
|
|
sp<SPFoo> sp2 = std::move(sp1);
|
|
ASSERT_EQ(1, foo->getStrongCount()) << "std::move failed, incremented refcnt";
|
|
ASSERT_EQ(nullptr, sp1.get()) << "std::move failed, sp1 is still valid";
|
|
// The strong count isn't increasing, let's double check the old object
|
|
// is properly reset and doesn't early delete
|
|
sp1 = std::move(sp2);
|
|
}
|
|
ASSERT_FALSE(isDeleted) << "deleted too early! still has a reference!";
|
|
{
|
|
// Now let's double check it deletes on time
|
|
sp<SPFoo> sp2 = std::move(sp1);
|
|
}
|
|
ASSERT_TRUE(isDeleted) << "foo was leaked!";
|
|
}
|
|
|
|
TEST(StrongPointer, NullptrComparison) {
|
|
sp<SPFoo> foo;
|
|
ASSERT_EQ(foo, nullptr);
|
|
ASSERT_EQ(nullptr, foo);
|
|
}
|
|
|
|
TEST(StrongPointer, PointerComparison) {
|
|
bool isDeleted;
|
|
sp<SPFoo> foo = new SPFoo(&isDeleted);
|
|
ASSERT_EQ(foo.get(), foo);
|
|
ASSERT_EQ(foo, foo.get());
|
|
ASSERT_NE(nullptr, foo);
|
|
ASSERT_NE(foo, nullptr);
|
|
}
|