tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
platform_system_core/adb
History
Spencer Low d62bce8040 adb: win32: fix key files reading/writing 
The issue is that adb uses fopen() with "e" (presumably to open the file
with O_CLOEXEC), but that flag causes MSVCRT.DLL to return an error. So
when adb_auth_host.cpp goes to read or write the adbkey files, it fails.

The quick fix is to not use the "e" option on adb host code since it
isn't necessary there, compared to adbd.

An alternative fix would be to have a fopen() wrapper on Windows that
filters out the "e" option.

Bug: http://b/21806456
Bug: https://code.google.com/p/android/issues/detail?id=175077
Change-Id: I7d8ba2847dab0ed558ffe156e79093251eb253c9
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
(cherry picked from commit 9b9603148b)
2015-06-12 11:02:37 -07:00
..
tests Fix ' escaping in adb. 2015-05-15 14:50:47 -07:00
.clang-format Fix clang-format file for correct indent settings. 2015-03-19 13:27:20 -07:00
adb.cpp Add WriteFdFmt and clean up more code. 2015-05-01 17:37:28 -07:00
adb.h More adb buffer fixes. 2015-05-01 17:09:34 -07:00
adb_auth.cpp File header cleanup. 2015-03-19 15:32:33 -07:00
adb_auth.h Remove extern "C" barriers to using C++. 2015-04-17 09:47:42 -07:00
adb_auth_client.cpp File header cleanup. 2015-03-19 15:32:33 -07:00
adb_auth_host.cpp adb: win32: fix key files reading/writing 2015-06-12 11:02:37 -07:00
adb_client.cpp Add WriteFdFmt and clean up more code. 2015-05-01 17:37:28 -07:00
adb_client.h More fixed-length buffer removal. 2015-04-30 12:31:11 -07:00
adb_io.cpp Add WriteFdFmt and clean up more code. 2015-05-01 17:37:28 -07:00
adb_io.h Add WriteFdFmt and clean up more code. 2015-05-01 17:37:28 -07:00
adb_io_test.cpp Add WriteFdFmt and clean up more code. 2015-05-01 17:37:28 -07:00
adb_listeners.cpp Add WriteFdFmt and clean up more code. 2015-05-01 17:37:28 -07:00
adb_listeners.h Add WriteFdFmt and clean up more code. 2015-05-01 17:37:28 -07:00
adb_main.cpp Include the git sha in the adb version. 2015-05-06 09:11:16 -07:00
adb_trace.h More adb buffer fixes. 2015-05-01 17:09:34 -07:00
adb_utils.cpp Fix ' escaping in adb. 2015-05-15 14:50:47 -07:00
adb_utils.h More adb buffer fixes. 2015-05-01 17:09:34 -07:00
adb_utils_test.cpp Fix ' escaping in adb. 2015-05-15 14:50:47 -07:00
Android.mk Include the git sha in the adb version. 2015-05-06 09:11:16 -07:00
commandline.cpp Improve adb install help. 2015-06-01 23:59:20 +00:00
console.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
CPPLINT.cfg Ignore another stupid lint warning. 2015-02-20 17:19:22 -08:00
fdevent.cpp File header cleanup. 2015-03-19 15:32:33 -07:00
fdevent.h Remove extern "C" barriers to using C++. 2015-04-17 09:47:42 -07:00
file_sync_client.cpp Move __adb_error to std::string, and improve various errors. 2015-04-29 11:42:13 -07:00
file_sync_service.cpp File header cleanup. 2015-03-19 15:32:33 -07:00
file_sync_service.h Fix "adb sync" for devices without vendor and oem. 2015-04-21 10:17:07 -07:00
framebuffer_service.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
get_my_path_darwin.cpp Move get_my_path_darwin to C++. 2015-04-16 13:24:58 -07:00
get_my_path_linux.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
get_my_path_windows.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
jdwp_service.cpp Remove extern "C" barriers to using C++. 2015-04-17 09:47:42 -07:00
MODULE_LICENSE_APACHE2
mutex_list.h
NOTICE
OVERVIEW.TXT
protocol.txt
qemu_tracing.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
qemu_tracing.h Remove extern "C" barriers to using C++. 2015-04-17 09:47:42 -07:00
remount_service.cpp Failure to find an oem partition should not be a remount failure. 2015-05-11 13:36:13 -07:00
remount_service.h Failure to find an oem partition should not be a remount failure. 2015-05-11 13:36:13 -07:00
services.cpp Add WriteFdFmt and clean up more code. 2015-05-01 17:37:28 -07:00
SERVICES.TXT adb: implement "adb reverse <local> <remote>" 2014-05-27 16:42:13 +02:00
set_verity_enable_state_service.cpp Failure to find an oem partition should not be a remount failure. 2015-05-11 13:36:13 -07:00
sockets.cpp More adb buffer fixes. 2015-05-01 17:09:34 -07:00
sockets.dia
SYNC.TXT Adding documentation on the sync part of the adb protocol previously missing. 2014-03-20 20:36:46 +01:00
sysdeps.h Remove strtok from adb. 2015-04-28 10:55:24 -07:00
sysdeps_win32.cpp More adb buffer fixes. 2015-05-01 17:09:34 -07:00
test_track_devices.cpp More adb buffer fixes. 2015-05-01 17:09:34 -07:00
transport.cpp Be tolerant of devices that don't report serials. 2015-05-07 15:56:03 -07:00
transport.h More adb buffer fixes. 2015-05-01 17:09:34 -07:00
transport_local.cpp Add WriteFdFmt and clean up more code. 2015-05-01 17:37:28 -07:00
transport_test.cpp Add some basic tests to adb. 2015-02-25 10:57:26 -08:00
transport_usb.cpp File header cleanup. 2015-03-19 15:32:33 -07:00
usb_linux.cpp Be tolerant of devices that don't report serials. 2015-05-07 15:56:03 -07:00
usb_linux_client.cpp Add missing null checks after allocations. 2015-04-21 19:43:22 -07:00
usb_osx.cpp Add missing null checks after allocations. 2015-04-21 19:43:22 -07:00
usb_windows.cpp File header cleanup. 2015-03-19 15:32:33 -07:00