da75cef983
In form, inspired by ANDROID_BASE_UNIQUE_FD_DISABLE_IMPLICIT_CONVERSION. We get occasional bugs about sp double-ownership. When this flag is enabled, we have: - you must construct RefBase objects using sp<>::make - you must construct wp<> objects by converting them to sp<> - if you want to convert a raw pointer to an sp<> object (this is possible since the refcount is used internally, and is used commonly on this*), then you must use 'assertStrongRefExists' semantics which aborts if there is no strong ref held. That is, if a client uses std::make_shared and then calls a function which internally used to call `sp<T>(this)`, you would now call `sp<T>::assertStrongRefExists(this)`, and the double ownership problem would become a runtime error. Bug: 184190315 Test: libutils_test Change-Id: Ie18d3146420df1808e3733027070ec234dda4e9d
82 lines
2.4 KiB
C++
82 lines
2.4 KiB
C++
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <utils/StrongPointer.h>
|
|
#include <utils/RefBase.h>
|
|
|
|
using namespace android;
|
|
|
|
class SPFoo : virtual public RefBase {
|
|
public:
|
|
explicit SPFoo(bool* deleted_check) : mDeleted(deleted_check) {
|
|
*mDeleted = false;
|
|
}
|
|
|
|
~SPFoo() {
|
|
*mDeleted = true;
|
|
}
|
|
private:
|
|
bool* mDeleted;
|
|
};
|
|
|
|
TEST(StrongPointer, move) {
|
|
bool isDeleted;
|
|
sp<SPFoo> sp1 = sp<SPFoo>::make(&isDeleted);
|
|
SPFoo* foo = sp1.get();
|
|
ASSERT_EQ(1, foo->getStrongCount());
|
|
{
|
|
sp<SPFoo> sp2 = std::move(sp1);
|
|
ASSERT_EQ(1, foo->getStrongCount()) << "std::move failed, incremented refcnt";
|
|
ASSERT_EQ(nullptr, sp1.get()) << "std::move failed, sp1 is still valid";
|
|
// The strong count isn't increasing, let's double check the old object
|
|
// is properly reset and doesn't early delete
|
|
sp1 = std::move(sp2);
|
|
}
|
|
ASSERT_FALSE(isDeleted) << "deleted too early! still has a reference!";
|
|
{
|
|
// Now let's double check it deletes on time
|
|
sp<SPFoo> sp2 = std::move(sp1);
|
|
}
|
|
ASSERT_TRUE(isDeleted) << "foo was leaked!";
|
|
}
|
|
|
|
TEST(StrongPointer, NullptrComparison) {
|
|
sp<SPFoo> foo;
|
|
ASSERT_EQ(foo, nullptr);
|
|
ASSERT_EQ(nullptr, foo);
|
|
}
|
|
|
|
TEST(StrongPointer, PointerComparison) {
|
|
bool isDeleted;
|
|
sp<SPFoo> foo = sp<SPFoo>::make(&isDeleted);
|
|
ASSERT_EQ(foo.get(), foo);
|
|
ASSERT_EQ(foo, foo.get());
|
|
ASSERT_NE(nullptr, foo);
|
|
ASSERT_NE(foo, nullptr);
|
|
}
|
|
|
|
TEST(StrongPointer, AssertStrongRefExists) {
|
|
// uses some other refcounting method, or non at all
|
|
bool isDeleted;
|
|
SPFoo* foo = new SPFoo(&isDeleted);
|
|
|
|
// can only get a valid sp<> object when you construct it as an sp<> object
|
|
EXPECT_DEATH(sp<SPFoo>::fromExisting(foo), "");
|
|
|
|
delete foo;
|
|
}
|