92acaac8c7
Modify the code for the no header sections because it turns out that it is not okay to assume that the fdes are non-overlapping. It's necessary to read the fdes in order and match as you go. Modify the code so that it only reads until it finds the given pc rather than reading all of the cie/fde entries at once. Rewrote the tests to verify the new behavior. Bug: 68998033 Bug: 110235461 Test: Ran libbacktrace/libunwindstack unit tests. Test: Unwind the mediaserver process on a walleye and verify it Test: unwinds properly. Change-Id: I7bb59d1db72c13fa34caa9735ec34c1a60e20ed2
167 lines
5.2 KiB
C++
167 lines
5.2 KiB
C++
/*
|
|
* Copyright (C) 2016 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <stdint.h>
|
|
|
|
#include <gmock/gmock.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <unwindstack/DwarfSection.h>
|
|
|
|
#include "MemoryFake.h"
|
|
|
|
namespace unwindstack {
|
|
|
|
class MockDwarfSection : public DwarfSection {
|
|
public:
|
|
MockDwarfSection(Memory* memory) : DwarfSection(memory) {}
|
|
virtual ~MockDwarfSection() = default;
|
|
|
|
MOCK_METHOD3(Init, bool(uint64_t, uint64_t, uint64_t));
|
|
|
|
MOCK_METHOD5(Eval, bool(const DwarfCie*, Memory*, const dwarf_loc_regs_t&, Regs*, bool*));
|
|
|
|
MOCK_METHOD3(Log, bool(uint8_t, uint64_t, const DwarfFde*));
|
|
|
|
MOCK_METHOD1(GetFdes, void(std::vector<const DwarfFde*>*));
|
|
|
|
MOCK_METHOD1(GetFdeFromPc, const DwarfFde*(uint64_t));
|
|
|
|
MOCK_METHOD3(GetCfaLocationInfo, bool(uint64_t, const DwarfFde*, dwarf_loc_regs_t*));
|
|
|
|
MOCK_METHOD1(GetCieOffsetFromFde32, uint64_t(uint32_t));
|
|
|
|
MOCK_METHOD1(GetCieOffsetFromFde64, uint64_t(uint64_t));
|
|
|
|
MOCK_METHOD1(AdjustPcFromFde, uint64_t(uint64_t));
|
|
};
|
|
|
|
class DwarfSectionTest : public ::testing::Test {
|
|
protected:
|
|
void SetUp() override { section_.reset(new MockDwarfSection(&memory_)); }
|
|
|
|
MemoryFake memory_;
|
|
std::unique_ptr<MockDwarfSection> section_;
|
|
};
|
|
|
|
TEST_F(DwarfSectionTest, Step_fail_fde) {
|
|
EXPECT_CALL(*section_, GetFdeFromPc(0x1000)).WillOnce(::testing::Return(nullptr));
|
|
|
|
bool finished;
|
|
ASSERT_FALSE(section_->Step(0x1000, nullptr, nullptr, &finished));
|
|
}
|
|
|
|
TEST_F(DwarfSectionTest, Step_fail_cie_null) {
|
|
DwarfFde fde{};
|
|
fde.pc_end = 0x2000;
|
|
fde.cie = nullptr;
|
|
|
|
EXPECT_CALL(*section_, GetFdeFromPc(0x1000)).WillOnce(::testing::Return(&fde));
|
|
|
|
bool finished;
|
|
ASSERT_FALSE(section_->Step(0x1000, nullptr, nullptr, &finished));
|
|
}
|
|
|
|
TEST_F(DwarfSectionTest, Step_fail_cfa_location) {
|
|
DwarfCie cie{};
|
|
DwarfFde fde{};
|
|
fde.pc_end = 0x2000;
|
|
fde.cie = &cie;
|
|
|
|
EXPECT_CALL(*section_, GetFdeFromPc(0x1000)).WillOnce(::testing::Return(&fde));
|
|
EXPECT_CALL(*section_, GetCfaLocationInfo(0x1000, &fde, ::testing::_))
|
|
.WillOnce(::testing::Return(false));
|
|
|
|
bool finished;
|
|
ASSERT_FALSE(section_->Step(0x1000, nullptr, nullptr, &finished));
|
|
}
|
|
|
|
TEST_F(DwarfSectionTest, Step_pass) {
|
|
DwarfCie cie{};
|
|
DwarfFde fde{};
|
|
fde.pc_end = 0x2000;
|
|
fde.cie = &cie;
|
|
|
|
EXPECT_CALL(*section_, GetFdeFromPc(0x1000)).WillOnce(::testing::Return(&fde));
|
|
EXPECT_CALL(*section_, GetCfaLocationInfo(0x1000, &fde, ::testing::_))
|
|
.WillOnce(::testing::Return(true));
|
|
|
|
MemoryFake process;
|
|
EXPECT_CALL(*section_, Eval(&cie, &process, ::testing::_, nullptr, ::testing::_))
|
|
.WillOnce(::testing::Return(true));
|
|
|
|
bool finished;
|
|
ASSERT_TRUE(section_->Step(0x1000, nullptr, &process, &finished));
|
|
}
|
|
|
|
static bool MockGetCfaLocationInfo(::testing::Unused, const DwarfFde* fde,
|
|
dwarf_loc_regs_t* loc_regs) {
|
|
loc_regs->pc_start = fde->pc_start;
|
|
loc_regs->pc_end = fde->pc_end;
|
|
return true;
|
|
}
|
|
|
|
TEST_F(DwarfSectionTest, Step_cache) {
|
|
DwarfCie cie{};
|
|
DwarfFde fde{};
|
|
fde.pc_start = 0x500;
|
|
fde.pc_end = 0x2000;
|
|
fde.cie = &cie;
|
|
|
|
EXPECT_CALL(*section_, GetFdeFromPc(0x1000)).WillOnce(::testing::Return(&fde));
|
|
EXPECT_CALL(*section_, GetCfaLocationInfo(0x1000, &fde, ::testing::_))
|
|
.WillOnce(::testing::Invoke(MockGetCfaLocationInfo));
|
|
|
|
MemoryFake process;
|
|
EXPECT_CALL(*section_, Eval(&cie, &process, ::testing::_, nullptr, ::testing::_))
|
|
.WillRepeatedly(::testing::Return(true));
|
|
|
|
bool finished;
|
|
ASSERT_TRUE(section_->Step(0x1000, nullptr, &process, &finished));
|
|
ASSERT_TRUE(section_->Step(0x1000, nullptr, &process, &finished));
|
|
ASSERT_TRUE(section_->Step(0x1500, nullptr, &process, &finished));
|
|
}
|
|
|
|
TEST_F(DwarfSectionTest, Step_cache_not_in_pc) {
|
|
DwarfCie cie{};
|
|
DwarfFde fde0{};
|
|
fde0.pc_start = 0x1000;
|
|
fde0.pc_end = 0x2000;
|
|
fde0.cie = &cie;
|
|
EXPECT_CALL(*section_, GetFdeFromPc(0x1000)).WillOnce(::testing::Return(&fde0));
|
|
EXPECT_CALL(*section_, GetCfaLocationInfo(0x1000, &fde0, ::testing::_))
|
|
.WillOnce(::testing::Invoke(MockGetCfaLocationInfo));
|
|
|
|
MemoryFake process;
|
|
EXPECT_CALL(*section_, Eval(&cie, &process, ::testing::_, nullptr, ::testing::_))
|
|
.WillRepeatedly(::testing::Return(true));
|
|
|
|
bool finished;
|
|
ASSERT_TRUE(section_->Step(0x1000, nullptr, &process, &finished));
|
|
|
|
DwarfFde fde1{};
|
|
fde1.pc_start = 0x500;
|
|
fde1.pc_end = 0x800;
|
|
fde1.cie = &cie;
|
|
EXPECT_CALL(*section_, GetFdeFromPc(0x600)).WillOnce(::testing::Return(&fde1));
|
|
EXPECT_CALL(*section_, GetCfaLocationInfo(0x600, &fde1, ::testing::_))
|
|
.WillOnce(::testing::Invoke(MockGetCfaLocationInfo));
|
|
|
|
ASSERT_TRUE(section_->Step(0x600, nullptr, &process, &finished));
|
|
ASSERT_TRUE(section_->Step(0x700, nullptr, &process, &finished));
|
|
}
|
|
|
|
} // namespace unwindstack
|