c6ce48ef19
Bug: 290835996
Test: libutils_fuzz_string8 for several minutes
String8::removeAll() has 2 serious problems:
1. When `other` is an empty string, `removeAll()` will loop infinitely
due to below process:
a) with `other` being empty string `""`, find() will call strstr()
on an empty string, which always returns `mString`, and thus
find() always return 0 in this case
b) with find() returns 0 for empty string, the next while loop in
String8::removeAll() will keep loop infinitely as `index` will
always be 0
This CL fixes this problem by returning true if `other` is an empty
string (i.e. `strlen(other) == 0`), this follows the logic that an
empty string will always be found and no actual remove needs to be
done.
2. When `other` is a NULL string, strstr() has undefined behavior. See
https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1570.pdf.
This undefined behavior on Android unfortunately causes immediate
segmentation fault as the current `strstr` implementation in bionic
libc doesn't check `needle` being NULL, and an access to a NULL
location is performed to check if the `needle` string is an empty
string, and thus causes segmentation fault.
This CL gives an error message and aborts instead of having a
segfault, and to keep some backward compatibility.
This CL also adds test for String8::removeAll()
Change-Id: Ie2ccee6767efe0fed476db4ec6072717198279e9
134 lines
3.9 KiB
C++
134 lines
3.9 KiB
C++
/*
|
|
* Copyright (C) 2010 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#define LOG_TAG "String8_test"
|
|
|
|
#include <utils/Log.h>
|
|
#include <utils/String8.h>
|
|
#include <utils/String16.h>
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
using namespace android;
|
|
|
|
class String8Test : public testing::Test {
|
|
protected:
|
|
virtual void SetUp() {
|
|
}
|
|
|
|
virtual void TearDown() {
|
|
}
|
|
};
|
|
|
|
TEST_F(String8Test, Cstr) {
|
|
String8 tmp("Hello, world!");
|
|
|
|
EXPECT_STREQ(tmp.string(), "Hello, world!");
|
|
}
|
|
|
|
TEST_F(String8Test, OperatorPlus) {
|
|
String8 src1("Hello, ");
|
|
|
|
// Test adding String8 + const char*
|
|
const char* ccsrc2 = "world!";
|
|
String8 dst1 = src1 + ccsrc2;
|
|
EXPECT_STREQ(dst1.string(), "Hello, world!");
|
|
EXPECT_STREQ(src1.string(), "Hello, ");
|
|
EXPECT_STREQ(ccsrc2, "world!");
|
|
|
|
// Test adding String8 + String8
|
|
String8 ssrc2("world!");
|
|
String8 dst2 = src1 + ssrc2;
|
|
EXPECT_STREQ(dst2.string(), "Hello, world!");
|
|
EXPECT_STREQ(src1.string(), "Hello, ");
|
|
EXPECT_STREQ(ssrc2.string(), "world!");
|
|
}
|
|
|
|
TEST_F(String8Test, OperatorPlusEquals) {
|
|
String8 src1("My voice");
|
|
|
|
// Testing String8 += String8
|
|
String8 src2(" is my passport.");
|
|
src1 += src2;
|
|
EXPECT_STREQ(src1.string(), "My voice is my passport.");
|
|
EXPECT_STREQ(src2.string(), " is my passport.");
|
|
|
|
// Adding const char* to the previous string.
|
|
const char* src3 = " Verify me.";
|
|
src1 += src3;
|
|
EXPECT_STREQ(src1.string(), "My voice is my passport. Verify me.");
|
|
EXPECT_STREQ(src2.string(), " is my passport.");
|
|
EXPECT_STREQ(src3, " Verify me.");
|
|
}
|
|
|
|
TEST_F(String8Test, SetToSizeMaxReturnsNoMemory) {
|
|
const char *in = "some string";
|
|
EXPECT_EQ(NO_MEMORY, String8("").setTo(in, SIZE_MAX));
|
|
}
|
|
|
|
// http://b/29250543
|
|
TEST_F(String8Test, CorrectInvalidSurrogate) {
|
|
// d841d8 is an invalid start for a surrogate pair. Make sure this is handled by ignoring the
|
|
// first character in the pair and handling the rest correctly.
|
|
String16 string16(u"\xd841\xd841\xdc41\x0000");
|
|
String8 string8(string16);
|
|
|
|
EXPECT_EQ(4U, string8.length());
|
|
}
|
|
|
|
TEST_F(String8Test, CheckUtf32Conversion) {
|
|
// Since bound checks were added, check the conversion can be done without fatal errors.
|
|
// The utf8 lengths of these are chars are 1 + 2 + 3 + 4 = 10.
|
|
const char32_t string32[] = U"\x0000007f\x000007ff\x0000911\x0010fffe";
|
|
String8 string8(string32);
|
|
EXPECT_EQ(10U, string8.length());
|
|
}
|
|
|
|
TEST_F(String8Test, ValidUtf16Conversion) {
|
|
char16_t tmp[] = u"abcdef";
|
|
String8 valid = String8(String16(tmp));
|
|
EXPECT_STREQ(valid, "abcdef");
|
|
}
|
|
|
|
TEST_F(String8Test, append) {
|
|
String8 s;
|
|
EXPECT_EQ(OK, s.append("foo"));
|
|
EXPECT_STREQ("foo", s);
|
|
EXPECT_EQ(OK, s.append("bar"));
|
|
EXPECT_STREQ("foobar", s);
|
|
EXPECT_EQ(OK, s.append("baz", 0));
|
|
EXPECT_STREQ("foobar", s);
|
|
EXPECT_EQ(NO_MEMORY, s.append("baz", SIZE_MAX));
|
|
EXPECT_STREQ("foobar", s);
|
|
}
|
|
|
|
TEST_F(String8Test, removeAll) {
|
|
String8 s("Hello, world!");
|
|
|
|
// NULL input should cause an assertion failure and error message in logcat
|
|
EXPECT_DEATH(s.removeAll(NULL), "");
|
|
|
|
// expect to return true and string content should remain unchanged
|
|
EXPECT_TRUE(s.removeAll(""));
|
|
EXPECT_STREQ("Hello, world!", s);
|
|
|
|
// expect to return false
|
|
EXPECT_FALSE(s.removeAll("x"));
|
|
EXPECT_STREQ("Hello, world!", s);
|
|
|
|
EXPECT_TRUE(s.removeAll("o"));
|
|
EXPECT_STREQ("Hell, wrld!", s);
|
|
}
|