Created libkeystore-engine as cc-library instead of cc-test-library to

avoid issues while linking shared libraries with Rust test binaries.

This change is made to avoid vts-tradefed failure to link the shared
library while running the Rust VTS `keystore2_client_tests` test
suite. As suggested in b/314110490#24 using the libkeystore-engine
static-library to run keystore2_client_tests.

Bug: 314110490, 298668920
Test: atest keystore2_client_tests; run vts -m keystore2_client_tests
Change-Id: If956865eeb4af908f33b1ad81a2b2e26300aae0e
This commit is contained in:
Rajesh Nyamagoud 2024-01-03 01:01:17 +00:00
parent df2668bd96
commit 4347357814
2 changed files with 10 additions and 3 deletions

View file

@ -21,9 +21,14 @@ package {
default_applicable_licenses: ["system_security_license"], default_applicable_licenses: ["system_security_license"],
} }
cc_test_library { // This is expected to be cc_test_library but due to issue mentioned in b/298668920, b/314110490
// we are creating cc_library and using static library to link with `keystore_client_tests`.
cc_library {
name: "libkeystore-engine", name: "libkeystore-engine",
defaults: [
"keystore2_use_latest_aidl_ndk_shared",
],
srcs: [ srcs: [
"android_engine.cpp", "android_engine.cpp",
"keystore2_engine.cpp", "keystore2_engine.cpp",

View file

@ -43,13 +43,14 @@ rust_defaults {
], ],
static_libs: [ static_libs: [
"libkeystore2_ffi_test_utils", "libkeystore2_ffi_test_utils",
"libkeystore-engine",
], ],
shared_libs: [ shared_libs: [
"android.system.keystore2-V3-ndk",
"libbase", "libbase",
"libcrypto", "libcrypto",
"libkeymaster_portable", "libkeymaster_portable",
"libkeymint_support", "libkeymint_support",
"libkeystore-engine",
], ],
} }
@ -75,17 +76,18 @@ cc_library_static {
srcs: ["ffi_test_utils.cpp"], srcs: ["ffi_test_utils.cpp"],
defaults: [ defaults: [
"keymint_use_latest_hal_aidl_ndk_shared", "keymint_use_latest_hal_aidl_ndk_shared",
"keystore2_use_latest_aidl_ndk_shared",
], ],
generated_headers: [ generated_headers: [
"cxx-bridge-header", "cxx-bridge-header",
"libkeystore2_ffi_test_utils_bridge_header", "libkeystore2_ffi_test_utils_bridge_header",
], ],
generated_sources: ["libkeystore2_ffi_test_utils_bridge_code"], generated_sources: ["libkeystore2_ffi_test_utils_bridge_code"],
static_libs: ["libkeystore-engine"],
shared_libs: [ shared_libs: [
"libbase", "libbase",
"libcrypto", "libcrypto",
"libkeymaster_portable", "libkeymaster_portable",
"libkeystore-engine",
"libkeymint_support", "libkeymint_support",
], ],
} }