tequilaOS/platform_system_security
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use stream operator to report result code

Browse source 
The cast operator for KeyStoreNativeReturnCode and
KeyStoreNativeReturnCode will be removed later.
There already exists a stream operator to get
at the underlying value. Use that instead.

Bug: 119771891
Test: Built for walleye successfully, basic operations with
      keystore_cli_v2 tool work correctly.
Change-Id: I357e0582841b1deadbffd59bb49b5ae8542c9aee
This commit is contained in:
Branden Archer 2018-11-20 10:53:25 -08:00
parent 50e9c3a684
commit 7cb02e3c8e
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
keystore-engine/keystore_backend_binder.cpp
View file

@ -156,7 +156,7 @@ int32_t KeystoreBackendBinder::sign(const char* key_id, const uint8_t* in, size_
OperationResult result = future.get();
if (!result.resultCode.isOk()) {
LOG(ERROR) << AT << "begin failed: " << int32_t(result.resultCode);
LOG(ERROR) << AT << "begin failed: " << result.resultCode;
return -1;
}
auto handle = std::move(result.token);
@ -180,7 +180,7 @@ int32_t KeystoreBackendBinder::sign(const char* key_id, const uint8_t* in, size_
result = future.get();
if (!result.resultCode.isOk()) {
LOG(ERROR) << AT << "update failed: " << int32_t(result.resultCode);
LOG(ERROR) << AT << "update failed: " << result.resultCode;
return -1;
}
@ -199,7 +199,7 @@ int32_t KeystoreBackendBinder::sign(const char* key_id, const uint8_t* in, size_
if (!KSReturn(error_code).isOk()) {
LOG(ERROR) << AT << "abort failed: " << error_code;
} else if (!(rc = KSReturn(abortFuture.get().response_code())).isOk()) {
LOG(ERROR) << AT << "abort failed: " << int32_t(rc);
LOG(ERROR) << AT << "abort failed: " << rc;
}
return -1;
}
@ -228,7 +228,7 @@ int32_t KeystoreBackendBinder::sign(const char* key_id, const uint8_t* in, size_
result = future.get();
if (!result.resultCode.isOk()) {
LOG(ERROR) << AT << "finish failed: " << int32_t(result.resultCode);
LOG(ERROR) << AT << "finish failed: " << result.resultCode;
return -1;
}
@ -272,7 +272,7 @@ int32_t KeystoreBackendBinder::get_pubkey(const char* key_id, uint8_t** pubkey,
auto export_result = future.get();
if (!export_result.resultCode.isOk()) {
LOG(ERROR) << AT << "exportKey failed: " << int32_t(export_result.resultCode);
LOG(ERROR) << AT << "exportKey failed: " << export_result.resultCode;
return -1;
}