From 153d1aaff4939f7fd9f39b95177c8fe836dd912d Mon Sep 17 00:00:00 2001 From: Jeff Vander Stoep Date: Wed, 7 Feb 2024 14:33:36 +0100 Subject: [PATCH] Replace use of deprecated logging functions This is needed to upgrade the android_logger crate from 0.12.0 to 0.13.3. with_max_level provides the same functionality as with_min_level. The renaming is admittedly confusing, but the new name is accurate and it makes sense that they deprecated and then removed the previously poorly named with_min_level. See crate documentation [1] and code [2]. [1]: https://docs.rs/android_logger/0.12.0/android_logger/struct.Config.html#method.with_min_level [2]: https://docs.rs/android_logger/0.12.0/src/android_logger/lib.rs.html#227 Bug: 322718401 Test: build and run CF with the change. Test: m aosp_cf_x86_64_phone Change-Id: Ibd13989ffe52a93191dd2d5a1b8f5a651eecd91d --- keystore2/selinux/src/concurrency_test.rs | 2 +- keystore2/selinux/src/lib.rs | 2 +- keystore2/src/error.rs | 2 +- keystore2/watchdog/src/lib.rs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/keystore2/selinux/src/concurrency_test.rs b/keystore2/selinux/src/concurrency_test.rs index a5d2df2c..fa97f3aa 100644 --- a/keystore2/selinux/src/concurrency_test.rs +++ b/keystore2/selinux/src/concurrency_test.rs @@ -69,7 +69,7 @@ fn test_concurrent_check_access() { android_logger::init_once( android_logger::Config::default() .with_tag("keystore2_selinux_concurrency_test") - .with_min_level(log::Level::Debug), + .with_max_level(log::LevelFilter::Debug), ); let cpus = num_cpus::get(); diff --git a/keystore2/selinux/src/lib.rs b/keystore2/selinux/src/lib.rs index 32fdb594..695e0291 100644 --- a/keystore2/selinux/src/lib.rs +++ b/keystore2/selinux/src/lib.rs @@ -720,7 +720,7 @@ mod tests { android_logger::init_once( android_logger::Config::default() .with_tag("keystore_selinux_tests") - .with_min_level(log::Level::Debug), + .with_max_level(log::LevelFilter::Debug), ); let scontext = Context::new("u:r:shell:s0")?; let backend = KeystoreKeyBackend::new()?; diff --git a/keystore2/src/error.rs b/keystore2/src/error.rs index b4c57fbd..f0d0d27b 100644 --- a/keystore2/src/error.rs +++ b/keystore2/src/error.rs @@ -352,7 +352,7 @@ pub mod tests { android_logger::init_once( android_logger::Config::default() .with_tag("keystore_error_tests") - .with_min_level(log::Level::Debug), + .with_max_level(log::LevelFilter::Debug), ); // All Error::Rc(x) get mapped on a service specific error // code of x. diff --git a/keystore2/watchdog/src/lib.rs b/keystore2/watchdog/src/lib.rs index 01043c55..fa4620a8 100644 --- a/keystore2/watchdog/src/lib.rs +++ b/keystore2/watchdog/src/lib.rs @@ -335,7 +335,7 @@ mod tests { android_logger::init_once( android_logger::Config::default() .with_tag("keystore2_watchdog_tests") - .with_min_level(log::Level::Debug), + .with_max_level(log::LevelFilter::Debug), ); let wd = Watchdog::new(Watchdog::NOISY_REPORT_TIMEOUT.checked_mul(3).unwrap());