b5613dae22
Remove IKeystoreMaintenance#onDeviceOffBody(), as it's no longer called. In addition, remove the code that tried to enforce the AllowWhileOnBody key parameter. This code was broken during the rewrite of Keystore in Android 12, and as a result, AllowWhileOnBody has no user-visible effect. AllowWhileOnBody is *supposed* to cause the key's authentication timeout, if it has one, to automatically expire when the device is removed from the user's body. (A better name for it might have been something like UserAuthenticationExpiresWhenRemovedFromBody.) Android 11 Keystore implemented this behavior; see https://android.googlesource.com/platform/system/security/+/refs/heads/android11-release/keystore/auth_token_table.cpp#165 Android 12 Keystore changed AllowWhileOnBody to have no effect. Apparently due to a misunderstanding, the (incorrect) behavior that was attempted to be implemented was "The key may be used after authentication timeout if device is still on-body". But what was actually implemented was that the Keystore daemon stopped enforcing authentication timeouts for AllowWhileOnBody keys entirely, except after a wearable device was removed from the body in which case the timeout is enforced for any earlier authentications. Yet, this has no user-visible effect because KeyMint still enforces the authentication timeout as usual. So, AllowWhileOnBody has really been a no-op since Android 12. We can always bring this code back, fixed and with tests, if this feature comes back. But for now there is no reason to keep it around. Bug: 289849354 Test: atest -p --include-subdirs system/security/keystore2 Test: atest CtsKeystoreTestCases Change-Id: I4a7b3a90b56dacbb5316e30a30bf3fabc0debe48 |
||
---|---|---|
.. | ||
aaid | ||
aconfig | ||
aidl | ||
apc_compat | ||
legacykeystore | ||
message_macro | ||
rkpd_client | ||
selinux | ||
src | ||
test_utils | ||
tests | ||
watchdog | ||
Android.bp | ||
android.system.keystore2-service.xml | ||
keystore2.rc | ||
OWNERS | ||
rustfmt.toml | ||
TEST_MAPPING |