platform_system_sepolicy/tools/checkfc.c

500 lines
15 KiB
C
Raw Normal View History

#include <getopt.h>
#include <stdbool.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <sepol/module.h>
#include <sepol/policydb/policydb.h>
#include <sepol/sepol.h>
Add checkfc mode to validate file_contexts against test data A new mode for checkfc is introduced (-t) which takes a file_contexts and a test data file. Each line in the test data file contains a path and the expected type. checkfc loads the file_contexts and repeatedly calls selabel_lookup(3) to verify that the computed type is as expected. This mode can be used to confirm that any modification to file_contexts or its build process is benign. A test data file (plat_file_contexts_test) is added. This file was manually created based on private/file_contexts. Each static path was copied as-is. Each regular expression was expanded into a couple of entries. For instance, /dev/adf[0-9]* generated /dev/adf, /dev/adf0 and /dev/adf123. libselinux keeps track of which specification is being hit when using selabel_lookup. When calling selabel_stats(3), the file backend will output a warning if a specification has not been used. This can be leveraged to ensure that each rule is at least hit once. This property will be leveraged in a follow-up change (by running the test as part of the build process), to ensure that the plat_file_contexts_test file remains up-to-date (that is, when an entry is added to private/file_contexts, the build will fail unless a test is also added to plat_file_contexts_test to exercice the specification/regular expression). Test: m checkfc && checkfc -t ./private/file_contexts ./tests/plat_file_contexts_test Bug: 299839280 Change-Id: Ibf56859a16bd17e1f878ce7b0570b2aead79c7e0
2023-10-05 00:44:24 +02:00
#include <selinux/context.h>
#include <selinux/selinux.h>
#include <selinux/label.h>
#include <sys/stat.h>
#include <sys/types.h>
static const char * const CHECK_FC_ASSERT_ATTRS[] = { "fs_type", "dev_type", "file_type", NULL };
static const char * const CHECK_PC_ASSERT_ATTRS[] = { "property_type", NULL };
static const char * const CHECK_SC_ASSERT_ATTRS[] = { "service_manager_type", NULL };
static const char * const CHECK_HW_SC_ASSERT_ATTRS[] = { "hwservice_manager_type", NULL };
static const char * const CHECK_VND_SC_ASSERT_ATTRS[] = { "vndservice_manager_type", NULL };
typedef enum filemode filemode;
enum filemode {
filemode_file_contexts = 0,
filemode_property_contexts,
filemode_service_contexts,
filemode_hw_service_contexts,
filemode_vendor_service_contexts
};
static struct {
/* policy */
struct {
union {
/* Union these so we don't have to cast */
sepol_policydb_t *sdb;
policydb_t *pdb;
};
sepol_policy_file_t *pf;
sepol_handle_t *handle;
FILE *file;
#define SEHANDLE_CNT 2
struct selabel_handle *sehnd[SEHANDLE_CNT];
} sepolicy;
/* assertions */
struct {
const char * const *attrs; /* for the original set to print on error */
ebitmap_t set; /* the ebitmap representation of the attrs */
} assert;
} global_state;
static const char * const *filemode_to_assert_attrs(filemode mode)
{
switch (mode) {
case filemode_file_contexts:
return CHECK_FC_ASSERT_ATTRS;
case filemode_property_contexts:
return CHECK_PC_ASSERT_ATTRS;
case filemode_service_contexts:
return CHECK_SC_ASSERT_ATTRS;
case filemode_hw_service_contexts:
return CHECK_HW_SC_ASSERT_ATTRS;
case filemode_vendor_service_contexts:
return CHECK_VND_SC_ASSERT_ATTRS;
}
/* die on invalid parameters */
fprintf(stderr, "Error: Invalid mode of operation: %d\n", mode);
exit(1);
}
static int get_attr_bit(policydb_t *policydb, const char *attr_name)
{
struct type_datum *attr = hashtab_search(policydb->p_types.table, (char *)attr_name);
if (!attr) {
fprintf(stderr, "Error: \"%s\" is not defined in this policy.\n", attr_name);
return -1;
}
if (attr->flavor != TYPE_ATTRIB) {
fprintf(stderr, "Error: \"%s\" is not an attribute in this policy.\n", attr_name);
return -1;
}
return attr->s.value - 1;
}
static bool ebitmap_attribute_assertion_init(ebitmap_t *assertions, const char * const attributes[])
{
while (*attributes) {
int bit_pos = get_attr_bit(global_state.sepolicy.pdb, *attributes);
if (bit_pos < 0) {
/* get_attr_bit() logs error */
return false;
}
int err = ebitmap_set_bit(assertions, bit_pos, 1);
if (err) {
fprintf(stderr, "Error: setting bit on assertion ebitmap!\n");
return false;
}
attributes++;
}
return true;
}
static bool is_type_of_attribute_set(policydb_t *policydb, const char *type_name,
ebitmap_t *attr_set)
{
struct type_datum *type = hashtab_search(policydb->p_types.table, (char *)type_name);
if (!type) {
fprintf(stderr, "Error: \"%s\" is not defined in this policy.\n", type_name);
return false;
}
if (type->flavor != TYPE_TYPE) {
fprintf(stderr, "Error: \"%s\" is not a type in this policy.\n", type_name);
return false;
}
ebitmap_t dst;
ebitmap_init(&dst);
/* Take the intersection, if the set is empty, then its a failure */
int rc = ebitmap_and(&dst, attr_set, &policydb->type_attr_map[type->s.value - 1]);
if (rc) {
fprintf(stderr, "Error: Could not perform ebitmap_and: %d\n", rc);
exit(1);
}
bool res = (bool)ebitmap_length(&dst);
ebitmap_destroy(&dst);
return res;
}
static void dump_char_array(FILE *stream, const char * const *strings)
{
const char * const *p = strings;
fprintf(stream, "\"");
while (*p) {
const char *s = *p++;
const char *fmt = *p ? "%s, " : "%s\"";
fprintf(stream, fmt, s);
}
}
static int validate(char **contextp)
{
bool res;
char *context = *contextp;
sepol_context_t *ctx;
int rc = sepol_context_from_string(global_state.sepolicy.handle, context,
&ctx);
if (rc < 0) {
fprintf(stderr, "Error: Could not allocate context from string");
exit(1);
}
rc = sepol_context_check(global_state.sepolicy.handle,
global_state.sepolicy.sdb, ctx);
if (rc < 0) {
goto out;
}
const char *type_name = sepol_context_get_type(ctx);
// Temporarily exempt hal_power_stats_vendor_service from the check.
// TODO(b/211953546): remove this
if (strcmp(type_name, "hal_power_stats_vendor_service") == 0) {
goto out;
}
uint32_t len = ebitmap_length(&global_state.assert.set);
if (len > 0) {
res = !is_type_of_attribute_set(global_state.sepolicy.pdb, type_name,
&global_state.assert.set);
if (res) {
fprintf(stderr, "Error: type \"%s\" is not of set: ", type_name);
dump_char_array(stderr, global_state.assert.attrs);
fprintf(stderr, "\n");
/* The calls above did not affect rc, so set error before going to out */
rc = -1;
goto out;
}
}
/* Success: Although it should be 0, we explicitly set rc to 0 for clarity */
rc = 0;
out:
sepol_context_free(ctx);
return rc;
}
static void usage(char *name) {
fprintf(stderr, "usage1: %s [-l|-p|-s|-v] [-e] sepolicy context_file\n\n"
"Parses a context file and checks for syntax errors.\n"
"If -p is specified, the property backend is used.\n"
"If -s is specified, the service backend is used to verify binder services.\n"
"If -l is specified, the service backend is used to verify hwbinder services.\n"
"If -v is specified, the service backend is used to verify vndbinder services.\n"
"Otherwise, context_file is assumed to be a file_contexts file\n"
"If -e is specified, then the context_file is allowed to be empty.\n\n"
"usage2: %s -c file_contexts1 file_contexts2\n\n"
Add checkfc mode to validate file_contexts against test data A new mode for checkfc is introduced (-t) which takes a file_contexts and a test data file. Each line in the test data file contains a path and the expected type. checkfc loads the file_contexts and repeatedly calls selabel_lookup(3) to verify that the computed type is as expected. This mode can be used to confirm that any modification to file_contexts or its build process is benign. A test data file (plat_file_contexts_test) is added. This file was manually created based on private/file_contexts. Each static path was copied as-is. Each regular expression was expanded into a couple of entries. For instance, /dev/adf[0-9]* generated /dev/adf, /dev/adf0 and /dev/adf123. libselinux keeps track of which specification is being hit when using selabel_lookup. When calling selabel_stats(3), the file backend will output a warning if a specification has not been used. This can be leveraged to ensure that each rule is at least hit once. This property will be leveraged in a follow-up change (by running the test as part of the build process), to ensure that the plat_file_contexts_test file remains up-to-date (that is, when an entry is added to private/file_contexts, the build will fail unless a test is also added to plat_file_contexts_test to exercice the specification/regular expression). Test: m checkfc && checkfc -t ./private/file_contexts ./tests/plat_file_contexts_test Bug: 299839280 Change-Id: Ibf56859a16bd17e1f878ce7b0570b2aead79c7e0
2023-10-05 00:44:24 +02:00
"Compares two file contexts files and reports one of \n"
"subset, equal, superset, or incomparable.\n\n"
"usage3: %s -t file_contexts test_data\n\n"
"Validates a file contexts file against test_data.\n"
"test_data is a text file where each line has the format:\n"
" path expected_type\n\n\n",
name, name, name);
exit(1);
}
static void cleanup(void) {
if (global_state.sepolicy.file) {
fclose(global_state.sepolicy.file);
}
if (global_state.sepolicy.sdb) {
sepol_policydb_free(global_state.sepolicy.sdb);
}
if (global_state.sepolicy.pf) {
sepol_policy_file_free(global_state.sepolicy.pf);
}
if (global_state.sepolicy.handle) {
sepol_handle_destroy(global_state.sepolicy.handle);
}
ebitmap_destroy(&global_state.assert.set);
int i;
for (i = 0; i < SEHANDLE_CNT; i++) {
struct selabel_handle *sehnd = global_state.sepolicy.sehnd[i];
if (sehnd) {
selabel_close(sehnd);
}
}
}
static void do_compare_and_die_on_error(struct selinux_opt opts[], unsigned int backend, char *paths[])
{
enum selabel_cmp_result result;
char *result_str[] = { "subset", "equal", "superset", "incomparable" };
int i;
opts[0].value = NULL; /* not validating against a policy when comparing */
for (i = 0; i < SEHANDLE_CNT; i++) {
opts[1].value = paths[i];
global_state.sepolicy.sehnd[i] = selabel_open(backend, opts, 2);
if (!global_state.sepolicy.sehnd[i]) {
fprintf(stderr, "Error: could not load context file from %s\n", paths[i]);
exit(1);
}
}
result = selabel_cmp(global_state.sepolicy.sehnd[0], global_state.sepolicy.sehnd[1]);
printf("%s\n", result_str[result]);
}
static int warnings = 0;
static int log_callback(int type, const char *fmt, ...) {
va_list ap;
if (type == SELINUX_WARNING) {
warnings += 1;
}
va_start(ap, fmt);
vfprintf(stderr, fmt, ap);
va_end(ap);
return 0;
}
Add checkfc mode to validate file_contexts against test data A new mode for checkfc is introduced (-t) which takes a file_contexts and a test data file. Each line in the test data file contains a path and the expected type. checkfc loads the file_contexts and repeatedly calls selabel_lookup(3) to verify that the computed type is as expected. This mode can be used to confirm that any modification to file_contexts or its build process is benign. A test data file (plat_file_contexts_test) is added. This file was manually created based on private/file_contexts. Each static path was copied as-is. Each regular expression was expanded into a couple of entries. For instance, /dev/adf[0-9]* generated /dev/adf, /dev/adf0 and /dev/adf123. libselinux keeps track of which specification is being hit when using selabel_lookup. When calling selabel_stats(3), the file backend will output a warning if a specification has not been used. This can be leveraged to ensure that each rule is at least hit once. This property will be leveraged in a follow-up change (by running the test as part of the build process), to ensure that the plat_file_contexts_test file remains up-to-date (that is, when an entry is added to private/file_contexts, the build will fail unless a test is also added to plat_file_contexts_test to exercice the specification/regular expression). Test: m checkfc && checkfc -t ./private/file_contexts ./tests/plat_file_contexts_test Bug: 299839280 Change-Id: Ibf56859a16bd17e1f878ce7b0570b2aead79c7e0
2023-10-05 00:44:24 +02:00
static void do_test_data_and_die_on_error(struct selinux_opt opts[], unsigned int backend,
char *paths[])
{
opts[0].value = NULL; /* not validating against a policy */
opts[1].value = paths[0];
global_state.sepolicy.sehnd[0] = selabel_open(backend, opts, 2);
if (!global_state.sepolicy.sehnd[0]) {
fprintf(stderr, "Error: could not load context file from %s: %s\n",
paths[0], strerror(errno));
exit(1);
}
FILE* test_data = fopen(paths[1], "r");
if (test_data == NULL) {
fprintf(stderr, "Error: could not load test file from %s : %s\n",
paths[1], strerror(errno));
exit(1);
}
char line[1024];
while (fgets(line, sizeof(line), test_data)) {
char *path;
char *expected_type;
if (!strcmp(line, "\n") || line[0] == '#') {
continue;
}
int ret = sscanf(line, "%ms %ms", &path, &expected_type);
if (ret != 2) {
fprintf(stderr, "Error: unable to parse the line %s\n", line);
exit(1);
}
char *found_context;
ret = selabel_lookup(global_state.sepolicy.sehnd[0], &found_context, path, 0);
if (ret != 0) {
fprintf(stderr, "Error: unable to lookup the path for %s\n", line);
exit(1);
}
context_t found = context_new(found_context);
const char *found_type = context_type_get(found);
if (strcmp(found_type, expected_type)) {
fprintf(stderr, "Incorrect type for %s: resolved to %s, expected %s\n",
path, found_type, expected_type);
}
free(found_context);
context_free(found);
free(path);
free(expected_type);
}
fclose(test_data);
// Prints the coverage of file_contexts on the test data. It includes
// warnings for rules that have not been hit by any test example.
union selinux_callback cb;
cb.func_log = log_callback;
selinux_set_callback(SELINUX_CB_LOG, cb);
Add checkfc mode to validate file_contexts against test data A new mode for checkfc is introduced (-t) which takes a file_contexts and a test data file. Each line in the test data file contains a path and the expected type. checkfc loads the file_contexts and repeatedly calls selabel_lookup(3) to verify that the computed type is as expected. This mode can be used to confirm that any modification to file_contexts or its build process is benign. A test data file (plat_file_contexts_test) is added. This file was manually created based on private/file_contexts. Each static path was copied as-is. Each regular expression was expanded into a couple of entries. For instance, /dev/adf[0-9]* generated /dev/adf, /dev/adf0 and /dev/adf123. libselinux keeps track of which specification is being hit when using selabel_lookup. When calling selabel_stats(3), the file backend will output a warning if a specification has not been used. This can be leveraged to ensure that each rule is at least hit once. This property will be leveraged in a follow-up change (by running the test as part of the build process), to ensure that the plat_file_contexts_test file remains up-to-date (that is, when an entry is added to private/file_contexts, the build will fail unless a test is also added to plat_file_contexts_test to exercice the specification/regular expression). Test: m checkfc && checkfc -t ./private/file_contexts ./tests/plat_file_contexts_test Bug: 299839280 Change-Id: Ibf56859a16bd17e1f878ce7b0570b2aead79c7e0
2023-10-05 00:44:24 +02:00
selabel_stats(global_state.sepolicy.sehnd[0]);
if (warnings) {
fprintf(stderr, "No test entries were found for the contexts above. " \
"You may need to update %s.\n", paths[1]);
exit(1);
}
Add checkfc mode to validate file_contexts against test data A new mode for checkfc is introduced (-t) which takes a file_contexts and a test data file. Each line in the test data file contains a path and the expected type. checkfc loads the file_contexts and repeatedly calls selabel_lookup(3) to verify that the computed type is as expected. This mode can be used to confirm that any modification to file_contexts or its build process is benign. A test data file (plat_file_contexts_test) is added. This file was manually created based on private/file_contexts. Each static path was copied as-is. Each regular expression was expanded into a couple of entries. For instance, /dev/adf[0-9]* generated /dev/adf, /dev/adf0 and /dev/adf123. libselinux keeps track of which specification is being hit when using selabel_lookup. When calling selabel_stats(3), the file backend will output a warning if a specification has not been used. This can be leveraged to ensure that each rule is at least hit once. This property will be leveraged in a follow-up change (by running the test as part of the build process), to ensure that the plat_file_contexts_test file remains up-to-date (that is, when an entry is added to private/file_contexts, the build will fail unless a test is also added to plat_file_contexts_test to exercice the specification/regular expression). Test: m checkfc && checkfc -t ./private/file_contexts ./tests/plat_file_contexts_test Bug: 299839280 Change-Id: Ibf56859a16bd17e1f878ce7b0570b2aead79c7e0
2023-10-05 00:44:24 +02:00
}
static void do_fc_check_and_die_on_error(struct selinux_opt opts[], unsigned int backend, filemode mode,
const char *sepolicy_file, const char *context_file, bool allow_empty)
{
struct stat sb;
if (stat(context_file, &sb) < 0) {
perror("Error: could not get stat on file contexts file");
exit(1);
}
if (sb.st_size == 0) {
/* Nothing to check on empty file_contexts file if allowed*/
if (allow_empty) {
return;
}
/* else: We could throw the error here, but libselinux backend will catch it */
}
global_state.sepolicy.file = fopen(sepolicy_file, "r");
if (!global_state.sepolicy.file) {
perror("Error: could not open policy file");
exit(1);
}
global_state.sepolicy.handle = sepol_handle_create();
if (!global_state.sepolicy.handle) {
fprintf(stderr, "Error: could not create policy handle: %s\n", strerror(errno));
exit(1);
}
if (sepol_policy_file_create(&global_state.sepolicy.pf) < 0) {
perror("Error: could not create policy handle");
exit(1);
}
sepol_policy_file_set_fp(global_state.sepolicy.pf, global_state.sepolicy.file);
sepol_policy_file_set_handle(global_state.sepolicy.pf, global_state.sepolicy.handle);
int rc = sepol_policydb_create(&global_state.sepolicy.sdb);
if (rc < 0) {
perror("Error: could not create policy db");
exit(1);
}
rc = sepol_policydb_read(global_state.sepolicy.sdb, global_state.sepolicy.pf);
if (rc < 0) {
perror("Error: could not read file into policy db");
exit(1);
}
global_state.assert.attrs = filemode_to_assert_attrs(mode);
bool ret = ebitmap_attribute_assertion_init(&global_state.assert.set, global_state.assert.attrs);
if (!ret) {
/* error messages logged by ebitmap_attribute_assertion_init() */
exit(1);
}
selinux_set_callback(SELINUX_CB_VALIDATE,
(union selinux_callback)&validate);
opts[1].value = context_file;
global_state.sepolicy.sehnd[0] = selabel_open(backend, opts, 2);
if (!global_state.sepolicy.sehnd[0]) {
fprintf(stderr, "Error: could not load context file from %s\n", context_file);
exit(1);
}
}
int main(int argc, char **argv)
{
struct selinux_opt opts[] = {
{ SELABEL_OPT_VALIDATE, (void*)1 },
{ SELABEL_OPT_PATH, NULL }
};
// Default backend unless changed by input argument.
unsigned int backend = SELABEL_CTX_FILE;
bool allow_empty = false;
bool compare = false;
Add checkfc mode to validate file_contexts against test data A new mode for checkfc is introduced (-t) which takes a file_contexts and a test data file. Each line in the test data file contains a path and the expected type. checkfc loads the file_contexts and repeatedly calls selabel_lookup(3) to verify that the computed type is as expected. This mode can be used to confirm that any modification to file_contexts or its build process is benign. A test data file (plat_file_contexts_test) is added. This file was manually created based on private/file_contexts. Each static path was copied as-is. Each regular expression was expanded into a couple of entries. For instance, /dev/adf[0-9]* generated /dev/adf, /dev/adf0 and /dev/adf123. libselinux keeps track of which specification is being hit when using selabel_lookup. When calling selabel_stats(3), the file backend will output a warning if a specification has not been used. This can be leveraged to ensure that each rule is at least hit once. This property will be leveraged in a follow-up change (by running the test as part of the build process), to ensure that the plat_file_contexts_test file remains up-to-date (that is, when an entry is added to private/file_contexts, the build will fail unless a test is also added to plat_file_contexts_test to exercice the specification/regular expression). Test: m checkfc && checkfc -t ./private/file_contexts ./tests/plat_file_contexts_test Bug: 299839280 Change-Id: Ibf56859a16bd17e1f878ce7b0570b2aead79c7e0
2023-10-05 00:44:24 +02:00
bool test_data = false;
char c;
filemode mode = filemode_file_contexts;
Add checkfc mode to validate file_contexts against test data A new mode for checkfc is introduced (-t) which takes a file_contexts and a test data file. Each line in the test data file contains a path and the expected type. checkfc loads the file_contexts and repeatedly calls selabel_lookup(3) to verify that the computed type is as expected. This mode can be used to confirm that any modification to file_contexts or its build process is benign. A test data file (plat_file_contexts_test) is added. This file was manually created based on private/file_contexts. Each static path was copied as-is. Each regular expression was expanded into a couple of entries. For instance, /dev/adf[0-9]* generated /dev/adf, /dev/adf0 and /dev/adf123. libselinux keeps track of which specification is being hit when using selabel_lookup. When calling selabel_stats(3), the file backend will output a warning if a specification has not been used. This can be leveraged to ensure that each rule is at least hit once. This property will be leveraged in a follow-up change (by running the test as part of the build process), to ensure that the plat_file_contexts_test file remains up-to-date (that is, when an entry is added to private/file_contexts, the build will fail unless a test is also added to plat_file_contexts_test to exercice the specification/regular expression). Test: m checkfc && checkfc -t ./private/file_contexts ./tests/plat_file_contexts_test Bug: 299839280 Change-Id: Ibf56859a16bd17e1f878ce7b0570b2aead79c7e0
2023-10-05 00:44:24 +02:00
while ((c = getopt(argc, argv, "clpsvet")) != -1) {
switch (c) {
case 'c':
compare = true;
break;
case 'e':
allow_empty = true;
break;
case 'p':
mode = filemode_property_contexts;
backend = SELABEL_CTX_ANDROID_PROP;
break;
case 's':
mode = filemode_service_contexts;
backend = SELABEL_CTX_ANDROID_SERVICE;
break;
case 'l':
mode = filemode_hw_service_contexts;
backend = SELABEL_CTX_ANDROID_SERVICE;
break;
case 'v':
mode = filemode_vendor_service_contexts;
backend = SELABEL_CTX_ANDROID_SERVICE;
break;
Add checkfc mode to validate file_contexts against test data A new mode for checkfc is introduced (-t) which takes a file_contexts and a test data file. Each line in the test data file contains a path and the expected type. checkfc loads the file_contexts and repeatedly calls selabel_lookup(3) to verify that the computed type is as expected. This mode can be used to confirm that any modification to file_contexts or its build process is benign. A test data file (plat_file_contexts_test) is added. This file was manually created based on private/file_contexts. Each static path was copied as-is. Each regular expression was expanded into a couple of entries. For instance, /dev/adf[0-9]* generated /dev/adf, /dev/adf0 and /dev/adf123. libselinux keeps track of which specification is being hit when using selabel_lookup. When calling selabel_stats(3), the file backend will output a warning if a specification has not been used. This can be leveraged to ensure that each rule is at least hit once. This property will be leveraged in a follow-up change (by running the test as part of the build process), to ensure that the plat_file_contexts_test file remains up-to-date (that is, when an entry is added to private/file_contexts, the build will fail unless a test is also added to plat_file_contexts_test to exercice the specification/regular expression). Test: m checkfc && checkfc -t ./private/file_contexts ./tests/plat_file_contexts_test Bug: 299839280 Change-Id: Ibf56859a16bd17e1f878ce7b0570b2aead79c7e0
2023-10-05 00:44:24 +02:00
case 't':
test_data = true;
break;
case 'h':
default:
usage(argv[0]);
break;
}
}
int index = optind;
if (argc - optind != 2) {
usage(argv[0]);
}
Add checkfc mode to validate file_contexts against test data A new mode for checkfc is introduced (-t) which takes a file_contexts and a test data file. Each line in the test data file contains a path and the expected type. checkfc loads the file_contexts and repeatedly calls selabel_lookup(3) to verify that the computed type is as expected. This mode can be used to confirm that any modification to file_contexts or its build process is benign. A test data file (plat_file_contexts_test) is added. This file was manually created based on private/file_contexts. Each static path was copied as-is. Each regular expression was expanded into a couple of entries. For instance, /dev/adf[0-9]* generated /dev/adf, /dev/adf0 and /dev/adf123. libselinux keeps track of which specification is being hit when using selabel_lookup. When calling selabel_stats(3), the file backend will output a warning if a specification has not been used. This can be leveraged to ensure that each rule is at least hit once. This property will be leveraged in a follow-up change (by running the test as part of the build process), to ensure that the plat_file_contexts_test file remains up-to-date (that is, when an entry is added to private/file_contexts, the build will fail unless a test is also added to plat_file_contexts_test to exercice the specification/regular expression). Test: m checkfc && checkfc -t ./private/file_contexts ./tests/plat_file_contexts_test Bug: 299839280 Change-Id: Ibf56859a16bd17e1f878ce7b0570b2aead79c7e0
2023-10-05 00:44:24 +02:00
if ((compare || test_data) && backend != SELABEL_CTX_FILE) {
usage(argv[0]);
}
atexit(cleanup);
if (compare) {
do_compare_and_die_on_error(opts, backend, &(argv[index]));
Add checkfc mode to validate file_contexts against test data A new mode for checkfc is introduced (-t) which takes a file_contexts and a test data file. Each line in the test data file contains a path and the expected type. checkfc loads the file_contexts and repeatedly calls selabel_lookup(3) to verify that the computed type is as expected. This mode can be used to confirm that any modification to file_contexts or its build process is benign. A test data file (plat_file_contexts_test) is added. This file was manually created based on private/file_contexts. Each static path was copied as-is. Each regular expression was expanded into a couple of entries. For instance, /dev/adf[0-9]* generated /dev/adf, /dev/adf0 and /dev/adf123. libselinux keeps track of which specification is being hit when using selabel_lookup. When calling selabel_stats(3), the file backend will output a warning if a specification has not been used. This can be leveraged to ensure that each rule is at least hit once. This property will be leveraged in a follow-up change (by running the test as part of the build process), to ensure that the plat_file_contexts_test file remains up-to-date (that is, when an entry is added to private/file_contexts, the build will fail unless a test is also added to plat_file_contexts_test to exercice the specification/regular expression). Test: m checkfc && checkfc -t ./private/file_contexts ./tests/plat_file_contexts_test Bug: 299839280 Change-Id: Ibf56859a16bd17e1f878ce7b0570b2aead79c7e0
2023-10-05 00:44:24 +02:00
} else if (test_data) {
do_test_data_and_die_on_error(opts, backend, &(argv[index]));
} else {
/* remaining args are sepolicy file and context file */
char *sepolicy_file = argv[index];
char *context_file = argv[index + 1];
do_fc_check_and_die_on_error(opts, backend, mode, sepolicy_file, context_file, allow_empty);
}
exit(0);
}