From 5e9b88f739580b932fcf2b026a809d7632b0f513 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thi=C3=A9baud=20Weksteen?= <tweek@google.com>
Date: Mon, 28 Aug 2023 12:22:17 +1000
Subject: [PATCH] Update documentation on binderservicedomain

The binderservicedomain attribute grants further permissions than its
name suggests. Update the documentation to avoid its usage.

Bug: 297785784
Test: build, documentation update only.
Change-Id: I41bc6f32cf4d56bde320261fe221c3653cda945a
---
 private/binderservicedomain.te | 3 ++-
 public/attributes              | 3 ++-
 public/te_macros               | 3 +--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/private/binderservicedomain.te b/private/binderservicedomain.te
index fa9dd7d1c..21349df17 100644
--- a/private/binderservicedomain.te
+++ b/private/binderservicedomain.te
@@ -1,4 +1,5 @@
-# Rules common to all binder service domains
+# Rules common to some specific binder service domains.
+# Deprecated. Consider granting the exact permissions required by your service.
 
 # Allow dumpstate and incidentd to collect information from binder services
 allow binderservicedomain { dumpstate incidentd }:fd use;
diff --git a/public/attributes b/public/attributes
index 0fdbf130b..fdac12744 100644
--- a/public/attributes
+++ b/public/attributes
@@ -221,7 +221,8 @@ attribute netdomain;
 # All domains used for apps with bluetooth access.
 attribute bluetoothdomain;
 
-# All domains used for binder service domains.
+# Specific domains that expose a binder service.
+# Deprecated, consider granting the exact permissions required by your service.
 attribute binderservicedomain;
 
 # All domains which have BPF access.
diff --git a/public/te_macros b/public/te_macros
index c4ebc63a7..d2f440600 100644
--- a/public/te_macros
+++ b/public/te_macros
@@ -440,8 +440,7 @@ allow $1 $2:fd use;
 
 #####################################
 # binder_service(domain)
-# Mark a domain as being a Binder service domain.
-# Used to allow binder IPC to the various system services.
+# Deprecated. Consider granting the exact permissions required by your service.
 define(`binder_service', `
 typeattribute $1 binderservicedomain;
 ')