tequilaOS/platform_system_sepolicy
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

seamendc: prefetch binary policy in memory before parsing

Browse source 
This optimization improves the runtime of seamendc by ~6-7ms.

Bug: 236691128
Test: atest seamendc-test && atest SeamendcHostTest
Change-Id: Id1e86a5f51d035fac415a0e6ae05b99b3bd774d4
This commit is contained in:
Sandro 2022-07-22 08:49:58 +00:00
parent f503e3e7e2
commit 8978204264
1 changed files with 34 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
tools/seamendc.c
View file

@ -9,6 +9,7 @@
#include <cil/cil.h>
#include <cil/android.h>
#include <sepol/policydb.h>
#include "sepol/handle.h"
void usage(const char *prog)
{
@ -26,10 +27,17 @@ void usage(const char *prog)
/*
* Read binary policy file from path into the allocated pdb.
*
* We first read the binary policy into memory, and then we parse it to a
* policydb object using sepol_policydb_from_image. This combination is slightly
* faster than using sepol_policydb_read that reads the binary file in small
* chunks at a time.
*/
static int read_binary_policy(char *path, sepol_policydb_t *pdb)
{
int rc = SEPOL_OK;
char *buff = NULL;
sepol_handle_t *handle = NULL;
FILE *file = fopen(path, "r");
if (!file) {
@ -44,24 +52,38 @@ static int read_binary_policy(char *path, sepol_policydb_t *pdb)
fprintf(stderr, "Could not stat %s: %s.\n", path, strerror(errno));
goto exit;
}
if (!binarydata.st_size) {
uint32_t file_size = binarydata.st_size;
if (!file_size) {
fprintf(stderr, "Binary policy file is empty.\n");
rc = SEPOL_ERR;
goto exit;
}
struct sepol_policy_file *pf = NULL;
rc = sepol_policy_file_create(&pf);
if (rc != 0) {
fprintf(stderr, "Failed to create policy file: %d.\n", rc);
buff = malloc(file_size);
if (buff == NULL) {
perror("malloc failed");
rc = SEPOL_ERR;
goto exit;
}
sepol_policy_file_set_fp(pf, file);
rc = sepol_policydb_read(pdb, pf);
rc = fread(buff, file_size, 1, file);
if (rc != 1) {
fprintf(stderr, "Failure reading %s: %s.\n", path, strerror(errno));
rc = SEPOL_ERR;
goto exit;
}
handle = sepol_handle_create();
if (!handle) {
perror("Could not create policy handle");
rc = SEPOL_ERR;
goto exit;
}
rc = sepol_policydb_from_image(handle, buff, file_size, pdb);
if (rc != 0) {
fprintf(stderr, "Failed to read binary policy: %d.\n", rc);
goto exit;
}
exit:
@ -69,6 +91,10 @@ exit:
perror("Failure closing binary file");
rc = SEPOL_ERR;
}
if(handle != NULL) {
sepol_handle_destroy(handle);
}
free(buff);
return rc;
}