8a8770cdac
(cherry pick from commit6937aa93ac
) Followup to121f5bfd80
. Move misc_logd_file neverallow rule from domain.te to logd.te, since the goal of the neverallow rule is to protect logd / logpersist files from other processes. Switch the misc_logd_file neverallow rule from using "rw_file_perms" to "no_rw_file_perms". The latter covers more cases of file modifications. Add more neverallow rules covering misc_logd_file directories. Instead of using not_userdebug_nor_eng(), modify the rules to be consistent with other highly constrained file types such as keystore_data_file or vold_data_file. See, for example, https://android-review.googlesource.com/144768 To see the net effect of this change, you can use the following command line: sesearch --allow -t misc_logd_file -c file,dir,lnk_file \ out/target/product/bullhead/root/sepolicy Before this change: # userdebug builds allow init misc_logd_file:dir { search setattr read create getattr write relabelfrom ioctl rmdir remove_name relabelto open add_name }; allow init misc_logd_file:file { setattr read create write relabelfrom getattr relabelto unlink open }; allow init misc_logd_file:lnk_file { setattr relabelfrom create getattr relabelto unlink }; allow logd misc_logd_file:dir { search read lock getattr write ioctl remove_name open add_name }; allow logd misc_logd_file:file { rename setattr read lock create getattr write ioctl unlink open append }; allow shell misc_logd_file:dir { search read lock getattr ioctl open }; allow shell misc_logd_file:file { read lock ioctl open getattr }; # user builds allow init misc_logd_file:dir { search setattr read create getattr write relabelfrom ioctl rmdir remove_name relabelto open add_name }; allow init misc_logd_file:file relabelto; allow init misc_logd_file:lnk_file { setattr relabelfrom create getattr relabelto unlink }; After this change: # userdebug builds allow init misc_logd_file:dir { search setattr read create getattr ioctl relabelto open }; allow init misc_logd_file:file { relabelto getattr }; allow init misc_logd_file:lnk_file relabelto; allow logd misc_logd_file:dir { search read lock getattr write ioctl remove_name open add_name }; allow logd misc_logd_file:file { rename setattr read lock create getattr write ioctl unlink open append }; allow shell misc_logd_file:dir { search read lock getattr ioctl open }; allow shell misc_logd_file:file { read lock ioctl open getattr }; # user builds allow init misc_logd_file:dir { search setattr read create getattr ioctl relabelto open }; allow init misc_logd_file:file { relabelto getattr }; allow init misc_logd_file:lnk_file relabelto; Change-Id: I0b00215049ad83182f458b4b9e258289c5144479 Bug: 27965066
67 lines
2.1 KiB
Text
67 lines
2.1 KiB
Text
# android user-space log manager
|
|
type logd, domain, domain_deprecated, mlstrustedsubject;
|
|
type logd_exec, exec_type, file_type;
|
|
|
|
init_daemon_domain(logd)
|
|
|
|
# Read access to pseudo filesystems.
|
|
r_dir_file(logd, proc)
|
|
r_dir_file(logd, proc_net)
|
|
|
|
allow logd self:capability { setuid setgid sys_nice audit_control };
|
|
allow logd self:capability2 syslog;
|
|
allow logd self:netlink_audit_socket { create_socket_perms nlmsg_write };
|
|
allow logd kernel:system syslog_read;
|
|
allow logd kmsg_device:chr_file w_file_perms;
|
|
allow logd system_data_file:file r_file_perms;
|
|
# logpersist is only allowed on userdebug and eng builds
|
|
userdebug_or_eng(`
|
|
allow logd misc_logd_file:file create_file_perms;
|
|
allow logd misc_logd_file:dir rw_dir_perms;
|
|
')
|
|
allow logd pstorefs:dir search;
|
|
allow logd pstorefs:file r_file_perms;
|
|
|
|
# Set persist.sys. and sys.powerctl
|
|
set_prop(logd, safemode_prop)
|
|
set_prop(logd, powerctl_prop)
|
|
|
|
# Access device logging gating property
|
|
get_prop(logd, device_logging_prop)
|
|
|
|
r_dir_file(logd, domain)
|
|
|
|
allow logd kernel:system syslog_mod;
|
|
|
|
control_logd(logd)
|
|
|
|
# case where logpersistd is actually logcat -f in logd context (nee: logcatd)
|
|
userdebug_or_eng(`
|
|
unix_socket_connect(logd, logdr, logd)
|
|
')
|
|
|
|
###
|
|
### Neverallow rules
|
|
###
|
|
### logd should NEVER do any of this
|
|
|
|
# Block device access.
|
|
neverallow logd dev_type:blk_file { read write };
|
|
|
|
# ptrace any other app
|
|
neverallow logd domain:process ptrace;
|
|
|
|
# Write to /system.
|
|
neverallow logd system_file:dir_file_class_set write;
|
|
|
|
# Write to files in /data/data or system files on /data
|
|
neverallow logd { app_data_file system_data_file }:dir_file_class_set write;
|
|
|
|
# logd is not allowed to write anywhere other than /data/misc/logd, and then
|
|
# only on userdebug or eng builds
|
|
neverallow logd { file_type -logd_tmpfs userdebug_or_eng(` -misc_logd_file -coredump_file ') }:file { create write append };
|
|
|
|
# logpersist is only allowed on userdebug/eng builds
|
|
neverallow { domain userdebug_or_eng(`-logd -shell') } misc_logd_file:file no_rw_file_perms;
|
|
neverallow { domain userdebug_or_eng(`-logd') } misc_logd_file:dir { add_name link relabelfrom remove_name rename reparent rmdir write };
|
|
neverallow { domain -init } misc_logd_file:dir create;
|