bdfc0301a1
With project Treble, we're relying heavily on attributes for
permission inheritance and enforcement of separation between
platform and vendor components.
We neead tests that verify those attributes are correctly applied.
This change adds the framework for those tests including a wrapper
around libsepol for loading and querying policy, and a python module
for running tests on policy and file_contexts.
Included with the testing framework is a test asserting that the
coredomain attribute is only applied to core processes. This
verification is done using the following rules:
1. Domain's entrypoint is on /system - coredomain
2. Domain's entrypoint is on /vendor - not coredomain
3. Domain belongs to a whitelist of known coredomains - coredomain
In a subsequent commit these tests will be applied at build time.
However, I first need to fix existing Treble violations exposed by
this test. These tests will also be applied during CTS.
Test: LD_PRELOAD=$ANDROID_HOST_OUT/lib64/libsepolwrap.so python \
treble.py -p $OUT/vendor/etc/selinux/precompiled_sepolicy \
-f $OUT/vendor/etc/selinux/nonplat_file_contexts \
-f $OUT/system/etc/selinux/plat_file_contexts
Bug: 37008075
Change-Id: I7825f5c2909a5801deaccf2bef2bfd227adb0ae9
(cherry picked from commit 0366afdf14
)
266 lines
7.5 KiB
C++
266 lines
7.5 KiB
C++
#include <stdio.h>
|
|
#include <string>
|
|
#include <sstream>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
#include <iostream>
|
|
#include <sys/mman.h>
|
|
#include <sys/stat.h>
|
|
#include <sepol/policydb/avtab.h>
|
|
#include <sepol/policydb/policydb.h>
|
|
#include <sepol/policydb/services.h>
|
|
#include <sepol/policydb/util.h>
|
|
#include <sys/types.h>
|
|
#include <fstream>
|
|
|
|
#include <android-base/file.h>
|
|
#include <android-base/strings.h>
|
|
#include <sepol_wrap.h>
|
|
|
|
|
|
struct type_iter {
|
|
type_datum *d;
|
|
ebitmap_node *n;
|
|
unsigned int length;
|
|
unsigned int bit;
|
|
};
|
|
|
|
void *init_type_iter(void *policydbp, const char *type, bool is_attr)
|
|
{
|
|
policydb_t *db = static_cast<policydb_t *>(policydbp);
|
|
struct type_iter *out = (struct type_iter *)
|
|
calloc(1, sizeof(struct type_iter));
|
|
|
|
if (!out) {
|
|
std::cerr << "Failed to allocate type type iterator" << std::endl;
|
|
return NULL;
|
|
}
|
|
|
|
out->d = static_cast<type_datum *>(hashtab_search(db->p_types.table, type));
|
|
if (is_attr && out->d->flavor != TYPE_ATTRIB) {
|
|
std::cerr << "\"" << type << "\" MUST be an attribute in the policy" << std::endl;
|
|
free(out);
|
|
return NULL;
|
|
} else if (!is_attr && out->d->flavor !=TYPE_TYPE) {
|
|
std::cerr << "\"" << type << "\" MUST be a type in the policy" << std::endl;
|
|
free(out);
|
|
return NULL;
|
|
}
|
|
|
|
if (is_attr) {
|
|
out->bit = ebitmap_start(&db->attr_type_map[out->d->s.value - 1], &out->n);
|
|
out->length = ebitmap_length(&db->attr_type_map[out->d->s.value - 1]);
|
|
} else {
|
|
out->bit = ebitmap_start(&db->type_attr_map[out->d->s.value - 1], &out->n);
|
|
out->length = ebitmap_length(&db->type_attr_map[out->d->s.value - 1]);
|
|
}
|
|
|
|
return static_cast<void *>(out);
|
|
}
|
|
|
|
void destroy_type_iter(void *type_iterp)
|
|
{
|
|
struct type_iter *type_i = static_cast<struct type_iter *>(type_iterp);
|
|
free(type_i);
|
|
}
|
|
|
|
/*
|
|
* print allow rule into *out buffer.
|
|
*
|
|
* Returns -1 on error.
|
|
* Returns 0 on successfully reading an avtab entry.
|
|
* Returns 1 on complete
|
|
*/
|
|
int get_type(char *out, size_t max_size, void *policydbp, void *type_iterp)
|
|
{
|
|
size_t len;
|
|
policydb_t *db = static_cast<policydb_t *>(policydbp);
|
|
struct type_iter *i = static_cast<struct type_iter *>(type_iterp);
|
|
|
|
for (; i->bit < i->length; i->bit = ebitmap_next(&i->n, i->bit)) {
|
|
if (!ebitmap_node_get_bit(i->n, i->bit)) {
|
|
continue;
|
|
}
|
|
len = snprintf(out, max_size, "%s", db->p_type_val_to_name[i->bit]);
|
|
if (len >= max_size) {
|
|
std::cerr << "type name exceeds buffer size." << std::endl;
|
|
return -1;
|
|
}
|
|
i->bit = ebitmap_next(&i->n, i->bit);
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
void *load_policy(const char *policy_path)
|
|
{
|
|
FILE *fp;
|
|
policydb_t *db;
|
|
|
|
fp = fopen(policy_path, "re");
|
|
if (!fp) {
|
|
std::cerr << "Invalid or non-existing policy file: " << policy_path << std::endl;
|
|
return NULL;
|
|
}
|
|
|
|
db = (policydb_t *) calloc(1, sizeof(policydb_t));
|
|
if (!db) {
|
|
std::cerr << "Failed to allocate memory for policy db." << std::endl;
|
|
fclose(fp);
|
|
return NULL;
|
|
}
|
|
|
|
sidtab_t sidtab;
|
|
sepol_set_sidtab(&sidtab);
|
|
sepol_set_policydb(db);
|
|
|
|
struct stat sb;
|
|
if (fstat(fileno(fp), &sb)) {
|
|
std::cerr << "Failed to stat the policy file" << std::endl;
|
|
free(db);
|
|
fclose(fp);
|
|
return NULL;
|
|
}
|
|
|
|
auto unmap = [=](void *ptr) { munmap(ptr, sb.st_size); };
|
|
std::unique_ptr<void, decltype(unmap)> map(
|
|
mmap(NULL, sb.st_size, PROT_READ, MAP_PRIVATE, fileno(fp), 0), unmap);
|
|
if (!map) {
|
|
std::cerr << "Failed to map the policy file" << std::endl;
|
|
free(db);
|
|
fclose(fp);
|
|
return NULL;
|
|
}
|
|
|
|
struct policy_file pf;
|
|
policy_file_init(&pf);
|
|
pf.type = PF_USE_MEMORY;
|
|
pf.data = static_cast<char *>(map.get());
|
|
pf.len = sb.st_size;
|
|
if (policydb_init(db)) {
|
|
std::cerr << "Failed to initialize policydb" << std::endl;
|
|
free(db);
|
|
fclose(fp);
|
|
return NULL;
|
|
}
|
|
|
|
if (policydb_read(db, &pf, 0)) {
|
|
std::cerr << "Failed to read binary policy" << std::endl;
|
|
policydb_destroy(db);
|
|
free(db);
|
|
fclose(fp);
|
|
return NULL;
|
|
}
|
|
|
|
return static_cast<void *>(db);
|
|
}
|
|
|
|
/* items needed to iterate over the avtab */
|
|
struct avtab_iter {
|
|
avtab_t avtab;
|
|
uint32_t i;
|
|
avtab_ptr_t cur;
|
|
};
|
|
|
|
/*
|
|
* print allow rule into *out buffer.
|
|
*
|
|
* Returns -1 on error.
|
|
* Returns 0 on successfully reading an avtab entry.
|
|
* Returns 1 on complete
|
|
*/
|
|
static int get_avtab_allow_rule(char *out, size_t max_size, policydb_t *db,
|
|
struct avtab_iter *avtab_i)
|
|
{
|
|
size_t len;
|
|
|
|
for (; avtab_i->i < avtab_i->avtab.nslot; (avtab_i->i)++) {
|
|
if (avtab_i->cur == NULL) {
|
|
avtab_i->cur = avtab_i->avtab.htable[avtab_i->i];
|
|
}
|
|
for (; avtab_i->cur; avtab_i->cur = (avtab_i->cur)->next) {
|
|
if (!((avtab_i->cur)->key.specified & AVTAB_ALLOWED)) continue;
|
|
|
|
len = snprintf(out, max_size, "allow,%s,%s,%s,%s",
|
|
db->p_type_val_to_name[(avtab_i->cur)->key.source_type - 1],
|
|
db->p_type_val_to_name[(avtab_i->cur)->key.target_type - 1],
|
|
db->p_class_val_to_name[(avtab_i->cur)->key.target_class - 1],
|
|
sepol_av_to_string(db, (avtab_i->cur)->key.target_class, (avtab_i->cur)->datum.data));
|
|
avtab_i->cur = (avtab_i->cur)->next;
|
|
if (!(avtab_i->cur))
|
|
(avtab_i->i)++;
|
|
if (len >= max_size) {
|
|
std::cerr << "Allow rule exceeds buffer size." << std::endl;
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|
|
avtab_i->cur = NULL;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
int get_allow_rule(char *out, size_t len, void *policydbp, void *avtab_iterp)
|
|
{
|
|
policydb_t *db = static_cast<policydb_t *>(policydbp);
|
|
struct avtab_iter *avtab_i = static_cast<struct avtab_iter *>(avtab_iterp);
|
|
|
|
return get_avtab_allow_rule(out, len, db, avtab_i);
|
|
}
|
|
|
|
/*
|
|
* <sepol/policydb/expand.h->conditional.h> uses 'bool' as a variable name
|
|
* inside extern "C" { .. } construct, which clang doesn't like.
|
|
* So, declare the function we need from expand.h ourselves.
|
|
*/
|
|
extern "C" int expand_avtab(policydb_t *p, avtab_t *a, avtab_t *expa);
|
|
|
|
static avtab_iter *init_avtab_common(avtab_t *in, policydb_t *p)
|
|
{
|
|
struct avtab_iter *out = (struct avtab_iter *)
|
|
calloc(1, sizeof(struct avtab_iter));
|
|
if (!out) {
|
|
std::cerr << "Failed to allocate avtab" << std::endl;
|
|
return NULL;
|
|
}
|
|
|
|
if (avtab_init(&out->avtab)) {
|
|
std::cerr << "Failed to initialize avtab" << std::endl;
|
|
free(out);
|
|
return NULL;
|
|
}
|
|
|
|
if (expand_avtab(p, in, &out->avtab)) {
|
|
std::cerr << "Failed to expand avtab" << std::endl;
|
|
free(out);
|
|
return NULL;
|
|
}
|
|
return out;
|
|
}
|
|
|
|
void *init_avtab(void *policydbp)
|
|
{
|
|
policydb_t *p = static_cast<policydb_t *>(policydbp);
|
|
return static_cast<void *>(init_avtab_common(&p->te_avtab, p));
|
|
}
|
|
|
|
void *init_cond_avtab(void *policydbp)
|
|
{
|
|
policydb_t *p = static_cast<policydb_t *>(policydbp);
|
|
return static_cast<void *>(init_avtab_common(&p->te_cond_avtab, p));
|
|
}
|
|
|
|
void destroy_avtab(void *avtab_iterp)
|
|
{
|
|
struct avtab_iter *avtab_i = static_cast<struct avtab_iter *>(avtab_iterp);
|
|
avtab_destroy(&avtab_i->avtab);
|
|
free(avtab_i);
|
|
}
|
|
|
|
void destroy_policy(void *policydbp)
|
|
{
|
|
policydb_t *p = static_cast<policydb_t *>(policydbp);
|
|
policydb_destroy(p);
|
|
}
|