From 3fe931109c213dfe057161d8e32a4be3d3c8962c Mon Sep 17 00:00:00 2001 From: Paul Lawrence Date: Fri, 12 Jun 2020 08:12:48 -0700 Subject: [PATCH] Don't call block checkpoint functions above dm-default-key Bug: 156225476 Test: Build for f2fs and ext4 device, make sure checkpoints roll back and commit Change-Id: Ic15fadc67d306463dd0b554f679306d8f9081451 --- MetadataCrypt.cpp | 2 +- cryptfs.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MetadataCrypt.cpp b/MetadataCrypt.cpp index 7891bee..bf0220e 100644 --- a/MetadataCrypt.cpp +++ b/MetadataCrypt.cpp @@ -103,7 +103,7 @@ static bool mount_via_fs_mgr(const char* mount_point, const char* blk_device) { } auto mount_rc = fs_mgr_do_mount(&fstab_default, const_cast(mount_point), const_cast(blk_device), nullptr, - android::vold::cp_needsCheckpoint()); + android::vold::cp_needsCheckpoint(), true); if (setexeccon(nullptr)) { PLOG(ERROR) << "Failed to clear setexeccon"; return false; diff --git a/cryptfs.cpp b/cryptfs.cpp index da748fd..7bcd835 100644 --- a/cryptfs.cpp +++ b/cryptfs.cpp @@ -1569,7 +1569,7 @@ static int cryptfs_restart_internal(int restart_main) { } bool needs_cp = android::vold::cp_needsCheckpoint(); while ((mount_rc = fs_mgr_do_mount(&fstab_default, DATA_MNT_POINT, crypto_blkdev, 0, - needs_cp)) != 0) { + needs_cp, false)) != 0) { if (mount_rc == FS_MGR_DOMNT_BUSY) { /* TODO: invoke something similar to Process::killProcessWithOpenFiles(DATA_MNT_POINT,