tequilaOS/platform_system_vold
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Retry deleting dm devices.

Browse source 
For some reason this can be racy; until we understand the root cause,
retry to unblock presubmit.

Bug: 149396179
Test: atest AdoptableHostTest no longer hangs
Change-Id: I3fb4f1d966172bac2f6c52d41c4564f905765212
This commit is contained in:
Martijn Coenen 2020-02-13 16:20:52 +01:00
parent 724f0092a3
commit 26ad7b34d1
1 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
cryptfs.cpp
View file

@ -64,6 +64,9 @@
#include <time.h>
#include <unistd.h>
#include <chrono>
#include <thread>
extern "C" {
#include <crypto_scrypt.h>
}
@ -1219,9 +1222,22 @@ static int create_crypto_blk_dev(struct crypt_mnt_ftr* crypt_ftr, const unsigned
}
static int delete_crypto_blk_dev(const std::string& name) {
bool ret;
auto& dm = DeviceMapper::Instance();
if (!dm.DeleteDevice(name)) {
SLOGE("Cannot remove dm-crypt device %s: %s\n", name.c_str(), strerror(errno));
// TODO(b/149396179) there appears to be a race somewhere in the system where trying
// to delete the device fails with EBUSY; for now, work around this by retrying.
int tries = 5;
while (tries-- > 0) {
ret = dm.DeleteDevice(name);
if (ret || errno != EBUSY) {
break;
}
SLOGW("DM_DEV Cannot remove dm-crypt device %s: %s, retrying...\n", name.c_str(),
strerror(errno));
std::this_thread::sleep_for(std::chrono::milliseconds(100));
}
if (!ret) {
SLOGE("DM_DEV Cannot remove dm-crypt device %s: %s\n", name.c_str(), strerror(errno));
return -1;
}
return 0;