diff --git a/Ext4Crypt.cpp b/Ext4Crypt.cpp index 67b7e90..68439c0 100644 --- a/Ext4Crypt.cpp +++ b/Ext4Crypt.cpp @@ -177,6 +177,7 @@ static void fixate_user_ce_key(const std::string& directory_path, const std::str PLOG(WARNING) << "Unable to rename " << to_fix << " to " << current_path; } } + android::vold::FsyncDirectory(directory_path); } static bool read_and_fixate_user_ce_key(userid_t user_id, @@ -569,6 +570,7 @@ bool e4crypt_add_user_key_auth(userid_t user_id, int serial, const std::string& std::string ce_key_path; if (!get_ce_key_new_path(directory_path, paths, &ce_key_path)) return false; if (!android::vold::storeKeyAtomically(ce_key_path, user_key_temp, auth, ce_key)) return false; + if (!android::vold::FsyncDirectory(directory_path)) return false; return true; } diff --git a/KeyStorage.cpp b/KeyStorage.cpp index 0518930..6fc7250 100644 --- a/KeyStorage.cpp +++ b/KeyStorage.cpp @@ -223,6 +223,10 @@ static KeymasterOperation begin(Keymaster& keymaster, const std::string& dir, PLOG(ERROR) << "Unable to move upgraded key to location: " << kmKeyPath; return KeymasterOperation(); } + if (!android::vold::FsyncDirectory(dir)) { + LOG(ERROR) << "Key dir sync failed: " << dir; + return KeymasterOperation(); + } if (!keymaster.deleteKey(kmKey)) { LOG(ERROR) << "Key deletion failed during upgrade, continuing anyway: " << dir; } @@ -480,6 +484,7 @@ bool storeKey(const std::string& dir, const KeyAuthentication& auth, const KeyBu if (!encryptWithoutKeymaster(appId, key, &encryptedKey)) return false; } if (!writeStringToFile(encryptedKey, dir + "/" + kFn_encrypted_key)) return false; + if (!FsyncDirectory(dir)) return false; return true; } diff --git a/Utils.cpp b/Utils.cpp index 98e8a9b..d578d79 100644 --- a/Utils.cpp +++ b/Utils.cpp @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include @@ -731,5 +732,23 @@ bool IsRunningInEmulator() { return android::base::GetBoolProperty("ro.kernel.qemu", false); } +bool FsyncDirectory(const std::string& dirname) { + android::base::unique_fd fd(TEMP_FAILURE_RETRY(open(dirname.c_str(), O_RDONLY | O_CLOEXEC))); + if (fd == -1) { + PLOG(ERROR) << "Failed to open " << dirname; + return false; + } + if (fsync(fd) == -1) { + if (errno == EROFS || errno == EINVAL) { + PLOG(WARNING) << "Skip fsync " << dirname + << " on a file system does not support synchronization"; + } else { + PLOG(ERROR) << "Failed to fsync " << dirname; + return false; + } + } + return true; +} + } // namespace vold } // namespace android diff --git a/Utils.h b/Utils.h index 5caa4e9..533e17c 100644 --- a/Utils.h +++ b/Utils.h @@ -125,6 +125,8 @@ bool Readlinkat(int dirfd, const std::string& path, std::string* result); /* Checks if Android is running in QEMU */ bool IsRunningInEmulator(); +bool FsyncDirectory(const std::string& dirname); + } // namespace vold } // namespace android