tequilaOS/platform_system_vold
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

prevent ioctl_init() to write outside buffer

Browse source 
The strncpy operation does not write a 0 termination
if the name is larger than the target buffer.

Ensure that zero termination is always written using
safe strlcpy function.

Change-Id: Idb68cdff7cd1a860c1dfac7494fa99f3d382cb91
This commit is contained in:
Marek Pola 2015-02-05 14:22:34 +01:00 committed by Henrik Baard
parent f3b2637e06
commit 5e6b9141c1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cryptfs.c
View file

@ -326,7 +326,7 @@ static void ioctl_init(struct dm_ioctl *io, size_t dataSize, const char *name, u
io->version[2] = 0;
io->flags = flags;
if (name) {
strncpy(io->name, name, sizeof(io->name));
strlcpy(io->name, name, sizeof(io->name));
}
}