tequilaOS/platform_system_vold
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Revert "Use apexservice to get the list of apexes"

Browse source 
Revert submission 2685449-apexdata-dirs

Reason for revert: b/295345486 performance regression.

Reverted changes: /q/submissionid:2685449-apexdata-dirs

Bug: b/295345486
Test: n/a
Change-Id: I710a416398148b544635e32e6b8066fb0560171f
This commit is contained in:
Jooyung Han 2023-08-11 15:34:35 +00:00
parent d54caf0598
commit 6d07925510
2 changed files with 14 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Android.bp
View file

@ -239,10 +239,7 @@ cc_binary {
cc_binary {
name: "vold_prepare_subdirs",
defaults: [
"vold_default_flags",
"libapexservice-deps",
],
defaults: ["vold_default_flags"],
srcs: [
"vold_prepare_subdirs.cpp",

41
vold_prepare_subdirs.cpp
View file

@ -30,11 +30,7 @@
#include <sys/types.h>
#include <android-base/logging.h>
#include <android-base/result.h>
#include <android-base/scopeguard.h>
#include <android/apex/ApexInfo.h>
#include <android/apex/IApexService.h>
#include <binder/IServiceManager.h>
#include <cutils/fs.h>
#include <selinux/android.h>
@ -145,35 +141,24 @@ static bool rmrf_contents(const std::string& path) {
}
}
static android::base::Result<std::vector<std::string>> get_apex_list() {
auto sm = android::defaultServiceManager();
auto binder = sm->waitForService(android::String16("apexservice"));
if (binder == nullptr) {
return android::base::Error() << "Failed to get apexservice";
}
auto service = android::interface_cast<android::apex::IApexService>(binder);
std::vector<android::apex::ApexInfo> list;
auto status = service->getActivePackages(&list);
if (!status.isOk()) {
return android::base::Error() << status.exceptionMessage().c_str();
}
std::vector<std::string> names;
names.reserve(list.size());
for (const auto& apex_info : list) {
names.push_back(apex_info.moduleName);
}
return names;
}
static bool prepare_apex_subdirs(struct selabel_handle* sehandle, const std::string& path) {
if (!prepare_dir(sehandle, 0711, 0, 0, path + "/apexdata")) return false;
auto apex_list = get_apex_list();
if (!apex_list.ok()) {
LOG(ERROR) << apex_list.error();
auto dirp = std::unique_ptr<DIR, int (*)(DIR*)>(opendir("/apex"), closedir);
if (!dirp) {
PLOG(ERROR) << "Unable to open apex directory";
return false;
}
for (const auto& name : *apex_list) {
struct dirent* entry;
while ((entry = readdir(dirp.get())) != nullptr) {
if (entry->d_type != DT_DIR) continue;
const char* name = entry->d_name;
// skip any starting with "."
if (name[0] == '.') continue;
if (strchr(name, '@') != NULL) continue;
if (!prepare_dir(sehandle, 0771, AID_ROOT, AID_SYSTEM, path + "/apexdata/" + name)) {
return false;
}