tequilaOS/platform_system_vold
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improve vold logging.

Browse source 
This patch adds more error logging to mountFstab. In a few cases, the
were error paths with no existing error logs. In other cases, the log
messages are there to help understand error flow in logs (for example
when a function with lots of error paths returns false).

Bug: 205314634
Test: treehugger builds
Change-Id: I464edc6e74ea0d7419ee9d9b75fd238752c13f4f
This commit is contained in:
David Anderson 2021-11-05 18:57:49 -07:00
parent 2a89e7c577
commit e179157dc5
3 changed files with 40 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
KeyStorage.cpp
View file

@ -601,9 +601,15 @@ static bool storeKey(const std::string& dir, const KeyAuthentication& auth, cons
if (!generateKeyStorageKey(keystore, appId, &ksKey)) return false;
if (!writeStringToFile(ksKey, dir + "/" + kFn_keymaster_key_blob)) return false;
km::AuthorizationSet keyParams = beginParams(appId);
if (!encryptWithKeystoreKey(keystore, dir, keyParams, key, &encryptedKey)) return false;
if (!encryptWithKeystoreKey(keystore, dir, keyParams, key, &encryptedKey)) {
LOG(ERROR) << "encryptWithKeystoreKey failed";
return false;
}
} else {
if (!encryptWithoutKeystore(appId, key, &encryptedKey)) return false;
if (!encryptWithoutKeystore(appId, key, &encryptedKey)) {
LOG(ERROR) << "encryptWithoutKeystore failed";
return false;
}
}
if (!writeStringToFile(encryptedKey, dir + "/" + kFn_encrypted_key)) return false;
if (!FsyncDirectory(dir)) return false;
@ -648,9 +654,15 @@ bool retrieveKey(const std::string& dir, const KeyAuthentication& auth, KeyBuffe
Keystore keystore;
if (!keystore) return false;
km::AuthorizationSet keyParams = beginParams(appId);
if (!decryptWithKeystoreKey(keystore, dir, keyParams, encryptedMessage, key)) return false;
if (!decryptWithKeystoreKey(keystore, dir, keyParams, encryptedMessage, key)) {
LOG(ERROR) << "decryptWithKeystoreKey failed";
return false;
}
} else {
if (!decryptWithoutKeystore(appId, encryptedMessage, key)) return false;
if (!decryptWithoutKeystore(appId, encryptedMessage, key)) {
LOG(ERROR) << "decryptWithoutKeystore failed";
return false;
}
}
return true;
}

5
KeyUtil.cpp
View file

@ -54,7 +54,10 @@ static bool randomKey(size_t size, KeyBuffer* key) {
}
bool generateStorageKey(const KeyGeneration& gen, KeyBuffer* key) {
if (!gen.allow_gen) return false;
if (!gen.allow_gen) {
LOG(ERROR) << "Generating storage key not allowed";
return false;
}
if (gen.use_hw_wrapped_key) {
if (gen.keysize != FSCRYPT_MAX_KEY_SIZE) {
LOG(ERROR) << "Cannot generate a wrapped key " << gen.keysize << " bytes long";

26
MetadataCrypt.cpp
View file

@ -245,7 +245,8 @@ bool fscrypt_mount_metadata_encrypted(const std::string& blk_device, const std::
<< fs_type;
auto encrypted_state = android::base::GetProperty("ro.crypto.state", "");
if (encrypted_state != "" && encrypted_state != "encrypted") {
LOG(DEBUG) << "fscrypt_enable_crypto got unexpected starting state: " << encrypted_state;
LOG(ERROR) << "fscrypt_mount_metadata_encrypted got unexpected starting state: "
<< encrypted_state;
return false;
}
@ -282,12 +283,18 @@ bool fscrypt_mount_metadata_encrypted(const std::string& blk_device, const std::
auto gen = needs_encrypt ? makeGen(options) : neverGen();
KeyBuffer key;
if (!read_key(data_rec->metadata_key_dir, gen, &key)) return false;
if (!read_key(data_rec->metadata_key_dir, gen, &key)) {
LOG(ERROR) << "read_key failed in mountFstab";
return false;
}
std::string crypto_blkdev;
uint64_t nr_sec;
if (!create_crypto_blk_dev(kDmNameUserdata, blk_device, key, options, &crypto_blkdev, &nr_sec))
if (!create_crypto_blk_dev(kDmNameUserdata, blk_device, key, options, &crypto_blkdev,
&nr_sec)) {
LOG(ERROR) << "create_crypto_blk_dev failed in mountFstab";
return false;
}
if (needs_encrypt) {
if (should_format) {
@ -301,10 +308,17 @@ bool fscrypt_mount_metadata_encrypted(const std::string& blk_device, const std::
LOG(ERROR) << "Unknown filesystem type: " << fs_type;
return false;
}
LOG(DEBUG) << "Format (err=" << error << ") " << crypto_blkdev << " on " << mount_point;
if (error != 0) return false;
if (error != 0) {
LOG(ERROR) << "Format of " << crypto_blkdev << " for " << mount_point
<< " failed (err=" << error << ").";
return false;
}
LOG(DEBUG) << "Format of " << crypto_blkdev << " for " << mount_point << " succeeded.";
} else {
if (!encrypt_inplace(crypto_blkdev, blk_device, nr_sec, false)) return false;
if (!encrypt_inplace(crypto_blkdev, blk_device, nr_sec, false)) {
LOG(ERROR) << "encrypt_inplace failed in mountFstab";
return false;
}
}
}