Fix bogus error checking on unique_fd
The expression "!fd" calls the implicit conversion to int, but comparing the raw fd against 0 does not work, since open() and other POSIX calls returning a file descriptor use -1 to signal an error. Test: m vold Change-Id: I0847c276f39cb9dd09c7ffb96951276113418fc8
This commit is contained in:
parent
32a8a47b07
commit
ebe293ab54
1 changed files with 1 additions and 1 deletions
|
@ -330,7 +330,7 @@ Status cp_prepareCheckpoint() {
|
|||
if (fstab_rec->fs_mgr_flags.checkpoint_blk) {
|
||||
android::base::unique_fd fd(
|
||||
TEMP_FAILURE_RETRY(open(mount_rec.mount_point.c_str(), O_RDONLY | O_CLOEXEC)));
|
||||
if (!fd) {
|
||||
if (fd == -1) {
|
||||
PLOG(ERROR) << "Failed to open mount point" << mount_rec.mount_point;
|
||||
continue;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue