tequilaOS/platform_system_vold
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Allow IV_INO_LBLK_32 with virtio storage

Browse source 
This has to be allowed as a workaround until there is a way for
userspace to check the maximum DUN size directly.

Bug: 207390665
Change-Id: Id5e51720ca963fe80e65dbae1965f777b3cd2ee4
This commit is contained in:
Eric Biggers 2021-11-22 11:15:23 -08:00
parent 017e95fa6a
commit f9c6dfa8fd
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
FsCrypt.cpp
View file

@ -208,7 +208,7 @@ static bool read_and_fixate_user_ce_key(userid_t user_id,
return false; return false;
} }
static bool IsEmmcStorage(const std::string& blk_device) { static bool MightBeEmmcStorage(const std::string& blk_device) {
// Handle symlinks. // Handle symlinks.
std::string real_path; std::string real_path;
if (!Realpath(blk_device, &real_path)) { if (!Realpath(blk_device, &real_path)) {
@ -224,8 +224,15 @@ static bool IsEmmcStorage(const std::string& blk_device) {
} }
// Now we should have the "real" block device. // Now we should have the "real" block device.
LOG(DEBUG) << "IsEmmcStorage(): blk_device = " << blk_device << ", real_path=" << real_path; LOG(DEBUG) << "MightBeEmmcStorage(): blk_device = " << blk_device
return StartsWith(Basename(real_path), "mmcblk"); << ", real_path=" << real_path;
std::string name = Basename(real_path);
return StartsWith(name, "mmcblk") ||
// virtio devices may provide inline encryption support that is
// backed by eMMC inline encryption on the host, thus inheriting the
// DUN size limitation. So virtio devices must be allowed here too.
// TODO(b/207390665): check the maximum DUN size directly instead.
StartsWith(name, "vd");
} }
// Retrieve the options to use for encryption policies on the /data filesystem. // Retrieve the options to use for encryption policies on the /data filesystem.
@ -241,7 +248,7 @@ static bool get_data_file_encryption_options(EncryptionOptions* options) {
return false; return false;
} }
if ((options->flags & FSCRYPT_POLICY_FLAG_IV_INO_LBLK_32) && if ((options->flags & FSCRYPT_POLICY_FLAG_IV_INO_LBLK_32) &&
!IsEmmcStorage(entry->blk_device)) { !MightBeEmmcStorage(entry->blk_device)) {
LOG(ERROR) << "The emmc_optimized encryption flag is only allowed on eMMC storage. Remove " LOG(ERROR) << "The emmc_optimized encryption flag is only allowed on eMMC storage. Remove "
"this flag from the device's fstab"; "this flag from the device's fstab";
return false; return false;