Commit graph

14 commits

Author SHA1 Message Date
Nick Kralevich
e7e89acbc8 vold: cleanups for O_CLOEXEC tidy checks.
Bug: 129350825
Test: compiles and boots
Change-Id: I83a484ca15df1b757b670008f15af5504bc94df1
2019-03-29 16:04:47 -07:00
Rubin Xu
f2e846f153 Remove excess logging in secdiscard
Remove all debug logs to reduce logspam a bit.

Bug: 64349233
Test: manual
Change-Id: I234fae7b9fb719b09af27985736f43f085dad301
2019-03-21 19:13:51 +00:00
Paul Crowley
14c8c0765a clang-format many files.
Test: Format-only changes; treehugger suffices.
Change-Id: I23cde3f0bbcac13bef555d13514e922c79d5ad48
2018-09-18 15:41:22 -07:00
Jaegeuk Kim
1dcfbe2a01 fix wrong ioctl direction for F2FS_IOC_GET_PIN_FILE
Change-Id: I0cf212c3e1770e233ae1f70e7fc4a6d70b82583e
Signed-off-by: Jaegeuk Kim <jaegeuk@google.com>
2018-09-12 10:10:51 -07:00
Jaegeuk Kim
ab515b2011 secdiscard: should pin_file to avoid moving blocks in F2FS
This file should avoid F2FS GC, since it directly access block device based
on fibmap.

Bug: 111659036
Change-Id: I15aef8175c23ba4029eb580e2dba59c77cca8227
Signed-off-by: Jaegeuk Kim <jaegeuk@google.com>
2018-08-02 14:17:17 -07:00
Paul Crowley
03f89d3d95 Move functions useful for crypto test into their own file
More refactoring in advance of work on bug.

Bug: 36029169
Test: compiles.
Change-Id: Ic4cdd4761e4c2b11a3ddca5c3bbc4d5e42fac9d4
2017-06-16 16:17:26 -07:00
Paul Crowley
e4c93da492 Abolish AutoCloseFD.h in favour of unique_fd
Android has a standard way to do what AutoCloseFD.h does, so use that
instead. Refactor before work on the bug.

Bug: 36029169
Test: Deleted a user and checked that secdiscard logs looked good.
Change-Id: I5d8bedfb3fa1f032fd2bced88b1b561e4a8c2ff4
2017-06-16 16:14:03 -07:00
Paul Crowley
2143ee8d61 Zero out blocks if BLKSECDISCARD fails
On a device where we can't BLKSECDISCARD sectors, we "overwrite" them
with zeroes. This changes the FTL to remap those sectors to new
locations.  With this done, the old contents are accessible only given
a compromise of flash firmware or a die level attack.

Bug: 26021231
Change-Id: Ia065921389886fac1ba456c19c138187237c2561
2016-07-11 17:31:36 -07:00
Paul Crowley
8bb8fcfb4f Use android-base logging not cutils in secdiscard
Much nicer C++ style logging, but the main reason is to clean up
AutoCloseFD.h so I don't have to use cutils to use it.

Change-Id: I7a7f227508418046eecce6c89f813bd8854f448a
2016-01-12 10:03:05 +00:00
Paul Crowley
28c4df4bdc Make deletion of larger files possible.
Bug: 22502684
Change-Id: I9034af1ce919bff51f836e5bf51cc2585089440e
2015-11-17 13:29:20 +00:00
Paul Crowley
5ab73e945d Add --no-unlink option to secdiscard for testing.
Also allow deletion of multiple files in one invocation.

Change-Id: I5011bf45f2d3b91964bc68fd8e61ec037e1de2ca
2015-11-02 10:13:52 +00:00
Paul Crowley
4432e73494 secdiscard.cpp: Use getmntent and my newfound C++ knowledge.
Bug: 19706593
Change-Id: I6254e0339ab42fdbecda80c6f37e64c323329190
2015-11-02 10:13:52 +00:00
Paul Crowley
747e1f7a6d Fix erroneous comment in secdiscard.cpp, plus style fixes.
Bug: 19706593

Change-Id: I9c1442f31cc6b6507225a5aa9ad07be6042d69ce
2015-06-24 16:06:33 +00:00
Paul Crowley
53af81c60d Scrub the key from the disk with BLKSECDISCARD.
Bug: 19706593
Change-Id: Ib91b5182413b5dca6d0e1fdda7990ea0973843bb
2015-06-17 03:40:33 +01:00