Commit graph

43343 commits

Author SHA1 Message Date
Elliott Hughes
be241d1d6b Merge "<unistd.h>: explain why getpagesize() is better than getauxval() as well as sysconf()." into main 2024-06-04 11:03:05 +00:00
Christopher Ferris
7f4c837186 Update to v6.9 kernel headers.
Kernel headers coming from:

Git: https://android.googlesource.com/kernel/common/
Branch: android-mainline
Tag: android-mainline-6.9

Test: Builds and bionic unit tests pass on raven.
Test: Able to log in to an Android GO 32 bit device.
Change-Id: If53a38bbb65c3c653ce790fe5c6e51597901a14e
2024-06-03 14:22:19 -07:00
Elliott Hughes
b63934c060 Merge "setjmp_test: riscv64 does have callee-save fp registers." into main am: 1bebfd3c10 am: 6246e95adf
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3096178

Change-Id: Ibf8d3247eba551ba3eeb4ca854338f706bc8ff2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-03 20:40:40 +00:00
Elliott Hughes
544939d04b Merge "getpagesize(): remove "portability" claim." into main am: a84f9cffcf am: 7e6ca0d6b5
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3112480

Change-Id: I6a3da98f860800b43b9f8e101f35c7d4f1475626
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-03 20:40:18 +00:00
Elliott Hughes
6246e95adf Merge "setjmp_test: riscv64 does have callee-save fp registers." into main am: 1bebfd3c10
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3096178

Change-Id: I15624144982e01cb4e8bbeadc753e670868f7103
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-03 20:33:36 +00:00
Elliott Hughes
7e6ca0d6b5 Merge "getpagesize(): remove "portability" claim." into main am: a84f9cffcf
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3112480

Change-Id: I3dc4c2fdf157f765ce264c031bda11d5ab9734e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-03 20:33:08 +00:00
Elliott Hughes
1bebfd3c10 Merge "setjmp_test: riscv64 does have callee-save fp registers." into main 2024-06-03 20:30:33 +00:00
Elliott Hughes
a84f9cffcf Merge "getpagesize(): remove "portability" claim." into main 2024-06-03 20:27:00 +00:00
Elliott Hughes
4e63125ce1 getpagesize(): remove "portability" claim.
This is just POSIX nonsense. Android, iOS/macOS, the BSDs, and glibc all have getpagesize(). Window doesn't, but Windows doesn't have sysconf(3) either, so there's not a strong "portability" argument to be had there!

Change-Id: Ieacfbb61c3612045f27c20c3fa4fa12694db2243
2024-06-03 19:21:46 +00:00
Elliott Hughes
b631ec7409 <unistd.h>: explain why getpagesize() is better than getauxval() as well as sysconf().
I thought we'd already done this, but apparently not.

Bug: http://b/315511637
Change-Id: I0581438a6f551be9750b6679a9f3ad06c83f1e9b
2024-06-03 19:19:22 +00:00
Elliott Hughes
86968d95f1 setjmp_test: riscv64 does have callee-save fp registers.
The setjmp implementation is correct, but this comment was wrong, and we were missing the implementation of the test. This would be slightly simpler if we enabled Zfa in the build system and qemu, but this works for now.

Change-Id: Iad32771019584beacd8b35138ac2bf4c0a14c903
2024-06-03 18:38:10 +00:00
Elliott Hughes
78706d25d0 <stdio.h>: warn on some unused results.
This is fairly conservative, touching only those functions (such as feof()) where it's clearly an error to not use the return value.

Also fix a test that was ignoring the return value of feof() (because it was just checking whether the function could take the lock, and genuinely didn't care about the result).

Change-Id: If2ade10ae87df45a8b9bfcb24828e460201fa9a1
2024-05-31 22:55:22 +00:00
Elliott Hughes
7716771527 Merge "Warn about unused results with bsearch()." into main am: b851c4c5bf am: 74e8e58109
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3108440

Change-Id: I11704455de8a8e1703fb2fb047d93045782663e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-31 20:34:47 +00:00
Elliott Hughes
74e8e58109 Merge "Warn about unused results with bsearch()." into main am: b851c4c5bf
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3108440

Change-Id: I792804d3ae115d65187f7240a8c847c4b3b5cc7e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-31 20:27:27 +00:00
Elliott Hughes
b851c4c5bf Merge "Warn about unused results with bsearch()." into main 2024-05-31 20:17:57 +00:00
Elliott Hughes
d4c54b4448 Warn about unused results with bsearch().
This function has no side-effects, and the return value is the whole point.

Change-Id: Ibb9143c6a3c4089bfd6402c1c580ef76ce0f5d27
2024-05-31 17:33:33 +00:00
Elliott Hughes
494be60a89 Merge "fdtrack: make it clearer that there's more information available." into main am: 3cd51b749d am: 4f4fc67f63
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3108439

Change-Id: I91abbaa15393cc06ee18558eeb9f814a5ca4356d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 19:55:39 +00:00
Elliott Hughes
8d32726075 Merge "pthread_exit(): reduce duplication." into main am: aec1f25248 am: 7379926162
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3103458

Change-Id: Ic6bac2d14d5e7b9545940dbbb9a229db8be369b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 19:55:26 +00:00
Elliott Hughes
4f4fc67f63 Merge "fdtrack: make it clearer that there's more information available." into main am: 3cd51b749d
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3108439

Change-Id: Iaa562629c0b750798dac0f34053a6bc001b5b339
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 19:48:57 +00:00
Elliott Hughes
7379926162 Merge "pthread_exit(): reduce duplication." into main am: aec1f25248
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3103458

Change-Id: I548a372bfa6d4043c1dd17f7d3b409be3114ec72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 19:48:43 +00:00
Elliott Hughes
3cd51b749d Merge "fdtrack: make it clearer that there's more information available." into main 2024-05-30 19:47:07 +00:00
Elliott Hughes
aec1f25248 Merge "pthread_exit(): reduce duplication." into main 2024-05-30 19:47:04 +00:00
Elliott Hughes
e56350c4ad fdtrack: make it clearer that there's more information available.
A lot of people who see these via pitot or whatever don't even think to look at the real tombstone. Make it explicit that this is what they should do next. Also, since we have the numbers, say exactly what we mean by "most common".

Bug: http://b/338882189
Change-Id: Ia21848a40e82cb2486538a7578501e2ec0948e1c
2024-05-30 17:26:25 +00:00
Elliott Hughes
e4b72dbd27 Merge "Spell "calling convention" out in full." into main am: a1e51dc4b8 am: c62d1255f9
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3107937

Change-Id: Ib6c4f8c5e5aa8bc88013f734ad9dd97d90557d41
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 12:36:08 +00:00
Elliott Hughes
c62d1255f9 Merge "Spell "calling convention" out in full." into main am: a1e51dc4b8
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3107937

Change-Id: I24c02ce5102f0662aa5f1f9242b492927f889b7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 12:29:43 +00:00
Elliott Hughes
a1e51dc4b8 Merge "Spell "calling convention" out in full." into main 2024-05-30 12:26:07 +00:00
Elliott Hughes
590711df65 Merge "bionic_allocator: more detailed and consistent error reporting." into main am: 793ce9c90a am: 5e7b7f0056
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3107217

Change-Id: I0896396f66179682137d0f2d01ac3da2cac5dcdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 12:06:28 +00:00
Elliott Hughes
bcb0c1ec16 Merge "Fix some wcwidth() special cases." into main am: f4a27aee8d am: cee6832eb3
Original change: https://android-review.googlesource.com/c/platform/bionic/+/2983497

Change-Id: I100c9ef0bda09352a934508586b1a2d6f940d27b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 12:06:12 +00:00
Elliott Hughes
5e7b7f0056 Merge "bionic_allocator: more detailed and consistent error reporting." into main am: 793ce9c90a
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3107217

Change-Id: I7af459d9572b2a493ed665729552204df26d7208
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 11:59:18 +00:00
Elliott Hughes
cee6832eb3 Merge "Fix some wcwidth() special cases." into main am: f4a27aee8d
Original change: https://android-review.googlesource.com/c/platform/bionic/+/2983497

Change-Id: I0d71b38128f2bd43a6ab1da35c348c74c4f0fdf7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 11:59:03 +00:00
Elliott Hughes
793ce9c90a Merge "bionic_allocator: more detailed and consistent error reporting." into main 2024-05-30 11:41:59 +00:00
Elliott Hughes
f4a27aee8d Merge "Fix some wcwidth() special cases." into main 2024-05-30 11:41:24 +00:00
Treehugger Robot
69efc8ce41 Merge "Remove unused Android.mk under bionic" into main am: f6486e0e71 am: 3fc8fc4bb7
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3107717

Change-Id: I5d9e76dc4e1582ca118e1ef60218534535f98c97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 22:32:20 +00:00
Elliott Hughes
8f653f8ad9 bionic_allocator: more detailed and consistent error reporting.
I only came to improve the signature mismatch error, but I was then annoyed by the copy & paste of the other checks.

get_chunk_size() seems to be deliberately avoiding any checks, though I think that might be a bug, and there should be a get_chunk_size() that _does_ check for most callers, and a get_chunk_size_unchecked() for the <sys/thread_properties.h> stuff that seems to want to only be "best effort" (but does still have _some_ possibility of aborting, in addition to the possibility of segfaulting).

Also a bit of "include what you use" after cider complained about all the unused includes in bionic_allocator.h.

Bug: https://issuetracker.google.com/341850283
Change-Id: I278b495601353733af516a2d60ed10feb9cef36b
2024-05-29 22:25:37 +00:00
Treehugger Robot
527b00e809 Merge "<sys/thread_properties.h>: remove stray semicolon in the implementation." into main am: 1395fa865f am: 00ee4c556b
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3103457

Change-Id: I7defa9449cdb289c33e12361e1a4de4e573bac5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 22:23:48 +00:00
Elliott Hughes
7d0e6d7f67 Merge "Fix gettid() in functions that call fork() or equivalent." into main am: 7147a477c1 am: 3c7274d386
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3106497

Change-Id: I73006f8efaffe8e222dbc21ffd66ce6f1acb4972
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 22:16:41 +00:00
Treehugger Robot
207cb76302 Merge "Revert^2 "Convert Android.mk under bionic to Android.bp"" into main am: cdaaa0a6bb am: 38ad80a3ad
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3102918

Change-Id: I8d51374d0dcf15dcc6e7f963a1a161d3a1574aa9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 22:07:26 +00:00
Automerger Merge Worker
981b587516 Merge "[automerger skipped] Skip 2024-06 Release (ab/AP2A.240605.024) to aosp-main-future am: ce0d5cf48a -s ours" into main 2024-05-29 21:56:19 +00:00
Xin Li
958474f350 [automerger skipped] Skip 2024-06 Release (ab/AP2A.240605.024) to aosp-main-future am: ce0d5cf48a -s ours
am skip reason: Merged-In I39365064e6c1538b0be1114479557d94a72ee369 with SHA-1 23a3482169 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/bionic/+/27555744

Change-Id: I71159110c9f800d28844508eb6e905ccf550b2f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 21:55:51 +00:00
Xin Li
9c59dba8f3 [automerger skipped] Skip 2024-06 Release (ab/AP2A.240605.024) to aosp-main-future am: ce0d5cf48a -s ours
am skip reason: Merged-In I39365064e6c1538b0be1114479557d94a72ee369 with SHA-1 23a3482169 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/bionic/+/27555744

Change-Id: I2fc25c08d87a363cf80deeeda272a92a38506311
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 21:55:48 +00:00
Elliott Hughes
20a9f99b3b Fix some wcwidth() special cases.
Detailed explanation in the code comments.

Test: treehugger
Change-Id: I2aef2510724c1c622b83e226b51d4c8429b88272
2024-05-29 21:45:51 +00:00
Xin Li
15ccdaefd8 [automerger skipped] Merge Android 24Q2 Release (ab/11526283) to aosp-main-future am: 431ecbca72 -s ours
am skip reason: Merged-In Ibe2ffda9155246f2217aaa0e7d589ed7effec311 with SHA-1 5951b4100c is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/bionic/+/27273745

Change-Id: Id31e907cebece02702375d0fb03700abc3fda8ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 20:48:32 +00:00
Treehugger Robot
3fc8fc4bb7 Merge "Remove unused Android.mk under bionic" into main am: f6486e0e71
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3107717

Change-Id: I99607908de624c33d724063446b0b18fe6c11265
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 12:34:37 +00:00
Elliott Hughes
13090d0bbf Spell "calling convention" out in full.
We only use this in one other place anyway.

Also be explicit about how `__tls_get_addr` and `___tls_get_addr` differ, since I missed that at first!

Change-Id: Ica214886c5346f118f063bca26e6dd8d74ee21f4
2024-05-29 12:34:18 +00:00
Treehugger Robot
f6486e0e71 Merge "Remove unused Android.mk under bionic" into main 2024-05-29 12:26:38 +00:00
Treehugger Robot
00ee4c556b Merge "<sys/thread_properties.h>: remove stray semicolon in the implementation." into main am: 1395fa865f
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3103457

Change-Id: I93338d0e279c99e91da9f19ac38e5e7f48c22d75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 12:25:59 +00:00
Treehugger Robot
1395fa865f Merge "<sys/thread_properties.h>: remove stray semicolon in the implementation." into main 2024-05-29 12:02:00 +00:00
Elliott Hughes
3c7274d386 Merge "Fix gettid() in functions that call fork() or equivalent." into main am: 7147a477c1
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3106497

Change-Id: I9ef6fa58a96e6f21078fe8623753e0af4fdb73cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 11:41:04 +00:00
Elliott Hughes
7147a477c1 Merge "Fix gettid() in functions that call fork() or equivalent." into main 2024-05-29 11:23:06 +00:00
kellyhung
0aaab1b66f Remove unused Android.mk under bionic
Bug: b/311284462
Test: CIs
Change-Id: I2586c425616ef59dbf2ba88fe1cbaa75a3bc2d5c
2024-05-29 14:50:18 +08:00