Commit graph

43424 commits

Author SHA1 Message Date
Elliott Hughes
988c807ff8 Merge "<malloc.h>: warn on unused results for malloc_usable_size()." into main 2024-06-05 15:48:45 +00:00
Elliott Hughes
2267f25e1f Merge "Add a README.md to docs/, as a guide to what we have available." into main am: bbc1befc2c am: c67976a64e
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3112900

Change-Id: Icc68db2a4932c0e6faabf0f18637311d2ad93c22
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-05 13:23:25 +00:00
Elliott Hughes
c67976a64e Merge "Add a README.md to docs/, as a guide to what we have available." into main am: bbc1befc2c
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3112900

Change-Id: Idf54c8bb96c4cecdb894035e4b3ba8e9640ea73f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-05 13:01:31 +00:00
Elliott Hughes
bbc1befc2c Merge "Add a README.md to docs/, as a guide to what we have available." into main 2024-06-05 12:39:52 +00:00
Elliott Hughes
ad44152c38 new.cpp: add sized operator delete.
clang-19 and later default to C++14 sized deallocation. Currently we don't have C23's C equivalent of free_sized(), so we just implement these in terms of free() for now.

Bug: http://b/344993254
Change-Id: I708710aee3f7a684bfe494a96f7baed014acbe57
2024-06-05 12:26:56 +00:00
Android Build Coastguard Worker
161975d992 Snap for 11926388 from 9ebb86ac26 to 24Q3-release
Change-Id: I183cb0f6ab6658686f1a1c3a29d5a0283fa5510a
2024-06-04 23:55:39 +00:00
Christopher Ferris
9ebb86ac26 Merge "Update to v6.9 kernel headers." into main am: b9279b62c2 am: 02f33c7090
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3111723

Change-Id: I2ced174692ff326e3c31c0472aaadf910c572d04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-04 18:58:43 +00:00
Elliott Hughes
f9feb7ad62 Merge "<stdio.h>: warn on some unused results." into main am: 5b57093ecc am: c87d87ca60
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3110539

Change-Id: I76672bdfc6b8fdc95c7621882feb0fff538d98c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-04 18:58:31 +00:00
Christopher Ferris
02f33c7090 Merge "Update to v6.9 kernel headers." into main am: b9279b62c2
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3111723

Change-Id: Iff882dc72e0044d04ef7d9b9a19ef995425b0b9b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-04 18:44:07 +00:00
Elliott Hughes
c87d87ca60 Merge "<stdio.h>: warn on some unused results." into main am: 5b57093ecc
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3110539

Change-Id: I4c15330dc742672b8ab675496543e5899c8f6e61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-04 18:43:51 +00:00
Christopher Ferris
b9279b62c2 Merge "Update to v6.9 kernel headers." into main 2024-06-04 18:22:22 +00:00
Elliott Hughes
5b57093ecc Merge "<stdio.h>: warn on some unused results." into main 2024-06-04 18:20:48 +00:00
Elliott Hughes
ecaa192929 Add a README.md to docs/, as a guide to what we have available.
I was actually here to add some new documentation, but realized there wasn't really a good place to put it...

Change-Id: I8a2fc93e61a89e87aa53dd0beb9dfcc6561687ca
2024-06-04 18:20:05 +00:00
Elliott Hughes
69ddb74135 <malloc.h>: warn on unused results for malloc_usable_size().
Not a security problem, but definitely a bug if you're calling this and ignoring the result, since it has no side-effects.

(All of the more important functions -- realloc() especially -- are already annotated.)

Change-Id: I217463518b4716befcc0ed9426648eafbfbbdde4
2024-06-04 15:32:45 +00:00
Elliott Hughes
857f0302a5 Merge "<unistd.h>: explain why getpagesize() is better than getauxval() as well as sysconf()." into main am: be241d1d6b am: 862d6713e2
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3112242

Change-Id: I4b828915556098d0ce3272940749ccc6089056ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-04 11:39:34 +00:00
Elliott Hughes
862d6713e2 Merge "<unistd.h>: explain why getpagesize() is better than getauxval() as well as sysconf()." into main am: be241d1d6b
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3112242

Change-Id: Ic5e61455b5b2157b647a77c6bb7581ba2a1ba2d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-04 11:20:18 +00:00
Elliott Hughes
be241d1d6b Merge "<unistd.h>: explain why getpagesize() is better than getauxval() as well as sysconf()." into main 2024-06-04 11:03:05 +00:00
Android Build Coastguard Worker
1726eadc7c Snap for 11920703 from b63934c060 to 24Q3-release
Change-Id: I96ee556fb9f66ef09ae131808dcea51087041ee1
2024-06-03 23:35:54 +00:00
Christopher Ferris
7f4c837186 Update to v6.9 kernel headers.
Kernel headers coming from:

Git: https://android.googlesource.com/kernel/common/
Branch: android-mainline
Tag: android-mainline-6.9

Test: Builds and bionic unit tests pass on raven.
Test: Able to log in to an Android GO 32 bit device.
Change-Id: If53a38bbb65c3c653ce790fe5c6e51597901a14e
2024-06-03 14:22:19 -07:00
Elliott Hughes
b63934c060 Merge "setjmp_test: riscv64 does have callee-save fp registers." into main am: 1bebfd3c10 am: 6246e95adf
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3096178

Change-Id: Ibf8d3247eba551ba3eeb4ca854338f706bc8ff2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-03 20:40:40 +00:00
Elliott Hughes
544939d04b Merge "getpagesize(): remove "portability" claim." into main am: a84f9cffcf am: 7e6ca0d6b5
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3112480

Change-Id: I6a3da98f860800b43b9f8e101f35c7d4f1475626
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-03 20:40:18 +00:00
Elliott Hughes
6246e95adf Merge "setjmp_test: riscv64 does have callee-save fp registers." into main am: 1bebfd3c10
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3096178

Change-Id: I15624144982e01cb4e8bbeadc753e670868f7103
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-03 20:33:36 +00:00
Elliott Hughes
7e6ca0d6b5 Merge "getpagesize(): remove "portability" claim." into main am: a84f9cffcf
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3112480

Change-Id: I3dc4c2fdf157f765ce264c031bda11d5ab9734e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-03 20:33:08 +00:00
Elliott Hughes
1bebfd3c10 Merge "setjmp_test: riscv64 does have callee-save fp registers." into main 2024-06-03 20:30:33 +00:00
Elliott Hughes
a84f9cffcf Merge "getpagesize(): remove "portability" claim." into main 2024-06-03 20:27:00 +00:00
Elliott Hughes
4e63125ce1 getpagesize(): remove "portability" claim.
This is just POSIX nonsense. Android, iOS/macOS, the BSDs, and glibc all have getpagesize(). Window doesn't, but Windows doesn't have sysconf(3) either, so there's not a strong "portability" argument to be had there!

Change-Id: Ieacfbb61c3612045f27c20c3fa4fa12694db2243
2024-06-03 19:21:46 +00:00
Elliott Hughes
b631ec7409 <unistd.h>: explain why getpagesize() is better than getauxval() as well as sysconf().
I thought we'd already done this, but apparently not.

Bug: http://b/315511637
Change-Id: I0581438a6f551be9750b6679a9f3ad06c83f1e9b
2024-06-03 19:19:22 +00:00
Elliott Hughes
86968d95f1 setjmp_test: riscv64 does have callee-save fp registers.
The setjmp implementation is correct, but this comment was wrong, and we were missing the implementation of the test. This would be slightly simpler if we enabled Zfa in the build system and qemu, but this works for now.

Change-Id: Iad32771019584beacd8b35138ac2bf4c0a14c903
2024-06-03 18:38:10 +00:00
Android Build Coastguard Worker
bd8034a6ce Snap for 11914274 from 7716771527 to 24Q3-release
Change-Id: I2d6ac24b07023bd8f61b57fba00b3b582cde976b
2024-06-01 01:00:36 +00:00
Elliott Hughes
78706d25d0 <stdio.h>: warn on some unused results.
This is fairly conservative, touching only those functions (such as feof()) where it's clearly an error to not use the return value.

Also fix a test that was ignoring the return value of feof() (because it was just checking whether the function could take the lock, and genuinely didn't care about the result).

Change-Id: If2ade10ae87df45a8b9bfcb24828e460201fa9a1
2024-05-31 22:55:22 +00:00
Elliott Hughes
7716771527 Merge "Warn about unused results with bsearch()." into main am: b851c4c5bf am: 74e8e58109
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3108440

Change-Id: I11704455de8a8e1703fb2fb047d93045782663e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-31 20:34:47 +00:00
Elliott Hughes
74e8e58109 Merge "Warn about unused results with bsearch()." into main am: b851c4c5bf
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3108440

Change-Id: I792804d3ae115d65187f7240a8c847c4b3b5cc7e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-31 20:27:27 +00:00
Elliott Hughes
b851c4c5bf Merge "Warn about unused results with bsearch()." into main 2024-05-31 20:17:57 +00:00
Elliott Hughes
d4c54b4448 Warn about unused results with bsearch().
This function has no side-effects, and the return value is the whole point.

Change-Id: Ibb9143c6a3c4089bfd6402c1c580ef76ce0f5d27
2024-05-31 17:33:33 +00:00
Android Build Coastguard Worker
ec839b69bf Snap for 11908474 from 494be60a89 to 24Q3-release
Change-Id: If6fd107338a15a16781c98e6767cfd3ad318609c
2024-05-30 23:00:54 +00:00
Elliott Hughes
494be60a89 Merge "fdtrack: make it clearer that there's more information available." into main am: 3cd51b749d am: 4f4fc67f63
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3108439

Change-Id: I91abbaa15393cc06ee18558eeb9f814a5ca4356d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 19:55:39 +00:00
Elliott Hughes
8d32726075 Merge "pthread_exit(): reduce duplication." into main am: aec1f25248 am: 7379926162
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3103458

Change-Id: Ic6bac2d14d5e7b9545940dbbb9a229db8be369b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 19:55:26 +00:00
Elliott Hughes
4f4fc67f63 Merge "fdtrack: make it clearer that there's more information available." into main am: 3cd51b749d
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3108439

Change-Id: Iaa562629c0b750798dac0f34053a6bc001b5b339
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 19:48:57 +00:00
Elliott Hughes
7379926162 Merge "pthread_exit(): reduce duplication." into main am: aec1f25248
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3103458

Change-Id: I548a372bfa6d4043c1dd17f7d3b409be3114ec72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 19:48:43 +00:00
Elliott Hughes
3cd51b749d Merge "fdtrack: make it clearer that there's more information available." into main 2024-05-30 19:47:07 +00:00
Elliott Hughes
aec1f25248 Merge "pthread_exit(): reduce duplication." into main 2024-05-30 19:47:04 +00:00
Elliott Hughes
e56350c4ad fdtrack: make it clearer that there's more information available.
A lot of people who see these via pitot or whatever don't even think to look at the real tombstone. Make it explicit that this is what they should do next. Also, since we have the numbers, say exactly what we mean by "most common".

Bug: http://b/338882189
Change-Id: Ia21848a40e82cb2486538a7578501e2ec0948e1c
2024-05-30 17:26:25 +00:00
Elliott Hughes
e4b72dbd27 Merge "Spell "calling convention" out in full." into main am: a1e51dc4b8 am: c62d1255f9
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3107937

Change-Id: Ib6c4f8c5e5aa8bc88013f734ad9dd97d90557d41
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 12:36:08 +00:00
Elliott Hughes
c62d1255f9 Merge "Spell "calling convention" out in full." into main am: a1e51dc4b8
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3107937

Change-Id: I24c02ce5102f0662aa5f1f9242b492927f889b7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 12:29:43 +00:00
Elliott Hughes
a1e51dc4b8 Merge "Spell "calling convention" out in full." into main 2024-05-30 12:26:07 +00:00
Elliott Hughes
590711df65 Merge "bionic_allocator: more detailed and consistent error reporting." into main am: 793ce9c90a am: 5e7b7f0056
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3107217

Change-Id: I0896396f66179682137d0f2d01ac3da2cac5dcdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 12:06:28 +00:00
Elliott Hughes
bcb0c1ec16 Merge "Fix some wcwidth() special cases." into main am: f4a27aee8d am: cee6832eb3
Original change: https://android-review.googlesource.com/c/platform/bionic/+/2983497

Change-Id: I100c9ef0bda09352a934508586b1a2d6f940d27b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 12:06:12 +00:00
Elliott Hughes
5e7b7f0056 Merge "bionic_allocator: more detailed and consistent error reporting." into main am: 793ce9c90a
Original change: https://android-review.googlesource.com/c/platform/bionic/+/3107217

Change-Id: I7af459d9572b2a493ed665729552204df26d7208
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 11:59:18 +00:00
Elliott Hughes
cee6832eb3 Merge "Fix some wcwidth() special cases." into main am: f4a27aee8d
Original change: https://android-review.googlesource.com/c/platform/bionic/+/2983497

Change-Id: I0d71b38128f2bd43a6ab1da35c348c74c4f0fdf7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 11:59:03 +00:00
Elliott Hughes
793ce9c90a Merge "bionic_allocator: more detailed and consistent error reporting." into main 2024-05-30 11:41:59 +00:00