tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Revert "Revert "Apply pylint to cc/symbolfile""

Browse source 
This reverts commit ea28f4cae7.

Reason for revert: Postsubmit failure was unrelated, and was fixed by this revert CL aosp/1802327

Change-Id: I2693b17c2261cfc3dce0ed69baeb2d1f45f784f8
This commit is contained in:
Spandan Das 2021-08-19 19:31:54 +00:00
parent ea28f4cae7
commit 3f5659f268
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cc/symbolfile/__init__.py
View file

@ -329,7 +329,7 @@ class SymbolFileParser:
def parse(self) -> List[Version]:
"""Parses the symbol file and returns a list of Version objects."""
versions = []
while self.next_line() != '':
while self.next_line():
assert self.current_line is not None
if '{' in self.current_line:
versions.append(self.parse_version())
@ -376,7 +376,7 @@ class SymbolFileParser:
symbols: List[Symbol] = []
global_scope = True
cpp_symbols = False
while self.next_line() != '':
while self.next_line():
if '}' in self.current_line:
# Line is something like '} BASE; # tags'. Both base and tags
# are optional here.
@ -428,11 +428,11 @@ class SymbolFileParser:
A return value of '' indicates EOF.
"""
line = self.input_file.readline()
while line.strip() == '' or line.strip().startswith('#'):
while not line.strip() or line.strip().startswith('#'):
line = self.input_file.readline()
# We want to skip empty lines, but '' indicates EOF.
if line == '':
if not line:
break
self.current_line = line
return self.current_line