Commit graph

37745 commits

Author SHA1 Message Date
Nikita Ioffe
59b8d28cf6 Merge "Set default value of generate_hashtree property to true" am: f932613c3f
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1736785

Change-Id: Ie1f9147e02f79062d1a17dca5f61ff518a2ae5a6
2021-06-18 13:27:46 +00:00
Nikita Ioffe
f932613c3f Merge "Set default value of generate_hashtree property to true" 2021-06-18 13:14:22 +00:00
satayev
6ea9e45d9c Merge "Add classpath fragment property to skip proto generation." am: f45966f35b
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1738336

Change-Id: I153af3111b835ce3bbfb56b9d91cf43269285ee4
2021-06-18 10:29:26 +00:00
satayev
f45966f35b Merge "Add classpath fragment property to skip proto generation." 2021-06-18 10:17:50 +00:00
Paul Duffin
c4a3e6d2f3 Export boot image files from prebuilt_apex/apex_set am: 5466a3699c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1736777

Change-Id: I1cf84ff519ca6865d3a87ae75b1f48fc6ed1e3f4
2021-06-18 06:48:21 +00:00
Paul Duffin
56a6834640 Copy boot dex jars from prebuilt art-bootclasspath-fragment if preferred am: ce918b0278
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1736226

Change-Id: I116ef8467e180b691ba6e6f2bcf38cd275f6ecba
2021-06-18 06:47:41 +00:00
Xin Li
ea50a05063 DO NOT MERGE - Mark RQ3A.210410.001 as merged
Bug: 190855093
Merged-In: I33b074204ffba5aa2bf83bbbe350d744ee9d8c57
Change-Id: I50911f727ba98df1035500dbbf467b849be8d6c2
2021-06-17 22:43:25 -07:00
TreeHugger Robot
aee99b3a13 Merge "DO NOT MERGE - Merge ab/7272582" into stage-aosp-master 2021-06-18 00:30:18 +00:00
Paul Duffin
5466a3699c Export boot image files from prebuilt_apex/apex_set
Previously, the prebuilt art-bootclasspath-fragment did not provide any
boot image files. That meant it was impossible to build any module that
requires access to those files from prebuilts, e.g. any module that
needs to be dexpreopt-ed.

This change enables that module to retrieve those files from the
prebuilt_apex.

Bug: 177892522
Bug: 189298093
Test: m nothing
      m droid SOONG_CONFIG_art_module_source_build=false SKIP_BOOT_JARS_CHECK=true
      - the previous command does not work but this change does fix one
        of the issues reported.
Change-Id: I1d4d9545172d79282918130df6b9aa55471bffc1
2021-06-17 23:05:43 +01:00
Paul Duffin
ce918b0278 Copy boot dex jars from prebuilt art-bootclasspath-fragment if preferred
Previously, the boot dex jars were only copied to the predefined
locations used by the build from the source art-bootclasspath-fragment
if it was preferred, otherwise no files were copied. That caused build
failures when attempting to build with ART prebuilts. This change
copies the files from prebuilts too.

Bug: 177892522
Bug: 189298093
Test: m nothing
      m droid SOONG_CONFIG_art_module_source_build=false SKIP_BOOT_JARS_CHECK=true
      - the previous command does not work but this change does fix one
        of the issues reported.
Change-Id: I35b37355170546daf6ecac2134d1ca9a73d0e3bc
2021-06-17 23:05:43 +01:00
Xin Li
007875cd10 DO NOT MERGE - Merge ab/7272582
Bug: 190855093
Merged-In: I0f5da13644fd2ec7b0472fe82918e3c6a72d953c
Change-Id: I33b074204ffba5aa2bf83bbbe350d744ee9d8c57
2021-06-17 21:41:17 +00:00
Paul Duffin
d11c1c8fa4 Merge "Copy implementation and header jars to make when possible" am: 94b2e705d1
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1740074

Change-Id: I5faab59bcde87b6be2e1b21ec9e85bdd75a5f687
2021-06-17 20:46:57 +00:00
Paul Duffin
eaae506467 Exclude jacocoagent from boot jars package check am: 7f8721618c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1739993

Change-Id: I83ba8899b202dd89ee613543eead69ab1f88ac4c
2021-06-17 20:37:45 +00:00
Paul Duffin
94b2e705d1 Merge "Copy implementation and header jars to make when possible" 2021-06-17 20:34:49 +00:00
Paul Duffin
85fa344d09 Copy implementation and header jars to make when possible
Fixes test issues caused by a jar containing a classes.dex file was
copied to a place that was expected a jar containing class files.

Bug: 191360201
Test: - in master-art
      find out/ -name \*core-icu4j\* | xargs rm -fr
      art/tools/buildbot-build.sh --target --installclean
      art/tools/bootjars.sh --path --core
      - examine file output from previous script for core-icu4j,
        before this change it contained classes.dex file after this
        change it contained *.class files.
Change-Id: I05ecf652535ec097125fb76d6ca80fee6587f98d
2021-06-17 20:33:54 +01:00
Paul Duffin
7f8721618c Exclude jacocoagent from boot jars package check
This replicates the previous behavior when the boot jars package check
was performed by a singleton. When the singleton was removed and the
check was performed by the platform-bootclasspath the logic to exclude
jacocoagent from the list was lost. This change replaces it.

Bug: 191377804
Test: m EMMA_INSTRUMENT=true EMMA_INSTRUMENT_FRAMEWORK=true check-boot-jars
      - fails without this change passes with this change.
Change-Id: If9eae254045bef9a0c0963213721fc12a9f463cb
2021-06-17 19:33:24 +01:00
Paul Duffin
55e9321255 Merge "Move boot jars package check into platform_bootclasspath" am: 4aea00ec18
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1737753

Change-Id: I4d85e0f1abac976520b0127f314566348fbc33ee
2021-06-17 16:23:08 +00:00
Paul Duffin
57f3d6c870 Merge "Cleanup bootclasspathFragmentInitContentsFromImage" am: 909a2fd055
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1737754

Change-Id: Id717912bdc2b89154ab8a2a44d1e15b26010f6ee
2021-06-17 16:22:59 +00:00
Paul Duffin
b9b5bcf0e3 Merge "Combine hidden API encoding with flag generation" am: 975e757232
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1736225

Change-Id: I16158c1f154b52e29482d9b35b87d8828b92b58b
2021-06-17 16:22:10 +00:00
Paul Duffin
4aea00ec18 Merge "Move boot jars package check into platform_bootclasspath" 2021-06-17 16:06:51 +00:00
Paul Duffin
909a2fd055 Merge "Cleanup bootclasspathFragmentInitContentsFromImage" 2021-06-17 16:03:51 +00:00
Paul Duffin
975e757232 Merge "Combine hidden API encoding with flag generation" 2021-06-17 16:03:22 +00:00
satayev
b98371cc13 Add classpath fragment property to skip proto generation.
This must always be true for updatable apexes, but is not necessary
for non-updatable apexes like com.android.i18n.

In a follow up this will be used to figure out whether apex boot jars
should be bundled into platform_bootclasspath.

Bug: 191127295
Test: atest CtsClasspathsTestCases derive_classpath_test
Change-Id: Ib7dc5b057cb24955222fb97f3ff9da079f30ed77
2021-06-17 12:59:33 +01:00
Lukács T. Berki
288dc903aa Merge "Make the IsSdkVariant field and method the same." am: 419117ee89
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1738338

Change-Id: I8a0874b1477059293612333de68459592752a6d3
2021-06-17 11:56:40 +00:00
satayev
46a327565f Merge "Rename ClasspathFragmentToConfiguredJarList methods to configuredJars." am: 68c8dd019c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1738335

Change-Id: I877ff28de478172f66cef3fd5cd44cb5058ff193
2021-06-17 11:55:43 +00:00
Lukács T. Berki
419117ee89 Merge "Make the IsSdkVariant field and method the same." 2021-06-17 11:48:00 +00:00
satayev
68c8dd019c Merge "Rename ClasspathFragmentToConfiguredJarList methods to configuredJars." 2021-06-17 11:43:37 +00:00
Treehugger Robot
2009a3d70d Merge "Use IsEnvTrue for USE_BAZEL_ANALYSIS check." am: 2d16ec5af7
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1738873

Change-Id: Ice8ab71e72469b84e8af5b38ae537bd71fe71783
2021-06-17 11:01:12 +00:00
Treehugger Robot
2d16ec5af7 Merge "Use IsEnvTrue for USE_BAZEL_ANALYSIS check." 2021-06-17 10:48:59 +00:00
Paul Duffin
c8ead41ba9 Move boot jars package check into platform_bootclasspath
Bug: 177892522
Bug: 189298093
Test: m check-boot-jars
      m SOONG_CONFIG_art_module_source_build=false check-boot-jars
      - Ran both commands with and without java.lang in the
        package_allowed_list.txt
Change-Id: Iba1a881c8f6b6919d5c0c0520eb3073658f3b8d2
2021-06-17 10:54:27 +01:00
Paul Duffin
58e7586b3d Cleanup bootclasspathFragmentInitContentsFromImage
Removes some unnecessary logic left over from previous changes.

Bug: 177892522
Test: m nothing
Change-Id: Id11e2ea8a647283af1b152b33757132e44dcd6c3
2021-06-17 10:54:27 +01:00
Paul Duffin
e521881bd4 Combine hidden API encoding with flag generation
Previously, the rules to perform hidden API encoding were generated
separately to the rules to perform hidden API flag generation. This
change combines them within the (renamed) produceHiddenAPIOutput()
method and makes the paths to the encoded dex files an output of the
generateHiddenAPIBuildActions method alongside the paths to the
generated flag files.

As encoded dex jars are now an output of the produceHiddenAPIOutput()
method which is implemented for both prebuilts and source
bootclasspath_fragment modules that necessitated the prebuilt also
providing paths to encoded dex files. That in turn required updates to
some of the tests to provide dex files from prebuilt_apex modules.

Similarly, as the produceHiddenAPIOutput() method may not be called
for some bootclasspath_fragment modules as they do not yet provide all
the information needed to perform hidden API encoding then it is
necessary to extract the encoded dex files produced by the modules
themselves. That also required a few changes to tests that did not
previously provide dex files.

Bug: 177892522
Test: m com.android.art
      - check that this change does not change the contents of the apex
        file, i.e. is byte-for-byte identical.
Change-Id: I60996a34d06ed1c87ed244ab3509621999ad86ec
2021-06-17 10:20:33 +01:00
Martin Stjernholm
1a3fdba364 Merge "Clean up statsd-module-sdk-for-art." am: 2ed110c092
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1737040

Change-Id: Id2c956621f3c9dd91bd3ba8a3b58874d0981aeb0
2021-06-17 08:15:33 +00:00
Martin Stjernholm
2ed110c092 Merge "Clean up statsd-module-sdk-for-art." 2021-06-17 08:04:23 +00:00
Lukacs T. Berki
2063a0d7b8 Make the IsSdkVariant field and method the same.
Before, the IsSdkVariant() method also checked AlwaysSdk(). Instead,
sdkMutator now sets the IsSdkVariant field to True even for the single
variation it creates when AlwaysSdk is true.

Test: Presubmits.
Change-Id: Ied8b42a3441a30484ef8c5dff5aade5fe92574bb
2021-06-17 09:32:36 +02:00
Jingwen Chen
442b1a4070 Use IsEnvTrue for USE_BAZEL_ANALYSIS check.
Make this consistent with the check in soong_ui: https://cs.android.com/android/platform/superproject/+/master:build/soong/ui/build/config.go;l=930;drc=0b55bdb7af7ab2a039fefc88086f0ee41c00ac69

Change-Id: I8d57fafa954ce3dd041cc38250819531125d81ac
Test: TH
2021-06-17 07:02:23 +00:00
Paul Duffin
ea621048f3 Merge "Make apex variants of prebuilt apex exported modules available in make" am: 2c891873d6
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1738035

Change-Id: If738b8f670d171bdf43844c967f745f20d2bda84
2021-06-17 06:48:41 +00:00
Paul Duffin
70fc36a6fc Merge "Create APEX variant for prebuilt_apex/apex_set" am: 2960e9bdf2
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1738034

Change-Id: I1003d7a860691c0d13a31f0b5ac0e6f384989fd5
2021-06-17 06:47:46 +00:00
Paul Duffin
2c891873d6 Merge "Make apex variants of prebuilt apex exported modules available in make" 2021-06-17 06:36:45 +00:00
Paul Duffin
2960e9bdf2 Merge "Create APEX variant for prebuilt_apex/apex_set" 2021-06-17 06:32:55 +00:00
Treehugger Robot
f5e6633028 Merge "Remove jungjw from OWNERS." am: e7cf91bea4
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1738713

Change-Id: Id39a3643de200df1324a5a87589eb069d7e5ce05
2021-06-17 03:59:06 +00:00
Treehugger Robot
e7cf91bea4 Merge "Remove jungjw from OWNERS." 2021-06-17 03:42:06 +00:00
Jaewoong Jung
dc7a51e600 Remove jungjw from OWNERS.
Test: None
Change-Id: I8dfc727db02d734f771c012945a694a0ebc72422
2021-06-16 18:47:09 -07:00
Colin Cross
fe6f1e6fd0 Merge changes from topic "ndk_libandroid_support_late_static_libs" am: 9fb2d1fb62
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1736360

Change-Id: I5d987d66b27b1d2c434c8e99d91b95e2e50a9c0c
2021-06-16 22:08:15 +00:00
Colin Cross
9fb2d1fb62 Merge changes from topic "ndk_libandroid_support_late_static_libs"
* changes:
  Use LateStaticLibs for ndk_libandroid_support
  Move LateStaticLibs after SharedLibs in the dependency include order
  Test include directory ordering
2021-06-16 21:54:37 +00:00
Paul Duffin
5d2be4d35f Merge "Dedup apex/Prebuilt and apex/ApexSet" am: 8b8c4f74f3
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1736208

Change-Id: I4424dbf52b561ad32d689f724f25b8f1f0b9c575
2021-06-16 20:42:57 +00:00
Paul Duffin
8b8c4f74f3 Merge "Dedup apex/Prebuilt and apex/ApexSet" 2021-06-16 20:30:31 +00:00
Pirama Arumuga Nainar
8f5a60cac9 Merge "Revert "Switch to clang-r416183d"" am: 8d24812be7
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1736920

Change-Id: I693cc0e6127bd96dfa703405c4f62ba51fe08cd5
2021-06-16 20:21:22 +00:00
Pirama Arumuga Nainar
8d24812be7 Merge "Revert "Switch to clang-r416183d"" 2021-06-16 20:00:18 +00:00
Pirama Arumuga Nainar
e6f19467c1 Revert "Switch to clang-r416183d"
Revert submission 1737013-switch-to-clang-r416183d

Bug: http://b/191276541
Bug: http://b/189328402

Reason for revert: Breaks renderscript_mac build
Reverted Changes:
I25142ddaa:[scripts/symbol] Switch to clang-r416183d
If11e59638:Switch to clang-r416183d

Change-Id: I9e95b4823f111d4482f9fbb5da48acc62f74cc8c
2021-06-16 18:26:49 +00:00