Commit graph

1485 commits

Author SHA1 Message Date
Manali Bhutiyani
3dc6dd2bd4 Update aidl documentation
Bug: 290685621
Test: N/A

Change-Id: I1d30c24e667ce02d7553462d663cf66a32aa4b4b
2024-01-09 20:14:14 +00:00
Leon Scroggins
50ede7f71a Merge "Avoid crashing when failing graphics VTS" into main 2024-01-09 19:00:47 +00:00
Leon Scroggins III
94f4b20dcf Avoid crashing when failing graphics VTS
When the tests fail, ensure we continue running so we can run the
remainder of the tests.

Bug: 304976052
Test: atest GraphicsComposerAidlCommandTest
Change-Id: Ia6ab2bbd284bb7eddeb49164dcbe7285829ad9c3
2024-01-09 12:39:11 -05:00
Wiwit Rifa'i
c67c887c5a composer: vts: update getClientTargetSupport tests
Ensure the primary display to set power on before running
getClientTargetSupport tests for VTS 2.1 - 2.3.

Bug: 308252481
Test: atest VtsHalGraphicsComposerV2_1TargetTest
Test: atest VtsHalGraphicsComposerV2_2TargetTest
Test: atest VtsHalGraphicsComposerV2_3TargetTest
Change-Id: I6b793537ee42c87f37c4c1d7141364541f448134
2024-01-05 16:29:12 +08:00
Ady Abraham
a00d246f27 composer: vts: add support for batched create/destroy layers
Bug: 315517904
Test: TBD
Change-Id: Ic3c0415612b1387671ab8efa0ec95ed727f6bf68
2023-12-27 22:32:45 +00:00
ramindani
52416e06ff [Composer3] Update notifyExpectedPresent parameter names
Update the timeoutNs description to specify what 0 and not absent value
expected behavior is
BUG: 294102485
Test: VTS

Change-Id: I3954c8f1efad8190ed6d608e2968fe1dc15c2f11
2023-12-21 08:58:00 -08:00
Peter Lin
f43004efcf [VTS] Update SetDisplayBrightness test item am: 70d2ef6b34
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2883951

Change-Id: Ia57991b0f949307764afeb9fe9fa58c67740900e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-21 02:13:22 +00:00
Peter Lin
70d2ef6b34 [VTS] Update SetDisplayBrightness test item
Ensure the primary display power on before run the
SetDisplayBrightness test item.

Bug: 313794734
Test: atest VtsHalGraphicsComposer3_TargetTest:PerInstance/
      GraphicsComposerAidlCommandTest#SetDisplayBrightness/
      0_android_hardware_graphics_composer3_IComposer_default
      -- --abi arm64-v8a
Change-Id: I94fb700704bcbd8543f2a608dd75b9e745e40e37
Merged-In: I94fb700704bcbd8543f2a608dd75b9e745e40e37
2023-12-20 06:49:27 +00:00
Treehugger Robot
59d64f830e Merge "[VTS] Update SetDisplayBrightness test item" into main 2023-12-19 11:27:19 +00:00
Peter Lin
b9fbd4e3c7 [VTS] Update SetDisplayBrightness test item
Ensure the primary display power on before run the
SetDisplayBrightness test item.

Bug: 313794734
Test: atest VtsHalGraphicsComposer3_TargetTest:PerInstance/
      GraphicsComposerAidlCommandTest#SetDisplayBrightness/
      0_android_hardware_graphics_composer3_IComposer_default
      -- --abi arm64-v8a
Change-Id: I94fb700704bcbd8543f2a608dd75b9e745e40e37
2023-12-14 06:03:58 +00:00
Ram Indani
730f86fe18 Merge changes from topic "RRN" into main
* changes:
  [Composer3-VTS] Test Composer3-V3 for refreshPeriodNanos and vsyncPeriodNanos
  [HWC3] AIDL change to add refreshPeriodNanos to RefreshRateChangedDebugData
2023-12-13 19:03:18 +00:00
ramindani
a2a6deaf50 [Composer3-VTS] Test Composer3-V3 for refreshPeriodNanos and
vsyncPeriodNanos

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 314527560
Change-Id: If45c0d8c4b61b8c46c1e4336fe261d11414535e5
2023-12-13 01:14:10 +00:00
ramindani
1eb2ecfe4a [HWC3] AIDL change to add refreshPeriodNanos to RefreshRateChangedDebugData
Test: atest VtsHalGraphicsComposer3_TargetTest and device boots
BUG: 314527560
Change-Id: Iaf961ae6ad118c5cd99b07ec133023297dac7040
2023-12-13 01:07:58 +00:00
Manali Bhutiyani
e11bda9789 [aidl] add hwc batching capability
This CL adds the new aidl/apis for HWC command batching feature.

Bug: 290685621
Test: atest VtsHalGraphicsComposer3_TargetTest
      atest PerInstance/GraphicsComposerAidlBatchedCommandTest

Change-Id: Ibccc2cb30954f5d054f8e45e59a0b831fd15a304
2023-12-13 00:27:53 +00:00
Manali Bhutiyani
38565ccd51 [hwc-batching] AIDL changes for HWC command batching support.
This CL adds the new aidl/apis for HWC command batching feature.

Bug: 290685621
Test: atest VtsHalGraphicsComposer3_TargetTest
      atest PerInstance/GraphicsComposerAidlBatchedCommandTest
Change-Id: I9e8a8afefb03e04a4cd4d8db36d72e29d30e975f
2023-12-09 00:25:42 +00:00
Alec Mouri
8695c7bbc4 Merge "Support extended range fp16 ClientTargets in HWC" into main 2023-12-06 01:59:49 +00:00
Jason Macnak
73e5844464 Remove oneway from onHotplugEvent callback
IIUC, oneway makes the callback a non-blocking call. Hwcomposer
implementations are expected to call onHotplug/onHotplugEvent during
the initial hwcomposer->registerCallback(). However, a oneway callback
would not block and cause the hwcomposer's implementation of
registerCallback() to return immediately. Example log:

11-30 23:32:32.962   508   508 E RanchuHwc: registerCallback
11-30 23:32:32.962   508   508 E RanchuHwc: registerCallback:
display:0
11-30 23:32:32.962   508   508 E RanchuHwc: setCallbacks for display:0
11-30 23:32:32.962   508   508 E RanchuHwc: registerCallback:
display:1
11-30 23:32:32.962   508   508 E RanchuHwc: setCallbacks for display:1
11-30 23:32:32.962   508   508 E RanchuHwc: registerCallback initial
registration, hotplug connecting display:0
11-30 23:32:32.962   508   508 E RanchuHwc: registerCallback initial
registration, hotplug connecting display:1
11-30 23:32:32.962   572   592 E SurfaceFlinger: jasonjason
SurfaceFlinger::onComposerHalHotplugEvent()
11-30 23:32:32.962   572   572 F SurfaceFlinger: Initial display
configuration failed: HWC did not hotplug
11-30 23:32:32.962   572   592 E SurfaceFlinger: jasonjason SurfaceFlinger::onComposerHalHotplugEvent()
<SurfaceFlinger aborts from the Fatal "HWC did not hotplug">

Bug: b/314208907
Test: Launch Cuttlefish with ag/25521493 then
      vts -m VtsHalGraphicsComposer3_TargetTest
Change-Id: Ibfea0b21e1d4c8b0de17bbe25dc55483050700b7
2023-12-01 14:29:50 -08:00
Alec Mouri
8062f1feda Support extended range fp16 ClientTargets in HWC
Introduce the concept of hdrSdrRatio for ClientTargets, so that:

* 1.0 is treated as SDR luminance
* hdrSdrRatio is provided to scale the content into display luminance
  range during composition. That is, 1.0 maps to SDR max, and
  hdrSdrRatio maps to display max luminance

Bug: 236745178
Test: builds
Change-Id: Id82a102eaca82f85bf3982538786dd2ae6cb8e61
2023-11-29 17:32:58 +00:00
Huihong Luo
5569efbc00 Add a new API to report display hotplug events
When a display is connected, error may occur, this new api introduces
an event variable to specify the hotplug event, including errors.

This new api should be used, and the old onHotplug method is deprecated.

Bug: 241286153
Test: manual
Change-Id: I20ea685c5012015836024e7cab4dc0e68ebb835f
2023-11-28 11:46:53 -08:00
ramindani
cdcfcafc63 [VTS] Update validateDisplay with frameIntervalNs
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 284845445
Change-Id: I4821a535518b113923fac02adadb3f4867ce922e
2023-11-09 10:01:28 -08:00
ramindani
ac6e50ab4c Update ComposerClientWriter::validateDisplay with frameInterval
BUG: 284845445
Test: Manual test
Change-Id: I2f856ae4acd45cb2a9827c367d2d3185da859b8a
2023-11-07 16:54:04 -08:00
ramindani
72edecff8e Update ComposerClientWriter::presentOrValidate with frameInterval
BUG: 284845445
Test: Manual test
Change-Id: I096ef0d0523cf33a3867030339a18f9421b9ad2b
2023-11-07 16:53:45 -08:00
Treehugger Robot
6cd27b6f2a Merge "Reland "Add a DisplayCapability for multi-threaded present"" into main 2023-10-18 02:21:51 +00:00
Joen Chen
e0a962c8e3 Reland "Add a DisplayCapability for multi-threaded present"
Originally landed as I5dbb01fc23abd5e0108c565f96d25e62c77fc16d and
previously reverted in I6265f8de3db31f07506906cee82a91fe3baac0bc due to
timeline constraints.

Add a test presenting from multiple threads. Split up execute() so that
it can be called for a single display. Update MultiThreadedPresent
(test) to offload presentDisplay to a separate thread, similar to how
Ib9d074671e32c95875ef7e0791dd95d6e595e47a does it, as described in
go/multi-threaded-present.

Bug: 259132483
Bug: 284156408
Fixes: 251842321
Fixes: 295841597
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: If975ee9bb0b9c6f64ef50401e2aee32f934e3f08
2023-10-16 15:23:59 -04:00
Leon Scroggins III
79d7ae8207 Remove deprecated warnings for SKIP_VALIDATE
We deliberately use a deprecated API to test that it is not used. Ignore
warnings from using it in this test.

In PresentDisplayNoLayerStateChanges, remove the check for
SKIP_VALIDATE, removing the other warning. As written, the test would be
skipped without SKIP_VALIDATE support. But devices should *not* claim
Capability::SKIP_VALIDATE, meaning the test would always be skipped. The
docs state that the behavior previously indicated by SKIP_VALIDATE is
now the default, so we should always be running the test.

Bug: NA
Test: atest VtsHalGraphicsComposer3_TargetTest (no warnings)
Change-Id: Icc89a82b4850428c2f0940be0f78f5ebff1881b3
2023-10-12 08:38:12 -04:00
Jason Macnak
cde05dd247 Merge "Ensure AIMapper and underlying IMPL outlive IMapperProvider" into main am: b8c23a8a7d am: 4c11b51986 am: 8dcf909435 am: f5dbe8113a am: ba4b850b8a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2781709

Change-Id: Ie4edc900be0e48bb00e3913ec75456347a58f81a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-11 02:14:30 +00:00
Jason Macnak
8dcf909435 Merge "Ensure AIMapper and underlying IMPL outlive IMapperProvider" into main am: b8c23a8a7d am: 4c11b51986
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2781709

Change-Id: Ie96a5db1377ca841d493b168ffa4c6b2a5c90d8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:31:55 +00:00
Xin Li
11ee4fea87 Merge android14-tests-dev
Bug: 263910020
Merged-In: I770dc5620648df2eab608e030c5e76cf190f315d
Change-Id: If4fe726d538386d70061e8051299d8fb393ef5df
2023-10-10 16:17:14 -07:00
Alec Mouri
b9556b3aba Merge "Start VTS for color management." into main 2023-10-10 20:40:46 +00:00
Jason Macnak
7d201b58fa Ensure AIMapper and underlying IMPL outlive IMapperProvider
... as a

  static vendor::mapper::IMapperProvider<IMPL> provider;

may be destructed during a clean process exit (during __cxa_finalize())
but the underlying IMPL may still be in use on other threads.

Bug: b/304343434
Test: boot Cuttlefish
Change-Id: I80687494c61210d527908b5a67375950ca45c8ea
2023-10-10 11:54:00 -07:00
Sergiu Ferentz
31b637fd90 Merge "Bump android.hardware.graphics.common V4->V5" into main 2023-10-09 08:27:26 +00:00
Sergiu Ferentz
d2075f0d14 Merge "Modifying Dataspace.aidl to add additional HAL_ Datapoints present in graphics/**/swapchain.cpp" into main 2023-10-09 08:27:26 +00:00
Alec Mouri
f6c039a49e Start VTS for color management.
Right now this only makes sure that extended sRGB buffers aren't
corrupted by the time it hits the display. This is especially important
for Ultra HDR, because display compensation is defined by the spec.

Bug: 276331687
Bug: 259144781
Test: VtsHalGraphicsComposer3_ReadbackTest
Change-Id: Ib6c39858289d5559ae76280ca1a0ef756f2daef0
2023-10-06 23:04:15 +00:00
Alec Mouri
3e82b63ae8 Merge "Setting layer brightness doesn't need nit info for readback tests" into stage-aosp-udc-ts-dev am: be23bf4f23 am: 2d96a0a082
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24944166

Change-Id: If96b68cdef28070dba0a446b57bea4581e1b3b40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 20:41:40 +00:00
Alec Mouri
a47d46affb Setting layer brightness doesn't need nit info for readback tests
The nit information was used when we set exact nit values rather than a
relative brightness per layer. But we only need nit values for the
renderengine interface, which isn't tied to any hwc or panel
capabilities.

Bug: 301261125
Test: VtsHalGraphicsComposer3_TargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:712b3d9880b6aff51ab17d539bfcbdf3785cc6ca)
Merged-In: I770dc5620648df2eab608e030c5e76cf190f315d
Change-Id: I770dc5620648df2eab608e030c5e76cf190f315d
2023-10-04 21:14:06 +00:00
sergiuferentz
14960cae33 Modifying Dataspace.aidl to add additional HAL_ Datapoints present in graphics/**/swapchain.cpp
Bug: 291142745
Change-Id: I54a41f3170b6c21f1c1b12aec40a8ce928f9163f
2023-10-03 16:14:06 +00:00
sergiuferentz
7d7a24d5f6 Bump android.hardware.graphics.common V4->V5
Test: Build
Bug: 291142745
Change-Id: Ib0002feb982ffcc37fa7b69493c644b7a835cf4f
2023-10-03 16:14:03 +00:00
Alec Mouri
712b3d9880 Setting layer brightness doesn't need nit info for readback tests
The nit information was used when we set exact nit values rather than a
relative brightness per layer. But we only need nit values for the
renderengine interface, which isn't tied to any hwc or panel
capabilities.

Bug: 301261125
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: I770dc5620648df2eab608e030c5e76cf190f315d
2023-09-29 00:21:37 +00:00
Treehugger Robot
83dd5881a0 Merge "Add deprecation note" into main 2023-09-07 20:15:54 +00:00
Treehugger Robot
cb0d2eb323 Merge "Revert "[Composer AIDL] Rename notifyExpectedPresentTimeoutNs and"" into main 2023-09-01 23:58:48 +00:00
John Reck
89b26e7623 Add deprecation note
Flag: DOCS_ONLY
Test: doc-only && make
Change-Id: I16638c3772269e4946a002a7e821735423df5084
2023-09-01 16:32:53 -04:00
Ram Indani
82426a4a40 Revert "[Composer AIDL] Rename notifyExpectedPresentTimeoutNs and"
This reverts commit f850701be0.

Reason for revert: Delaying rename to avoid churn for external partner work.

Change-Id: If96786d074a61ac0f781540e98d020a6f7fd673b
2023-09-01 20:02:50 +00:00
Treehugger Robot
7445bd7b80 Merge "Clarify GPU API requirements for BufferUsage" into main 2023-09-01 16:13:38 +00:00
John Reck
9db00ec784 Clarify GPU API requirements for BufferUsage
Bug: 283989374
Test: n/a doc only change
Change-Id: I4caec722420d4fa2089d1f297f377408a1e674ae
2023-08-31 17:42:05 -04:00
ramindani
f850701be0 [Composer AIDL] Rename notifyExpectedPresentTimeoutNs and
notifyExpectedPresentHeadsUpNs
Renamed to timeoutNs and headsUpNs respectively

BUG: 294102485
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: Id890d9634d80700ad2515c9b4fe2a423b6b75d96
2023-08-30 18:51:19 -07:00
ramindani
2b2ec50b56 [Composer VTS] Check Vrr mode is the only mode in the Config Group
BUG: 296636107
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I4bdf7b0988673a13297d648dcf3360a6821aaecb
2023-08-25 18:48:47 -07:00
Xin Li
879960bdce Merge Android U (ab/10368041)
Bug: 291102124
Merged-In: I7b6fffac2ada0e039f79bad8cc9b4d954e9c3460
Change-Id: I9466127d8d0fa38df36ca99f704853b2db871e67
2023-08-25 13:29:30 -07:00
Alec Mouri
19698cdd0e Merge "Adjust documentation for UNKNOWN dataspaces." into main 2023-08-24 17:44:49 +00:00
Alec Mouri
75a546270a Remove useFramebufferCache parameter in drawLayers()
GLESRenderEngine used it, but GLESRenderEngine is no more.

Bug: 199918329
Test: builds
Change-Id: I9c735e5820bd187f910905e7e77f9445f0ff30db
2023-08-18 15:01:52 +00:00
Alec Mouri
6dd267ee95 Merge "Remove color management configuration in VTS" into main 2023-08-15 15:52:36 +00:00
Alec Mouri
32a41abac3 Remove color management configuration in VTS
Color management is now turned on by default, so there's no reason to
explicitly enable it in renderengine.

Bug: 295966830
Test: builds
Change-Id: I42c8afb30950081cd57072680da06895dcc02f2c
2023-08-15 02:11:49 +00:00
Alec Mouri
d5df919eb7 Merge "Add API level for IMapper 4's bad metadata test" into main 2023-08-08 00:14:55 +00:00
Alec Mouri
2ee3317613 Add API level for IMapper 4's bad metadata test
Some devices shipped with broken validation for HDR metadata. Relax the
test for vendor freeze purposes.

Bug: 276843519
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: I564f4bd12145f7831faa1e5a0f2d2abe074e4769
2023-08-04 21:59:23 +00:00
Treehugger Robot
6d9576d649 Merge "composer3: minor fix to dpi documentation " into main 2023-08-01 21:13:01 +00:00
Ady Abraham
07a826c28c composer3: minor fix to dpi documentation
Change-Id: Ie31cb78f682761d1022592a22867307ab78b5a75
Test: prebuild
2023-08-01 20:00:07 +00:00
Ram Indani
789cd64b73 Merge "[Composer-HAL-AIDL] Deprecates getDisplayAttribute" into main 2023-07-31 19:46:10 +00:00
ramindani
d411bd3bda [Composer-HAL-AIDL] Deprecates getDisplayAttribute
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 284866749
BUG: 287518295
Change-Id: Ib4f32d9b60cbbbf127963e0fa4b273951e9d46e6
2023-07-31 10:16:05 -07:00
Treehugger Robot
f2d57b1e40 Merge "composer3: add rust backend " into main 2023-07-28 19:44:38 +00:00
John Reck
631dc15b2e Remove allocator from composer2.1-4 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest VtsHalGraphicsComposerV2_4TargetTest VtsHalGraphicsComposerV2_2TargetTest VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I6c5e8c8b96450f800bb60b6ed0ce3b3c10ce1565
2023-07-26 16:06:34 -04:00
John Reck
6d0abbb439 Remove mapper from composer2.1 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest VtsHalGraphicsComposerV2_4TargetTest VtsHalGraphicsComposerV2_2TargetTest VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I3642995e7236a3b9b08ad5419c9d02b67243b24a
2023-07-26 15:54:47 -04:00
Ady Abraham
9118110a15 composer3: add rust backend
Change-Id: I2d3d91fd714130252d63b697958f128c9bd06dc5
Test: presubmit
Bug: 293256928
2023-07-26 19:42:10 +00:00
John Reck
82c666bd8c Remove mapper from composer2.2 VTS
Test: make VtsHalGraphicsComposerV2_2TargetTest
Bug: 292584923
Change-Id: Id281c732535ace4a36750d759b59db7aa6e5cb3a
2023-07-26 10:17:17 -04:00
John Reck
650fe3ed52 Remove mapper from composer2.3 VTS
It was unused anyway

Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest
Change-Id: I81fb1be275ef54062a8ae5bddec17a137dda7946
2023-07-25 21:08:42 -04:00
John Reck
7f996c3f1c Remove direct mapper from composer2.4 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_4TargetTest
Change-Id: I4379df1d673fc709b9a496b5c44cb9420798a05d
2023-07-25 17:35:08 -04:00
John Reck
e849ecd055 Remove unused dependencies from composer3 VTS
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I1eeb3ad326d91ec317e91bc3c515a8f28baae074
2023-07-25 16:32:49 -04:00
Ram Indani
15e0bb9f83 Merge changes from topic "HWC3-V3-VRR" into main
* changes:
  [Composer VTS] Adds VTS for the vrr configuration
  [Composer-HAL-AIDL] Adds vrr interface configuration
2023-07-22 04:14:52 +00:00
ramindani
2704c5fe12 [Composer VTS] Adds VTS for the vrr configuration
Test getDisplayConfigurations with vrr parameters
Test notifyExpectedPresent does not return error

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 287517352
BUG: 284881912
Change-Id: I49d6876922e9fde47e531200a29413495458b8a5
2023-07-21 21:13:37 -07:00
ramindani
bc41c5fb19 [Composer-HAL-AIDL] Adds vrr interface configuration
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 287517352
BUG: 284881912
Change-Id: I71ed35acb18a00009cd23afe47f5c48494d08c0c
2023-07-21 21:13:37 -07:00
Alec Mouri
3d978df32d Support per-port display configs in VTS am: 821d5c05c2 am: 29d915f375
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24169145

Change-Id: I1b799ba8830247d57b37c0df1ab86c68f9bf8ec6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-22 03:52:49 +00:00
Alec Mouri
821d5c05c2 Support per-port display configs in VTS
Bug: 277855934
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:be1b4d6ccec45f47bbb9459bf9aa31b4c6875c7b)
Merged-In: I92e1615d8eb9466b40e02f8e2df8b3432e927af6
Change-Id: I92e1615d8eb9466b40e02f8e2df8b3432e927af6
2023-07-22 00:58:03 +00:00
Treehugger Robot
d683f7da0b Merge "Support per-port display configs in VTS" into main 2023-07-21 21:13:11 +00:00
Alec Mouri
be1b4d6cce Support per-port display configs in VTS
Bug: 277855934
Change-Id: I92e1615d8eb9466b40e02f8e2df8b3432e927af6
2023-07-21 21:12:16 +00:00
Treehugger Robot
595664a377 Merge "Fix a DimmingStage documentation typo by rewording the doc." into main am: 299db35551 am: 518f74b2f9 am: 7cafdb3073 am: f0c1565ef0 am: d0c6ea82e6
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2669815

Change-Id: Ic26033b197832c2ba22c5ce704edc4c1f3a65424
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-21 07:30:31 +00:00
Treehugger Robot
7cafdb3073 Merge "Fix a DimmingStage documentation typo by rewording the doc." into main am: 299db35551 am: 518f74b2f9
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2669815

Change-Id: Ibf33531aa91335f1a34d1d8db17dfa8ffbe84a54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-21 05:13:07 +00:00
Alec Mouri
cdcfd05736 Fix a DimmingStage documentation typo by rewording the doc.
Change-Id: I5a1b3a99630cfded4b34c74b020bb4df2ce12084
2023-07-20 23:07:17 +00:00
Kriti Dang
13ffa1d123 Merge "composer: vts: changing config groups should not check newVsyncAppliedTimeNanos" into main 2023-07-18 10:27:27 +00:00
Ady Abraham
b241927097 composer: vts: changing config groups should not check newVsyncAppliedTimeNanos
Bug: 240542961
Test: by partner
Change-Id: Id39d6c4a2a238b43dcf7b24249cab84a27eaf9dd
2023-07-17 12:23:38 +02:00
ramindani
02fe477218 [Composer VTS] Adds VTS for getDisplayConfigurations
Test getDisplayConfigurations on the version 3 of the composer.

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 287518719
BUG: 284866749
Change-Id: Ibb654dbeb4b164d86f92f51f8083ed1ab06fcfa4
2023-07-14 14:53:11 -07:00
ramindani
d40b5667d7 [Composer-HAL-AIDL] Interface changes with getDisplayConfigurations
Updates to the AIDL interfaces with getDisplayConfigurations
This will be replacing the getDisplayConfig api that will be deprecated in the upcoming CL's.
implementations will follow in the upcoming CL's

Test: device boots, atest libsurfacerflinger_unittest, atest VtsHalGraphicsComposer3_TargetTest
BUG: 284866749
BUG: 287517352
Change-Id: I2b64dcaace26a297f308e8f5c2568c35c9cd38cb
2023-07-13 10:55:20 -07:00
ramindani
e50ed5d4e6 Upgrade Composer interface version
Test: device boots, atest libsurfacerflinger_unittest, atest VtsHalGraphicsComposer3_TargetTest
BUG: 284866749
BUG: 287517352
Change-Id: I803a4291c0839857f7e23696da7dac4c15a21e09
2023-07-13 10:55:20 -07:00
Alec Mouri
e5c4f5546a Adjust documentation for UNKNOWN dataspaces.
Summarize the recommendations in {STANDARD, TRANSFER, RANGE}_UNSPECIFIED, but also indicate the UNKNOWN isn't really appropriate to signal.

Bug: 288461753
Change-Id: I237e45b7d83ed620ee79b9e39aed73fe71a047b0
Test: docs
2023-07-13 01:23:07 +00:00
Treehugger Robot
a68be420fd Merge "Clarify null-termination of name field" into main am: 8328cbb343 am: b47a11c1d5 am: 3f76bf5b23 am: 84816ec99d am: f5af8ff475 am: 2705f61931
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2651037

Change-Id: I89154927eaf442ca05a3fcdf92fc1a1cc0e17139
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 22:47:09 +00:00
Treehugger Robot
84816ec99d Merge "Clarify null-termination of name field" into main am: 8328cbb343 am: b47a11c1d5 am: 3f76bf5b23
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2651037

Change-Id: I8840b5f4925bd801ddf4b39940b6b6246631176b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 20:43:39 +00:00
John Reck
735206b1a5 Clarify null-termination of name field
Test: make
Change-Id: I22e7c20074fe49bd533fc16c88a979447362d3f2
2023-07-07 12:11:00 -04:00
John Reck
54996257f1 Merge "Add ChromaSiting VERTICAL & BOTH" 2023-06-22 15:31:15 +00:00
ramindani
12423f5ff6 [Composer VTS] Subclass the test cases by the interface version
This helps us write tests by version number, and avoids checking version
interface in every test that we add in newer versions, avoids common mistakes of
missing a version check. And makes it clear what features were added in new versions

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 274999658
Change-Id: I2a8d5aa6c9d426de02ab0abf2ca662e330b6a5ea
2023-06-15 22:52:32 +00:00
John Reck
fc489cac9e Add ChromaSiting VERTICAL & BOTH
Bug: 221248303
Test: make
Change-Id: Ib5a3db2b580c1a063ae176ba3718cdd3ed7e1e9c
2023-06-09 16:46:49 -04:00
Edward Liaw
dbacb2173e Merge "TEST_MAPPING: enable vts hal tests in kernel-presubmit" am: 24a8a39219 am: 69771123ba am: ac75f2d41c am: c01432b259 am: abed2fcab0 am: d4ac480aa1
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2610093

Change-Id: Ia634246c8f465af29a8092c4ef7691b46480891a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 00:13:30 +00:00
Edward Liaw
c01432b259 Merge "TEST_MAPPING: enable vts hal tests in kernel-presubmit" am: 24a8a39219 am: 69771123ba am: ac75f2d41c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2610093

Change-Id: Id502dbe01f18f68a140290f5f0bf8b709d35bf0e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 22:00:27 +00:00
Edward Liaw
69771123ba Merge "TEST_MAPPING: enable vts hal tests in kernel-presubmit" am: 24a8a39219
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2610093

Change-Id: Ifb1fe3792f481cfe57d3b4e9e0f7995ced887a7c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 21:11:34 +00:00
Edward Liaw
24a8a39219 Merge "TEST_MAPPING: enable vts hal tests in kernel-presubmit" 2023-06-01 20:34:33 +00:00
Edward Liaw
24696b3e32 TEST_MAPPING: enable vts hal tests in kernel-presubmit
Enable the following tests:
VtsHalBluetoothAudioTargetTest
VtsHalGraphicsComposerV2_4TargetTest

Bug: 284307085
Bug: 258819618
Test: atest :kernel-presubmit
Change-Id: I8667eaee120777a776339481f72558566e6c94b3
Signed-off-by: Edward Liaw <edliaw@google.com>
2023-06-01 16:08:42 +00:00
Ram Indani
361a1fd8ed Merge "[HIDL composer] Verify key & value sizes are within the data size range" 2023-05-31 23:48:49 +00:00
ramindani
c7a880719e [HIDL composer] Verify key & value sizes are within the data size range
Sizes when invalid can cause OOB reads and causes the crash

Test: atest VtsHalGraphicsComposerV2_1TargetTest && atest VtsHalGraphicsComposerV2_2TargetTest && atest VtsHalGraphicsComposerV2_3TargetTest && atest VtsHalGraphicsComposerV2_4TargetTest
go/wm-smoke test
BUG: 252995613

Change-Id: I77e472851236eba2b8418034144c9cc8237c7143
2023-05-31 23:00:53 +00:00
John Reck
0cf823b31d Merge "Add test for USAGE query for >32-bit" am: 4ef9f5dd2b am: a1171f30d8 am: 0284fd727c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2607685

Change-Id: I81d2669f98a9716acb638d632cfb28442b122add
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 22:31:34 +00:00
John Reck
a1171f30d8 Merge "Add test for USAGE query for >32-bit" am: 4ef9f5dd2b
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2607685

Change-Id: I2000c140565d02a503a2b394a63d5342c4cd1830
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 21:03:51 +00:00
John Reck
4ef9f5dd2b Merge "Add test for USAGE query for >32-bit" 2023-05-30 20:11:24 +00:00
Ram Indani
b6ffd5c35d Merge "[VTS 2.3] Add length check before reading blob" into udc-dev am: a9d135cd14
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23438943

Change-Id: I492cd7aa3aec59dc6af2385de5d3af6b9b1a887b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 17:09:05 +00:00
John Reck
b9cd45c741 Add test for USAGE query for >32-bit
Bug: 284333373
Test: this
Change-Id: Ie9683e5cccb85db1280b85b0b32d7cec042d79a3
2023-05-26 16:55:09 -04:00
ramindani
caee7cd3f6 [VTS 2.3] Add length check before reading blob
Adding a length check prevents the read() from
reading outside the bounds and prevents OOB crash.

Test: atest VtsHalGraphicsComposerV2_3TargetTest && atest VtsHalGraphicsComposerV2_4TargetTest
BUG: 252764300
Change-Id: I6231e340a925127f9c32ccb76768286f7292df58
Merged-In: I6231e340a925127f9c32ccb76768286f7292df58
2023-05-25 22:12:24 +00:00