Commit graph

2250 commits

Author SHA1 Message Date
Aaqib Ismail
5a8f91761b Merge changes I36d1e494,I65a74ac6 into main
* changes:
  Add missing supportedEnumValues
  Add missing status codes
2023-09-07 03:21:12 +00:00
Changyeon Jo
88ef0d64bc Merge "Update the default EVS HAL implementation" into main 2023-09-06 17:13:30 +00:00
Changyeon Jo
ada95035ec Update OWNERS file am: bacdd1ec09 am: d095b7aafa am: e927deb8f8 am: 8de98a639b am: 3507d52f9e
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2740885

Change-Id: I16e0cd29d4d27327e0e1f7e861ef8a81dd9d0cdf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-06 07:20:45 +00:00
Changyeon Jo
3507d52f9e Update OWNERS file am: bacdd1ec09 am: d095b7aafa am: e927deb8f8 am: 8de98a639b
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2740885

Change-Id: Iaf2e2243f18d66b8f1e004602acba168a67f528e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-06 07:12:08 +00:00
Changyeon Jo
d095b7aafa Update OWNERS file am: bacdd1ec09
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2740885

Change-Id: Ie6784053acee05538e6d328d98c7cea1730291a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-06 04:55:17 +00:00
Changyeon Jo
bacdd1ec09 Update OWNERS file
This change updates OWNERS file for EVS interface.

Bug: 299195329
Test: Manual
Change-Id: Ife421b8aa4a380d8585e6d8476f0a24f31bc2633
2023-09-06 00:57:59 +00:00
Aaqib Ismail
810144a168 Add missing supportedEnumValues
Bug: 299192013
Test: m
Change-Id: I36d1e4942cb44604539e384bde9300ac8ca8eba2
2023-09-05 17:52:12 -07:00
Aaqib Ismail
e279306e57 Add missing status codes
Bug: 299191602
Test: m
Change-Id: I65a74ac6e93ec5ffcf32b54b6a11c983b1c32262
2023-09-05 17:20:49 -07:00
Changyeon Jo
130d5a3aa0 Update the default EVS HAL implementation
Remove H2BGraphicBufferProducer usages from the default EVS HAL
implementation.

Bug: 297601247
Bug: 298091684
Test: Run evs_app on the cuttlefish emulator.
Change-Id: Ibca21d8e9cf87deb79c0050f9adcf02b5f16d34b
2023-08-31 13:12:39 -07:00
Treehugger Robot
3c8c62f7ee Merge "Allow empty preuload_files." into main 2023-08-30 20:41:27 +00:00
Yu Shan
b1fc8c914f Allow empty preuload_files.
When a CL only removes file, the PREUPLOAD_FILES in repohook might
be empty.

Test: None
Bug: 298222655
Change-Id: I70bb347c02c5d09a0525313087acb9c38b9a2ff2
2023-08-30 11:51:04 -07:00
Yu Shan
2fd9496ecd Use AIDL for test vendor properties.
Use AIDL enum instead of hard coding the test vendor property
definitions so that we don't have to duplicate the value among VHAL
and the clients. This also shows how vendor can uses a custom AIDL
enum to define vendor properties.

Test: atest FakeVehicleHardwareTest
Bug: 296913406
Change-Id: Ief889b86bfbef136f8afd4a4f49405f2213b441c
2023-08-28 17:48:30 -07:00
Yu Shan
3a129d7a3b Implement a host side TestWakeupClientService.
Implement a host program that could be used to test the remote
access feature. The program will provides grpc service that the
remote access HAL running on device can talk to to get tasks. The
program will also use adb/aemu command to control the power of the
Android instance.

This CL also changes the GRPC service address for the default
remoteaccess HAL to 10.0.2.2 which points to the host's 127.0.0.1
from the emulator.

Test: m -j TestWakeupClientServerHost, run manually.
TestWakeupClientServerHost
>>> inject task [clientID] taskdata
verify emualtor boot up
verify emulator shutdown after task finish
>>> power on
verify emualtor boot up
>>> inject task [clientID] taskdata
verify emulator does not shutdown after task finish
>>> power off
>>> inject task [clientID] taskdata
verify emulator boot up
>>> set vehicleInUse
verify emulator does not shutdown after task finish
>>> power off
>>> genFakeTask start [clientID]
verify emulator starts up to execute remote tasks.
verify emulator shuts down after 300s.
verify emulator restarts after shutdown.
>>> genFakeTask stop
verify emulator shuts down after finishing last task.
Bug: 285205122

Change-Id: I22b660448d8b495cf3ced3378c1c1dc10051d87a
2023-08-28 17:45:08 -07:00
Shrikar Amirisetty
892e1feaa0 Merge "Added logic for ACC properties to return NOT_AVAILABLE in standard CC." into main 2023-08-28 19:40:17 +00:00
Xin Li
879960bdce Merge Android U (ab/10368041)
Bug: 291102124
Merged-In: I7b6fffac2ada0e039f79bad8cc9b4d954e9c3460
Change-Id: I9466127d8d0fa38df36ca99f704853b2db871e67
2023-08-25 13:29:30 -07:00
Eva Chen
af66916e2c Merge changes from topic "vhal_v3" into main
* changes:
  Add UNKNOWN to VehicleAreaSeat aidl.
  Update VHAL property version to v3.
2023-08-24 19:51:21 +00:00
shrikar
cc3f5884cd Added logic for ACC properties to return NOT_AVAILABLE in standard CC.
ACC properties and certain CRUISE_CONTROL_COMMAND enums will return
StatusCode NOT_AVAILABLE_DISABLED when CRUISE_CONTROL_TYPE is STANDARD.

Bug: 268680457
Test: atest FakeVehicleHardwareTest
Change-Id: Id79c93a0dab6224dd3e6fae3aa747781a848aa94
2023-08-24 12:50:38 +00:00
Krzysztof Kosiński
9d92d55a55 Add missing gRPC include. am: c608187f21 am: e1ea603e02
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24501312

Change-Id: I5730c9a2586715d4bcf36e7cbcbc55ebb89513fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:43:16 +00:00
Krzysztof Kosiński
c608187f21 Add missing gRPC include.
Othewise the header is not self contained and breaks when
upgrading gRPC.

Bug: 279548314
Test: presubmit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3d3baed1bc85f8ddddb2764a5a09cd4d578419f0)
Merged-In: Ife50863bd16eda6bc639261b1f91fdfcf48f6294
Change-Id: Ife50863bd16eda6bc639261b1f91fdfcf48f6294
2023-08-21 20:12:27 +00:00
Krzysztof Kosiński
3d3baed1bc Add missing gRPC include.
Othewise the header is not self contained and breaks when
upgrading gRPC.

Bug: 279548314
Test: presubmit
Change-Id: Ife50863bd16eda6bc639261b1f91fdfcf48f6294
2023-08-19 02:07:47 +00:00
Eva Chen
46d65626e2 Add UNKNOWN to VehicleAreaSeat aidl.
Bug: 293521207
Test: atest VtsHalAutomotiveVehicle_TargetTest
Test: atest CtsCarTestCases:CarPropertyManagerTest
Test: atest CtsCarTestCases:VehiclePropertyIdsTest
Change-Id: Idf42a5735eb8e187759c3d84cc4891a473d97d35
2023-08-11 13:24:29 -07:00
Eva Chen
b36d24d12a Update VHAL property version to v3.
Bug: 295405997
Test: Manual Build
Change-Id: I2faf065006e6889309caf69a9b277f42fdc00702
2023-08-11 13:24:21 -07:00
Terry Guan
b324444c8a Update version for audiocontrol
Bug: 255369346
Bug: 255383566
Test: atest vts_treble_vintf_vendor_test
Change-Id: I17000be75963e511d2a56583be0f619a3dee66f1
Merged-In: I17000be75963e511d2a56583be0f619a3dee66f1
Merged-In: Ic42e51b616782a2763eb80e1cad5ca776cc079d4
2023-08-04 16:50:58 -07:00
Yu Shan
21d7b02a9a [RESTRICT AUTOMERGE] Pass property set error to subscribed clients.
Pass the async property set error generated by VehicleHardware layer
to subscribed clients.

Test: atest DefaultVehicleHalTest
Bug: 286384730
Bug: 292001021
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6fe26625db72da7760014d0c71019fb3e847e2d3)
Merged-In: Iadd92e1c0c741ad6450a0508fe9e6301bdfe66c5
Change-Id: Iadd92e1c0c741ad6450a0508fe9e6301bdfe66c5
2023-08-02 22:03:41 +00:00
Treehugger Robot
ab51d34ef7 Merge "Changed radius to diameter in INFO_EXTERIOR_DIMENSIONS docs in HAL layer" into main 2023-07-25 19:31:19 +00:00
shrikar
c665f4e34f Changed radius to diameter in INFO_EXTERIOR_DIMENSIONS docs in HAL layer
Bug: 284972202
Test: manual build
Change-Id: Ib72aa4d93d2fcf8c9961fd143842018efe27c18c
2023-07-24 18:30:28 +00:00
Yu Shan
8ddd65dbc0 Add script to parse VehicleProperty.aidl to CSV.
Allow parsing the VHAL property definitions/annotations in
VehicleProperty.aidl into a CSV file so that we can generate
documentation.

Test: python generate_annotation_enums.py --output_csv /tmp/prop.csv
Bug: 288331747
Change-Id: Icc5d023c8efdc01ead220313d6a7c66d22c63a0a
2023-07-11 14:33:36 -07:00
Yu Shan
bc614aeae0 Minor update on access annotation.
Test: None
Bug: 288331747
Change-Id: I3a2246c1c5fd02d06fa2c8f08dc69ac0506bfbcb
2023-07-11 14:33:36 -07:00
Yu Shan
595c1da89f Add more access annotations.
For some READ_WRITE property, READ is also allowed. Add the annotations
to reflect that.

Test: None
Bug: 288331747
Change-Id: I46d86606087e747e217269db028ddf03c9bdc0b6
2023-07-10 16:57:45 -07:00
Treehugger Robot
795e58a333 Merge "Pass property set error to subscribed clients." into udc-qpr-dev am: 94a43b30ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23880264

Change-Id: If342d76ba837924f37f051253326b7a0ecaf91c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 21:46:10 +00:00
Treehugger Robot
94a43b30ef Merge "Pass property set error to subscribed clients." into udc-qpr-dev 2023-07-10 21:07:10 +00:00
Yu Shan
733c744072 Merge "Minor fix to comment style." into main 2023-07-10 18:35:34 +00:00
Treehugger Robot
fb867bc8a6 Merge "Cleanup dead code." into main 2023-07-08 03:45:03 +00:00
Treehugger Robot
9eb7b82d9a Merge "Fix flaky recurrent timer test." into main am: d0cb2e73b2 am: 83e99ff3b1 am: b3f840a6ff am: d8ab63802a am: e993d4b849
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2651319

Change-Id: If412439e197b7d2cfbf5570314f2e9c81e287ec2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 23:53:36 +00:00
Treehugger Robot
d8ab63802a Merge "Fix flaky recurrent timer test." into main am: d0cb2e73b2 am: 83e99ff3b1 am: b3f840a6ff
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2651319

Change-Id: Ia670893b8cebee92cb8d6f2248123009c434382c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 22:28:53 +00:00
Yu Shan
fda1197d79 Pass property set error to subscribed clients.
Pass the async property set error generated by VehicleHardware layer
to subscribed clients

Test: atest DefaultVehicleHalTest
Bug: 286384730
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7b1448edcfd3f88365932e2d94659952444aae2b)
Merged-In: Iadd92e1c0c741ad6450a0508fe9e6301bdfe66c5
Change-Id: Iadd92e1c0c741ad6450a0508fe9e6301bdfe66c5
2023-07-07 21:26:02 +00:00
Yu Shan
bdba2b578d Fix flaky recurrent timer test.
Do not rely on sleep in tests, but wait for the events to happen
before timeout. Set the timeout to be large enough (5s) so that the
tests are more stable.

Test: atest RecurrentTimerTest
Bug: 289759453
Change-Id: Iff271ca440426871ed3a798bab50b9532f9256f0
Merged-In: Iff271ca440426871ed3a798bab50b9532f9256f0
(cherry picked from commit 76d7fbf6a1)
2023-07-07 20:30:43 +00:00
Treehugger Robot
9c5889cecb Merge "Pass property set error to subscribed clients." into main 2023-07-07 01:41:20 +00:00
Yu Shan
52c0a3dd9d Minor fix to comment style.
Use a separate block for HVAC properties comments since we will use
the first line as description for the property and hvac fan speed
description will not be correct.

Test: None
Bug: 288331747
Change-Id: Ie6518dec394a3d9c90bd2cb5b38939a2cdd7cccf
2023-07-06 17:41:01 -07:00
Yu Shan
4ea2dbc27b Cleanup dead code.
We no longer implement subscription by periodically requesting
get from VHAL layer, so most of the logic in subscriptionClient
is no longer useful.

Test: atest DefaultVehicleHalTest, manually run on emulator verify
subscription works.
Bug: 288627179

Change-Id: Ice3824514b3205ca3446baf0086be81eda0c47d6
2023-07-06 17:41:01 -07:00
Yu Shan
7b1448edcf Pass property set error to subscribed clients.
Pass the async property set error generated by VehicleHardware layer
to subscribed clients

Test: atest DefaultVehicleHalTest
Bug: 286384730
Change-Id: Iadd92e1c0c741ad6450a0508fe9e6301bdfe66c5
2023-07-06 17:18:18 -07:00
Yu Shan
76d7fbf6a1 Fix flaky recurrent timer test.
Do not rely on sleep in tests, but wait for the events to happen
before timeout. Set the timeout to be large enough (5s) so that the
tests are more stable.

Test: atest RecurrentTimerTest
Bug: 289759453
Change-Id: Iff271ca440426871ed3a798bab50b9532f9256f0
2023-07-05 17:16:59 -07:00
Yu Shan
ddd7b58149 Fix a type conversion bug.
Convert int64_t to long on x86 platform loses info.

Test: atest FakeVehicleHardwareTest on cf_gwear_x86.
Bug: 288376096
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:76aaef448fcd9458b07b1d78ea4b79165af0cde0)
Merged-In: I8826e2c0ba6c3e26af858a1d8f1388b75d537082
Change-Id: I8826e2c0ba6c3e26af858a1d8f1388b75d537082
2023-06-30 20:55:19 +00:00
Yu Shan
76aaef448f Fix a type conversion bug.
Convert int64_t to long on x86 platform loses info.

Test: atest FakeVehicleHardwareTest on cf_gwear_x86.
Bug: 288376096
Change-Id: I8826e2c0ba6c3e26af858a1d8f1388b75d537082
2023-06-30 19:07:17 +00:00
Yu Shan
51b5c77534 Move flaky HIDL VHAL impl test to post submit.
The tests is flaky by nature because it depends on timer. Although
the flakiness is low, it is too flaky to run as presubmit.

Test: atest -s emulator-5554 DefaultVhalImplTest
Bug: 288197123
Change-Id: I735e3e6197769e47372f025d7eb82d54159a8ff8
2023-06-29 17:52:20 -07:00
Yu Shan
d68149e363 Support VEHICLE_IN_USE and SHUTDOWN_REQUEST.
Support VEHICLE_IN_USE and SHUTDOWN_REQUEST properties in reference
VHAL. They are used for remote access feature.

Test: atest FakeVehicleHardwareTest
Bug: 285205122
Change-Id: Ideb964d1ee625b127bc8e708b46f9639dd59c011
2023-06-22 20:48:23 -07:00
Changyeon Jo
a842eea300 Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b am: 55baee93d6 am: e0868c4484 am: ca64f5b140 am: 9e8d44aba4 am: 0a4815e73a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: I9382ebec2b2960627f03e99ac243cfd11e99599e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 03:52:37 +00:00
Changyeon Jo
f018e5213d Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b am: 55baee93d6 am: 4bf0cb2c5f am: b484054880 am: f1c67f57e9
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: Ibc853cb9ad6ab961b3140c69efeb1c024f91006a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 02:46:28 +00:00
Changyeon Jo
9e8d44aba4 Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b am: 55baee93d6 am: e0868c4484 am: ca64f5b140
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: If414ff886a8c2e6c336289e89f73719d740ac73c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 02:24:19 +00:00
Changyeon Jo
b484054880 Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b am: 55baee93d6 am: 4bf0cb2c5f
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: I74e22a7195fb761c3920b7fd865b000d0a4d3ee7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 01:16:37 +00:00