Commit graph

15080 commits

Author SHA1 Message Date
Xusong Wang
5d8fec169e Merge "Add quant8 variant of VTS CompilationCachingTest." into qt-dev
am: c9d90efcc7

Change-Id: Iccc7cbb84462e07d8f3462d3ef4eb4f3edf59459
2019-05-09 17:42:51 -07:00
Janis Danisevskis
e08ba7a9fd Verify mac change on time stamp change am: 33d75d090b
am: 3b8bae3554

Change-Id: I26af43007c28b1b251ce5e2d22dc0975711ad8a3
2019-05-09 15:50:26 -07:00
Xusong Wang
c9d90efcc7 Merge "Add quant8 variant of VTS CompilationCachingTest." into qt-dev 2019-05-09 22:38:54 +00:00
Janis Danisevskis
3b8bae3554 Verify mac change on time stamp change
am: 33d75d090b

Change-Id: I00092609f97d985d203ca5df6987a05fa9b0ae6c
2019-05-09 14:32:42 -07:00
Janis Danisevskis
33d75d090b Verify mac change on time stamp change
This test verifies that verification tokens with different time stamps do
not have the same MAC. This may not guarantee that the MAC is computed
correctly but it catches implementation that do not include the time
stamp in the mac.

It also checks that the MAC changes when both time stamp and challenge
changes.

Test: yes it is
Bug: 131859731
Bug: 132288466
Bug: 132287277
Change-Id: I85aa1d873eff46df7a66fc69bd61a031e6e6fbe0
2019-05-09 12:50:11 -07:00
Michael Butler
de8c30edb6 [automerger skipped] Follow up CL to "Add validation tests for NNAPI Burst serialized format" am: 353a624bd4
am: d128dc15c1 -s ours
am skip reason: change_id I6bd088f01c051a76561c0ecf9bbf878bb21c5754 with SHA1 0a1ad962bb is in history

Change-Id: Ice070c7d3805acd9db89604cf322f7da0a963e7b
2019-05-08 19:43:54 -07:00
Michael Butler
3f7553b99d [automerger skipped] Add validation tests for NNAPI Burst serialized format am: d6e38fd71b
am: d496c3481e -s ours
am skip reason: change_id Ib90fe7f662824de17db5a254a8c501855e45f6bd with SHA1 20f28a24e9 is in history

Change-Id: I3c949009a9297dcc0008db05895746ffbe520313
2019-05-08 19:43:00 -07:00
Michael Butler
d128dc15c1 Follow up CL to "Add validation tests for NNAPI Burst serialized format"
am: 353a624bd4

Change-Id: Ia73cd893c5b76957fcf74343649704fc2f8f2c1c
2019-05-08 18:53:11 -07:00
Michael Butler
d496c3481e Add validation tests for NNAPI Burst serialized format
am: d6e38fd71b

Change-Id: If0b61fbc9c6501f0df14bc549a51ec97aeb0ee08
2019-05-08 18:51:33 -07:00
Michael Butler
353a624bd4 Follow up CL to "Add validation tests for NNAPI Burst serialized format"
Bug: 129779280
Bug: 129157135
Test: mma
Test: atest NeuralNetworksTest_static
Test: atest VtsHalNeuralnetworksV1_0TargetTest (with sample-all)
Test: atest VtsHalNeuralnetworksV1_1TargetTest (with sample-all)
Test: atest VtsHalNeuralnetworksV1_2TargetTest (with sample-all)
Change-Id: I6bd088f01c051a76561c0ecf9bbf878bb21c5754
Merged-In: I6bd088f01c051a76561c0ecf9bbf878bb21c5754
(cherry picked from commit 0a1ad962bb)
2019-05-08 22:46:10 +00:00
Michael Butler
d6e38fd71b Add validation tests for NNAPI Burst serialized format
This CL adds the following two types of validation tests on the NNAPI
Burst serialized format:
(1) it directly modifies the serialized data (invalidating it) to ensure
    that vendor  driver services properly validates the serialized
    request
(2) it ensures that vendor driver services properly fail when the result
    channel is not large enough to return the data

This CL additionally includes miscellaneous cleanups:
(1) having a generic "validateEverything" function
(2) moving the "prepareModel" function that's common across
    validateRequest and validateBurst to a common area

Fixes: 129779280
Bug: 129157135
Test: mma
Test: VtsHalNeuralnetworksV1_2TargetTest (with sample-all)
Change-Id: Ib90fe7f662824de17db5a254a8c501855e45f6bd
Merged-In: Ib90fe7f662824de17db5a254a8c501855e45f6bd
(cherry picked from commit 20f28a24e9)
2019-05-08 22:40:22 +00:00
Xusong Wang
35e7599eb2 Add quant8 variant of VTS CompilationCachingTest.
Prior to this CL, the VTS compilation caching tests are using float32
models. However, there exists several drivers that only support QUANT8
operations, and most of the tests are simply skipped.

This CL makes the CompilationCachingTest fixture parameterized that
every test will run twice, with the first pass running with float32
models and the second pass running with quant8 models.

Bug: 132112463
Test: 1.2 VTS with sample drivers
Test: 1.2 VTS with test drivers that can read and write cache entries
Change-Id: Iaf28065e46c2d90ab8b347b9848be1e6546cce86
2019-05-08 15:22:34 -07:00
Michael Butler
720f869dd9 Merge "Follow up CL to "Add validation tests for NNAPI Burst serialized format"" into qt-dev
am: e84f442c4c

Change-Id: I4f40772d30e3b0fa5aeb41edbf9a7d8a26d2ef51
2019-05-08 14:35:43 -07:00
Michael Butler
e84f442c4c Merge "Follow up CL to "Add validation tests for NNAPI Burst serialized format"" into qt-dev 2019-05-08 21:04:12 +00:00
Lev Proleev
9201bd34ca Merge "Fix LSTM documentation" into qt-dev
am: 881e261f0e

Change-Id: Iaae38e885aa2f60d9d39030b2db06e7039cc0872
2019-05-08 13:49:14 -07:00
TreeHugger Robot
881e261f0e Merge "Fix LSTM documentation" into qt-dev 2019-05-08 20:17:28 +00:00
Peiyong Lin
2007f2d931 Merge "Return display capability if getDisplayBrightnessSupport is not registered." into qt-dev
am: 248f72a9a0

Change-Id: I105e29926e146e4d7e9c6924fcb4588e57e1400b
2019-05-08 11:28:09 -07:00
Peiyong Lin
248f72a9a0 Merge "Return display capability if getDisplayBrightnessSupport is not registered." into qt-dev 2019-05-08 17:59:55 +00:00
Slava Shklyaev
0052d3085b [automerger skipped] Document that quantized PAD behavior is undefined before NNAPI 1.2 am: cc0b0d4509
am: 6bde1ee91f -s ours
am skip reason: change_id Ibfc0801ab746fc271dc5f8efc764b818c6d49df4 with SHA1 b01ce9644e is in history

Change-Id: I18fa384cdec22153d103a22b150fc34317007110
2019-05-08 10:58:15 -07:00
Miao Wang
7a135cc861 [automerger skipped] Fix the order of width and height for NNAPI RESIZE_BILINEAR and RESIZE_NEAREST_NEIGHBOR am: 9bfecb5591
am: 012e69378b -s ours
am skip reason: change_id I6c79459fa73347fb51fc34a76ad78d5ac207f210 with SHA1 286339b4c8 is in history

Change-Id: Ia35bcc53b38ecbf4838ea5e273af8316c2010f51
2019-05-08 10:57:57 -07:00
Jeff Tinker
97bf88fea2 Merge "Add status for license starting in the future" into qt-dev
am: a51399ef5f

Change-Id: I2178215a3cbb44a830690081f008c3053282fe65
2019-05-08 10:49:33 -07:00
Slava Shklyaev
6bde1ee91f Document that quantized PAD behavior is undefined before NNAPI 1.2
am: cc0b0d4509

Change-Id: Icc2649dc9e36844ee43bccb1936c6cc1d3af3666
2019-05-08 10:49:05 -07:00
Miao Wang
012e69378b Fix the order of width and height for NNAPI RESIZE_BILINEAR and RESIZE_NEAREST_NEIGHBOR
am: 9bfecb5591

Change-Id: If60c67b876772db13653af655e87a026306f0fb1
2019-05-08 10:48:40 -07:00
Jeff Tinker
a51399ef5f Merge "Add status for license starting in the future" into qt-dev 2019-05-08 17:17:43 +00:00
Lev Proleev
e0537f09fb Fix LSTM documentation
The documentation said that cell-to-input weights are required to be
present when input-to-input weights, recurrent-to-input weights and
input gate bias are present. This was incorrect since this weights can
be omitted if peephole connections are not used even if all the other
tensors are present.

Another bug that is fixed in this change is that for output #0 the docs
said "of shape [batch_size, num_units * 4] with CIFG, or [batch_size,
num_units * 3] without CIFG" when in fact it is the opposite, i.e.  "of
shape [batch_size, num_units * 3] with CIFG, or [batch_size, num_units *
4] without CIFG."

Existing CTS/VTS tests expect behaviour described in the fixed documentation.
Existing CPU implementation is also compliant with the fixed documentation.

Fix: 111842951
Test: mma
Change-Id: Id011783e33672ae65dc6fe3784cb26feb832acf9
2019-05-08 17:28:53 +01:00
Slava Shklyaev
cc0b0d4509 Document that quantized PAD behavior is undefined before NNAPI 1.2
We had no tests for quantized PAD in NNAPI 1.1 and think that vendors might have implemented different behaviors.

Bug: 122243484
Test: N/A
Change-Id: Ibfc0801ab746fc271dc5f8efc764b818c6d49df4
Merged-In: Ibfc0801ab746fc271dc5f8efc764b818c6d49df4
(cherry picked from commit b01ce9644e)
2019-05-08 15:34:41 +01:00
Miao Wang
9bfecb5591 Fix the order of width and height for NNAPI RESIZE_BILINEAR and
RESIZE_NEAREST_NEIGHBOR

  - The CPU implementation always had the order of {width, height}.
  - In P, the documentation was incorrectly changed to {height, width}.

Bug: 131623949
Bug: 130035110
Test: mm
Change-Id: I6c79459fa73347fb51fc34a76ad78d5ac207f210
Merged-In: I6c79459fa73347fb51fc34a76ad78d5ac207f210
(cherry picked from commit 286339b4c8)
2019-05-08 15:33:55 +01:00
Valerie Hau
18af76ef9f Merge "Fix getDisplayCapabilitiesBasic VTS test" into qt-dev
am: 767a57fb19

Change-Id: I9477c6015409156e1d184ae70c15630e77f44025
2019-05-07 21:27:41 -07:00
TreeHugger Robot
767a57fb19 Merge "Fix getDisplayCapabilitiesBasic VTS test" into qt-dev 2019-05-08 03:17:43 +00:00
Robert Shih
31703179a5 Add status for license starting in the future
Bug:116738851
Test: vts-tradefed run commandAndExit -m VtsHalDrmV1_2Target
Change-Id: Id5017e3ffa1fcf5aaad1815b59a425ac63f2e53e
2019-05-08 00:52:01 +00:00
Valerie Hau
0db2322402 Merge "Fix setLayerCursorPosition test" into qt-dev
am: 34f36713bf

Change-Id: Ic4ebed51afcd11f766f82fa51658c0f871bca65a
2019-05-07 16:27:50 -07:00
TreeHugger Robot
34f36713bf Merge "Fix setLayerCursorPosition test" into qt-dev 2019-05-07 23:07:29 +00:00
Michael Butler
0a1ad962bb Follow up CL to "Add validation tests for NNAPI Burst serialized format"
Bug: 129779280
Bug: 129157135
Test: mma
Test: atest NeuralNetworksTest_static
Test: atest VtsHalNeuralnetworksV1_0TargetTest (with sample-all)
Test: atest VtsHalNeuralnetworksV1_1TargetTest (with sample-all)
Test: atest VtsHalNeuralnetworksV1_2TargetTest (with sample-all)
Change-Id: I6bd088f01c051a76561c0ecf9bbf878bb21c5754
2019-05-07 15:45:48 -07:00
Valerie Hau
66ea37f739 Merge "Fix setLayerCursorPosition Test" into qt-dev
am: 3da7baee06

Change-Id: I3a42c2d84d1cb76252ea808b6341b457d2f693c2
2019-05-07 13:11:46 -07:00
Michael Butler
557b9a9581 Merge "NNAPI: validate that FmqResultDatum padding is 0 -- VTS" into qt-dev
am: 2cd02a4121

Change-Id: I6bbb1c4247ca7279edb35db1565afdb56b75f114
2019-05-07 12:54:12 -07:00
Valerie Hau
185d7a4b1f Fix setLayerCursorPosition test
Set composition type to Cursor

Bug: 132057336, 131181758
Test: VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I03ae799358abcdbd0a1c39a13d30d76aa7712004
2019-05-07 12:35:49 -07:00
Valerie Hau
3da7baee06 Merge "Fix setLayerCursorPosition Test" into qt-dev 2019-05-07 19:10:24 +00:00
Valerie Hau
804857176a Fix getDisplayCapabilitiesBasic VTS test
Old test checked error code when calling getBrightnessSupport in the
getDisplayCapabilitiesBasic test.  However, it is possible that the
function is not implemented (UNSUPPORTED).  We want to return normally
and use the returned supported boolean to check this instead.

Bug: 132043561, 132056857
Test: VtsHalGraphicsComposerV2_3TargetTest
Change-Id: I94f8f39ba9129c4a8d939a5385538db3489c46b9
2019-05-07 11:52:27 -07:00
Michael Butler
2cd02a4121 Merge "NNAPI: validate that FmqResultDatum padding is 0 -- VTS" into qt-dev 2019-05-07 18:52:13 +00:00
Michael Butler
ddb770f0e4 NNAPI: validate that FmqResultDatum padding is 0 -- VTS
FmqResultDatum::OperandInformation has padding that may not be
initialized by an NN HAL service instance. This CL adds a validation
check to ensure that services are not leaking uninitialized data through
this padding region.

Bug: 131356202
Test: mma
Test: atest VtsHalNeuralnetworksV1_2TargetTest
      (for ValidationTest with sample-all)
Test: altered sample-driver to randomly set a padding byte to 1;
      the new validation test successfully failed the test

Change-Id: I6661945392b3fc773493d8f2f306f29b39e09bab
2019-05-07 18:42:47 +00:00
Valerie Hau
efe7621dac Fix setLayerCursorPosition Test
Bug: 131181758
Test: build, boot, VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I70f4f8f64c16ce45eba70c2e47d3fa2913034eba
2019-05-07 08:06:05 -07:00
Anil Admal
3e346ff672 Merge "Fix wait/notify logic in GNSS VTS 2.0 test cases (part 2)" into qt-dev
am: e5289f618c

Change-Id: Idb35e4ccf2c5a7825aa88c15e7e815b5206d4448
2019-05-06 18:38:30 -07:00
Anil Admal
e5289f618c Merge "Fix wait/notify logic in GNSS VTS 2.0 test cases (part 2)" into qt-dev 2019-05-07 01:06:57 +00:00
Janis Danisevskis
90d9d5a1fa [automerger skipped] Keymaster support: Verbose vendor errors am: 3414222e3a
am: 7daf7da188 -s ours
am skip reason: change_id Ida093941d3b76b3d2e953439229081345909c16b with SHA1 c7a8b863cd is in history

Change-Id: I6b03ce7ad41028a677cd88903be7104a81c01a88
2019-05-06 17:18:29 -07:00
Janis Danisevskis
7daf7da188 Keymaster support: Verbose vendor errors
am: 3414222e3a

Change-Id: I86f5a241d7e9fdbd6f306f3c711004c8b6aa8a56
2019-05-06 16:46:44 -07:00
Anil Admal
2690a27d8d Fix wait/notify logic in GNSS VTS 2.0 test cases (part 2)
Addresses follow up code review comments after merge of ag/7324643.

Fixes: 131869042
Test: atest VtsHalGnssV2_0TargetTest
Change-Id: I0177ee60c5edfb6855ce6a1d45b8805166a33cf2
2019-05-06 12:09:57 -07:00
Valerie Hau
86a6f6e805 Merge "Call into validateBufferSize and getTransportSize" into qt-dev
am: 85b557fd1a

Change-Id: I367da83cd2e912d623698e28a6bda09a931aa33a
2019-05-06 09:29:05 -07:00
Valerie Hau
85b557fd1a Merge "Call into validateBufferSize and getTransportSize" into qt-dev 2019-05-06 16:11:34 +00:00
Anil Admal
bf6201d843 Merge "Fix wait/notify logic in GNSS VTS 2.0 test cases" into qt-dev
am: 5f6334036f

Change-Id: I2888a2b267490b1ceccb3fb6494dd0c357003fcf
2019-05-04 19:51:06 -07:00
Anil Admal
5f6334036f Merge "Fix wait/notify logic in GNSS VTS 2.0 test cases" into qt-dev 2019-05-05 02:41:13 +00:00