Commit graph

10333 commits

Author SHA1 Message Date
nagendra modadugu
8414fb8556 keymaster: spec does not require that update produce output
Remove out of spec enforcement on the amount of data returned
by update, as this is not specified in the HAL.

Bug: 109771020
Test: yes it is
Merged-In: Ic41afbd01d51faf48d3c0fe090409ebcd257cc1e
Change-Id: Ic41afbd01d51faf48d3c0fe090409ebcd257cc1e
(cherry picked from commit 7b75f015a7)
2018-08-28 15:17:31 -07:00
Shawn Willden
e1e08f8dde Fix attestation test.
Bug: 77588764
Test: VtsHalKeymasterV4_0TargetTest
Merged-In: Ibe264d08ae7b3333a6949761a92759f5305b3fcb
Change-Id: Ibe264d08ae7b3333a6949761a92759f5305b3fcb
(cherry picked from commit d898d0a422)
2018-08-28 15:16:58 -07:00
Eran Messeri
ff29edcc71 Fixing Keymaster documentation.
Keymaster HAL documentation documents the bootPatchLevel as having
tag 718, while types.hal indicates the tag value for it is actually
719.

Test: N/A
Bug: 78104779
Merged-In: I0dde0b3c863081f2594e20466d8e82866a5f2d2e
Change-Id: I0dde0b3c863081f2594e20466d8e82866a5f2d2e
(cherry picked from commit ae8da1b70a)
2018-08-28 15:08:39 -07:00
Treehugger Robot
0b1461687f Merge changes Ia3b96e83,I80d924cc into pie-vts-dev
* changes:
  Add REQUEST_NOT_SUPPORTED for pin and pin2 Icc VTS
  Add SIM_PUK2 for Icc VTS tests
2018-08-28 22:06:22 +00:00
WyattRiley
2d86da7b28 Improve VTS GNSS 1.1 reliability.
Allow VTS test for low power mode to handle
certain vendor issues that supply one extra location
at the start of low power mode.

Allow more time for GNSS first fix, and warmup as
needed given limited VTS access to AGPS.

Bug: 110626730
Bug: 110987651
Test: (TODO) Passes on device.
Merged-In: Ieeefd7fcd45890b03dffbbee965e1d9b17805c4c
Change-Id: Ieeefd7fcd45890b03dffbbee965e1d9b17805c4c
(cherry picked from commit 5ea5dda2c3)
2018-08-28 21:17:02 +00:00
Yu-Han Yang
66fb7a1b88 Delete time/position in InjectDelete instead of Delete_all
- DELETE_ALL will delete XTRA.

Bug: 110626730
Test: run VTS test on device.
Merged-In: I4f01430f24f92238193d3de6b6fbb31e81e9f006
Change-Id: I4f01430f24f92238193d3de6b6fbb31e81e9f006
(cherry picked from commit 84cff99b2f)
2018-08-28 21:14:53 +00:00
Yu-Han Yang
75b0c4bba2 Inject last location in InjectBestLocation VTS test
Bug: 110626730
Test: run VTS on device.
Merged-In: I6f57dd7f9164dacf011f25412e55fcd22821aca0
Change-Id: I6f57dd7f9164dacf011f25412e55fcd22821aca0
(cherry picked from commit bb372e5984)
2018-08-28 21:13:38 +00:00
Treehugger Robot
a9ad41d1ad Merge "Tolerate 1 sv status in GNSS blacklist VTS test" into pie-vts-dev 2018-08-28 19:14:59 +00:00
Treehugger Robot
5e6dd1288e Merge "VTS: Do not require XML for Audio effect V2" into pie-vts-dev 2018-08-28 19:13:44 +00:00
Treehugger Robot
75ceb36b27 Merge "Camera: Don't hold 'mLock' when closing the camera session" into pie-vts-dev 2018-08-28 19:11:28 +00:00
Treehugger Robot
b3e86d489a Merge "Audio VTS was testing wrong uninitialized variable due to typo" into pie-vts-dev 2018-08-28 18:48:10 +00:00
Yu-Han Yang
398b272b30 Tolerate 1 sv status in GNSS blacklist VTS test
Bug: 110969497
Test: run VTS test on device.
Merged-In: I26345bb62513da8530cb48672e5f59a915817cb4
Change-Id: I26345bb62513da8530cb48672e5f59a915817cb4
(cherry picked from commit 91cc8f4832)
2018-08-28 18:18:47 +00:00
Kevin Rocard
8ca56c3dee VTS: Do not require XML for Audio effect V2
In O, the Audio effect V2 HAL allows not to have an audio effect XML
configuration but to use a .conf format.

In P, before this patch, the Audio effect V2 HAL _requires_ to have an
audio effect XML configuration and forbids the use of a .conf format.

This is discouraged by Treble as it means that an unchanged HAL V2
implementation that was compatible with O VTS will not be with P VTS.

As a result, revert to the Oreo behavior for Audio Effect V2 VTS.

Note that the audio effect V4 VTS is not changed by this patch and
still requires an audio effect XML configuration.
Aka device _updating_ to P will not have to upgrade to XML but new
devices lunching on P are still required to have an audio effect
XML configuration.

This commit only changes VTS code.

Test: cd hardware/interfaces/audio/effect/
      mmm 2.0/vts/functional 4.0/vts/functional && adb sync data
      adb push *.0/xml/audio_effects_conf_V*.xsd /data/local/tmp/
      adb shell
      cd /data/nativetest64
      OPS=--gtest_filter=CheckConfig.audioEffectsConfigurationValidation
      VtsHalAudioEffectV2_0TargetTest/VtsHalAudioEffectV2_0TargetTest $OPS
      VtsHalAudioEffectV4_0TargetTest/VtsHalAudioEffectV4_0TargetTest $OPS
      rm /{odm,vendor,system}/etc/audio_effects.xml || true
      VtsHalAudioEffectV2_0TargetTest/VtsHalAudioEffectV2_0TargetTest $OPS
      ! VtsHalAudioEffectV4_0TargetTest/VtsHalAudioEffectV4_0TargetTest $OPS
Bug: 111421676
Change-Id: Ifb15d65ae4aa65759c8ebaa91cbc8c02234030dc
Merged-In: Ifb15d65ae4aa65759c8ebaa91cbc8c02234030dc
Signed-off-by: Kevin Rocard <krocard@google.com>
(cherry picked from commit b41b575475)
2018-08-28 18:18:21 +00:00
Emilian Peev
6fa94395fd Camera: Don't hold 'mLock' when closing the camera session
After flushing the camera requests don't try to close the
camera session while still holding 'mLock'. Different Hals
could still try and return additional results which then will
get blocked on 'mLock'. Closing the session could potentially
introduce a deadlock if the Hal implementation waits for any
of the result calls to return.

Bug: 111836165
Test: vts-tradefed run commandAndExit vts --skip-all-system-status-check
--skip-preconditions --module VtsHalCameraProviderV2_4Target -l INFO

Change-Id: I0f309f435cc76db3f9b6ba500da65a232b014717
Merged-In: I0f309f435cc76db3f9b6ba500da65a232b014717
(cherry picked from commit 8e92056837)
2018-08-28 18:17:55 +00:00
Kevin Rocard
8073d8e41c Audio VTS was testing wrong uninitialized variable due to typo
The test was testing a uninitialized variable instead of testing
the result of the tested method.

Bug: 110963314
Test: vts-tradefed run commandAndExit vts --module VtsHalAudioV2_0Target
Merged-In: I9a212eef690ae627fd7f7dbfaf4a0b4047c491b3
Change-Id: I9a212eef690ae627fd7f7dbfaf4a0b4047c491b3
Signed-off-by: Kevin Rocard <krocard@google.com>
(cherry picked from commit 72641e7ad0)
2018-08-28 17:46:41 +00:00
Vishal Agarwal
2910e64d24 Add VTS test to verify scheduling capability
2018+ devices must support GNSS capability scheduling
Test results: go/vts-review-bucket/pi-dev/4267645

Bug: 109642198
Test: atest VtsHalGnssV1_0TargetTest
Merged-In: I7394674abca8f8c40ab30403be6b41bbbb279956
Change-Id: I7394674abca8f8c40ab30403be6b41bbbb279956
(cherry picked from commit e3ff41fc12)
2018-08-28 17:37:48 +00:00
sqian
388883a3ec Add setIndicationFilter response notification in 1.2 VTS
Test: compile
Bug: 109822806
Merged-In: I95102a148a26cab80235cc68ad83143a9bb6eb39
Change-Id: I95102a148a26cab80235cc68ad83143a9bb6eb39
(cherry picked from commit 0ff41b94b3)
2018-08-28 10:25:14 -07:00
sqian
5fd0ccf7a8 Add REQUEST_NOT_SUPPORTED for pin and pin2 Icc VTS
Bug: 111222834
Test: sanity
Change-Id: Ia3b96e83d6173c2c80bdbf7763a876883b167af9
Merged-In: Ia3b96e83d6173c2c80bdbf7763a876883b167af9
(cherry picked from commit c0a06f34c8)
2018-08-22 19:04:18 +08:00
sqian
ad34a11fba Add SIM_PUK2 for Icc VTS tests
Add SIM_PUK2 for supplyIccPin2ForApp and changeIccPin2ForApp if sim
card is in the puk2 state.

Bug: 111211929
Test: sanity
Change-Id: I80d924cc4a61565887cbd2a65ee5927a42ad656e
Merged-In: I80d924cc4a61565887cbd2a65ee5927a42ad656e
(cherry picked from commit 4ed0a216ad)
2018-08-22 19:04:18 +08:00
Nathan Harold
dd06d73cab Add docs for setSignalStrengthReportingCriteria
Because setSignalStrengthReportingCriteria only
supports a single measurement quantity, provide
further clarification on the applicability of the
API and how it may be used in various situations.

Bug: 110121199
Test: compilation - docstring-only change
Merged-In: If4236070fbc03368e5a78b0cf502cdc4a529a6ed
Change-Id: If4236070fbc03368e5a78b0cf502cdc4a529a6ed
(cherry picked from commit 529d2fffa0)
2018-08-21 02:12:38 +00:00
Treehugger Robot
6a20e646e4 Merge "Add back keymaster@4.0 hash." into pie-vts-dev 2018-08-20 23:44:03 +00:00
Yin-Chia Yeh
46a5d4f73b [automerger skipped] resolve merge conflicts of cd02298b46 to oreo-mr1-vts-dev
am: 79cea44239  -s ours

Change-Id: I17d4a58573074b7746a9d35be04414f9227ec47e
2018-08-20 11:29:40 -07:00
Kevin Rocard
a3268e954d Effect VTS: Allow an effect proxy as pre/post processing
am: 0f0328fc4e

Change-Id: I570e2a73de01900cf39b5d08cfed370ee17a0e38
2018-08-20 11:13:35 -07:00
Steven Moreland
a00fa0d372 Add back keymaster@4.0 hash.
This was changed after this branch was released. The originally
released hash needs to be restored since that is what partners
are building with.

Bug: 112688384
Bug: 78104779
Test: m android.hardware.keymaster@4.0 (tests hashes)
Change-Id: I0f59a493d7f17a13402d992495d1a259f6257077
(cherry picked from commit ec720564db)
2018-08-20 10:53:10 -07:00
Treehugger Robot
a73a8c9b2b Merge "Fix base class of WifiHidlEnvironment_1_2" into pie-vts-dev 2018-08-16 15:43:19 +00:00
Treehugger Robot
0a55878d1e Merge "Fix IUsb version number in vts test" into pie-vts-dev 2018-08-16 15:42:37 +00:00
sqian
a8b8b6b1b3 Patch for setSimCardPower_1_1
Do not expect its affect on cardStatus if it is not successfully returned.
Check the response error before updating sim card status.

Test: sanity
Bug: 111661946
Change-Id: I48551f5469289b9fcfc47dd9fd2e455779640329
Merged-In: I48551f5469289b9fcfc47dd9fd2e455779640329
(cherry picked from commit 7e787e192cd4700d8f4e7cc5f55501bc37590245)
2018-08-15 05:49:52 +00:00
Treehugger Robot
c1db422723 Merge "Fix setSimCardPower_1_1" into pie-vts-dev 2018-08-14 20:13:47 +00:00
sqian
f25e996302 Fix setSimCardPower_1_1
If the function isn't executed successfully, do not expect its effect
of cardStatus.

Bug: 111661946
Test: run vts
Change-Id: I952728311b595149b449280e73142f2f82af544d
Merged-In: I952728311b595149b449280e73142f2f82af544d
(cherry picked from commit 934243085a)
(cherry picked from commit c02dd2562f)
2018-08-14 12:15:35 -07:00
Treehugger Robot
a935e652af Merge "Fix ICameraDeviceCallback version in VTS test" into pie-vts-dev 2018-08-14 16:35:34 +00:00
sqian
2d0ba0f61b Check INVALID_SIM_STATE for sim permanent lock status
PUK1 and PUK2 can get permanent blocked when it inputs wrong
passwords more than 10 times.

Bug: 111211929
Test: sanity
Change-Id: I736873b1b181b88f279df7dc1c09e18e0fc76af3
2018-08-13 17:36:54 -07:00
sqian
9da8a72744 resolve merge conflicts of 898d05a713 to pie-vts-dev
Test: I solemnly swear I tested this conflict resolution.
Bug: 72075328
Change-Id: I5d7c124bc3905f899e63f080ac94def4e06fe9c2
Merged-In: I8c993cd2fa95c961dc7f976b5bd85a2826b42889
2018-08-13 16:32:59 -07:00
Hsin-Yi Chen
82179cf468 Fix base class of WifiHidlEnvironment_1_2
WifiHidlEnvironment_1_2 inherits WifiHidlEnvironment so that it stops
Wifi before every test.

Test: run vts -m VtsHalWifiV1_2Target
Bug: 112058501
Change-Id: I73c50351fa486f2ae7749e43a060ff05672c0f65
Merged-In: I73c50351fa486f2ae7749e43a060ff05672c0f65
(cherry picked from commit 4721523a96)
2018-08-13 15:18:50 +08:00
Hsin-Yi Chen
68c347fa62 Fix ICameraDeviceCallback version in VTS test
Test: ./VtsHalCameraProviderV2_4TargetTest --gtest_filter=CameraHidlTest.constructDefaultRequestSettings
Bug: 111625570
Change-Id: I8ad02afb0e9c2131c240999c4a8c78a1f770e847
Merged-In: I8ad02afb0e9c2131c240999c4a8c78a1f770e847
(cherry picked from commit cccd5bf1dd)
2018-08-13 15:16:28 +08:00
Hsin-Yi Chen
b782cb8565 Fix IUsb version number in vts test
Bug: 110913709
Test: vts-tradefed run vts -m VtsHalUsbV1_1Target
Change-Id: I9ae6add2fe8ff7138e07797c3a191b6dfe611948
Merged-In: I9ae6add2fe8ff7138e07797c3a191b6dfe611948
(cherry picked from commit b4193b855c)
2018-08-13 15:13:28 +08:00
Michael Wright
795990cca6 Update power HAL to version 1.3.
Adds new EXPENSIVE_RENDERING power hint.

This adds a new library which does not affect any pre-existing
targets unless they create and add a new binary which uses this.

BUG: 110112323
Test: adb shell /data/nativetest/VtsHalPowerV1_3TargetTest/VtsHalPowerV1_3TargetTest
Change-Id: I5fb33abbbe4c4958882a106dfa400ad74013e40d
2018-08-10 18:37:07 -07:00
Pawin Vongmasa
841940be1c resolve merge conflicts of b92f1d2e1b to oreo-mr1-vts-dev
am: c0243f2ff8

Change-Id: I25bf6387a074f630cc3e10c3b265d16390e39eca
2018-08-10 14:30:13 -07:00
Kevin Rocard
92dc397252 [automerger skipped] Audio VTS: run tear-down hooks in LIFO instead of FIFO am: 01ead7c96b -s ours
am: 70d13c2ad3  -s ours

Change-Id: I1040539ea50b8c6c02daa1b032d9b5be01bd920e
2018-08-10 14:29:59 -07:00
Kevin Rocard
5381192973 Audio VTS: run tear-down hooks in LIFO instead of FIFO
am: cfab8dac2b

Change-Id: Ibd24dda91b5d334a62553dfe980d6559743688b8
2018-08-10 14:29:43 -07:00
sqian
698b7fe3f4 [automerger skipped] Fix setBandMode. am: ab2b8bf919 -s ours
am: d1e489c94c  -s ours

Change-Id: Ia6efc79ef18e4614f784a3a393ce19d33dd564f1
2018-08-10 14:29:29 -07:00
Eric Schwarzenbach
a22fea6160 Call notify for voiceReg and dataReg VTS tests
Bug: 80554443
Test: vts
Merged-In: I19f7131f7b65323065f3c283a89668ff761815e3
Change-Id: I19f7131f7b65323065f3c283a89668ff761815e3
(cherry picked from commit 2bb626a297)
2018-08-10 00:48:52 +00:00
sqian
70afa883ae Add REQUEST_NOT_SUPPORTED for changeIccPinForApp and changeIccPin2ForApp
Bug: 110037298
Test: run vts -m VtsHalRadioV1_0Target
Merged-In: Iaba800814c5a6950d086a2f105714d01fdaa14a4
Change-Id: Iaba800814c5a6950d086a2f105714d01fdaa14a4
(cherry picked from commit 7470cbd04d)
2018-08-10 00:48:45 +00:00
Hung-ying Tyan
555cb5e13b Fix free() in keymaster VTS
The buffer is allocated by OPENSSL_malloc() in X509_NAME_oneline(name, nullptr, 0).
Should be reclaimed by OPENSSL_free() instead of free().

The patch is provided by vink.shen@mediatek.corp-partner.google.com

Bug: 109708231
Test: build pass
Merged-In: I66a864e3e28905eebac2e7d3a4517d4d5aaa39df
Change-Id: I66a864e3e28905eebac2e7d3a4517d4d5aaa39df
(cherry picked from commit 79db3ec849)
2018-08-10 00:48:32 +00:00
nagendra modadugu
bbe9263f85 Respect limited requirements for Strongbox KM implementations
With this patch the KM VTS test apply the restricted requirements on
supported key sizes, EC curves, and Digests to Strongbox keymaster
implementations.

Also amend tests to use Update().

Test: Yes it is
Bug: 74519020
Merged-In: Ibec9c3398671f81dbc0ecf78e554726276160579
Change-Id: Ibec9c3398671f81dbc0ecf78e554726276160579
(cherry picked from commit 3a7e2cade3)
2018-08-10 00:48:11 +00:00
Yin-Chia Yeh
79cea44239 resolve merge conflicts of cd02298b46 to oreo-mr1-vts-dev
Bug: None
Test: none
Change-Id: I1d705ee440f49b1d7713b9225cbfb1815b79d5a0
2018-08-02 15:13:24 -07:00
Yin-Chia Yeh
cd02298b46 Camera: add proper HwLevel check
Bug: 112011195

Merged-In: Ib0b98f32c401566323eee546ee23c7873c00aef0
Change-Id: If27bb5b12cfd2ffd8abf3079302d5967e37bf241
2018-07-31 03:16:26 +00:00
Kevin Rocard
0f0328fc4e Effect VTS: Allow an effect proxy as pre/post processing
Effect proxy were previously mistakenly forbidden as post
or pre processing effects.

An effect being a proxy or not should not affect where
it can be use in the effect framework.

Bug: 111421676
Test: xmllint --noout --schema hardware/interfaces/audio/effect/2.0/xml/audio_effects_conf_V2_0.xsd $(find -name audio_effects.xml)
Change-Id: Iad1c1467226b86a2935a36dd90cf2e32f7f753b0
Signed-off-by: Kevin Rocard <krocard@google.com>
2018-07-19 09:04:21 -07:00
sqian
898d05a713 resolve merge conflicts of dfa79a6292 to oreo-mr1-vts-dev
Test: I solemnly swear I tested this conflict resolution.
Bug: None
Change-Id: I10919718b841fdb33ab0e873d1b4bbd787fafcd2
2018-07-16 08:36:50 -07:00
Treehugger Robot
dfa79a6292 Merge "Add NONE for LceService" into oreo-vts-dev 2018-07-16 15:19:43 +00:00
sqian
70805cffdd Add NONE for LceService
"Allow startLceService to succeed even in the
SIM_ABSENT case. The original RIL documentation
states that SUCCESS is valid for all LCE
operations, and there is no logical reason why
one of these operations must fail in a no-SIM
case (though a vendor may choose not to support
that configuration). Thus, a call to
startLceService should permit NONE when requested
in the no-SIM case for 1.0 VTS.

In addition, a successful call to startLceService
should also permit a successful call to
pullLceData, so also allow RadioError::NONE for
the pull operation. Ideally the tests would only
allow NONE for pull if startLceService also
returns NONE, but that's out of scope for now."

Bug: 110181475
Bug: 72075328
Test: confirmed in the discussion; compilation
2018-07-13 18:12:08 +00:00