Commit graph

59026 commits

Author SHA1 Message Date
Treehugger Robot
8c00013594 Merge "Audio Effect VTS: run Dowmmix data path test only after HAL version 2" into main 2024-01-03 19:45:02 +00:00
Treehugger Robot
4103ef0c5a Merge "Camera: Add missing characteristics for using buffermanager in ExternalCamera" into main 2024-01-03 18:59:01 +00:00
Shunkai Yao
6b7784edfe Audio Effect VTS: run Dowmmix data path test only after HAL version 2
Bug: 315074570
Test: VtsHalDownmixTargetTest
Change-Id: Iaa17519521f136901ec217f7d5b5fd0d03889533
2024-01-03 18:46:00 +00:00
Spandan Das
bce73c83b0 Merge "Make availability to com.android.tethering explicit" into main 2024-01-03 17:46:31 +00:00
Yu Shan
5df990f75d Merge "Fixed spelling mistake in LaneCenteringAssistCommand" into main 2023-12-29 01:00:43 +00:00
Mikhail Naganov
5f50cd6320 Merge changes from topic "cuttlefish_aidl_audio-3" into main
* changes:
  Revert "Add remote submix direct paths"
  audio: Add test configs for effects VTS tests
2023-12-28 22:53:57 +00:00
Steven Moreland
85333361c1 Merge "BufferPoolClient: avoid dereference null accessor" into main 2023-12-28 03:16:32 +00:00
Mikhail Naganov
27719f12e8 Revert "Add remote submix direct paths"
This reverts commit ce9767a966.

Please see the comment on aosp/2832731. This configuration
leads to anomalous framework behavior.

Bug: 311830316
Test: atest audiorouting_tests
Change-Id: I5be3ac18819e297aa199c5a0f5d2e85758448b4b
2023-12-27 15:54:30 -08:00
Mikhail Naganov
b80de7bcd7 audio: Add test configs for effects VTS tests
The main purpose of the config is to shut down the framework
audioserver while the VTS test is running. This is achieved by
setting 'vts.native_server.on' to '1'. Without this, restarts
of the effects HAL process which are a normal part of tests
affect the audioserver and may lead to failures of framework
tests that run interleaved with these VTS tests.

Bug: 264712385
Test: atest --test-mapping hardware/interfaces/audio/aidl/vts
Change-Id: I2515cb62e46ef8e93cbddb2c0219f4523d2ecda5
2023-12-27 15:54:30 -08:00
Steven Moreland
483e69f4eb BufferPoolClient: avoid dereference null accessor
Bug: 308739058
Test: N/A
Change-Id: I568e9d82976a1f7d7278748f347a17eb6f93fc79
2023-12-27 22:55:36 +00:00
Tyler Trephan
35bf32ff0f Fixed spelling mistake in LaneCenteringAssistCommand
Test: None
Bug: 290972334
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:077e36dee61db38ad8d0e28a62542e571e2921ae)
Merged-In: Ic85ba803abe349ea9a7edd7dca5cbe7159df34ac
Change-Id: Ic85ba803abe349ea9a7edd7dca5cbe7159df34ac
2023-12-27 20:02:52 +00:00
Mikhail Naganov
eafa78c929 Merge changes from topic "fix-aidl-mix-ports-and-bt" into main
* changes:
  audio: Fix BT AIDL HAL module implementation
  audio r_submix: Suggest configuration from the peer
  audio: Refactor configuration population
2023-12-27 03:42:02 +00:00
Mikhail Naganov
a88cf60b87 audio: Fix BT AIDL HAL module implementation
In order to align with legacy behavior, when opening a stream,
the module must suggest the current configuration of the BT session.
For that to work, the BT device proxy must be opened prior
to creating a stream, code moved to ModuleBluetooth.

Fix minor inconsistencies and bugs found during testing.

Bug: 301213930
Bug: 316027906
Test: atest pts-bot
Change-Id: I04ddaf73be82f872a3f32a789563c3cbd648eb61
2023-12-26 16:34:58 -08:00
Mikhail Naganov
3b732895a8 audio r_submix: Suggest configuration from the peer
When there is a pipe established for a remote submix
device, suggest the configuration of the peer when opening
the other end.

Refactor SubmixRoute management to move it out from
StreamRemoteSubmix so that ModuleRemoteSubmix could also
use it.

Bug: 294962274
Test: atest audiorouting_tests
Change-Id: Ib31a662e7b65b92c614dc441a01160cae3485f3a
2023-12-26 10:31:43 -08:00
Ray Chin
8ef6a81771 Blind scan should be an optional feature based on the design document am: 58be11ecc4
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2890674

Change-Id: I99083d453ebc4e41b46f40abbbf883f254312f3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-26 07:27:41 +00:00
Ray Chin
58be11ecc4 Blind scan should be an optional feature based on the design document
Bug: 317215552
Bug: 305118733
Test: cf_x86_tv-staging-userdebug
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:740a0a8c5ebd0218139aded763fb3204886c2dd0)
Merged-In: Id0153700cfa2c02933c23e13ca1305b0a96b00ca
Change-Id: Id0153700cfa2c02933c23e13ca1305b0a96b00ca

NOTE FOR REVIEWERS - errors occurred while applying the patch.
PLEASE REVIEW CAREFULLY.
Errors:
Error applying patch in tv/tuner/aidl/vts/functional/VtsHalTvTunerTargetTest.cpp, hunk HunkHeader[1258,6->1262,10]: Hunk cannot be applied

Original patch:
 From 740a0a8c5e Mon Sep 17 00:00:00 2001
From: Ray Chin <raychin@google.com>
Date: Fri, 22 Dec 2023 19:10:46 +0800
Subject: [PATCH] Blind scan should be an optional feature based on the design document

Bug: 317215552
Bug: 305118733
Test: cf_x86_tv-staging-userdebug
Change-Id: Id0153700cfa2c02933c23e13ca1305b0a96b00ca
---
2023-12-26 10:28:05 +08:00
Treehugger Robot
78b266ba5a Merge "Secretkeeper: Disable a replay protection VTS" into main 2023-12-22 11:46:34 +00:00
Shikha Panwar
ebeaa36f43 Secretkeeper: Disable a replay protection VTS
This test does not account for potentially missing Sk HAL. Ideally, the
test should pass on those devices too (since Sk is an optional HAL at
the moment).

This test uses should_panic expecting the client code to panic on
processing the message, but that code is never executed because the
backend is not present & the method doesn't panic & the test fails.

As a mitigation, #ignore the test.

Bug: 317416663
Test: VTS show "IGNORED"

Change-Id: I2f1bb45361943f22d8cadc929059c65cb3120f3f
2023-12-22 10:51:08 +00:00
Shikha Panwar
5f20ea7b01 Merge "Secretkeeper: Use byte[64] as SecretId" into main 2023-12-22 10:04:46 +00:00
sadiqsada
aa02c517d3 Add demux to mFrontendTests am: 86aa7010fd am: 6afaf8d190 am: 123934b067 am: 71be20f910
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2886926

Change-Id: Ia4c93f3c45da032e639d97dd2eb8e2b6ecc5bf28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-22 00:32:04 +00:00
Treehugger Robot
f1db884971 Merge "AHAL: update doc for prepareToDisconnectExternalDevice." into main 2023-12-22 00:17:18 +00:00
sadiqsada
71be20f910 Add demux to mFrontendTests am: 86aa7010fd am: 6afaf8d190 am: 123934b067
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2886926

Change-Id: I7de5829fa3f3fdaa816516ee057546b29af68e2b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-21 23:54:34 +00:00
Spandan Das
8dbad6f96c Make availability to com.android.tethering explicit
This is done implicitly today via a baseline map in
build/soong/apex/apex.go

The hidl_interface also requires //apex_available:platform in its
apex_available. This lib gets installed in vendor, and
//apex_available:platform is required on all non-apex variants including
the vendor variants

Bug: 281077552
Test: m nothing
Change-Id: I6f46244f9122fb3e025af53f3a42ad441284a723
2023-12-21 23:39:41 +00:00
Treehugger Robot
856abca8db Merge "use getDescription in test failure message" into main 2023-12-21 23:21:02 +00:00
jiabin
d470926597 AHAL: update doc for prepareToDisconnectExternalDevice.
Bug: 317405349
Test: make
Change-Id: If6c61a851c2e565ab16eb738b9dc0d42ebc04b05
2023-12-21 23:20:56 +00:00
sadiqsada
123934b067 Add demux to mFrontendTests am: 86aa7010fd am: 6afaf8d190
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2886926

Change-Id: I915317c40513987417d4e0de332e1205c2115d11
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-21 23:20:37 +00:00
Sadiq Sada
e1790b4419 Merge "Add demux to mFrontendTests" into android14-tests-dev am: f91c15c69e
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2886668

Change-Id: I8208255dc67576ec833972f023ffcc9fcfb71e76
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-21 22:51:22 +00:00
sadiqsada
6afaf8d190 Add demux to mFrontendTests am: 86aa7010fd
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2886926

Change-Id: I422f6448d26a5e5f2e7915309636503ac92e2c7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-21 22:49:41 +00:00
Sadiq Sada
f91c15c69e Merge "Add demux to mFrontendTests" into android14-tests-dev 2023-12-21 22:16:14 +00:00
Shikha Panwar
3526efd027 Secretkeeper: Use byte[64] as SecretId
SecretId is a parameter in deleteIds() method, which will be invoked by
host (Android). Restrict the size to 64 bytes to avoid unnecessarily
large bytes making it to HAL & TA.

Test: atest VtsSecretkeeperTargetTest
Bug: 317374882
Change-Id: Ieb34fee4efd11636bee133fe9132c1d739d08a1c
2023-12-21 19:47:54 +00:00
Alan Stokes
f7fb082947 Fix a typo
Test: N/A
Change-Id: I200d629e22824a4bfe5278194ff12d20a2d16f74
2023-12-21 11:13:02 +00:00
Peter Lin
f43004efcf [VTS] Update SetDisplayBrightness test item am: 70d2ef6b34
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2883951

Change-Id: Ia57991b0f949307764afeb9fe9fa58c67740900e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-21 02:13:22 +00:00
sadiqsada
86aa7010fd Add demux to mFrontendTests
aosp/2640754 adds a tuneFrontend call with testWithDemux enabled.
tuneFrontend() has some logic that calls DvrTests->openDvrInDemux()
which requires mDemux to be available, but mFrontendTests does not
have an associated demux. This CL adds a demux resource.

Bug: 317268814
Test: atest VtsHalTvTunerV1_1TargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e7c5595ee5cfe79eb181e60399d8d857526d1af7)
Merged-In: I62ad038829ca3ed0ecc077527197eec444a5eb12
Change-Id: I62ad038829ca3ed0ecc077527197eec444a5eb12
2023-12-20 22:51:16 +00:00
Mikhail Naganov
a92039ac48 audio: Refactor configuration population
In 'Module::setAudioPortConfig' allow subclasses to provide
their own suggested configuration.

In 'Module::populateConnectedDevicePort' provide the ID of
the device port instance that will be created as a result
of connecting an external device.

Also, expose 'ModuleDebug' flags to subclasses so that they
can know when device connections are simulated.

Bug: 264712385
Test: atest VtsHalAudioCoreTargetTest
Change-Id: Iceb2bdeb61c3470554b592fe197efa54d3b9e578
2023-12-20 14:31:47 -08:00
sadiqsada
630a974006 Add demux to mFrontendTests
aosp/2640754 adds a tuneFrontend call with testWithDemux enabled.
tuneFrontend() has some logic that calls DvrTests->openDvrInDemux()
which requires mDemux to be available, but mFrontendTests does not
have an associated demux. This CL adds a demux resource.

Bug: 317268814
Test: atest VtsHalTvTunerTargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e75c56787a1a9cd6280ab758788bc810ff50cb58)
Merged-In: I3eb69d8dc10cd2cdbb2d3526317faee2909787f5
Change-Id: I3eb69d8dc10cd2cdbb2d3526317faee2909787f5
2023-12-20 22:14:31 +00:00
Shikha Panwar
99cf847175 Merge "Clarify Secretkeeper comments" into main 2023-12-20 18:38:51 +00:00
Alan Stokes
45d1faaea8 Clarify Secretkeeper comments
Various small wording changes to attempt to clarify some of the
details of the Secretkeeper API.

While I'm here: fix error code naming inconsistency.

Bug: 291224769
Test: N/A
Change-Id: I956b549bc5bf4d2b964dde9867430cb4778e445b
2023-12-20 17:46:14 +00:00
Shikha Panwar
3d33a135ad Secretkeeper/VTS: Per-connection replay protection
Add test coverage for replay protection in Secretkeeper. Test that:
1. Sk implementation encrypts/decrypts messages using correct
sequence_numbers.
2. Out of order messages are not accepted.
3. The sequence numbers are per-connection ie, new SeqNum is used for a
   fresh connection.

Also, refactor code. SeqNumbers are maintained by
libsecretkeeper_client. Have sk_client use a handle to SkSession for
SecretManagement requests. Replay protection tests however require more
fine grained control of SeqNums. For these we have introduced
`secret_management_request_custom_aad()` method.

Bug: 316126411
Test: atest VtsSecretkeeperTargetTest
Change-Id: I385856c04e185d2b300d59a1b54cb8f09cbf836f
2023-12-20 14:41:09 +00:00
Shikha Panwar
73f66600e9 Add SeqNum as an the external_aad in CryptoPayload
Introduce sequence number in Secretkeeper packets to prevent replay of
packets with a session.

Bug: 316126411
Test: VTS
Change-Id: I20a5d8489e988bdcbe9058495ab56ed18a07b946
2023-12-20 14:41:09 +00:00
David Drysdale
91664b85b8 Merge "Secretkeeper VTS: check for declared instances" into main 2023-12-20 10:25:54 +00:00
David Drysdale
e1ac7c65a2 Merge "Add ISecretkeeper/default" into main 2023-12-20 10:24:11 +00:00
Sangheum
aa9d8dce11 Camera: Add missing characteristics for using buffermanager in ExternalCamera
Buffer manager is used in the external camera, but the key is not included in the aidl.
Add a buffermanger key according to the key definition.

Test: Test with USB Camera
Change-Id: I8c8c35d933fecb14dcf39996c709b643db3ee3e3
2023-12-20 17:37:47 +09:00
Peter Lin
70d2ef6b34 [VTS] Update SetDisplayBrightness test item
Ensure the primary display power on before run the
SetDisplayBrightness test item.

Bug: 313794734
Test: atest VtsHalGraphicsComposer3_TargetTest:PerInstance/
      GraphicsComposerAidlCommandTest#SetDisplayBrightness/
      0_android_hardware_graphics_composer3_IComposer_default
      -- --abi arm64-v8a
Change-Id: I94fb700704bcbd8543f2a608dd75b9e745e40e37
Merged-In: I94fb700704bcbd8543f2a608dd75b9e745e40e37
2023-12-20 06:49:27 +00:00
Bob Wang
161a39c309 Merge "Send DeviceResetCmd after task handle is dropped." into main 2023-12-20 01:52:05 +00:00
ziyiw
965dd14687 Send DeviceResetCmd after task handle is dropped.
Previously the command was sent before the task handle is dropped. This
may cause race condition that the DeviceResetRsp may be consumed by the
reader created in open(). In this case, the
consume_device_reset_rsp_and_ntf will wait until timeout.

Bug: 316421259
Test: manual
Change-Id: I680d3ea79344f9b5f07a36877837bfc1b8e0532a
2023-12-19 21:19:24 +00:00
Shunkai Yao
996e1ad8b7 Merge changes from topic "effect_ dependencies" into main
* changes:
  Effect AIDL: cleanup dependencies
  Update VTS header includes
2023-12-19 21:07:35 +00:00
David Drysdale
0bd88b03b3 Secretkeeper VTS: check for declared instances
Calling binder::get_interface(name) for a name that isn't declared may
take multiple seconds before failing.  Restrict to looking for instance
names that are declared.

Also add a rustfmt.toml file, copied from system/secretkeeper/

Bug: 291228655
Test: VtsSecretkeeperTargetTest on Cuttlefish and Pixel8
Change-Id: I9972bc782fe99f5dc5c2dc3b74fa12a0e000ea6c
2023-12-19 15:14:52 +00:00
David Drysdale
a662feeee4 Merge "secretkeeper: add fuzzer" into main 2023-12-19 09:45:14 +00:00
David Drysdale
05758a581f Merge "authgraph: cope with LocalTa being dropped" into main 2023-12-19 09:19:23 +00:00
Hang Shi
549fc869ef Merge "Bluetooth LMP Events: Interface for LMP events" into main 2023-12-19 02:34:53 +00:00