Commit graph

64283 commits

Author SHA1 Message Date
Devin Moore
952bb4ad1f Fix component ID for dumpstate OWNERS
Test: none
Bug: 335336565
Change-Id: I5c8c4ca0c5bff4ff27d298e1ff869e8a9a87f64c
2024-04-22 17:51:47 +00:00
Cody Schuffelen
e23e450487 Merge "C++ AIDL on-device GateKeeper / SharedSecret impl" into main 2024-04-14 22:08:37 +00:00
Bruno Carneiro
056aa140ca Improve OpenAfterOpen VTS test
A callback should be executed every time the NFC interface is opened,
even in OpenAfterOpen scenarios. If a callback is not executed, a
crash may occur where the NfcService hangs while waiting for an
OPEN_CPLT event.

Change-Id: Idd78c0dae944e3d39a6828b43db5a608adbaf1d9
Signed-off-by: Bruno Carneiro <bccunha@motorola.com>
2024-04-12 14:43:22 -03:00
A. Cody Schuffelen
097e625335 C++ AIDL on-device GateKeeper / SharedSecret impl
Because Keystore2 always requires valid auth tokens for user keys, this
copies and extends the existing in-guest GateKeeper implementation to
negotiate a shared secret key with Keymint in order to generate a
session key for signing auth tokens.

This implementation also uses AIDL rather than HIDL to interact with the
framework. It's also packaged in an APEX.

The files are cobbled together from a few sources:

- SoftGateKeeper.h is based on hardware/interfaces/gatekeeper/1.0/software/SoftGateKeeper.h
- GateKeeper.{cpp,h} are based on device/google/cuttlefish/guest/hals/gatekeeper/remote/remote_gatekeeper.{cpp,h}
- SharedSecret.{cpp,h} are based on device/google/cuttlefish/guest/hals/keymint/remote/remote_shared_secret.{cpp,h}
- Apex files are based on device/google/cuttlefish/guest/hals/keymint/rust/

Keymint modifications to use BOOT_TIME are lifted from

https://android-review.git.corp.google.com/c/platform/hardware/interfaces/+/2856649/6..8/security/keymint/aidl/default/ta/clock.rs#38

Bug: 332376454
Change-Id: I81845d5e6370bdddb1a24d67437964e03a5fb243
Test: Run with rust-nonsecure keymint on Cuttlefish
2024-04-11 13:53:32 -07:00
Treehugger Robot
0f141d1967 Merge "PresetReverb: Add test to validate PresetReverb Effect" into main 2024-04-11 17:25:34 +00:00
Treehugger Robot
a6c9097dd0 Merge "Bluetooth vts hal: Restore to 2s startup" into main 2024-04-11 17:21:34 +00:00
William Escande
ac0f34f6cd Bluetooth vts hal: Restore to 2s startup
1s should really be the max limit, but it requires time to investigate
the failures and optimize this

Bug: 327273567
Fix: 332815453
Test: atest VtsHalBluetoothTargetTest
Change-Id: I43767b5241d967cb643401711fd7b2e015e99455
2024-04-11 09:06:31 -07:00
Treehugger Robot
776e39b725 Merge "Allow vendor ISharedSecret HALs by any name" into main 2024-04-11 09:36:52 +00:00
Treehugger Robot
82bb6fcfdc Merge "[Thread] make sure buffer size is enough" into main 2024-04-11 08:18:51 +00:00
shihchienc
cb8a9d74a0 [Thread] make sure buffer size is enough
inotify event size is dynamic, we need to make sure read would not
return error when having inotify event.

Bug: 333829392
Test: manual check `Invalid argument` error won't happen
Change-Id: I3cac8d1519659c6b1b53c1d41013818adab876c7
2024-04-11 06:20:38 +00:00
Sneha Patil
94abce0998 PresetReverb: Add test to validate PresetReverb Effect
Added tests to verify increase in energy with decrease in room and hall size.
Remove preset reverb default implementation from the config file.

Bug: 305866207
Test: atest VtsHalPresetReverbTargetTest
Change-Id: I565612d90b7c7e52cb23bd5dbfaf02235f65cc67
2024-04-11 09:25:56 +05:30
Mikhail Naganov
7b9b9e03e5 audio: Use allow list for device connection types in TryConnectMissingDevice
Limit the connection types to test to the following:
 - HDMI*
 - IP_V4
 - USB

Only these connection types can be easily checked by the HAL
for presence of an external device.

Bug: 326888643
Test: atest VtsHalAudioCoreTargetTest
Change-Id: I659e14a150b3043ead8d844cd89a2c4700d57efd
2024-04-10 23:50:37 +00:00
A. Cody Schuffelen
f693f3bc5c Allow vendor ISharedSecret HALs by any name
This works together with the keystore2 implementation which already
scans the device for implementations by any name.

Relevant code that searches for "shared secret participants":

https://cs.android.com/android/platform/superproject/main/+/main:system/security/keystore2/src/shared_secret_negotiation.rs;l=142;drc=f20c0ddd095013f983d0f73aee0285331bfae4e3

Bug: 332376454
Test: Run cuttlefish
Change-Id: I5eef81e5f55aaa327cabb5c648e085229b8ce6db
2024-04-10 12:59:00 -07:00
Orlando Arbildo
287187f1d2 Add key parameter to deriveDicePolicyBoundKey
Adding a key parameter to deriveDicePolicyBoundKey to use it
as the base of the derived key.

Bug: 284152719
Test: qemu android build
Change-Id: Iab3ee341825f01345996bde3b0b62037e4ec45da
2024-04-09 22:53:21 +00:00
Seth Moore
fae563acb0 Merge "Allow RKP-only devices to pass keymint VTS" into main 2024-04-09 15:31:26 +00:00
David Drysdale
61c9ab4d87 Merge "Make batch attestation keys/certs optional" into main 2024-04-09 09:11:54 +00:00
Treehugger Robot
f02c7e0b2f Merge "[threadnetwork] update the platform log API usages and implementations" into main 2024-04-09 06:38:44 +00:00
Kiyoung Kim
160c3d610c Merge "Remove VNDK definition(s)" into main 2024-04-09 02:13:37 +00:00
Nikolay Elenkov
6e71b471a9 Merge "Enable Java backend for ISecretKeeper" into main 2024-04-09 01:59:35 +00:00
Orlando Arbildo
4761ae94fd Merge "Add deriveKey function" into main 2024-04-08 22:03:30 +00:00
Orlando Arbildo
22c8d13258 Merge "deriveDicePolicyBoundKey AIDL definition" into main 2024-04-08 22:03:18 +00:00
Orlando Arbildo
cfcdb0b4b9 Add deriveKey function
Adding a function to HWCryptoKey AIDL definition to derive a key given
another. This will be used with deriveDicePolicyBoundKey to create
device bound keys.

Bug: 284152719
Test: qemu android build
Change-Id: Ie1e8552846df73325c2428471ca007fca217b675
2024-04-08 19:55:39 +00:00
Orlando Arbildo
6a82aa921e deriveDicePolicyBoundKey AIDL definition
Adding deriveDicePolicyBoundKey function AIDL definition. It
will derive a new key based on a DICE policy

Bug: 284152719
Test: qemu android build
Change-Id: Ie9d5a1233b4aad07fe55cdc522de0cc057d3bec3
2024-04-08 19:55:37 +00:00
Seth Moore
c5c52ce1d3 Allow RKP-only devices to pass keymint VTS
Add test paths for HALs that are RKP-only so that they may pass tests.

Fix up a few tests that were just being skipped for RKP-only HALs.

Test: ran VTS against cuttlefish with no factory key
Bug: 329409739
Change-Id: I5400874dd2f9885c061970a30ea44985353d23ed
2024-04-08 12:38:20 -07:00
Rocky Fang
7efa3c930a Remove Arthur from owner's file
Change-Id: Idb9e891c9b391133d7f5604be0bf921783e27f41
2024-04-08 17:32:45 +00:00
Zhanglong Xia
3c153add59 [threadnetwork] update the platform log API usages and implementations
The latest OpenThread has updated the usage of the platform log APIs.
This CL updates the log APIs usages and implementations.

Bug: b/333301206
Test: Run ThreadNetwork HAL and check logs.
Change-Id: I0c0999edbed1c041e2752d195e753d02b2c734f4
2024-04-08 17:07:57 +08:00
David Drysdale
fe5f33a61e Make batch attestation keys/certs optional
Test: VtsKeyMintTargetTest
Bug: 329399923
Bug: 329269183
Change-Id: I4ef49fcbda7a69ea5623c084e276eb64d34c5813
2024-04-05 16:54:31 +00:00
Kiyoung Kim
9e9d41d162 Remove VNDK definition(s)
As of VNDK deprecation, any libraries that defines vndk is no longer
valid anymore. This change removes all VNDK definition(s) from modules
which was VNDK.

Bug: 328994089
Test: AOSP CF build succeeded
Change-Id: Ifdade9c052db29c989ce7d804ba725361c4c0f8e
Merged-In: Ic4f19113c1a25dc1fb60cdfbf9c0f2d8d7d09726
2024-04-05 02:29:07 +00:00
Charisee Chiw
0c2179c224 Merge "Update needed for Rust v1.77.1" into main 2024-04-04 17:59:39 +00:00
Ray Chin
863f96ecdd Refine infeasible frontend status check am: 9b13077c4c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3022524

Change-Id: I4a5f52304971ef1477147850eae9067455d1d221
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-03 23:57:27 +00:00
Charisee
5fc736d96d Update needed for Rust v1.77.1
error: field `0` is never read
  --> hardware/interfaces/security/keymint/aidl/default/main.rs:38:24
   |
38 | struct HalServiceError(String);
   |        --------------- ^^^^^^
   |        |
   |        field in this struct
   |
   = note: `HalServiceError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
38 | struct HalServiceError(());
   |                        ~~

error: aborting due to 1 previous err


Bug: http://b/330185853
Test: ./test_compiler.py --prebuilt-path dist/rust-dev.tar.xz  --target aosp_cf_x86_64_phone --image
Change-Id: I57f3bd1d702c97929f5fd34f909aa72aa2f2ba02
2024-04-03 20:05:19 +00:00
Gabriel Biren
48def07853 Merge "Copy legacy HAL header files to the wifi interface directory." into main 2024-04-03 18:54:27 +00:00
Orlando Arbildo
8e0b0ae117 Merge "HWCrypto AES non-authenticated AIDL definitions" into main 2024-04-03 14:34:19 +00:00
Roshan Pius
ffe8335846 nfc(interface): Align owner's file with other NFC locations
Bug: N/A
Test: N/A
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:21dde9152232bfda6b5c195806b030c37c385021)
Merged-In: Iddf46eb3f162992898403c2c4832ad2d87b6ac0e
Change-Id: Iddf46eb3f162992898403c2c4832ad2d87b6ac0e
2024-04-03 05:41:50 +00:00
Orlando Arbildo
d0470df3e3 HWCrypto AES non-authenticated AIDL definitions
AIDL definitions for non-authenticated AES-based commands.

Bug: 284152719
Test: qemu android build
Change-Id: Id2319bd186358b085788a3d8c318b78e592a1518
2024-04-02 23:14:13 +00:00
Orlando Arbildo
fbd08f8892 Merge "Add OWNERS file" into main 2024-04-02 22:34:50 +00:00
Devin Moore
aeab14d52c Merge "Fix fmq_test when HIDL is not supported" into main 2024-04-02 21:27:42 +00:00
Orlando Arbildo
2d9f5e9df9 Add OWNERS file
Adding an OWNERS file to the staging/security AIDL folders.

Bug: 284152719
Test: NA
Change-Id: I51838f772c4daf0a7da54c3fe0dd3c1d0edcd910
2024-04-02 19:51:49 +00:00
Gabriel Biren
97e48aa122 Copy legacy HAL header files to the wifi
interface directory.

No-Typo-Check: Unable to update misspelled variables
BYPASS_INCLUSIVE_LANGUAGE_REASON=Moving legacy code

Bug: 271177978
Test: atest VtsHalWifiChipTargetTest \
            VtsHalWifiStaIfaceTargetTest \
	    VtsHalWifiApIfaceTargetTest \
	    VtsHalWifiNanIfaceTargetTest \
	    VtsHalWifiRttControllerTargetTest
Change-Id: I9329c2bc8c816299cabacb4c3702a20b0056929f
2024-04-02 18:12:31 +00:00
Orlando Arbildo
648d748e35 Merge "HWCrypto authenticated symmetric cryptography AIDL definitions" into main 2024-04-02 17:56:10 +00:00
Orlando Arbildo
b4e55bd84d Merge "HWCrypto base AIDL definitions" into main 2024-04-02 17:55:56 +00:00
Shunkai Yao
e237f5bfaa Merge "Use customized toString for UUID in VTS" into main 2024-04-02 16:45:52 +00:00
Ray Chin
9b13077c4c Refine infeasible frontend status check
Bug: 322055872
Test: atest VtsHalTvTunerTargetTest
Change-Id: I43bef4b7c5b6bc0f85904916040617fbde16b894
2024-04-02 22:47:47 +08:00
Henri Chataing
bbd7bba074 Merge "VtsHalBluetoothTargetTest: Link with libbluetooth_log" into main 2024-04-01 23:40:57 +00:00
Treehugger Robot
926c26500c Merge changes I86ba4225,I04d8e19a into main
* changes:
  ExternalCameraHAL: fix CTS failures with callback for errors
  ExternalCameraHAL: improve buffer and error handling
2024-04-01 23:08:36 +00:00
Treehugger Robot
52815dd2b0 Merge "ExternalCameraHAL: Skip importing buffer from capture request" into main 2024-04-01 23:08:36 +00:00
Treehugger Robot
2fa41a801f Merge "ExternalCameraHAL: Prevent memory leak when manipulating native_handle" into main 2024-04-01 22:50:36 +00:00
Treehugger Robot
d741ab8a51 Merge "Package the rust_nonsecure keymint default HAL in an APEX" into main 2024-03-30 10:06:52 +00:00
Ray Chin
9022f45022 Support product specific VTS test configuration am: 7d03f49853
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3018625

Change-Id: I2dfd15a88f8b3d749fce434e58edb7928f117cf0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-30 03:21:15 +00:00
Treehugger Robot
86d8bf593a Merge "Remove unnecessary "_external" suffix from libcppbor" into main 2024-03-29 21:18:28 +00:00