Commit graph

313 commits

Author SHA1 Message Date
Chih-Hung Hsieh
63f4fe65b2 Fix implicit-fallthrough warnings.
Test: make checkbuild
Bug: 112564944
Change-Id: Ifc8b7444b95d667b0d185c7d45b3f15278d4af2f
2018-10-19 14:24:58 -07:00
Tomasz Wasilczyk
b557e0b748 Fix comments and internal names about SEEK operation.
Legacy radio HAL named it SCAN and the name slipped through HAL 1.x
into HAL 2.0. I finally noticed it after HAL 2.0 was locked down.

Bug: 109740376
Test: build ow
Change-Id: I5ca4147227a7dd0c32248a279f03fb632d97258e
2018-06-07 15:19:27 -07:00
Tomasz Wasilczyk
cea64964dc Improve current program info validation.
Bug: 74022658
Test: atest VtsHalBroadcastradioV2_0TargetTest
Change-Id: Ifee19249a9033363df863480e8a5da24334f5e59
2018-05-23 12:02:39 -07:00
Steven Moreland
4ee4582230 Update comments for doc comments.
Doc comments look like "/** ... */" and they
can only be in certain places.

Bug: 79865343
Test: m
Change-Id: Ic15c08ff7dc6e4f9827c1dbe7f7236c11a572ec1
2018-05-18 10:10:32 -07:00
Tomasz Wasilczyk
8acabf21a4 Add check for empty RDS_PS.
Bug: 78885613
Test: atest VtsHalBroadcastradioV2_0TargetTest
Change-Id: I9ac0e8975972636696504a6eeb0ecce58396e3fd
2018-04-30 10:25:22 -07:00
Tomasz Wasilczyk
55241f7c76 Extend tune workaround time.
Bug: 73963096
Test: atest VtsHalBroadcastradioV2_0TargetTest
Change-Id: I6b722fb4f82005fe468a17f0f29af9dc8bd0e8f7
2018-04-30 08:55:14 -07:00
Tomasz Wasilczyk
674696f92a Clear out ambiguity in broadcastradio@2.0 comments.
Bug: 76798863
Test: it builds
Change-Id: Icd13a187d3a002e6d1d0af8d360de31a75949b69
2018-03-30 16:01:22 -07:00
Tomasz Wasilczyk
5e6bebbd83 Update program list when switching bands.
Test: manual
Bug: 74353024
Change-Id: I893cd4f9c7d14951924759792206af798b0ceefc
2018-03-28 17:48:18 -07:00
Tomasz Wasilczyk
c863a957d4 Fix boadcastradio HAL 1.1 tuneByProgramSelector implementation.
It was not compliant with the HAL definition - it didn't auto-change
band if necessary.

Bug: 74353024
Test: manual
Change-Id: I015faffc42778fa27fca3030306f31b0abe409c7
2018-03-08 11:41:55 -08:00
Tomasz Wasilczyk
b314271b58 Reword ProgramInfo comments.
It makes clear which fields are required for the program list entries,
and which for currently tuned program.

Test: none
Change-Id: If7ec3ad8f99e22b225063ca71a0c249b5d6d2bc1
2018-02-21 13:20:50 -08:00
Zhuoyao Zhang
b46346f9bd Merge "Convert broadcastradio hal test to use VtsHalHidlTargetTestEnvBase" 2018-02-14 17:25:33 +00:00
Zhuoyao Zhang
190548f558 Convert broadcastradio hal test to use VtsHalHidlTargetTestEnvBase
Bug: 64203181
Test: make vts
      vts-tradefed run vts -m VtsHalBroadcastradioV1_0Target
      vts-tradefed run vts -m VtsHalBroadcastradioV1_1Target

Change-Id: I574b54dc95522486f4be9b50da436e90f3f88b9d
2018-02-13 10:15:37 -08:00
Tomasz Wasilczyk
869779ae92 Merge "Drop broadcastradio HAL 1.2." 2018-02-13 14:22:00 +00:00
Tomasz Wasilczyk
67360529f6 Verify physically/logicallyTunedTo field in ProgramInfo.
Test: it builds
Bug: 71614466
Change-Id: Iae6fe660cbadd3a4309c4700fc939289c0528d8f
2018-02-12 11:42:25 -08:00
Tomasz Wasilczyk
7aad611408 Drop broadcastradio HAL 1.2.
Test: it boots
Bug: 62945293
Change-Id: Ie05d50f3084f51aa6e4de53096656b1387503459
2018-02-10 10:49:58 -08:00
Tomasz Wasilczyk
0f5d21ae53 Remove broadcastradio HAL 1.2 support from the framework.
Bug: 62945293
Test: VTS
Change-Id: Ifd54fe476717ae71e5c9ff72498bf702b0c29454
2018-02-10 12:40:41 +00:00
Tomasz Wasilczyk
8c34c8179d Move broadcast radio 1.2 default implementation back to 1.1.
Bug: 62945293
Test: VTS

Change-Id: I95d68ea61f5b50c5b510212b0941bddad1158f97
2018-02-09 19:43:45 +00:00
TreeHugger Robot
6a99a2a901 Merge "Rename getConfigFlag to isConfigFlagSet." 2018-01-20 02:22:21 +00:00
Tomasz Wasilczyk
d773e954a4 Merge "Allow spaces in DAB frequency labels and make it up to 7 characters long." 2018-01-19 19:38:13 +00:00
Tomasz Wasilczyk
a425dedbe8 Allow spaces in DAB frequency labels and make it up to 7 characters long.
There is no standard for DAB label format, the regexp is based on our
partners knowledge.

Bug: 69958423
Test: VTS

Change-Id: I917508408de22f8a75d39d4e9badddd385869b03
2018-01-15 08:34:28 -08:00
Tomasz Wasilczyk
db902860e8 Fix remaining instrumentation tests.
Bug: 69958777
Test: VTS, Instrumentation
Change-Id: I98956ea4b1d2953b9159fb7d53ce61e57f80a90f
2018-01-15 08:10:40 -08:00
Tomasz Wasilczyk
3dd452a979 Rename getConfigFlag to isConfigFlagSet.
The latter matches code guidelines better.

Bug: 69958423
Test: it builds
Change-Id: I520733a061f03bab57544a1451dd763dc53ce5c6
2018-01-12 14:59:07 -08:00
Tomasz Wasilczyk
0d5ef5de01 Rename AnnouncementObserver to AnnouncementListener.
I feel this wording match java naming more closely.

Bug: 68045105
Test: VTS
Change-Id: If30fa9b356b6b45fe8853bc5194c7098d0fb2aa5
2018-01-11 19:26:02 -08:00
Tomasz Wasilczyk
653f766177 Broadcast radio 1.x default implementation: let's support background scan for real.
Bug: 69860743
Test: VTS, instrumentation
Change-Id: Ia636795494c88a82edf681adaa403e3b70f77814
2018-01-09 21:11:38 -08:00
Tomasz Wasilczyk
a72fb98f2b Merge "Broadcast radio 1.x default implementation: let's support background scan." 2018-01-09 22:20:27 +00:00
Tomasz Wasilczyk
06c82dd932 Merge "Fix few typos in broadcast radio HAL 2.0 comments." 2018-01-08 23:54:09 +00:00
Tomasz Wasilczyk
db1386a902 Broadcast radio 1.x default implementation: let's support background scan.
Bug: 69860743
Test: VTS
Change-Id: I7f0dc841e2b3fc218e5e7efa9b102697655cc9d5
2018-01-08 15:37:09 -08:00
Tomasz Wasilczyk
88960f1d3d Fix few typos in broadcast radio HAL 2.0 comments.
Bug: 69958423
Test: none
Change-Id: Ic9e5ddd4fb6d033f6f98eb0b537856abe4e4f025
2018-01-05 13:37:44 -08:00
Tomasz Wasilczyk
38b51669e4 Merge "Prepare a best-effort workaround for HD Radio station id abuse." 2018-01-04 20:17:28 +00:00
Tomasz Wasilczyk
c71624f8ed Prepare a best-effort workaround for HD Radio station id abuse.
In theory, 32bit HD Radio station ID + subchannel index (parts of
HD_STATION_ID_EXT) is a globally unique identifier. It allows broadcast
radio framework to determine which programs are the same and allow the
application to match entries from favourite list and the program list
provided by the tuner.

However, some broadcasters don't perform equipment setup correctly and
don't set station ID. As a result, there are some stations with
conflicting IDs.

As a workaround to treat these stations separately in a given location,
FM frequency was added as a part of HD_STATION_ID_EXT. This still doesn't
solve the global uniqueness problem: user might save KCQW 105.5 (sid=0) in
California, travel to Nevada and find KNAB 105.5 (sid=0). It turns out
there is no reliable identifier that might identify the station globally.

As a workaround, shortened station name is added for double-checking.
This is a best-effort fix, so it's not required for such misbehaving
stations to get correctly identified in every corner case.

Bug: 69958777
Test: VTS
Change-Id: Id11243096f1cde7fdda5cb70a7248d1831985cdd
2018-01-04 08:40:31 -08:00
Tomasz Wasilczyk
6a9f856e24 Implement broadcast radio announcements.
Bug: 68045105
Test: VTS
Change-Id: I14d394862ec34d63218c938779e217c28710e230
2018-01-03 10:01:10 -08:00
Tomasz Wasilczyk
8b70ee43b0 Implement regional configuration fetching.
Bug: 69958423
Test: VTS
Change-Id: I7c184191b4f4999bd03b06bd3b2283e028694918
2018-01-02 11:51:59 -08:00
Tomasz Wasilczyk
4ce6382a45 Implement currently tuned ID / channel indication.
Bug: 70939328
Test: it builds
Change-Id: I62011b70b3786b0d5e5ac24eb480a3c52a35f104
2017-12-28 20:31:20 -08:00
Tomasz Wasilczyk
eb2b87ba3e Merge "Implement program list fetching." 2017-12-22 20:44:15 +00:00
Tomasz Wasilczyk
bceb88585d Implement program list fetching.
Bug: 69860743
Test: VTS
Change-Id: I04eb43c1e0e1bb7bad86e123594a473454eed983
2017-12-22 10:19:50 -08:00
Tomasz Wasilczyk
30240f61ed Redefine meaning of DAB/FM linking.
Bug: 69958423
Test: VTS
Change-Id: I0ab4ddd6fc34f12720085cca9d0b821ec660a5c8
2017-12-20 14:49:45 -08:00
Tomasz Wasilczyk
43fe894562 Implement config flags.
Bug: 69958423
Test: VTS
Change-Id: I6221d2bd2c6f1e31c93b105fce4cfc6d673e3b77
2017-12-14 15:04:06 -08:00
Tomasz Wasilczyk
c961f613c3 Merge "Try to fix some builds." 2017-12-13 19:31:45 +00:00
Tomasz Wasilczyk
28ca7e9740 Try to fix some builds.
Broken builds: aosp_x86, docs, full, sdk_phone_armv7.

I cannot reproduce the break locally, so making my best guess on the fix.

Test: it still builds
Change-Id: Icf86c3502fede66dba815458b66f2ebdf33afe91
2017-12-13 10:09:22 -08:00
Tomasz Wasilczyk
6f6509f96b Merge "Implement broadcast radio HAL 2.0 VTS tests." 2017-12-13 17:05:42 +00:00
Tomasz Wasilczyk
b464e47977 Merge "Implement broadcast radio HAL 2.0 default implementation." 2017-12-13 15:21:12 +00:00
Tomasz Wasilczyk
31e8632d10 Implement broadcast radio HAL 2.0 VTS tests.
Test: VTS
Bug: 69958777
Change-Id: I671c033519a6a41421b9ad73b0b897f832a1c3c0
2017-12-12 10:46:56 -08:00
Tomasz Wasilczyk
06100b39db Implement broadcast radio HAL 2.0 default implementation.
Also, split internal common utils library to 1.x and 2.x.

Test: VTS
Bug: 69958777
Change-Id: I21244c74270a07cc350e8a2b974dafcdae02a0e8
2017-12-12 10:22:11 -08:00
Steven Moreland
4cd5506baa Update makefiles.
Been seeing these in CLs. Some were forgotten.

Test/Bug: none

Change-Id: I678f9ef157a3631586a3d3a9cc503121eed5a703
2017-12-11 20:48:11 +00:00
Tomasz Wasilczyk
6e0e1ae2a9 Define broadcast radio HAL 2.0.
The new HAL is a cleanup of 1.x branch of the legacy burden:
 * structure flattened (multi-level factory removed);
 * only one hardware tuner per HAL instance, only one session;
 * front-end app doesn't control region settings anymore;
 * metadata limited to int and string values;
 * removed deprecated methods;
 * result codes redefined.

It also fixes minor mistakes made with HAL 1.1:
 * ProgramSelector simplified;
 * there is no need to control background scan.

There are three features missing compared to the HAL 1.1, as they
are in development with the new design (see design docs attached):
 * Announcements - b/68045105
 * Program list - b/69860743
 * Region handling - b/69958423

Test: VTS
Bug: b/69958777
Change-Id: I0ad83f25630c1250d73dc3941144d345339fbde0
2017-12-05 14:10:04 -08:00
Tomasz Wasilczyk
25153f3586 Merge "Extend DAB primary identifier with SCIdS." 2017-11-29 18:10:52 +00:00
Tomasz Wasilczyk
002151ce25 Extend DAB primary identifier with SCIdS.
This replaces DAB_SIDECC with DAB_SID_EXT as primary DAB identifier.

Bug: 69308221
Test: it builds
Change-Id: I8d3c9628e7dc8a03c5aa0c04f136e60eccaa9940
2017-11-28 14:38:42 -08:00
Steven Moreland
fcca4e23b7 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:22:43 -08:00
TreeHugger Robot
5b7092f31c Merge "Transfer VTS test ownership." 2017-11-17 06:02:27 +00:00
Ryan Campbell
bf941ddefd Transfer VTS test ownership.
Remove self from test ownership and transfer to new owners as agreed.

Test: none
Bug: 69425312
Change-Id: I8b189e6f2d7076b9ee7f3bad91445ccf6c5e1767
2017-11-16 14:24:49 -08:00
Tomasz Wasilczyk
3906f455cd Merge "Update comments for vendor-specific parameters API." 2017-11-16 20:43:44 +00:00
Tomasz Wasilczyk
d64fe223e3 Update comments for vendor-specific parameters API.
Bug: 65862441
Test: none
Change-Id: Iffdc48ec86159ca3d7c0dddd586b9865ace4f492
2017-11-16 10:30:59 -08:00
Steven Moreland
8db261bc99 Updating makefiles for hidl_interface.
Bug: 64487114
Test: manual
Merged-In: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
Change-Id: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
2017-11-13 10:00:18 -08:00
Steven Moreland
f390f03aa4 Update for Soong-only makefiles.
Test: pass
Bug: 33420795
Change-Id: Ibec6d1e38939b9e7566a96381439be2aac3bf8ca
2017-10-11 18:30:28 +00:00
Steven Moreland
1d7374c5e1 Update for Soong java makefiles. am: c3e80fa01e am: 0fff75dee1 am: 6c811964a1
am: 116161d94e

Change-Id: I33643636e2511de77fdf7de57777eb67edee2e52
2017-10-11 16:39:21 +00:00
Steven Moreland
116161d94e Update for Soong java makefiles. am: c3e80fa01e am: 0fff75dee1
am: 6c811964a1

Change-Id: I85ccbb4a15cd18938607f5bca4e065b9d7e0182b
2017-10-11 16:31:07 +00:00
Steven Moreland
0fff75dee1 Update for Soong java makefiles.
am: c3e80fa01e

Change-Id: Ia8835f9c95bd98a96f5fd3aff11191e7d3726fb9
2017-10-11 16:23:54 +00:00
Steven Moreland
c3e80fa01e Update for Soong java makefiles.
Test: pass
Bug: 33420795
Change-Id: Id9b1919a19b8ff682738cfb0869a479b4dbb4293
2017-10-10 23:07:20 +00:00
Treehugger Robot
75d5cf515a Merge "Remove useless Android.mk files." 2017-10-05 21:40:27 +00:00
Tomasz Wasilczyk
26900b53b2 Merge changes from topics "radio-vendor-kvp", "radio-1.2"
* changes:
  Implement VTS tests for new radio interfaces.
  Implement generic vendor-specific parameters.
  Branch out Broadcast Radio 1.2 HAL.
2017-10-05 07:27:03 +00:00
Steven Moreland
4b60470f1a Remove useless Android.mk files.
These have been c/p'd all over the place.

Test: m -j nothing
Bug: 33420795
Change-Id: I77979866dbb2345a41a873c84ec3fccd7b127510
2017-10-04 15:52:40 -07:00
Steven Moreland
9a17f41f6f Merge "Update for hidl adapter module defaults." am: 988c977079 am: 861651985f
am: b53e6ad535

Change-Id: I23269fb7a9bdd352e670a80f390527d9eef31412
2017-10-04 21:51:00 +00:00
Steven Moreland
861651985f Merge "Update for hidl adapter module defaults."
am: 988c977079

Change-Id: I289818be1b30397391847ba1c532d1014fdbed27
2017-10-04 21:45:09 +00:00
Tomasz Wasilczyk
d921f6134b Implement VTS tests for new radio interfaces.
Test: VTS
Bug: 65862441
Change-Id: I57bd413f011433fbbd432b886cbd5ad60e05a57e
2017-10-04 14:10:14 -07:00
Tomasz Wasilczyk
45491be2c1 Implement generic vendor-specific parameters.
This commit covers HAL changes only.

Bug: 65862441
Test: it builds
Change-Id: Ibd20e2a1db826a0dc3ade4fb9bd1cb830ee11f8d
2017-10-04 14:10:06 -07:00
Steven Moreland
527fd76a0e Update for hidl adapter module defaults.
Test: pass
Change-Id: Idc6a943149a279bf17cfcfd0f2571473e53bbbbf
2017-10-04 12:47:03 -07:00
Steven Moreland
9fdd241905 Merge "Fix typo in update makefiles." am: 9960148420 am: f07e364ce3
am: 71a193a425

Change-Id: I45ae43f07323254212532acbf0f891d11143b05f
2017-09-26 23:58:51 +00:00
Steven Moreland
f07e364ce3 Merge "Fix typo in update makefiles."
am: 9960148420

Change-Id: I949634e72f817f3a5411130e968acd8efd1d7725
2017-09-26 23:51:07 +00:00
Steven Moreland
a5299ee739 Fix typo in update makefiles.
Bug: 37518178
Test: pass
Change-Id: Ic401b3a473f15ca4c01e58b3072e19db7c31b653
2017-09-26 21:59:43 +00:00
Steven Moreland
97228c0b7d Update makefiles for hidl adapter. am: 26a0bb2762 am: 73949c1d7e
am: b94d0c7290

Change-Id: If766cffbcc003cc0cc5eb98969b924aa918fff44
2017-09-26 12:53:13 +00:00
Steven Moreland
73949c1d7e Update makefiles for hidl adapter.
am: 26a0bb2762

Change-Id: I3a811f5cd49bd4e81e8fcd5c8e88922115812539
2017-09-25 23:14:44 +00:00
Steven Moreland
26a0bb2762 Update makefiles for hidl adapter.
Bug: 37518178
Test: manual
Change-Id: I50e999907d3c64d2b039272b823971998da64d1b
2017-09-25 18:35:56 +00:00
Tomasz Wasilczyk
f679e8b6ec Branch out Broadcast Radio 1.2 HAL.
Bug: 62945293
Change-Id: Ic84f9fe6c17040053257085801208ed527fd07ab
Fixes: 64115813
Test: instrumentation, VTS
2017-09-21 13:25:17 -07:00
Tomasz Wasilczyk
7c353e9dd8 Merge "Adjust AM/FM region ranges." into oc-mr1-dev 2017-09-13 15:36:09 +00:00
Tomasz Wasilczyk
ab70ddf2eb Adjust AM/FM region ranges.
Bug: 64541927
Test: instrumentation
Change-Id: I34ea5b0b426f0c0c73d1cbc2d64cb67e2d4b7bd6
2017-09-12 11:57:09 -07:00
Tri Vo
ba6d6e5767 VTS tests now static link to HAL def libs.
am: b65c5ceff2

Change-Id: I393284c12ca5cb79926c4891ffcfd332408a5b9f
2017-08-28 19:23:36 +00:00
Tomasz Wasilczyk
f4bae95eab Move Broadcast Radio HAL to a separate binary.
Bug: 63600413
Test: VTS, instrumentation
Change-Id: I34a779a6608f52bcadaca1dc159bcee02186b49f
2017-08-28 09:45:40 -07:00
Tri Vo
b65c5ceff2 VTS tests now static link to HAL def libs.
And use VtsHalTargetTestDefaults.
This is a partial cherry-pick of ag/2657080.

Bug: 64040096
Test: compiles, works fine in internal master
Merged-In: I8f6995e9536a9aefe283ee3effec9f5a7f03b620
Change-Id: I76d47d8546416b57055841851a9d343026cd3210
2017-08-25 11:48:10 -07:00
Steven Moreland
dfd8287506 Updating all makefiles.
Bug: 64487114
Test: none
Merged-In: I8608c8f636c35f21e4246a805a9eff6d14124e0a
Merged-In: I2fa89b6661c39859ec4fb62c4bb0a05a35e645f0
Merged-In: Ifdc3c17cb2b85c18b37dac2d03bb5c8935c23180
Change-Id: I170fa1c4fe39f8109b1670db58ef99bb11afc0be
2017-08-14 20:25:09 +00:00
Steven Moreland
f901ba801f Merge "Updating all makefiles." into oc-dr1-dev-plus-aosp 2017-08-14 19:19:33 +00:00
Tomasz Wasilczyk
848f29c2d1 Merge "Widen dummy band range to cover all regions." into oc-mr1-dev 2017-08-12 00:15:55 +00:00
Steven Moreland
ff308ea6ba Updating all makefiles.
Bug: 64487114
Test: none
Merged-In: I8608c8f636c35f21e4246a805a9eff6d14124e0a
Merged-In: I2fa89b6661c39859ec4fb62c4bb0a05a35e645f0
Change-Id: Ifdc3c17cb2b85c18b37dac2d03bb5c8935c23180
2017-08-11 22:58:47 +00:00
Tomasz Wasilczyk
fc73b0fcbd Merge "Update broadcastradio HAL 1.0 VTS tests." into oc-dev
am: 52af675d14

Change-Id: Ic5080cb6b22cd3984d0eb39d87cabf7c8a30178d
2017-08-11 22:16:16 +00:00
Tomasz Wasilczyk
9e7774c3b9 Update broadcastradio HAL 1.0 VTS tests.
This is a cherry-pick of the following VTS changes from O MR1 to O:
 - ag/2462390: Fix Broadcast radio 1.0 VTS to not fail on
   other radio types than AM/FM.
 - ag/2477726: Make tuned field description more precise and
   fix VTS tests to obey it.
 - ag/2549733: Implement out-of-band metadata images (a test for in-band).

Additionally, it fixes config callback handling in OpenTunerTwice test.

Bug: b/64324703
Test: VTS
Change-Id: I590b9b4d927fb0cd41f92e919343b5b94ad0e246
Merged-In: I590b9b4d927fb0cd41f92e919343b5b94ad0e246
2017-08-11 11:58:09 -07:00
TreeHugger Robot
b0e7821fcb Merge "Update broadcastradio HAL 1.0 VTS tests." into oc-mr1-dev 2017-08-11 18:56:16 +00:00
Tomasz Wasilczyk
394b343ae5 Update broadcastradio HAL 1.0 VTS tests.
This is a cherry-pick of the following VTS changes from O MR1 to O:
 - ag/2462390: Fix Broadcast radio 1.0 VTS to not fail on
   other radio types than AM/FM.
 - ag/2477726: Make tuned field description more precise and
   fix VTS tests to obey it.
 - ag/2549733: Implement out-of-band metadata images (a test for in-band).

Additionally, it fixes config callback handling in OpenTunerTwice test.

Bug: b/64324703
Test: VTS
Change-Id: I590b9b4d927fb0cd41f92e919343b5b94ad0e246
2017-08-10 20:28:18 -07:00
Tomasz Wasilczyk
701a5bdda5 Widen dummy band range to cover all regions.
Bug: b/64115131
Test: VTS, instrumentation
Change-Id: I34e9aac440a003226200243c835e6116ba7eae90
2017-08-10 16:07:20 -07:00
Tri Vo
2883486706 Merge "VTS tests now static link to HAL def libs. #2" into oc-mr1-dev 2017-08-10 17:45:07 +00:00
Tri Vo
0c2ce357b1 VTS tests now static link to HAL def libs. #2
And use VtsHalTargetTestDefaults.

Bug: 64040096
Test: crop out all non-affected tests from vts-hal-hidl.xml and run
vts-tradefed run commandAndExit vts-hal-hidl --skip-all-system-status-check 
--skip-preconditions
2 failures, same as without this change:
GatekeeperHidlTest.DeleteAllUsersTest
GatekeeperHidlTest.DeleteUserTest

Change-Id: I8f6995e9536a9aefe283ee3effec9f5a7f03b620
2017-08-10 17:44:57 +00:00
TreeHugger Robot
2187f58fad Merge "Add OWNERS for broadcast radio HAL 1.1." into oc-mr1-dev 2017-08-08 19:26:42 +00:00
Tomasz Wasilczyk
75c2bd8d1c Add OWNERS for broadcast radio HAL 1.1.
Test: not necessary
Change-Id: I73881db46382276f56963c9d3a40cb0bdc1a2070
2017-08-07 17:46:31 -07:00
Tomasz Wasilczyk
da97a6dd42 Change VENDOR program types to range.
Bug: b/64331420
Test: VTS, instrumentation
Change-Id: If91d8e6835ed3acaf429bb05b96f3d3a7985d19b
2017-08-07 10:27:28 -07:00
Tomasz Wasilczyk
eabdc13839 Merge "Pass ProgramInfo over currentProgramInfoChanged and drop afSwitch_1_1." into oc-mr1-dev 2017-08-05 20:47:14 +00:00
TreeHugger Robot
0a21415efa Merge changes from topic 'hidl-vndk-enabled-oc-mr1' into oc-mr1-dev
* changes:
  Mark hidl utils as vndk
  Manually update makefile for vndk-sp hidl libs.
  Update make file for vndk enabled.
2017-08-05 02:01:37 +00:00
Tomasz Wasilczyk
dd130660d3 Pass ProgramInfo over currentProgramInfoChanged and drop afSwitch_1_1.
Bug: b/64229617
Test: VTS, instrumentation
Change-Id: Id2d209a31d801f85e197312673eb6b7ee63ada46
2017-08-04 12:14:53 -07:00
Justin Yun
608d773ef8 Update make file for vndk enabled.
Update the Android.bp generated with hidl-gen.

Test: build with and without BOARD_VNDK_VERSION=current
Bug: 63866913
Change-Id: I1a9db1df49e0f13c5790da2b118ae9ec63ba34a7
2017-08-04 14:12:23 +09:00
Tomasz Wasilczyk
fa3a559d86 Pass vendor-specific info as map.
This solves a problem of identifying, if a given application is talking
to a hardware that can handle format of these strings.

Bug: b/64229617
Test: VTS, instrumentation
Change-Id: If1a5f9900800b8537ef158beefcbaf3c1008c3da
2017-08-03 18:21:47 -07:00
Tomasz Wasilczyk
dd58770c39 Implement missing broadcastradio 1.1 VTS tests.
Bug: b/36864490
Test: VTS
Change-Id: Iff25fdd65624db09e6667d32108e479d5eee6964
2017-08-03 12:59:12 -07:00
Tomasz Wasilczyk
e16fb74b05 Merge "Linguistic fixes for broadcastradio 1.1 HAL." into oc-mr1-dev 2017-08-03 16:54:54 +00:00
Tomasz Wasilczyk
b75bb41575 Merge "Address Broadcast Radio HAL review notes." into oc-mr1-dev 2017-08-03 16:52:31 +00:00
Tri Vo
f5d136c231 Update Android.bp HIDL makefiles
Allow HAL definition libs to be static.

Bug: 32920003
Bug: 64040096
Test: update-all-google-makefiles.sh
Change-Id: I1483d572bea6799717d1614fb7d52fe225e31104
2017-08-03 00:30:01 +00:00
Tomasz Wasilczyk
9214894ebc Linguistic fixes for broadcastradio 1.1 HAL.
Bug: b/64113304
Test: it builds
Change-Id: I5d5d090a44146e327d7b0f69cc2ba97060f3b515
2017-08-02 13:35:09 -07:00
Tomasz Wasilczyk
b8a2afe446 Address Broadcast Radio HAL review notes.
Bug: b/64229617
Test: instrumentation, VTS
Change-Id: I4009b33eaea6df585f514711f22dfb7fec5ad379
2017-08-01 14:53:43 -07:00
Tomasz Wasilczyk
614ffc163a Refine broadcastradio HAL comments.
Bug: b/64113304
Test: it builds
Change-Id: I42c1d32dbe436c97f0a05b4fdb88f60f11ceb0a1
2017-07-29 17:31:56 -07:00
Tomasz Wasilczyk
efadc19b6b Make virtual radio space generic, not only FM-exclusive.
Bug: b/36864090
Test: VTS, instrumentalization
Change-Id: I2764d09f56a397a1b80914a2634d6bad4b3bd3d2
2017-07-29 11:29:46 -07:00
Tomasz Wasilczyk
5be4c2b6e3 Remove a hack for 1.0/1.1 bitmap compatibility.
Instead, implement it correctly.
This hack was a quick jury-rigging before O MR1 FC.

Bug: b/36864090
Test: VTS
Change-Id: Ia9caff9228518ec573a85437e9070db777057359
2017-07-29 11:29:46 -07:00
Tomasz Wasilczyk
753c1d1ef2 Implement closing default radio implementation by invalidating all future calls.
Also, use the new hidl_vec range constructor.

Bug: b/36864090
Test: VTS
Change-Id: I92a22ab7f263edd39e42abb65bc25b3d3dc33a1e
2017-07-29 11:29:46 -07:00
Tomasz Wasilczyk
6e93c9c8ba Broadcast Radio default implementation: analog forced switch.
Bug: b/36864090
Test: VTS
Change-Id: I2b7bcf2bb3ad7075f39280ab72b32bff5bf166a3
2017-07-28 08:58:08 -07:00
Tomasz Wasilczyk
c1763a6796 Fix remaining broadcastradio 1.1 VTS TODOs.
This includes:
- cover all AM/FM bands, not just first one
- fix flakiness on late callback dereference
- fix 1.0 tuneComplete check
- move utils includes into separate subdirectories

Bug: b/36864490
Test: VTS
Change-Id: I6e2427ac29abd6278c9783cf83b4df05195ac7ea
2017-07-26 14:41:35 -07:00
Tomasz Wasilczyk
5ca56431d4 Rename vendorExtension fields to vendorInfo.
Bug: b/63634552
Test: instrumentation
Change-Id: Ifeb41ace8d4f4df093c925883c07ea86f0d9b5d7
2017-07-19 16:26:56 -07:00
Tomasz Wasilczyk
ba3e254483 Implement out-of-band metadata images.
This saves a lot of HIDL bandwidth, by not including raw image data in
metadata vector.

Bug: b/63702941
Test: VTS
Change-Id: I73d5218095e4af34c58da8dcfc520abd4cb46c26
2017-07-19 13:38:26 -07:00
Tomasz Wasilczyk
9400122ce8 Merge "Add DRMO_MODULATION program identifier type." 2017-07-19 13:55:56 +00:00
Tomasz Wasilczyk
5a76ec53c2 Add DRMO_MODULATION program identifier type.
Bug: b/63702941
Test: it builds
Change-Id: I3353b232c2e24f7e3c816d4089b2cbf40c4b79ae
2017-07-19 06:53:39 -07:00
Yifan Hong
c67f7b09fd Mark a.h.broadcastradio@1.1-utils-lib as vendor_available
It is used by libandroid_servers, a platform module.

Test: BOARD_VNDK_VERSION=current m libandroid_servers -j

Bug: 33241851
Change-Id: Iac260092d488133033b9a5f0238f7993ab5ef7f0
2017-07-18 15:37:28 -07:00
Tomasz Wasilczyk
85a60baea1 Merge "Make it possible to check if a given program/identifier type is supported." 2017-07-18 17:00:55 +00:00
Tomasz Wasilczyk
bb47714f8d Merge "Fill announcement-related gaps in Broadcast Radio APIs." 2017-07-18 16:49:17 +00:00
Tomasz Wasilczyk
8ca043b286 Merge "Added programInfoChanged callback." 2017-07-18 16:15:17 +00:00
Tomasz Wasilczyk
dc5291d63c Merge changes from topic 'radio-sprint-selector'
* changes:
  Split VENDOR program type to four distinct types.
  Move utils lib out from implementation namespace.
2017-07-18 15:36:23 +00:00
Tomasz Wasilczyk
e192c39c51 Make it possible to check if a given program/identifier type is supported.
Test: VTS
Bug: b/63702941
Change-Id: I8bf162646971188d3bed006c66eb25f1f5dc8df9
2017-07-17 16:56:02 -07:00
Tomasz Wasilczyk
24180098d7 Fill announcement-related gaps in Broadcast Radio APIs.
- adds TA and TP flags to ProgramInfo struct
- adds a callback to cancel announcement

Bug: b/63702941
Test: Instrumentalization, VTS
Change-Id: I03a0781d37429d4a84aab2dce3e5bb7794a20c57
2017-07-17 16:56:02 -07:00
Tomasz Wasilczyk
f8866e79d7 Added programInfoChanged callback.
Also, updated tuneComplete_1_1 and afSwitch_1_1 to match the new behavior
(not passing the whole ProgramInfo struct).

Bug: b/32621193
Test: VTS (none added)
Change-Id: Ic8aee15b05cb982d97e550fc0806f34fbe112e22
2017-07-17 16:56:02 -07:00
Tomasz Wasilczyk
d167caff30 Split VENDOR program type to four distinct types.
Bug: b/32621193
Test: VTS, none added
Change-Id: Ia3b793faeed1129932cf312d231c7d661542fda9
2017-07-17 16:55:56 -07:00
Mikhail Naganov
afae464376 Add OWNERS for audio-related HAL default implementations
Test: not needed
Change-Id: Idefe7be10bde22866be82f87118b9b54e74c3f40
2017-07-14 17:14:53 +00:00
Tomasz Wasilczyk
2834b95b12 Move utils lib out from implementation namespace.
RadioService may benefit from it too.

Also, fix subchannel base, as I found a tiny comment about it in the 1.0 HAL.

Bug: b/32621193
Test: instrumentalization
Change-Id: I11939025b72bdeab4cc6393e25159f53164e22ed
2017-07-13 14:14:11 -07:00
Tomasz Wasilczyk
bb5f29c9fb Use broadcastradio 1.1 default implementation by default.
Also, remove a warning for 1.1 interface, as the hidl freeze mechanism
is now in place.

Bug: b/34348946
Test: VTS, instrumentalization
Change-Id: I82025a7de8abd0758ba8b196bbbfc48b9322ac3b
2017-07-12 12:23:41 -07:00
Tomasz Wasilczyk
c9ba646a72 Refactor Broadcast Radio 1.1 VTS test.
Also apply some minor fixes and log tweaks to the default implementation.

Bug: b/36864490
Test: VTS
Change-Id: I16558d71c6cdee71854ecae9106b8a1c78032439
2017-07-10 15:32:29 -07:00
Tomasz Wasilczyk
a02b6ef23c Implement ProgramSelector at HIDL layer.
No front-end implementation yet.

Bug: b/32621193
Test: VTS
Change-Id: I48f034e709254836cad35bbeb4285c3c42a9e1cd
2017-07-06 17:45:26 -07:00
Tomasz Wasilczyk
2af8c52a6a Merge "Add RDS info to virtual stations, convert to ProgramInfo." 2017-07-05 21:22:46 +00:00
Tomasz Wasilczyk
100f2ed58a Add RDS info to virtual stations, convert to ProgramInfo.
Bug: b/36864090
Test: manual, VTS (none added)
Change-Id: Iad54f5abee4c722030ae118cb3c4d8ad64225b34
2017-06-30 09:06:30 -07:00
Tomasz Wasilczyk
7f7c8c9bc7 RDS PI is a number, not a string.
Makes an ABI-stable change to a hal definition file.

Bug: b/63147256
Test: manual, VTS, instumentalization
Change-Id: I7f1d88dea77fcfd7c203427c094553a6ae89d43b
2017-06-29 18:55:54 -07:00
TreeHugger Robot
ad48396212 Merge "Move broadcastradio test to vendor." 2017-06-29 20:00:34 +00:00
Steven Moreland
cfc836a326 Move broadcastradio test to vendor.
This is a vendor test and is causing builds with BOARD_VNDK_VERSION
to fail during soong processing.

Bug: 37342627
Test: BOARD_VNDK_VERSION=current builds fail later
Change-Id: Icc465b36ff0ecb0ac6c13ba99271eb9b86db6948
2017-06-29 11:09:33 -07:00
Tomasz Wasilczyk
0202b3e7b3 Make tuned field description more precise and fix VTS tests to obey it.
Also makes an ABI-stable change to a hal definition file.

Bug: b/36864490
Test: VTS
Change-Id: Ibf3513722144a559c31d0f61eb84bc718cd9dbdc
2017-06-29 16:21:54 +00:00
Tomasz Wasilczyk
4837755ce9 Initial Broadcast Radio HAL 1.1 default implementation.
The new implementation does not rely on legacy HAL, it implements
HAL 1.1 directly instead.

This is not a full implementation yet, but passes all existing tests.

Bug: b/36864090
Test: VTS, instrumentalization, Unit
Change-Id: Ic8eddd19d0bf6777b4086d099183d71e05d7da0e
2017-06-28 14:00:19 -07:00
Tomasz Wasilczyk
da72d37770 Fix Broadcast radio 1.0 VTS to not fail on other radio types than AM/FM.
Bug: b/36864090
Test: VTS
Change-Id: I402f2fb00a553af2118e8a7595f5b377befcaa01
2017-06-26 16:22:51 -07:00
Tomasz Wasilczyk
02b9cbaa85 Implement getProperties_1_1 for broadcast radio 1.1 default implementation.
Bug: b/36863239
Bug: b/38167547
Test: instrumentation
Change-Id: I129ff7c1a1e6a4711b6352dd6f22d16a324066f3
2017-06-13 10:21:24 -07:00
Steven Moreland
7708449766 Update makefiles. (2/2) am: 76cfb84140
am: f203167814

Change-Id: I1f13401266f3c2f78c627088b09c79cd7c8d0276
2017-05-22 17:29:04 +00:00
Steven Moreland
f203167814 Update makefiles. (2/2)
am: 76cfb84140

Change-Id: I24d21438a5b2f447d2160929c6ff6e17b2b66820
2017-05-22 17:15:20 +00:00
Steven Moreland
76cfb84140 Update makefiles. (2/2)
Adds default configuration for all hals.

Bug: 38415912
Test: pass
Change-Id: Idd1f3a2b7b16ad956d31784a513e93a066cdd02e
2017-05-19 15:54:03 -07:00
Tomasz Wasilczyk
6ca90ed3cf Fix getProgramList comment about possible result.
Also change default implementation results for not implemented calls
to be less harsh.

Test: instrumentation
Bug: b/36863239
Change-Id: I7f9adea8aa5b84aec81be13f5614ba16c8b74b75
2017-05-15 15:39:00 -07:00
Steven Moreland
d09cf863da Update makefiles for c++-sources and c++-headers. (2/2) am: bc71124120
am: a32ebce372

Change-Id: Ic1dd8f98e72656bc12a6e5224e541f75afb79daa
2017-05-11 01:38:14 +00:00
Steven Moreland
a32ebce372 Update makefiles for c++-sources and c++-headers. (2/2)
am: bc71124120

Change-Id: Icf36068a4d863a8520854c7a83e51f960c188e12
2017-05-11 00:48:55 +00:00
Steven Moreland
bc71124120 Update makefiles for c++-sources and c++-headers. (2/2)
Test: pass
Bug: 38174080
Change-Id: Icad451f9f9ad5f46412356a4171a8a1222f8e545
2017-05-09 19:58:43 -07:00
Tomasz Wasilczyk
20af5c5ed5 Merge "Convert android.hardware.broadcastradio@1.x-impl to soong." 2017-05-02 22:54:43 +00:00
Steven Moreland
5c63b11f76 Remove redundant dependencies
android.hidl.base@1.0 and android.hidl.manager@1.0 are built into libhidltransport.

Test: links
Bug: 33276472
Merged-In: I08aaad80f7e2fc262aa3a8b66fe932e8133a928d
Change-Id: I08aaad80f7e2fc262aa3a8b66fe932e8133a928d
2017-05-02 15:29:30 -07:00
Tomasz Wasilczyk
cff13a5a60 Convert android.hardware.broadcastradio@1.x-impl to soong.
Bug: 37512442
Test: it builds
Change-Id: If5bd21af21324e323efe3bc2fd77fe0d23560ea5
2017-05-02 13:43:01 -07:00
Steven Moreland
2cd0d42d72 Remove redundant dependencies
android.hidl.base@1.0 and android.hidl.manager@1.0 are built into libhidltransport.

Test: links
Bug: 33276472
Change-Id: I08aaad80f7e2fc262aa3a8b66fe932e8133a928d
2017-05-02 10:17:28 -07:00
Steven Moreland
d5bf55bd5a Merge changes from topic 'hidl-vendor-available' into oc-dev am: 17f0c0dde7
am: fce6b7f0d9

Change-Id: Ic95bee140e0bbbf094e89dcc7d0d99c30966786c
2017-04-12 22:54:17 +00:00
Steven Moreland
3b36a83a2e Update makefiles (2/2).
Test: pass
Change-Id: Ic7e6289c7b69785491708ce0acbb657f4c704229
2017-04-11 09:58:03 -07:00
Tomasz Wasilczyk
861fc27c48 Merge "Add opaque vendorExension fields to ProgramInfo and Properties structs." 2017-03-31 15:32:55 +00:00