It's reasonable to update the global variable "currentCalls" before
notifying the reader thread. Otherwise this can cause some issues such
as null pointer dereference in other modem.
Bug: 139264227
Test: Don't have devices that uses the corresponding modem that reports
this issues. This is verified according to a partner CL:
https://partner-android-review.googlesource.com/c/platform/hardware/interfaces/+/1422356
Change-Id: Iee9e18149397c39b7c84ec1dc570b9bac7142eb6
Merged-In: Iee9e18149397c39b7c84ec1dc570b9bac7142eb6
(cherry picked from commit fcd55caafd)
After disconnect calls, we want to verify there are no more current calls
by calling IRadio.getCurrenctCalls
Test: run vts
Bug: 138413412
Change-Id: Iacca49abff11fbdfb4ae6dd060a5f150e9e4a74d
Merged-In: Iacca49abff11fbdfb4ae6dd060a5f150e9e4a74d
(cherry picked from commit 5f68117e87)
The whole test case run emergencyDial.RadioHidlTest_v1_4 first and then
come after startNetworkScan.RadioHidlTest_v1_4 test case immediately
(within ~3 secs) the NWscan failure is device in emergency call in
progress/connected while doing emergencyDial.RadioHidlTest_v1_4 test
Although emergencyDial.RadioHidlTest_v1_4 only care about command/response
is successful or not and don't care call is established or not, modem do
care about call condition is in idle/progress/connected state before it
can do NWscan
When there's dedicated channel established, modem can not perform AP
request NWscan in parallel as we are single HW modem restriction.
Test: run vts
Bug: 135595082
Change-Id: Iecba54b93b96d33b57bc59e00f082ff133d2e57b
Merged-In: Iecba54b93b96d33b57bc59e00f082ff133d2e57b
(cherry picked from commit 07a53471c4)
This vts enforce IRadioConfig is existed when IRadio service is supported.
We didn't add IRadioConfigV1.2, so in this test IRadioConfigV1.1 will be
checked.
Bug: 132379735
Test: atest VtsHalRadioV1_4TargetTest
Change-Id: I2062ed6b191193d9a8af4f25059fed6cc8dc09d8
hidl-generated makefiles are now generated such that bpfmt(file) == file.
Bug: 67417008
Test: enable bpfmt hook
Change-Id: I1f69d292bc23a7cc293a66110cb02d597e1019ad
Added cuttlefish support for setDataProfile and
setInitialAttachApn v1.4 support
Test: vts-tradefed run vts -m VtsHalRadioV1_4Target
Bug: 121345833
Change-Id: Ie6acc8756f93ae16963cf9e05e0cf94d9039cb10
Introduction of VTS test cases for setAllowedCarriers_1_4 and
getAllowedCarriers_1_4.
Bug: 124015822
Test: compilation, VTS execution on cuttlefish
Change-Id: Ie1e737d413e6d3559d7a52170bff197eb709c7ca
Modify the document for 'hasKnownUserIntentEmergency'.
In the scenarios that the 'address' in the 'dialInfo' field has other
functions besides the emergency number function, if the
'hasKnownUserIntentEmergency' field is true, the user's intent for this
dial request is emergency call, and the modem must treat this as an
actual emergency dial; if the 'hasKnownUserIntentEmergency' field is
false, Android does not know user's intent for this call.
Test: compile
Bug: 121345950
Change-Id: I3457e7519be564ac5043e06380e9450a1b12425f
(cherry picked from commit 7208840ec0148ad5a01bdf419170282cd1b32437)
Add the NR Cell Identity field to the NrCellIdentity
struct.
Bug: 124126359
Test: compilation on goog/master; VTS currently infeasible
pending other changes.
Change-Id: Ie7082a7dc1737cb613ab178e86016fa0d09c24d3
New tests would be added in cpp files under functional folder. Add a new
folder since it doesn't exist for 1.4 yet.
Test: Compilation
Change-Id: Ieac30bbbc865b76a08d4bdd655f0d489bb7f77bd
Bug: 73784494
The new parameter is to indicate if the request is initiated
by the user through an emergency dialer or shortcut, meaning
that the request is explicitly an emergency dial request.
This is to indicate to the modem that no disambiguation (regarding
whether this is really an emergency request) should
be done for this request.
Test: builds fine
Bug: 123101600
Merged-in: Ic830762d8a8319f494f22d875ca6adad91ffce3b
Change-Id: Ic830762d8a8319f494f22d875ca6adad91ffce3b
(cherry picked from commit 143d32860f)
If 'isTesting' is true, this request is for testing purpose,
and must not be sent to a real emergency service; otherwise it's
a real emergency call request.
Bug: 122840137
Test: Treehugger (VTS later)
Merged-in: I9607967b2a362f72e9d2bcda4ef25afaf0cc7f1d
Change-Id: I9607967b2a362f72e9d2bcda4ef25afaf0cc7f1d
(cherry picked from commit 527d650656)
Clean up some unneeded/confusing error codes in the 1.4 Radio HAL.
Quoting description from aosp/616923:
-Remove SYSTEM_ERROR. This is an ultra-generic error
that also provides no meaningful distinction from
INTERNAL_ERROR but is even less specified in scope.
-Remove NO_MEMORY. This is very implementation
specific, and should be essentially impossible to
hit in the generic sense. Today we don't have a
generic EBUSY error code, which this would map to.
Since it should be essentially impossible to hit,
the preference is to assert that it shouldn't be.
If an implementation really has memory pressure
then it can return INTERNAL_ERROR, of which this
is a class. INTERNAL_ERROR will be treated as a
temporary failure anyway, making NO_MEMORY a
distinction without a difference.
-Remove CANCELLED. We have no way to cancel an API
call. If a persistent/ongoing request is cancelled
by the caller using a separate API request, then
that's a success case rather than an error case.
Bug: 73174777
Change-Id: I5bf268f86ed52e7294f7127f24beba04c9159fea
Test: Compilation
Many of error causes reason are using very esoteric
abbreviations and acronyms. Refine description for making more
clear to the developer.
Bug: 113505704
Test: Build pass and data call can setup normally.
Change-Id: Ifb9c256eef8354add46c76c322cd6a3bd126bd44
Add support for dual SIM to carrier restrictions.
Add support to exclude specific carriers in the list of carrier
restrictions.
Bug: 120313541
Test: Created test application to verify correct functionality.
Change-Id: Ib05267fda5f2fd0b8821a5812fcf47d460e60a2b
Merged-In: Ib05267fda5f2fd0b8821a5812fcf47d460e60a2b
Some countries or carriers require some emergency numbers that must
be handled with normal call routing or emergency routing.
In multi-sim senario, this radio request will be sent through the IRadio
service that serves the subscription the emergency number belongs to,
no matter of the PUK/PIN state of the subscription and the service state.
Test: Treehugger
Bug: 112657134
Change-Id: Iaa9768226dc2d7d2d66a9678823ba7d0047a1988
Merged-In: Iaa9768226dc2d7d2d66a9678823ba7d0047a1988
(cherry picked from commit dd49ad675e)
Currently, most of the fail causes for data connectivity are
exposed as ERROR_UNSPECIFIED. To know the precise fail
cause not just common exception, add more cause definitions
let exact fail reason can pass up to the apps from modem.
Bug: 113505704
Test: Build pass and data call can setup normally.
Change-Id: I1c8b910c272a027c811434d6d034b60ebfd64afa
