When fields are inapplicable, they should not
be set to a clearly out-of-range value to signal
to the framework that those fields are not used.
In some cases, there is an in-range invalid value
that has been defined by the standards. The docs
are inconsistent in calling out INT_MAX as the
value to be used when something is inapplicable
vs the case when a measurement is simply not
reported. In all cases, INT_MAX can be used to
denote an invalid value, and in cases where the
field/structure is inapplicable, it is the correct
value. This CL updates all the docstrings for
SignalStrength-related fields to clarify that
INT_MAX is the correct "invalid" value for cases
when fields are inapplicable.
Bug: 123088652
Test: compilation (docstring-only change); CTS
naturally enforces this change on devices with
newer HALs; backwards compatibility is preserved
for existing HAL versions.
Change-Id: I5cfa917f504d15691ab3f2c298189bdd47794a42
New tests would be added in cpp files under functional folder. Add a new
folder since it doesn't exist for 1.4 yet.
Test: Compilation
Change-Id: Ieac30bbbc865b76a08d4bdd655f0d489bb7f77bd
Bug: 73784494
The new parameter is to indicate if the request is initiated
by the user through an emergency dialer or shortcut, meaning
that the request is explicitly an emergency dial request.
This is to indicate to the modem that no disambiguation (regarding
whether this is really an emergency request) should
be done for this request.
Test: builds fine
Bug: 123101600
Merged-in: Ic830762d8a8319f494f22d875ca6adad91ffce3b
Change-Id: Ic830762d8a8319f494f22d875ca6adad91ffce3b
(cherry picked from commit 143d32860f)
If 'isTesting' is true, this request is for testing purpose,
and must not be sent to a real emergency service; otherwise it's
a real emergency call request.
Bug: 122840137
Test: Treehugger (VTS later)
Merged-in: I9607967b2a362f72e9d2bcda4ef25afaf0cc7f1d
Change-Id: I9607967b2a362f72e9d2bcda4ef25afaf0cc7f1d
(cherry picked from commit 527d650656)
Clean up some unneeded/confusing error codes in the 1.4 Radio HAL.
Quoting description from aosp/616923:
-Remove SYSTEM_ERROR. This is an ultra-generic error
that also provides no meaningful distinction from
INTERNAL_ERROR but is even less specified in scope.
-Remove NO_MEMORY. This is very implementation
specific, and should be essentially impossible to
hit in the generic sense. Today we don't have a
generic EBUSY error code, which this would map to.
Since it should be essentially impossible to hit,
the preference is to assert that it shouldn't be.
If an implementation really has memory pressure
then it can return INTERNAL_ERROR, of which this
is a class. INTERNAL_ERROR will be treated as a
temporary failure anyway, making NO_MEMORY a
distinction without a difference.
-Remove CANCELLED. We have no way to cancel an API
call. If a persistent/ongoing request is cancelled
by the caller using a separate API request, then
that's a success case rather than an error case.
Bug: 73174777
Change-Id: I5bf268f86ed52e7294f7127f24beba04c9159fea
Test: Compilation
Many of error causes reason are using very esoteric
abbreviations and acronyms. Refine description for making more
clear to the developer.
Bug: 113505704
Test: Build pass and data call can setup normally.
Change-Id: Ifb9c256eef8354add46c76c322cd6a3bd126bd44
Add support for dual SIM to carrier restrictions.
Add support to exclude specific carriers in the list of carrier
restrictions.
Bug: 120313541
Test: Created test application to verify correct functionality.
Change-Id: Ib05267fda5f2fd0b8821a5812fcf47d460e60a2b
Merged-In: Ib05267fda5f2fd0b8821a5812fcf47d460e60a2b
setModemsConfig and getModemsConfig APIs will allow the framework
to set the number of live modems to switch to single/multi sim state
Bug: 122073700
Test: vts
Change-Id: Ib200ffa5f2aebe21caf2b761407c79828730e6f1
Merged-In: Ib200ffa5f2aebe21caf2b761407c79828730e6f1
Some countries or carriers require some emergency numbers that must
be handled with normal call routing or emergency routing.
In multi-sim senario, this radio request will be sent through the IRadio
service that serves the subscription the emergency number belongs to,
no matter of the PUK/PIN state of the subscription and the service state.
Test: Treehugger
Bug: 112657134
Change-Id: Iaa9768226dc2d7d2d66a9678823ba7d0047a1988
Merged-In: Iaa9768226dc2d7d2d66a9678823ba7d0047a1988
(cherry picked from commit dd49ad675e)
Currently, most of the fail causes for data connectivity are
exposed as ERROR_UNSPECIFIED. To know the precise fail
cause not just common exception, add more cause definitions
let exact fail reason can pass up to the apps from modem.
Bug: 113505704
Test: Build pass and data call can setup normally.
Change-Id: I1c8b910c272a027c811434d6d034b60ebfd64afa
To better test CBRS, we want IRadio 1.1 to be Android P plus CBRS
HAL interfaces, while 1.2 will be 1.1 plus all other Android Q
interfaces. So we are creating V1_2 folder and moving everything
currently defined in android.hardware.radio.config.V1_1 there.
Bug: 117805040
Test: build and telephony unittest
Change-Id: Ia221258b62351d1190e78fa0e5faafc36163f4a9
Merged-In: Ia221258b62351d1190e78fa0e5faafc36163f4a9
To better test CBRS, we want IRadio 1.3 to be Android P plus CBRS
HAL interfaces, while 1.4 will be 1.3 plus all other Android Q
interfaces. So we are creating V1_4 folder and moving everything
currently defined in android.hardware.radio.V1_3 there.
Part 2: re-create 1.3 folder.
Bug: 117805040
Test: build and telephony unittest
Change-Id: If177cd24d8275e22c18d9b5b907cd65ac13a4461
Merged-In: If177cd24d8275e22c18d9b5b907cd65ac13a4461
To better test CBRS, we want IRadio 1.3 to be Android P plus CBRS
HAL interfaces, while 1.4 will be 1.3 plus all other Android Q
interfaces. So we are creating V1_4 folder and moving everything
currently defined in android.hardware.radio.V1_3 there.
Part 2: move 1.3 to 1.4.
Bug: 117805040
Test: build and telephony unittest
Change-Id: I9fc36f1af0e7cc4d2a5878531aae5746823e1bb4
Merged-In: I9fc36f1af0e7cc4d2a5878531aae5746823e1bb4
These two fields are still needed for some carriers. Should
not be removed in 1.3. Reverted back to what we have in 1.0.
Test: Telephony sanity tests
Bug: 73659459
Change-Id: I33e7b9b0cb26b56fc3c0e011557657136cb38a6c
1. Deprecated the fields 'mvnoType', 'mvnoMatchData', 'maxConnsTime',
and 'maxConns'.
2. Added a new flag 'preferred' indicating if this data profile
is preferred for default data connection setup.
3. Move modemCognative flag from setupDataCall and setInitialAttachApn
into the struct DataProfileInfo and rename it to 'persistent'.
4. Removed isRoaming flag in setupDataCall, setInitialAttachApn, and
setDataProfile.
Test: Telephony sanity tests
Bug: 73659459
Change-Id: Ia28715e85755b47a1ee870b5c90e5505a7fd8c4a
- Add Emergency Number source for Emergency number, which is critical for
management and display priority.
- Remove solicited request for getting emergency number list.
- Rephrasing the documentations.
Test: Treehugger (will add VTS later)
Bug: 112657134
Change-Id: Idbfebf8d246de06fd91e8de89088f5cc2c70227b
The type of mcc and mnc is String instead of Int now. They should be an
empty string if unknown. Also added a test case for their values.
Bug: 111703979
Test: Vts
Change-Id: Ie0426453dc426ccc6cf203b315806e78511ce14d
