Commit graph

1442 commits

Author SHA1 Message Date
Jooyung Han
2dd88e6c8a Explain how to add service_contexts for stable-c mapper
Stable-c mapper instance should be declared in two ways:
- vintf manifest
- service_contexts

The latter part was missing.

Bug: 336010345
Change-Id: I7bd776bf7d943049ef319c90739dae10071409ab
Test: documentation
2024-04-25 18:48:51 +00:00
Hsin-Yi Chen
219876109a Move libimapper_stablec ABI dumps from prebuilts/abi-dumps
The update process for prebuilts/abi-dumps/platform will be adapted for
trunk stable. The ABI dumps for libimapper_stablec are moved to
"abi-dumps" in this project so that the trunk stable release process
will not affect them.

Test: m libimapper_stablec_abicheck
Test: development/vndk/tools/header-checker/utils/create_reference_dumps.py \
      -libs libimapper_stablec_abicheck --lib-variant PLATFORM \
      -ref-dump-dir hardware/interfaces/graphics/mapper/stable-c/abi-dumps \
      -products aosp_arm64
Bug: 333532038
Change-Id: Ia69daa721ef983c18118bd6d0a70dd5b7a0a47a2
2024-04-16 20:21:56 +08:00
Kiyoung Kim
9e9d41d162 Remove VNDK definition(s)
As of VNDK deprecation, any libraries that defines vndk is no longer
valid anymore. This change removes all VNDK definition(s) from modules
which was VNDK.

Bug: 328994089
Test: AOSP CF build succeeded
Change-Id: Ifdade9c052db29c989ce7d804ba725361c4c0f8e
Merged-In: Ic4f19113c1a25dc1fb60cdfbf9c0f2d8d7d09726
2024-04-05 02:29:07 +00:00
Treehugger Robot
2116f9c807 Merge "Fix annotation in doc" into main 2024-03-20 00:41:09 +00:00
Ady Abraham
530024ea4a composer: vts: add support for batched create/destroy layers
Bug: 315517904
Fixes: 329461909
Test: atest VtsHalGraphicsComposer3_TargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a00d246f2725b22d32b2908230de7620238827ba)
Merged-In: Ic3c0415612b1387671ab8efa0ec95ed727f6bf68
Change-Id: Ic3c0415612b1387671ab8efa0ec95ed727f6bf68
2024-03-19 23:11:56 +00:00
John Reck
52414d1c2a Fix annotation in doc
Change-Id: I4fb90e7b30659227263087c85b98db31bb039184
2024-03-14 01:58:19 +00:00
Jooyung Han
c1e4f6ede3 Merge "Use new API to load mapper" into main am: f6b4016c32
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2963302

Change-Id: I62e056a3c0ed6a4ac130fae5c01ee455b0da061e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-14 22:59:48 +00:00
Treehugger Robot
52e9ebfa91 Merge "Use new API to load mapper" into main am: 6a5da15033
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2960862

Change-Id: If9bc9393e42d5af792d04fabda945c2bb1a5a028
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-14 01:32:01 +00:00
Jooyung Han
4784c0b0b3 Use new API to load mapper
AServiceManager_getDeclaredPassthroughHal() can replace
android_load_sphal_library().

Bug: 316051788
Test: VtsHalGraphicsAllocatorAidl_TargetTest
Change-Id: I50021790693c3ec2bce8cb4af96b0d6ee276b2e7
2024-02-14 09:48:00 +09:00
Jooyung Han
0425704133 Use new API to load mapper
AServiceManager_getDeclaredPassthroughHal() can replace
android_load_sphal_library().

Bug: 325018681
Test: VtsHalGraphicsMapperStableC_TargetTest
Change-Id: I004355a9df8bd1ba4f9fb00149d7fddb9ac9f499
2024-02-13 21:37:47 +09:00
Treehugger Robot
74dc4cc5d7 Merge "[DON'T BLOCK] Test ownership migration rules" into main am: 27e97308c4
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2950589

Change-Id: Ie4f36b193820490e606e7f5100ca29200f832fa2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-07 01:45:21 +00:00
Aditya Choudhary
ad2ba1b851 [DON'T BLOCK] Test ownership migration rules
This CL is created as a best effort to migrate test targets
to the new android ownership model. If you find incorrect or unnecessary
attribution in this CL, please create a separate CL to fix that.

For more details please refer to the link below,
go/new-android-ownership-model

Bug: 304529413
Test: N/A
Change-Id: Ic8c4bd6ac246e7efa98bbdaf822d12ae8e1230a5
2024-02-05 15:45:22 +00:00
Aditya Choudhary
85d604d0db [DON'T BLOCK] Test ownership migration rules am: c5c6c62995
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2939799

Change-Id: I1046113ffdcd09649fa65e023aae0969262772e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 17:06:10 +00:00
Aditya Choudhary
c5c6c62995 [DON'T BLOCK] Test ownership migration rules
This CL is created as a best effort to migrate test targets
to the new android ownership model. If you find incorrect or unnecessary
attribution in this CL, please create a separate CL to fix that.

For more details please refer to the link below,
<add g3 doc link>

Bug: 304529413
Test: N/A
Change-Id: I3322344f595f974f730dc824af0110388076d838
2024-01-31 11:06:17 +00:00
Xin Li
763c473c3d Merge Android 24Q1 Release (ab/11220357)
Bug: 319669529
Merged-In: I976f80006aeb88bde2ae34ca4f9be72cea727d9e
Change-Id: Id94b25af52bd2e2847b6858697ab21cc6ce27aa3
2024-01-30 10:36:50 -08:00
Peter Lin
f43004efcf [VTS] Update SetDisplayBrightness test item am: 70d2ef6b34
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2883951

Change-Id: Ia57991b0f949307764afeb9fe9fa58c67740900e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-21 02:13:22 +00:00
Peter Lin
70d2ef6b34 [VTS] Update SetDisplayBrightness test item
Ensure the primary display power on before run the
SetDisplayBrightness test item.

Bug: 313794734
Test: atest VtsHalGraphicsComposer3_TargetTest:PerInstance/
      GraphicsComposerAidlCommandTest#SetDisplayBrightness/
      0_android_hardware_graphics_composer3_IComposer_default
      -- --abi arm64-v8a
Change-Id: I94fb700704bcbd8543f2a608dd75b9e745e40e37
Merged-In: I94fb700704bcbd8543f2a608dd75b9e745e40e37
2023-12-20 06:49:27 +00:00
Ram Indani
730f86fe18 Merge changes from topic "RRN" into main
* changes:
  [Composer3-VTS] Test Composer3-V3 for refreshPeriodNanos and vsyncPeriodNanos
  [HWC3] AIDL change to add refreshPeriodNanos to RefreshRateChangedDebugData
2023-12-13 19:03:18 +00:00
ramindani
a2a6deaf50 [Composer3-VTS] Test Composer3-V3 for refreshPeriodNanos and
vsyncPeriodNanos

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 314527560
Change-Id: If45c0d8c4b61b8c46c1e4336fe261d11414535e5
2023-12-13 01:14:10 +00:00
ramindani
1eb2ecfe4a [HWC3] AIDL change to add refreshPeriodNanos to RefreshRateChangedDebugData
Test: atest VtsHalGraphicsComposer3_TargetTest and device boots
BUG: 314527560
Change-Id: Iaf961ae6ad118c5cd99b07ec133023297dac7040
2023-12-13 01:07:58 +00:00
Manali Bhutiyani
e11bda9789 [aidl] add hwc batching capability
This CL adds the new aidl/apis for HWC command batching feature.

Bug: 290685621
Test: atest VtsHalGraphicsComposer3_TargetTest
      atest PerInstance/GraphicsComposerAidlBatchedCommandTest

Change-Id: Ibccc2cb30954f5d054f8e45e59a0b831fd15a304
2023-12-13 00:27:53 +00:00
Manali Bhutiyani
38565ccd51 [hwc-batching] AIDL changes for HWC command batching support.
This CL adds the new aidl/apis for HWC command batching feature.

Bug: 290685621
Test: atest VtsHalGraphicsComposer3_TargetTest
      atest PerInstance/GraphicsComposerAidlBatchedCommandTest
Change-Id: I9e8a8afefb03e04a4cd4d8db36d72e29d30e975f
2023-12-09 00:25:42 +00:00
Alec Mouri
8695c7bbc4 Merge "Support extended range fp16 ClientTargets in HWC" into main 2023-12-06 01:59:49 +00:00
Jason Macnak
73e5844464 Remove oneway from onHotplugEvent callback
IIUC, oneway makes the callback a non-blocking call. Hwcomposer
implementations are expected to call onHotplug/onHotplugEvent during
the initial hwcomposer->registerCallback(). However, a oneway callback
would not block and cause the hwcomposer's implementation of
registerCallback() to return immediately. Example log:

11-30 23:32:32.962   508   508 E RanchuHwc: registerCallback
11-30 23:32:32.962   508   508 E RanchuHwc: registerCallback:
display:0
11-30 23:32:32.962   508   508 E RanchuHwc: setCallbacks for display:0
11-30 23:32:32.962   508   508 E RanchuHwc: registerCallback:
display:1
11-30 23:32:32.962   508   508 E RanchuHwc: setCallbacks for display:1
11-30 23:32:32.962   508   508 E RanchuHwc: registerCallback initial
registration, hotplug connecting display:0
11-30 23:32:32.962   508   508 E RanchuHwc: registerCallback initial
registration, hotplug connecting display:1
11-30 23:32:32.962   572   592 E SurfaceFlinger: jasonjason
SurfaceFlinger::onComposerHalHotplugEvent()
11-30 23:32:32.962   572   572 F SurfaceFlinger: Initial display
configuration failed: HWC did not hotplug
11-30 23:32:32.962   572   592 E SurfaceFlinger: jasonjason SurfaceFlinger::onComposerHalHotplugEvent()
<SurfaceFlinger aborts from the Fatal "HWC did not hotplug">

Bug: b/314208907
Test: Launch Cuttlefish with ag/25521493 then
      vts -m VtsHalGraphicsComposer3_TargetTest
Change-Id: Ibfea0b21e1d4c8b0de17bbe25dc55483050700b7
2023-12-01 14:29:50 -08:00
Alec Mouri
8062f1feda Support extended range fp16 ClientTargets in HWC
Introduce the concept of hdrSdrRatio for ClientTargets, so that:

* 1.0 is treated as SDR luminance
* hdrSdrRatio is provided to scale the content into display luminance
  range during composition. That is, 1.0 maps to SDR max, and
  hdrSdrRatio maps to display max luminance

Bug: 236745178
Test: builds
Change-Id: Id82a102eaca82f85bf3982538786dd2ae6cb8e61
2023-11-29 17:32:58 +00:00
Huihong Luo
5569efbc00 Add a new API to report display hotplug events
When a display is connected, error may occur, this new api introduces
an event variable to specify the hotplug event, including errors.

This new api should be used, and the old onHotplug method is deprecated.

Bug: 241286153
Test: manual
Change-Id: I20ea685c5012015836024e7cab4dc0e68ebb835f
2023-11-28 11:46:53 -08:00
ramindani
cdcfcafc63 [VTS] Update validateDisplay with frameIntervalNs
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 284845445
Change-Id: I4821a535518b113923fac02adadb3f4867ce922e
2023-11-09 10:01:28 -08:00
ramindani
ac6e50ab4c Update ComposerClientWriter::validateDisplay with frameInterval
BUG: 284845445
Test: Manual test
Change-Id: I2f856ae4acd45cb2a9827c367d2d3185da859b8a
2023-11-07 16:54:04 -08:00
ramindani
72edecff8e Update ComposerClientWriter::presentOrValidate with frameInterval
BUG: 284845445
Test: Manual test
Change-Id: I096ef0d0523cf33a3867030339a18f9421b9ad2b
2023-11-07 16:53:45 -08:00
Treehugger Robot
6cd27b6f2a Merge "Reland "Add a DisplayCapability for multi-threaded present"" into main 2023-10-18 02:21:51 +00:00
Joen Chen
e0a962c8e3 Reland "Add a DisplayCapability for multi-threaded present"
Originally landed as I5dbb01fc23abd5e0108c565f96d25e62c77fc16d and
previously reverted in I6265f8de3db31f07506906cee82a91fe3baac0bc due to
timeline constraints.

Add a test presenting from multiple threads. Split up execute() so that
it can be called for a single display. Update MultiThreadedPresent
(test) to offload presentDisplay to a separate thread, similar to how
Ib9d074671e32c95875ef7e0791dd95d6e595e47a does it, as described in
go/multi-threaded-present.

Bug: 259132483
Bug: 284156408
Fixes: 251842321
Fixes: 295841597
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: If975ee9bb0b9c6f64ef50401e2aee32f934e3f08
2023-10-16 15:23:59 -04:00
Leon Scroggins III
79d7ae8207 Remove deprecated warnings for SKIP_VALIDATE
We deliberately use a deprecated API to test that it is not used. Ignore
warnings from using it in this test.

In PresentDisplayNoLayerStateChanges, remove the check for
SKIP_VALIDATE, removing the other warning. As written, the test would be
skipped without SKIP_VALIDATE support. But devices should *not* claim
Capability::SKIP_VALIDATE, meaning the test would always be skipped. The
docs state that the behavior previously indicated by SKIP_VALIDATE is
now the default, so we should always be running the test.

Bug: NA
Test: atest VtsHalGraphicsComposer3_TargetTest (no warnings)
Change-Id: Icc89a82b4850428c2f0940be0f78f5ebff1881b3
2023-10-12 08:38:12 -04:00
Jason Macnak
cde05dd247 Merge "Ensure AIMapper and underlying IMPL outlive IMapperProvider" into main am: b8c23a8a7d am: 4c11b51986 am: 8dcf909435 am: f5dbe8113a am: ba4b850b8a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2781709

Change-Id: Ie4edc900be0e48bb00e3913ec75456347a58f81a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-11 02:14:30 +00:00
Jason Macnak
8dcf909435 Merge "Ensure AIMapper and underlying IMPL outlive IMapperProvider" into main am: b8c23a8a7d am: 4c11b51986
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2781709

Change-Id: Ie96a5db1377ca841d493b168ffa4c6b2a5c90d8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:31:55 +00:00
Xin Li
11ee4fea87 Merge android14-tests-dev
Bug: 263910020
Merged-In: I770dc5620648df2eab608e030c5e76cf190f315d
Change-Id: If4fe726d538386d70061e8051299d8fb393ef5df
2023-10-10 16:17:14 -07:00
Alec Mouri
b9556b3aba Merge "Start VTS for color management." into main 2023-10-10 20:40:46 +00:00
Jason Macnak
7d201b58fa Ensure AIMapper and underlying IMPL outlive IMapperProvider
... as a

  static vendor::mapper::IMapperProvider<IMPL> provider;

may be destructed during a clean process exit (during __cxa_finalize())
but the underlying IMPL may still be in use on other threads.

Bug: b/304343434
Test: boot Cuttlefish
Change-Id: I80687494c61210d527908b5a67375950ca45c8ea
2023-10-10 11:54:00 -07:00
Sergiu Ferentz
31b637fd90 Merge "Bump android.hardware.graphics.common V4->V5" into main 2023-10-09 08:27:26 +00:00
Sergiu Ferentz
d2075f0d14 Merge "Modifying Dataspace.aidl to add additional HAL_ Datapoints present in graphics/**/swapchain.cpp" into main 2023-10-09 08:27:26 +00:00
Alec Mouri
f6c039a49e Start VTS for color management.
Right now this only makes sure that extended sRGB buffers aren't
corrupted by the time it hits the display. This is especially important
for Ultra HDR, because display compensation is defined by the spec.

Bug: 276331687
Bug: 259144781
Test: VtsHalGraphicsComposer3_ReadbackTest
Change-Id: Ib6c39858289d5559ae76280ca1a0ef756f2daef0
2023-10-06 23:04:15 +00:00
Alec Mouri
3e82b63ae8 Merge "Setting layer brightness doesn't need nit info for readback tests" into stage-aosp-udc-ts-dev am: be23bf4f23 am: 2d96a0a082
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24944166

Change-Id: If96b68cdef28070dba0a446b57bea4581e1b3b40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 20:41:40 +00:00
Alec Mouri
a47d46affb Setting layer brightness doesn't need nit info for readback tests
The nit information was used when we set exact nit values rather than a
relative brightness per layer. But we only need nit values for the
renderengine interface, which isn't tied to any hwc or panel
capabilities.

Bug: 301261125
Test: VtsHalGraphicsComposer3_TargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:712b3d9880b6aff51ab17d539bfcbdf3785cc6ca)
Merged-In: I770dc5620648df2eab608e030c5e76cf190f315d
Change-Id: I770dc5620648df2eab608e030c5e76cf190f315d
2023-10-04 21:14:06 +00:00
sergiuferentz
14960cae33 Modifying Dataspace.aidl to add additional HAL_ Datapoints present in graphics/**/swapchain.cpp
Bug: 291142745
Change-Id: I54a41f3170b6c21f1c1b12aec40a8ce928f9163f
2023-10-03 16:14:06 +00:00
sergiuferentz
7d7a24d5f6 Bump android.hardware.graphics.common V4->V5
Test: Build
Bug: 291142745
Change-Id: Ib0002feb982ffcc37fa7b69493c644b7a835cf4f
2023-10-03 16:14:03 +00:00
Alec Mouri
712b3d9880 Setting layer brightness doesn't need nit info for readback tests
The nit information was used when we set exact nit values rather than a
relative brightness per layer. But we only need nit values for the
renderengine interface, which isn't tied to any hwc or panel
capabilities.

Bug: 301261125
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: I770dc5620648df2eab608e030c5e76cf190f315d
2023-09-29 00:21:37 +00:00
Treehugger Robot
83dd5881a0 Merge "Add deprecation note" into main 2023-09-07 20:15:54 +00:00
Treehugger Robot
cb0d2eb323 Merge "Revert "[Composer AIDL] Rename notifyExpectedPresentTimeoutNs and"" into main 2023-09-01 23:58:48 +00:00
John Reck
89b26e7623 Add deprecation note
Flag: DOCS_ONLY
Test: doc-only && make
Change-Id: I16638c3772269e4946a002a7e821735423df5084
2023-09-01 16:32:53 -04:00
Ram Indani
82426a4a40 Revert "[Composer AIDL] Rename notifyExpectedPresentTimeoutNs and"
This reverts commit f850701be0.

Reason for revert: Delaying rename to avoid churn for external partner work.

Change-Id: If96786d074a61ac0f781540e98d020a6f7fd673b
2023-09-01 20:02:50 +00:00
Treehugger Robot
7445bd7b80 Merge "Clarify GPU API requirements for BufferUsage" into main 2023-09-01 16:13:38 +00:00