Commit graph

1624 commits

Author SHA1 Message Date
Yu Shan
7502bc52b8 Merge changes I35f4860e,I4f02885b into main am: e2e4e54a0a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3096235

Change-Id: Ie659c0ee8001e931e45744b5edbd6cf9a647a526
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-24 23:18:52 +00:00
Yu Shan
89ab8c7623 Add subscribe to VHAL proto. am: 5c846f7cc9
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3096234

Change-Id: I69fa802d59a0b5ac45bb8a5e541a9ef7a8d43fc2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-24 23:18:45 +00:00
Xin Li
64e598ce2b Merge Android 24Q2 Release (ab/11526283) to aosp-main-future
Bug: 337098550
Merged-In: I53a278f1317f5307441103dc42dc5be6f20d7075
Change-Id: I3a53ebf7339cdb886d3c1b733b8eee1847f8832a
2024-05-24 08:28:04 -07:00
Yu Shan
5c846f7cc9 Add subscribe to VHAL proto.
The latest IVehicleHardware adds Subscribe/Unsubscribe function
to replace the existing updateSampleRate. This CL adds the
Subscribe function to protobuf definition and implements it.

Test: atest GRPCVehicleHardwareUnitTest GRPCVehicleProxyServerUnitTest
Flag: EXEMPT hal change
Bug: 328316981
Merged-In: I4f02885b77f21a215a8b282be583f76118e400ba
(cherry-picked from commit: f1a869055f)

Change-Id: I4f02885b77f21a215a8b282be583f76118e400ba
2024-05-23 15:51:25 -07:00
Yu Shan
2c37c11a82 Implement Unsubscribe in vhal proxy.
Implement the unsubscribe function in IVehicleHardware. This will
stop the server from generating property update events for the
specified [propId, areaId].

Test: atest GRPCVehicleHardwareUnitTest GRPCVehicleProxyServerUnitTest
Flag: EXEMPT hal change
Bug: 328316981
Merged-In: I35f4860eead0c8ec9b192657fe51cc0ff4319383
(cherry-picked from commit: cb00b1f816)

Change-Id: I35f4860eead0c8ec9b192657fe51cc0ff4319383
2024-05-23 15:51:25 -07:00
Yu Shan
e56e2981cd Add host prebuilt for fake VHAL config.
Test: Local build
Bug: 328316981
Flag: EXEMPT build rule
Merged-In: I965e704e29e62cd05540f46ef37d0bfa2a5568db
(cherry-picked from commit: 1c670114fd)

Change-Id: I965e704e29e62cd05540f46ef37d0bfa2a5568db
2024-05-21 13:52:23 -07:00
Yu Shan
02e4d07563 Add require_root to FakeVehicleHardwareTest.
According to b/329690075, vendor tests need root to use vendor
lib, otherwise atest will cause link error.

Test: atest FakeVehicleHardwareTest on cf_auto
Flag: EXEMPT bug
Bug: 341762230
Merged-In: I6bab19b20e6fe91dbdb2a6526172a5dd1d092ff5
(cherry-picked from commit: f01c7aec0d)

Change-Id: I6bab19b20e6fe91dbdb2a6526172a5dd1d092ff5
2024-05-21 13:52:23 -07:00
Yu Shan
0c447863ef Add host_supported to VHAL libs.
We need to build a FakeVehicleHardware impl on host, thus we need
to add the host_supported option.

Test: Local build on host.
Bug: 328316981
Flag: EXEMPT hal change
Merged-In: Ia21d26640c465846423cab1a0ff8a283c798b92a
(cherry-picked from commit: 9d3513882a)

Change-Id: Ia21d26640c465846423cab1a0ff8a283c798b92a
2024-05-21 13:51:39 -07:00
Yu Shan
fe49375ba9 Initialize mAddExtraTestVendorConfigs to false.
If we do not init, the initial value is undefined.

Test: Local run
Bug: 340947823
Flag: EXEMPT bugfix
Change-Id: I18a3688a446dd969545e1fc2cb5f63210c3c02cd
Merged-In: I18a3688a446dd969545e1fc2cb5f63210c3c02cd
2024-05-17 18:01:29 -07:00
Julie Pan
30da02f704 Merge "Remove chenhaosjtuacm@google.com from automotive/vehicle/OWNERS" into main 2024-04-22 16:19:11 +00:00
Ronish Kalia
98ef872235 Merge "Migrate Test Targets to New Android Ownership Model" into main 2024-04-22 15:01:56 +00:00
Owner Cleanup Bot
e8c0492a32 Remove chenhaosjtuacm@google.com from automotive/vehicle/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote CR -1 and the bot
will abandon it. Vote CR +1/2 to approve this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/chenhaosjtuacm@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I2d5fc15775dbf816c787795934438cbde46b178b
2024-04-16 17:41:30 +00:00
Felix Obenhuber
38f12da7b8 automotive aidl: Add required @RustDerive annotations
Derive vehicle hal parcelables from the Clone trait where applicable. This is is
supportive for implementing a vehicle hal service in Rust because caching e.g
VehiclePropValue or VehiclePropConfig instances allow less verbose code and
increase performance. Cloning a VehiclePropConfig instead of constructing each
time needed is less verbose. Property configs are normally not updated at
runtime.

This is not an API change, so in order to avoid having to bump the AIDL
API version for this HAL we used the hash_gen.sh script as below:

$ m android.hardware.automotive.vehicle-update-api
$ m android.hardware.automotive.vehicle-freeze-api

$ vim vehicle/aidl/Android.bp # removed frozen_api argument and the newly
created version 3 block

$ cp -r aidl_api/android.hardware.automotive.vehicle/3/* aidl_api/android.hardware.automotive.vehicle/2/
$ rm -rf aidl_api/android.hardware.automotive.vehicle/3/

./system/tools/aidl/build/hash_gen.sh \
    hardware/interfaces/automotive/vehicle/aidl/aidl_api/android.hardware.automotive.vehicle/2 \
    1 \
    hardware/interfaces/automotive/vehicle/aidl/aidl_api/android.hardware.automotive.vehicle/2/.hash

Test: manual - used new derives in custom implementation
Change-Id: I586b89b160eb7a01ce24fad211b9e909175cdd3c
Merged-In: I889c0d51f2c2633908231dd39c9ea5259de36667
2024-03-14 01:29:28 +00:00
Liana Kazanova
73c85334bd Merge "Revert "Change HVAC_MAX_DEFROST_ON to front and back row area IDs"" into main 2024-03-01 19:50:58 +00:00
Liana Kazanova
0a36f19c73 Revert "Change HVAC_MAX_DEFROST_ON to front and back row area IDs"
This reverts commit 21999ff48c.

Reason for revert: DroidMonitor: Potential culprit for b/327699697 - verifying through ABTD before revert submission. 

Change-Id: I53a278f1317f5307441103dc42dc5be6f20d7075
2024-03-01 19:08:25 +00:00
Treehugger Robot
57a4b047e2 Merge changes I1320c57d,I9b878369 into main
* changes:
  Fill in the missing status field.
  Update client-side remote access test script.
2024-03-01 05:01:42 +00:00
Yu Shan
c2b9eaa4e7 Fill in the missing status field.
Fill in the missing status field for VEHICLE_IN_USE and
AP_POWER_BOOTUP_REASON property.

Test: Presubmit
Bug: 327640442
Change-Id: I1320c57da5ec4c7910676a234b9c7bc0d3b6e3ea
2024-02-29 18:42:44 -08:00
Aaqib Ismail
21999ff48c Change HVAC_MAX_DEFROST_ON to front and back row area IDs
This helps standardize commands sent by Assistant for using the
defroster.

Bug: 323101580
Test: m
Change-Id: I006ca7fc779e011a3d3be8cac95fe34a3567d4b2
2024-02-29 13:08:55 -08:00
Devin Moore
9eec1433fa Merge "Vendor API level 202404 is now frozen" into main 2024-02-29 17:14:40 +00:00
Yu Shan
1bf90fa404 Fix a bug in VUR VTS test.
The logic is to check whether each element is not the same as
previous element. We forgot to increase i.

Test: Presubmit
Bug: 326987403
Change-Id: I5cab61a86092fb14d17551a533e8cdaff1abfee5
2024-02-26 11:25:36 -08:00
Yu Shan
13a8745385 Merge "Add VTS for VUR." into main 2024-02-23 21:38:09 +00:00
Shrikar Amirisetty
bb81704eba Merge changes If53c6395,I972b7f0c into main
* changes:
  Added resolution check in DefaultVehicleHal
  Added resolution to SubscriptionManager in reference VHAL
2024-02-22 21:52:32 +00:00
Yu Shan
a9cbdea48b Add VTS for VUR.
Add VTS for testing subscription with variable update rate on.

Test: atest VtsHalAutomotiveVehicle_TargetTest on reference VHAL.
Bug: 323073584
Change-Id: I3c8f4e87ee11487466a1b75ae611cb58f84d8ef5
2024-02-22 11:17:14 -08:00
Tyler Trephan
1519c7baa0 Merge "Generated UnitsForVehicleProperty.java from VehicleProeprty.aidl" into main 2024-02-22 16:00:34 +00:00
Yu Shan
2385eb0484 Merge changes from topic "vhal_grpc" into main
* changes:
  Use runtime config file instead of compile flag.
  Move FakeVehicleHardwareUnitTest to auto-presumbmit.
  Support Enter Garage Mode in remote access HAL.
2024-02-22 01:45:09 +00:00
Yu Shan
e0ed350875 Use runtime config file instead of compile flag.
Use runtime config file instead of compile flag to control an
optional external grpc server address. This allows us to test
connecting with an external simluated power unit without recompiling
the image.

Test: Manual test with push the config file at
/vendor/etc/automotive/powercontroller/serverconfig
Bug: 325675883

Change-Id: I04193e7603a670c8398c6d6dc0466a0071f7c33d
2024-02-21 14:37:18 -08:00
Yu Shan
4cc6345c6c Move FakeVehicleHardwareUnitTest to auto-presumbmit.
It depends on libgrpc++ which is not present on some cf target
system images.

Test: Presubmit
Bug: 316233421
Change-Id: I6fe76fff7fc4cab85ebe2bb50b6233cb71d33605
2024-02-21 14:36:26 -08:00
Yu Shan
9f982fb815 Support Enter Garage Mode in remote access HAL.
Handles task type in reference remote access HAL and passes to
remote access server through GRPC.

Update host-side TestWakeupClientService to handle vehicleInUse
and ApPowerBootupReason VHAL properties.

Update reference VHAL to get the property values rom a remote grpc
server.

Test: atest --host TestWakeupClientServiceImplUnitTest
Manual run TestWakeupClientServerHost verifies that reference
VHAL can get power properties.
Bug: 316233421

Change-Id: I188aa9eed2dedb3b81b4eb6f5685ca33b646b2f5
2024-02-21 12:03:52 -08:00
shrikar
cb59b0522b Added resolution check in DefaultVehicleHal
Bug: 276124296
Test: atest DefaultVehicleHalTest
Change-Id: If53c6395a8ea9656e6b59a43872a0d9f6871dac5
2024-02-21 01:17:22 +00:00
shrikar
67c465f7fe Added resolution to SubscriptionManager in reference VHAL
Bug: 276124296
Test: atest DefaultVehicleHalTest
Change-Id: I972b7f0c04953b390f642317c491f3f99e045045
2024-02-21 01:16:56 +00:00
Devin Moore
a8efdb127e Vendor API level 202404 is now frozen
Ignore-AOSP-First: VINTF 202404 Finalization
Bug: 279809333
Test: build
Change-Id: Ie6d38d27a287e258c30516e0030ad8c931d06432
2024-02-20 21:05:23 +00:00
Yu Shan
e6dc7d249b Merge "Populate both VehiclePropConfig and VehicleAreaConfig.access" into main 2024-02-20 18:58:51 +00:00
Tyler Trephan
c8a50dec9a Generated UnitsForVehicleProperty.java from VehicleProeprty.aidl
Test: None
Bug: 319307524
Change-Id: I27d680b8d8a673e70224703bc18c7dff5113f2d3
2024-02-20 04:57:04 +00:00
shrikar
127dc87b2f Populate both VehiclePropConfig and VehicleAreaConfig.access
Bug: 323122049
Test: atest JsonConfigLoaderTest VtsHalAutomotiveVehicle_TargetTest
Change-Id: I398b136e705df805c25d541f7721f36c47813273
2024-02-16 23:30:07 +00:00
Changyeon Jo
7cc8453ed4 Introduce CAMERA_SERVICE_CURRENT_STATE VHAL property
CarEvsService shares state changes of its service types via this new
VHAL property.

Bug: 325317031
Test: atest VtsHalAutomotiveVehicle_TargetTest
Change-Id: I50f8523aea6a2b5ccb55db9ca620e64e1cada8ee
2024-02-15 08:37:42 -08:00
Aditya Choudhary
04ef2121cd Migrate Test Targets to New Android Ownership Model
This CL is created as a best effort to migrate test targets to the new Android ownership model.
It is based on historical data from repository history and insights from git blame.
Given the nature of this effort, there may be instances of incorrect attribution. If you find incorrect or unnecessary
attribution in this CL, please create a new CL to fix that.

For detailed guidelines and further information on the migration please refer to the link below,
go/new-android-ownership-model

Bug: 304529413
Test: N/A
Change-Id: Ibe1360ca3f7eb919834715aa90b0b842fbcd0692
2024-02-02 14:00:43 +00:00
Yu Shan
9540e47340 Create EmuMetadataGenerator to check meta.json.
Create EmuMetadataGenerator to convert AIDL generated java files
to meta.json that can be used by emulator to populate the available
vhal props list.

Added build rules to generate the Java files from AIDL files and
check whether the meta.json file needs to be updated.

Test: make sdk_car_x86_64-trunk_staging-userdebug target
Bug: 318747444
Change-Id: Ib3bc7b68a1312152617fdab4598ed389447c20cd
Merged-In: Ib3bc7b68a1312152617fdab4598ed389447c20cd
2024-02-01 00:03:59 +00:00
Yu Shan
493a0cddb3 Create EmuMetadataGenerator to check meta.json.
Create EmuMetadataGenerator to convert AIDL generated java files
to meta.json that can be used by emulator to populate the available
vhal props list.

Added build rules to generate the Java files from AIDL files and
check whether the meta.json file needs to be updated.

Test: make sdk_car_x86_64-trunk_staging-userdebug target
Bug: 318747444
Change-Id: Ib3bc7b68a1312152617fdab4598ed389447c20cd
2024-01-31 14:32:23 -08:00
Yu Shan
9fbf4066cb Merge "Add retry in setProp test." into android14-tests-dev am: 2c12f0e9ae am: 83a9e12f6d
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2934133

Change-Id: I2c79c14e22d42e783c113b9c6604af5b9c0718f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 03:06:01 +00:00
Yu Shan
83a9e12f6d Merge "Add retry in setProp test." into android14-tests-dev am: 2c12f0e9ae
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2934133

Change-Id: I0639e2f1bc6152c37e7fc6fac76d271871195b32
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 02:21:18 +00:00
Yu Shan
2c12f0e9ae Merge "Add retry in setProp test." into android14-tests-dev 2024-01-31 01:40:17 +00:00
Shrikar Amirisetty
0cac55bd8d Merge "Updated JsonConfigLoader to parse access for area configs" into main 2024-01-31 00:00:50 +00:00
Xin Li
757e0a265f Merge "Merge Android 24Q1 Release (ab/11220357)" into aosp-main-future 2024-01-30 22:44:06 +00:00
Xin Li
763c473c3d Merge Android 24Q1 Release (ab/11220357)
Bug: 319669529
Merged-In: I976f80006aeb88bde2ae34ca4f9be72cea727d9e
Change-Id: Id94b25af52bd2e2847b6858697ab21cc6ce27aa3
2024-01-30 10:36:50 -08:00
Yu Shan
ec8db77066 Fix HIDL VHAL descriptor name in VTS. am: 928062ccac am: 8cda776ffe
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2928798

Change-Id: I7662938de3cdccbdedf1ef60f36dce21225332c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-30 18:11:52 +00:00
Yu Shan
8cda776ffe Fix HIDL VHAL descriptor name in VTS. am: 928062ccac
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2928798

Change-Id: I6f7dd76ee3c813194085f131fe495e8f60492f7c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-30 18:09:37 +00:00
Yu Shan
1837df06c2 Add retry in setProp test.
Set property operation is async so getting the property value
immediately after setting the property might not return the new
value. This CL adds the logic to retry when we do not get the
expected values back.

This CL also skips the test case if getting property or setting
property returns unavailable.

Test: atest VtsHalAutomotiveVehicle_TargetTest
Bug: 322070490
Change-Id: If9349a097a92c51101c7b5f4bf807b610ab2cb0b
Merged-In: If9349a097a92c51101c7b5f4bf807b610ab2cb0b
2024-01-29 22:50:49 +00:00
Yu Shan
928062ccac Fix HIDL VHAL descriptor name in VTS.
Bug: 322418005
Test: Manual test with HIDL VHAL, VTS pass.
Change-Id: I93e92d3587243c44b5651ab85d47442ebb64c51a
Merged-In: I93e92d3587243c44b5651ab85d47442ebb64c51a
2024-01-27 02:28:25 +00:00
Yu Shan
da2fa0929f Fix HIDL VHAL descriptor name in VTS.
Bug: 322418005
Test: Manual test with HIDL VHAL, VTS pass.
Change-Id: I93e92d3587243c44b5651ab85d47442ebb64c51a
2024-01-26 18:26:40 -08:00
Yu Shan
97770cf39c Fix property unavailable check logic.
Test: Presubmit
Bug: 322070490
Change-Id: Ifd97370a5dd71ace57791c0287bea0bb8c912c29
2024-01-26 18:25:26 -08:00