android-build-team Robot
2b995cef9d
Snap for 6437181 from bed9ac393e
to mainline-release
...
Change-Id: I549816ccb30e31f115edcd3073e2410fea3f3260
2020-04-28 07:13:04 +00:00
TreeHugger Robot
bed9ac393e
Merge "Convert vts configs to Android.bp" into rvc-dev am: 19685064b9
am: 66623c0132
am: eb047fdc33
...
Change-Id: I5f399c30cdc83174cedc2df76522938f96b343bf
2020-04-27 17:39:00 +00:00
TreeHugger Robot
eb047fdc33
Merge "Convert vts configs to Android.bp" into rvc-dev am: 19685064b9
am: 66623c0132
...
Change-Id: I992ff8c609b4072d38d850d4ef47b15b42b7a017
2020-04-27 17:29:35 +00:00
TreeHugger Robot
66623c0132
Merge "Convert vts configs to Android.bp" into rvc-dev am: 19685064b9
...
Change-Id: I5269acb6dd9c1be1183de67f28b3ef524377cb22
2020-04-27 17:14:01 +00:00
TreeHugger Robot
19685064b9
Merge "Convert vts configs to Android.bp" into rvc-dev
2020-04-27 17:05:10 +00:00
TreeHugger Robot
91f611c3f2
Merge changes I25df8eec,I493ff192 into rvc-dev am: 312bc65194
am: dce69882f5
am: 7b4e4bdf06
...
Change-Id: Ifa36e6082db4a248a509d6b3d28d2d9b386dd273
2020-04-27 16:55:17 +00:00
Maciej Żenczykowski
a69baf8b6a
expected.h - fix bugprone-forwarding-reference-overload warnings am: 62ae965b0a
am: 58d21b2a70
am: 679bd9810c
...
Change-Id: Id2f88a15af525d42134f74e1bdaf5b2fd6e4c03d
2020-04-27 16:55:15 +00:00
TreeHugger Robot
7b4e4bdf06
Merge changes I25df8eec,I493ff192 into rvc-dev am: 312bc65194
am: dce69882f5
...
Change-Id: Ia3b8318a158185d62837f371c365d07ed39fb9bc
2020-04-27 16:38:10 +00:00
Maciej Żenczykowski
679bd9810c
expected.h - fix bugprone-forwarding-reference-overload warnings am: 62ae965b0a
am: 58d21b2a70
...
Change-Id: I33eea8c97909e9ff4a8f2b8d89d3648598d8fc96
2020-04-27 16:38:06 +00:00
Automerger Merge Worker
cb02c1f825
Convert vts configs to Android.bp
...
Bug: 154727600
Test: treehugger
Change-Id: Ibe8ed03555ac78ee38be6511eb4169cddfcd3555
Merged-In: Ibe8ed03555ac78ee38be6511eb4169cddfcd3555
2020-04-27 16:36:53 +00:00
TreeHugger Robot
dce69882f5
Merge changes I25df8eec,I493ff192 into rvc-dev am: 312bc65194
...
Change-Id: I3ffd400a856a71ee3e90c3c749b40eb285a98184
2020-04-27 16:24:12 +00:00
Maciej Żenczykowski
58d21b2a70
expected.h - fix bugprone-forwarding-reference-overload warnings am: 62ae965b0a
...
Change-Id: I83ccc2f184efc9773be9520ce1557e22a2e9552b
2020-04-27 16:24:10 +00:00
TreeHugger Robot
312bc65194
Merge changes I25df8eec,I493ff192 into rvc-dev
...
* changes:
result.h - fix bugprone-suspicious-semicolon warning
expected.h - fix bugprone-forwarding-reference-overload warnings
2020-04-27 16:13:12 +00:00
android-build-team Robot
65abf25bfe
Snap for 6431658 from 39fd2266b3
to mainline-release
...
Change-Id: Ia28b325cba3673278cf6d2aa57e674f9f0dde26d
2020-04-26 07:10:20 +00:00
Maciej Żenczykowski
c708c3fa37
result.h - fix bugprone-suspicious-semicolon warning
...
Fixes:
system/core/base/include/android-base/result.h:
133:94: warning: potentially unintended semicolon [bugprone-suspicious-semicolon]
Bernie says:
it probably means that there's a parser bug with "if constexpr"
maybe, at static analysis pass, the "if constexpr" was evaluated to false,
and the compiler removed the "then" block from the AST...
... and then it thought you had written it that way :-)
https://reviews.llvm.org/D46027
Test: builds
Bug: 153035880
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I25df8eeca4ec06b3180c1cd21b554fc583c5581a
Merged-In: I25df8eeca4ec06b3180c1cd21b554fc583c5581a
2020-04-24 17:32:00 -07:00
Maciej Żenczykowski
62ae965b0a
expected.h - fix bugprone-forwarding-reference-overload warnings
...
Fixes:
system/core/base/include/android-base/expected.h:
186:13: warning: constructor accepting a forwarding reference can hide the copy and move constructors [bugprone-forwarding-reference-overload]
195:22: warning: constructor accepting a forwarding reference can hide the copy and move constructors [bugprone-forwarding-reference-overload]
611:13: warning: constructor accepting a forwarding reference can hide the copy and move constructors [bugprone-forwarding-reference-overload]
To quote Tom Cherry:
I'm a bit confused at what's happening there.
I think it's a bug in the linter itself.
The general solution to that problem is a heavy dose of std::enable_if<>
to hide that constructor when the 'U' parameter is the same class,
but those constructors do have the necessarily std::enable_if<> lines.
I think the problem is that the linter doesn't check that the macro
_ENABLE_IF() expands into std::enable_if<>. Let me try explicitly
putting the std::enable_if<> instead of the macro and check if it
goes away.
I expanded the macro but the linter doesn't still doesn't accept
the format of `std::enable_if_t<(condition_here)>* = nullptr`.
It does accept `typename Enable = std::enable_if_t<(condition_here), void>`,
which is the syntax used on their example here:
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-forwarding-reference-overload.html .
That latter syntax doesn't work for us.
See the Notes section on
https://en.cppreference.com/w/cpp/types/enable_if
as a reference for why what we're doing is correct.
Test: builds
Bug: 153035880
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I493ff19208cc104f5f176a36ec23fbcb914388f7
Merged-In: I493ff19208cc104f5f176a36ec23fbcb914388f7
2020-04-24 17:31:52 -07:00
Nikita Ioffe
39fd2266b3
Merge "Make /data/apex/active world readable" into rvc-dev am: e343f439a3
am: 7108b04f6d
am: 88f5d8ddcc
...
Change-Id: I04c639966c2d0614424817ca2323c0cfea32ec21
2020-04-24 22:33:31 +00:00
Nikita Ioffe
88f5d8ddcc
Merge "Make /data/apex/active world readable" into rvc-dev am: e343f439a3
am: 7108b04f6d
...
Change-Id: I1a86a7b735004af50920630efdd6bf6d2d7d4b70
2020-04-24 22:15:51 +00:00
Nikita Ioffe
7108b04f6d
Merge "Make /data/apex/active world readable" into rvc-dev am: e343f439a3
...
Change-Id: I3fd0f8c8e05b97dedc0cab1f1907adb853432d4b
2020-04-24 21:59:20 +00:00
Jeffrey Huang
a0d9a41b23
Add require root to libstats tests am: 18d239c5c5
am: 102c02a680
am: e713976f08
...
Change-Id: Ic9978a425a766f52296f4dcb74dc9f6adeb24ba8
2020-04-24 21:52:48 +00:00
Nikita Ioffe
e343f439a3
Merge "Make /data/apex/active world readable" into rvc-dev
2020-04-24 21:44:40 +00:00
Jeffrey Huang
e713976f08
Add require root to libstats tests am: 18d239c5c5
am: 102c02a680
...
Change-Id: Ic6734da91b9fb6ed7c5cfa38a785e08f83b30bf5
2020-04-24 21:38:02 +00:00
Jeffrey Huang
102c02a680
Add require root to libstats tests am: 18d239c5c5
...
Change-Id: If52aa108ae7c7824e42a531caf09279bbb13c1a1
2020-04-24 21:31:36 +00:00
Jeffrey Huang
18d239c5c5
Add require root to libstats tests
...
root is required for coverage tests
Bug: 154652564
Test: m -j
Change-Id: I3325565818a275a069aed35a34bf3a58ee4b5bfc
2020-04-24 10:44:25 -07:00
android-build-team Robot
c9591b5dc4
Snap for 6425864 from 13a209e355
to mainline-release
...
Change-Id: I28fd8866116c2c8b139871e3a46097aad025ce75
2020-04-24 07:03:59 +00:00
TreeHugger Robot
13a209e355
Merge "expected.h - fix bugprone-branch-clone warning" into rvc-dev am: 61e2b0104a
am: 4979a4aff8
am: 1e7aa96888
...
Change-Id: I275c6c7b755122a52b79b235d92fa5d04412b7d8
2020-04-24 03:28:29 +00:00
TreeHugger Robot
1e7aa96888
Merge "expected.h - fix bugprone-branch-clone warning" into rvc-dev am: 61e2b0104a
am: 4979a4aff8
...
Change-Id: Ice34c85ef47aeb1769692b19f925bb889f1b77a1
2020-04-24 03:10:06 +00:00
TreeHugger Robot
4979a4aff8
Merge "expected.h - fix bugprone-branch-clone warning" into rvc-dev am: 61e2b0104a
...
Change-Id: I2f08ff00903b78a20309f52b880283310926e485
2020-04-24 02:59:36 +00:00
TreeHugger Robot
61e2b0104a
Merge "expected.h - fix bugprone-branch-clone warning" into rvc-dev
2020-04-24 02:39:42 +00:00
Ytai Ben-tsvi
2d496503cb
Merge "Control audio HAL services in start/stop" into rvc-dev am: a6f8993f8b
am: bba9c37803
am: 2c9abb7530
...
Change-Id: I5b0e737afeb21cc8f275a48d9e639192b5eff224
2020-04-24 00:58:14 +00:00
Ytai Ben-tsvi
2c9abb7530
Merge "Control audio HAL services in start/stop" into rvc-dev am: a6f8993f8b
am: bba9c37803
...
Change-Id: I1005584361f99c66fded3746aa7306fe07e34010
2020-04-24 00:50:36 +00:00
Jeffrey Huang
39653eb268
Merge "Tag libstatspull and libstatssocket tests as MTS" into rvc-dev am: 6d99e68e74
am: 7d9a17ef98
am: 69c166e281
...
Change-Id: Ib018dab09ff4d02c55d96290920700dc07678c8b
2020-04-24 00:50:27 +00:00
Ytai Ben-tsvi
bba9c37803
Merge "Control audio HAL services in start/stop" into rvc-dev am: a6f8993f8b
...
Change-Id: I5a4b5b316d1b300392ce8d11cf072aa09d40591b
2020-04-24 00:39:34 +00:00
Jeffrey Huang
69c166e281
Merge "Tag libstatspull and libstatssocket tests as MTS" into rvc-dev am: 6d99e68e74
am: 7d9a17ef98
...
Change-Id: I6c43eebc52eedc265cc836bc2cea30394b1d5e1b
2020-04-24 00:32:53 +00:00
Ytai Ben-tsvi
a6f8993f8b
Merge "Control audio HAL services in start/stop" into rvc-dev
2020-04-24 00:30:36 +00:00
Treehugger Robot
ffaa7d6751
expected.h - fix bugprone-branch-clone warning
...
Fixes:
system/core/base/include/android-base/expected.h:606:39: warning: repeated branch in conditional chain [bugprone-branch-clone]
if (x.has_value() != y.has_value()) {
^
system/core/base/include/android-base/expected.h:608:4: note: end of the original
} else if (!x.has_value()) {
^
system/core/base/include/android-base/expected.h:610:10: note: clone 1 starts here
} else {
^
Test: builds
Bug: 153035880
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Ie67a8bb1bf622319adea15466c42077e0e9b1a18
Merged-In: Ie67a8bb1bf622319adea15466c42077e0e9b1a18
2020-04-24 00:24:38 +00:00
Jeffrey Huang
7d9a17ef98
Merge "Tag libstatspull and libstatssocket tests as MTS" into rvc-dev am: 6d99e68e74
...
Change-Id: I1c26776dc8e700e5b651ce11fa5c87ca1b9c2026
2020-04-24 00:19:55 +00:00
Jeffrey Huang
6d99e68e74
Merge "Tag libstatspull and libstatssocket tests as MTS" into rvc-dev
2020-04-23 23:55:31 +00:00
TreeHugger Robot
27eff567b7
Merge "logcatd: unset pinning log files" into rvc-dev am: 04083e2ba8
am: 0561cefc44
am: ead6029693
...
Change-Id: Icf21c968bf9b61bc7bb545cc5dea42235c758227
2020-04-23 23:27:43 +00:00
TreeHugger Robot
ead6029693
Merge "logcatd: unset pinning log files" into rvc-dev am: 04083e2ba8
am: 0561cefc44
...
Change-Id: I9f7f327fd8f0791be62db198337c128b80cc8344
2020-04-23 23:18:23 +00:00
TreeHugger Robot
0561cefc44
Merge "logcatd: unset pinning log files" into rvc-dev am: 04083e2ba8
...
Change-Id: I141461ab6ac7a2173616a5f65132a76450bde726
2020-04-23 23:04:22 +00:00
TreeHugger Robot
04083e2ba8
Merge "logcatd: unset pinning log files" into rvc-dev
2020-04-23 22:52:26 +00:00
Tom Cherry
4cbe11759b
Merge "Remove thread safety from libbase logging / liblog" into rvc-dev am: c53c64c0ec
am: 01cd4c654a
am: 7a05330c37
...
Change-Id: Ief85e6bf0ae772978bd721ddda241cee63e746ba
2020-04-23 22:19:41 +00:00
Tom Cherry
7a05330c37
Merge "Remove thread safety from libbase logging / liblog" into rvc-dev am: c53c64c0ec
am: 01cd4c654a
...
Change-Id: I3e217bf888f8f6003f5447d941a20f1cba811573
2020-04-23 22:03:34 +00:00
Tom Cherry
01cd4c654a
Merge "Remove thread safety from libbase logging / liblog" into rvc-dev am: c53c64c0ec
...
Change-Id: Ifeb3482fa4da475b49093e48a25427d5c82d80cc
2020-04-23 21:49:39 +00:00
David Anderson
166f0bd274
Merge "liblp: Fix tests for linear extent overlap." into rvc-dev am: d029ccd0d6
am: 659cc9d588
am: ef0811ad13
...
Change-Id: I6ec7b4c1c5cf34a1a3ea95f3ed376f48de0bd4fd
2020-04-23 21:42:13 +00:00
Tom Cherry
c53c64c0ec
Merge "Remove thread safety from libbase logging / liblog" into rvc-dev
2020-04-23 21:40:23 +00:00
David Anderson
ef0811ad13
Merge "liblp: Fix tests for linear extent overlap." into rvc-dev am: d029ccd0d6
am: 659cc9d588
...
Change-Id: If8d8e26f03c731a48f82dfee2ce943947aa63705
2020-04-23 21:23:09 +00:00
David Anderson
659cc9d588
Merge "liblp: Fix tests for linear extent overlap." into rvc-dev am: d029ccd0d6
...
Change-Id: I3a299b5d055aa4c412bc08d25c4ea93949c68d8e
2020-04-23 21:06:02 +00:00
TreeHugger Robot
38cf62df18
Merge "adb: Avoid extra string construction" into rvc-dev am: 386e91d21c
am: ca79430600
am: 997997a974
...
Change-Id: I34e900094eeb645da6d60e17a2bbeb4595617efc
2020-04-23 20:57:31 +00:00