Tommy Chiu
97466cb145
vold: Introduce android::vold::writeStringToFile
...
Remove static definition of writeStringToFile, and
move it from KeyStorage to Utils
(cherry picked from commit 0bd2d11692
2019-04-05 04:06:18 -07:00
Sandeep Patil
880deb6add
Merge "vdc: print the failed command with failure status."
...
am: b8d17384c5
2019-04-04 11:39:35 -07:00
Treehugger Robot
b8d17384c5
Merge "vdc: print the failed command with failure status."
2019-04-04 18:16:27 +00:00
Eric Biggers
2fba74c1e1
Merge "Add missing null terminator for getopt_long()" am: 4d05e017f9
...
am: 4e3300374b
2019-04-04 09:55:49 -07:00
Eric Biggers
4e3300374b
Merge "Add missing null terminator for getopt_long()"
...
am: 4d05e017f9
2019-04-04 09:37:52 -07:00
Sandeep Patil
4377234daa
vdc: print the failed command with failure status.
...
vdc currently only prints generic binder failure status on failure.
This doesn't help debugging early boot failures at all since we don't
know which exact vdc command failed. Fix that by adding the command as
part of the failure message.
Bug: 129946805
Test: Boot cuttlefish
Change-Id: Ic2367cf592d6b5bf23d6d4b1447baa1baf41afe7
Signed-off-by: Sandeep Patil <sspatil@google.com>
2019-04-04 09:35:51 -07:00
Eric Biggers
4d05e017f9
Merge "Add missing null terminator for getopt_long()"
2019-04-04 16:18:18 +00:00
Eric Biggers
f5ef40de83
Add missing null terminator for getopt_long()
...
getopt_long() assumes an all-zeroes 'struct option' at the end of the
array. Add it.
Fortunately this isn't causing problems in practice because vold is
always passed valid command line options...
Test: Running 'vold --foo' no longer segfaults.
Change-Id: I2cd3af501cc1aa11327a8062ec492be1d23defdf
2019-04-03 16:32:24 -07:00
Eric Biggers
143498f797
Merge "vold: downgrade lookup_key_ref() failure message to DEBUG level"
2019-04-03 21:38:28 +00:00
Daniel Rosenberg
c7da9acdce
Merge "Retry opening loop device" am: c8f5cbb5b1 am: de841f6d89
...
am: dde25e9167
2019-04-02 15:52:12 -07:00
Daniel Rosenberg
dde25e9167
Merge "Retry opening loop device" am: c8f5cbb5b1
...
am: de841f6d89
2019-04-02 15:08:19 -07:00
Daniel Rosenberg
de841f6d89
Merge "Retry opening loop device"
...
am: c8f5cbb5b1
2019-04-02 14:23:59 -07:00
Daniel Rosenberg
c8f5cbb5b1
Merge "Retry opening loop device"
2019-04-02 20:28:44 +00:00
Eric Biggers
d103404985
vold: downgrade lookup_key_ref() failure message to DEBUG level
...
Now that lockUserKey() will be called for every user each time the
framework is started, it's a normal case that the key being removed
doesn't exist. So downgrade the log message about being unable to find
a key from ERROR to DEBUG.
Test: build and boot, message is now debug level.
Change-Id: I2d1dce8dd8825b02982eab1c902aa10fe5b54b84
2019-04-02 11:13:57 -07:00
Daniel Rosenberg
4538cb20b9
Retry opening loop device
...
If more than the default number of loop devices is in use, we may need
to wait for the device path to be available.
Bug: 128873591
Bug: 122059364
Test: Set up adopted virtual disk and check that it loads on boot
Change-Id: I201dcc32043664076f50b0d6f40de6e5e1a65342
2019-04-01 17:37:47 -07:00
Jaegeuk Kim
cd1f06f6ec
Merge "idle-maint: don't need to change discard_granularity" am: 444a24558d am: a970ff8448
...
am: 240ca70d8d
2019-04-01 07:22:06 -07:00
Jaegeuk Kim
240ca70d8d
Merge "idle-maint: don't need to change discard_granularity" am: 444a24558d
...
am: a970ff8448
2019-04-01 07:17:59 -07:00
Jaegeuk Kim
a970ff8448
Merge "idle-maint: don't need to change discard_granularity"
...
am: 444a24558d
2019-04-01 07:13:28 -07:00
Jaegeuk Kim
444a24558d
Merge "idle-maint: don't need to change discard_granularity"
2019-04-01 14:04:24 +00:00
Nick Kralevich
58e1a816ba
VolumeManager: more O_CLOEXEC changes
...
Test: compiles and boots
Bug: 129350825
Change-Id: Ie6a0e05f1814d744eb16863f749c939ab1e097e0
2019-03-29 19:23:40 -07:00
Nick Kralevich
87fcd8b36a
Merge "vold: add android-* to tidy_checks" am: 1820b9b3b9 am: 874b841223
...
am: 2215bd7a75
2019-03-29 18:46:25 -07:00
Nick Kralevich
9bda3fe810
Merge "vold: cleanups for O_CLOEXEC tidy checks." am: a59868d6de am: 5af0c75525
...
am: 4197c098df
2019-03-29 18:46:07 -07:00
Nick Kralevich
2215bd7a75
Merge "vold: add android-* to tidy_checks" am: 1820b9b3b9
...
am: 874b841223
2019-03-29 18:42:20 -07:00
Nick Kralevich
4197c098df
Merge "vold: cleanups for O_CLOEXEC tidy checks." am: a59868d6de
...
am: 5af0c75525
2019-03-29 18:42:05 -07:00
Nick Kralevich
874b841223
Merge "vold: add android-* to tidy_checks"
...
am: 1820b9b3b9
2019-03-29 18:38:21 -07:00
Nick Kralevich
5af0c75525
Merge "vold: cleanups for O_CLOEXEC tidy checks."
...
am: a59868d6de
2019-03-29 18:38:04 -07:00
Nick Kralevich
1820b9b3b9
Merge "vold: add android-* to tidy_checks"
2019-03-30 01:27:57 +00:00
Nick Kralevich
a59868d6de
Merge "vold: cleanups for O_CLOEXEC tidy checks."
2019-03-30 01:27:38 +00:00
Paul Lawrence
25fe272764
Merge "Fix checkpoint on Taimen" am: 3889f17ad1 am: e2d9258979
...
am: 471325ad5a
2019-03-29 17:58:01 -07:00
Paul Lawrence
471325ad5a
Merge "Fix checkpoint on Taimen" am: 3889f17ad1
...
am: e2d9258979
2019-03-29 17:38:20 -07:00
Paul Lawrence
e2d9258979
Merge "Fix checkpoint on Taimen"
...
am: 3889f17ad1
2019-03-29 17:16:19 -07:00
Treehugger Robot
3889f17ad1
Merge "Fix checkpoint on Taimen"
2019-03-29 23:09:52 +00:00
Nick Kralevich
d78fb53378
vold: add android-* to tidy_checks
...
Bug: 129350825
Test: compiles and boots
Change-Id: If5a6267cc56bfc0ba73602bfa520035197b4fb90
2019-03-29 16:07:58 -07:00
Nick Kralevich
e7e89acbc8
vold: cleanups for O_CLOEXEC tidy checks.
...
Bug: 129350825
Test: compiles and boots
Change-Id: I83a484ca15df1b757b670008f15af5504bc94df1
2019-03-29 16:04:47 -07:00
Paul Lawrence
e81f4c1945
Fix checkpoint on Taimen
...
Bug: 129494872
Test: VtsKernelCheckpointTest runs and passes
Change-Id: Ib2de866db7c847d569789d1aa6cdbad7c3ee7ff4
2019-03-29 13:22:19 -07:00
Bernie Innocenti
a83d0fe1b6
Merge "Fix bogus error checking on unique_fd" am: 95587b085e am: 3e9b69bf77
...
am: eb2be538c0
2019-03-28 21:32:18 -07:00
Bernie Innocenti
eb2be538c0
Merge "Fix bogus error checking on unique_fd" am: 95587b085e
...
am: 3e9b69bf77
2019-03-28 21:15:34 -07:00
Bernie Innocenti
3e9b69bf77
Merge "Fix bogus error checking on unique_fd"
...
am: 95587b085e
2019-03-28 21:09:18 -07:00
Treehugger Robot
95587b085e
Merge "Fix bogus error checking on unique_fd"
2019-03-29 03:52:46 +00:00
Jaegeuk Kim
dc7162be6f
idle-maint: don't need to change discard_granularity
...
F2FS changes proper configurations along with gc_urgent, so idle-maint doesn't
need to set this redundantly.
Change-Id: I4a71a5d877a3bb9636e2b65132ec806edc56a8fe
Signed-off-by: Jaegeuk Kim <jaegeuk@google.com>
2019-03-28 06:40:12 -07:00
TreeHugger Robot
9cfc0b4b17
Merge "vold: fsync both file and directory after write keys"
2019-03-28 08:44:30 +00:00
TreeHugger Robot
32212df196
Merge "vold: Introduce android::vold::writeStringToFile"
2019-03-28 08:44:12 +00:00
Tommy Chiu
a98464f688
vold: fsync both file and directory after write keys
...
Use vold version of writeStringToFile which fsync files, and
manually fsync directories after initialize global DE
Bug: 71810347
Test: Build pass and reboot stress test.
Original boot failure symptom is NOT reproducible.
Change-Id: I1ca8f8cf0ccfd01075a9c33f79042e58d99aea26
2019-03-28 08:43:24 +00:00
Bernie Innocenti
ebe293ab54
Fix bogus error checking on unique_fd
...
The expression "!fd" calls the implicit conversion to int, but comparing
the raw fd against 0 does not work, since open() and other POSIX calls
returning a file descriptor use -1 to signal an error.
Test: m vold
Change-Id: I0847c276f39cb9dd09c7ffb96951276113418fc8
2019-03-28 15:54:52 +09:00
Daniel Rosenberg
0873a1c71c
Merge "Switch Checkpoint health sleep time to ms." am: 32a8a47b07 am: e6db7e0a23
...
am: 2cc8752935
2019-03-26 19:53:51 -07:00
Daniel Rosenberg
2cc8752935
Merge "Switch Checkpoint health sleep time to ms." am: 32a8a47b07
...
am: e6db7e0a23
2019-03-26 19:49:51 -07:00
Daniel Rosenberg
e6db7e0a23
Merge "Switch Checkpoint health sleep time to ms."
...
am: 32a8a47b07
2019-03-26 19:45:51 -07:00
Daniel Rosenberg
32a8a47b07
Merge "Switch Checkpoint health sleep time to ms."
2019-03-27 02:34:24 +00:00
Daniel Rosenberg
38f7671916
Merge "Fixed min_free_bytes prop name and usleep time default" am: 7522da3036 am: 23e15b78ad
...
am: 511073b610
2019-03-26 19:26:30 -07:00
Daniel Rosenberg
511073b610
Merge "Fixed min_free_bytes prop name and usleep time default" am: 7522da3036
...
am: 23e15b78ad
2019-03-26 19:22:27 -07:00
